Title: Python: qualify Flow.qll's AST references with Py:: prefix by yoff · Pull Request #21920 · github/codeql · GitHub
Open Graph Title: Python: qualify Flow.qll's AST references with Py:: prefix by yoff · Pull Request #21920 · github/codeql
X Title: Python: qualify Flow.qll's AST references with Py:: prefix by yoff · Pull Request #21920 · github/codeql
Description: Summary Preparatory refactor for the shared-CFG dataflow migration (#21894). Based on #21919 — merge that first. Switches Flow.qll from import python to import python as Py, and qualifies every AST-class reference in the file with the Py:: prefix. Why The new CFG facade (introduced in a follow-up PR) wants to re-export many of the same names as python (e.g. ControlFlowNode, CallNode, BasicBlock), so consumers can import semmle.python.controlflow.Cfg instead of import python and pick up the new CFG. To make Flow.qll itself coexist cleanly with the new CFG and avoid ambiguities when both worlds are visible, the AST imports inside Flow.qll are namespaced under Py::. Flow.qll's own CFG types (ControlFlowNode, BasicBlock, CallNode, NameNode, DefinitionNode, CompareNode, ...) keep their unqualified names — they remain the public CFG API exported from this file. Semantic effect None. The qualification was applied mechanically by script — every reference to an AST class (e.g. Expr, Bytes, Module, Scope, Call, Attribute, SsaVariable, AugAssign, Compare, BinaryExpr, etc.) was prefixed with Py::. No name resolution changes. Verified by: All 361 lib/ + src/ queries compile clean. All 186 ControlFlow + PointsTo + dataflow library-tests pass. Notes for reviewers This PR is a single-file mechanical diff. Easiest to review with git diff --word-diff-regex='[A-Za-z_]+'.
Open Graph Description: Summary Preparatory refactor for the shared-CFG dataflow migration (#21894). Based on #21919 — merge that first. Switches Flow.qll from import python to import python as Py, and qualifies every AST...
X Description: Summary Preparatory refactor for the shared-CFG dataflow migration (#21894). Based on #21919 — merge that first. Switches Flow.qll from import python to import python as Py, and qualifies every AST...
Opengraph URL: https://github.com/github/codeql/pull/21920
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:57ccc1e2-05f8-eedc-eb06-f4cd269a4d9a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D6DA:1EC7:26D733:38B3F6:6A4ED5E7 |
| html-safe-nonce | 779020693f9e98521f3d03812d37f59843d5916d51c71e60b105ecbb07a605bf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENkRBOjFFQzc6MjZENzMzOjM4QjNGNjo2QTRFRDVFNyIsInZpc2l0b3JfaWQiOiI0OTIxODgwODcxOTk5Mjk2OTk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d7921a3e37a58a6f8397004ad8245783775a952037e08673e598567906add88d |
| hovercard-subject-tag | pull_request:3780551993 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql/pull/21920/files |
| twitter:image | https://avatars.githubusercontent.com/u/647347?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/647347?s=400&v=4 |
| og:image:alt | Summary Preparatory refactor for the shared-CFG dataflow migration (#21894). Based on #21919 — merge that first. Switches Flow.qll from import python to import python as Py, and qualifies every AST... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql git https://github.com/github/codeql.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 143040428 |
| octolytics-dimension-repository_nwo | github/codeql |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 143040428 |
| octolytics-dimension-repository_network_root_nwo | github/codeql |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c37fe3e3f5f306900bd5b6bee97463f66c938b2c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width