Title: Go: Support `git_source` by mbg · Pull Request #20368 · github/codeql · GitHub
Open Graph Title: Go: Support `git_source` by mbg · Pull Request #20368 · github/codeql
X Title: Go: Support `git_source` by mbg · Pull Request #20368 · github/codeql
Description: This PR modifies the Go autobuilder/extractor to support git_source private registry configurations, in addition to the goproxy_server configurations that were already supported. In github/codeql-action#3079, we modified the CodeQL Action so that git_source configurations are now propagated to the Go autobuilder/extractor. With the changes in this PR, if a git_source configuration is provided, we set GOPRIVATE to include a pattern for the hostname provided in the configuration. The GOPRIVATE variable instructs go which packages should not be fetched via a GOPROXY (whether it's the default one or a custom one). For example, if the git_source configuration is for https://github.com/foo, then we'd set GOPRIVATE=github.com/foo*. This is a simplification of what is necessary for GOPRIVATE, because Go modules may not have the same name as the address of the repository that contains them. Ideally, we would make GOPRIVATE configurable somehow, possibly using a go.env file in the repository or similar. However, for initially supporting this, the behaviour here should be sufficient. If a git_source is configured, we also configure git on the runner to use the self-signed proxy certificate. Otherwise, it will refuse to connect.
Open Graph Description: This PR modifies the Go autobuilder/extractor to support git_source private registry configurations, in addition to the goproxy_server configurations that were already supported. In github/codeql-a...
X Description: This PR modifies the Go autobuilder/extractor to support git_source private registry configurations, in addition to the goproxy_server configurations that were already supported. In github/codeql-a...
Opengraph URL: https://github.com/github/codeql/pull/20368
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:794f1bb6-34ac-1beb-5a3f-c4cf9af1597b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A388:2FCF6D:315F2B:46561A:6A54814F |
| html-safe-nonce | e19b273caaf9ca4ef32857298e759df652e29334f804029290c3c6294c6c14c4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzg4OjJGQ0Y2RDozMTVGMkI6NDY1NjFBOjZBNTQ4MTRGIiwidmlzaXRvcl9pZCI6IjMzOTAxMjgxODk0MzUzMTQ1MTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2194430bd7df19e7a68980b44c65195de4ea9149e7ca59891394d7d7fefd8a3f |
| hovercard-subject-tag | pull_request:2799785939 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql/pull/20368/files |
| twitter:image | https://avatars.githubusercontent.com/u/278086?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/278086?s=400&v=4 |
| og:image:alt | This PR modifies the Go autobuilder/extractor to support git_source private registry configurations, in addition to the goproxy_server configurations that were already supported. In github/codeql-a... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql git https://github.com/github/codeql.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 143040428 |
| octolytics-dimension-repository_nwo | github/codeql |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 143040428 |
| octolytics-dimension-repository_network_root_nwo | github/codeql |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6d28624802c2f7d9500239dd6870ed7031b7353b |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width