René's URL Explorer Experiment


Title: Swift: Diff-informed queries: phase 3 (non-trivial locations) by d10c · Pull Request #20082 · github/codeql · GitHub

Open Graph Title: Swift: Diff-informed queries: phase 3 (non-trivial locations) by d10c · Pull Request #20082 · github/codeql

X Title: Swift: Diff-informed queries: phase 3 (non-trivial locations) by d10c · Pull Request #20082 · github/codeql

Description: This PR enables diff-informed mode on queries that select a location other than dataflow source or sink. This entails adding a non-trivial location override that returns the locations that are actually selected. Prior work includes PRs like #19663, #19759, and #19817. This PR uses the same patch script as those PRs to find candidate queries to convert to diff-enabled. This is the final step in mass-enabling diff-informed queries on all the languages. Commit-by-commit reviewing is recommended. I have split the commits that add/modify tests from the ones that enable/disable diff-informed queries. If the commit modifies a .qll file, in the commit message I've included links to the queries that depend on that .qll for easier reviewing. Feel free to delegate parts of the review to others who may be more specialized in certain languages.

Open Graph Description: This PR enables diff-informed mode on queries that select a location other than dataflow source or sink. This entails adding a non-trivial location override that returns the locations that are actu...

X Description: This PR enables diff-informed mode on queries that select a location other than dataflow source or sink. This entails adding a non-trivial location override that returns the locations that are actu...

Opengraph URL: https://github.com/github/codeql/pull/20082

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a46fb594-f956-9dc2-7a20-49e01a4d9dcd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C86:27EF7:9091FA:C70874:6A57E20D
html-safe-nonce7da2a4de0876a59d6c4e2089d2179d55e7f72ca99c22122a55d8a27b6c22db8d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Qzg2OjI3RUY3OjkwOTFGQTpDNzA4NzQ6NkE1N0UyMEQiLCJ2aXNpdG9yX2lkIjoiMzQ1NzcwNzAwNDQ2MjA5NjkwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1629ee2ca4730feebdc8067116862637a003e151a7518acdd94545d17099c222
hovercard-subject-tagpull_request:2673921790
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql/pull/20082/files
twitter:imagehttps://avatars.githubusercontent.com/u/9970661?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9970661?s=400&v=4
og:image:altThis PR enables diff-informed mode on queries that select a location other than dataflow source or sink. This entails adding a non-trivial location override that returns the locations that are actu...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None837767abbd14b05f219fd812ef2842c659968b63619e1b966dded83972ab5bca
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release36b9c371e4e031091f1b89adf913d9e6993943df
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/20082/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F20082%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F20082%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/20082/files
Reloadhttps://github.com/github/codeql/pull/20082/files
Reloadhttps://github.com/github/codeql/pull/20082/files
Please reload this pagehttps://github.com/github/codeql/pull/20082/files
github https://github.com/github
codeqlhttps://github.com/github/codeql
Notifications https://github.com/login?return_to=%2Fgithub%2Fcodeql
Fork 2k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Star 9.8k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Code https://github.com/github/codeql
Issues 990 https://github.com/github/codeql/issues
Pull requests 429 https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality 0 https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Code https://github.com/github/codeql
Issues https://github.com/github/codeql/issues
Pull requests https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
d10chttps://github.com/d10c
github:mainhttps://github.com/github/codeql/tree/main
d10c:d10c/diff-informed-phase-3-swifthttps://github.com/d10c/codeql/tree/d10c/diff-informed-phase-3-swift
Conversation 10 https://github.com/github/codeql/pull/20082
Findings https://github.com/github/codeql/pull/20082/findings
Commits 4 https://github.com/github/codeql/pull/20082/commits
Checks 19 https://github.com/github/codeql/pull/20082/checks
Files changed https://github.com/github/codeql/pull/20082/files
Please reload this pagehttps://github.com/github/codeql/pull/20082/files
Swift: Diff-informed queries: phase 3 (non-trivial locations) https://github.com/github/codeql/pull/20082/files#top
Show all changes 4 commits https://github.com/github/codeql/pull/20082/files
cd3fa64 [DIFF-INFORMED] Swift: CleartextStorageDatabase d10c Jul 16, 2025 https://github.com/github/codeql/pull/20082/commits/cd3fa64ee3f2427dc32a866e6b1541a5fb269bcb
6dea73b [DIFF-INFORMED] Swift: CleartextStoragePreferences d10c Jul 16, 2025 https://github.com/github/codeql/pull/20082/commits/6dea73b08138c0464d5dbfd37f97f1da554dcef8
b1e7239 [DIFF-INFORMED] Swift: InsecureTLS d10c Jul 16, 2025 https://github.com/github/codeql/pull/20082/commits/b1e723991e52eb137279f9cf6eb9dea6839ff488
4342b2b [DIFF-INFORMED] Swift: UnsafeWebViewFetch d10c Jul 16, 2025 https://github.com/github/codeql/pull/20082/commits/4342b2b799aa7877ee1131fe3f5b6db0045cc85e
Clear filters https://github.com/github/codeql/pull/20082/files
Please reload this pagehttps://github.com/github/codeql/pull/20082/files
Please reload this pagehttps://github.com/github/codeql/pull/20082/files
CleartextStorageDatabaseQuery.qll https://github.com/github/codeql/pull/20082/files#diff-a3b765e18905dc521bc9b2c016149ad7411c1a4f343847b2622cbb3402de1c5c
CleartextStoragePreferencesQuery.qll https://github.com/github/codeql/pull/20082/files#diff-b57ea093b8b785bab86e9fbe961a3c476494bd2087c8b5bedafbcefea559bec2
InsecureTLSQuery.qll https://github.com/github/codeql/pull/20082/files#diff-1ede93da633bea9c9530bd9bff3bd8c485ec8c79f1372d4f64b730f6ebd85389
UnsafeWebViewFetchQuery.qll https://github.com/github/codeql/pull/20082/files#diff-327c69ce7b80a9e1e8a0fd1d37dc32f282984d7f66a557a44aa76eb98e8a105f
https://github.com/github/codeql/blob/main/CODEOWNERS#L27
swift/ql/lib/codeql/swift/security/CleartextStorageDatabaseQuery.qllhttps://github.com/github/codeql/pull/20082/files#diff-a3b765e18905dc521bc9b2c016149ad7411c1a4f343847b2622cbb3402de1c5c
View file https://github.com/d10c/codeql/blob/4342b2b799aa7877ee1131fe3f5b6db0045cc85e/swift/ql/lib/codeql/swift/security/CleartextStorageDatabaseQuery.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/20082/{{ revealButtonHref }}
https://github.com/github/codeql/pull/20082/files#diff-a3b765e18905dc521bc9b2c016149ad7411c1a4f343847b2622cbb3402de1c5c
https://github.com/github/codeql/pull/20082/files#diff-a3b765e18905dc521bc9b2c016149ad7411c1a4f343847b2622cbb3402de1c5c
https://github.com/github/codeql/blob/main/CODEOWNERS#L27
swift/ql/lib/codeql/swift/security/CleartextStoragePreferencesQuery.qllhttps://github.com/github/codeql/pull/20082/files#diff-b57ea093b8b785bab86e9fbe961a3c476494bd2087c8b5bedafbcefea559bec2
View file https://github.com/d10c/codeql/blob/4342b2b799aa7877ee1131fe3f5b6db0045cc85e/swift/ql/lib/codeql/swift/security/CleartextStoragePreferencesQuery.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/20082/{{ revealButtonHref }}
https://github.com/github/codeql/pull/20082/files#diff-b57ea093b8b785bab86e9fbe961a3c476494bd2087c8b5bedafbcefea559bec2
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Jul 17, 2025https://github.com/github/codeql/pull/20082/files#r2213643729
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/20082/files
Copilothttps://docs.github.com/copilot/responsible-use-of-github-copilot-features/responsible-use-of-github-copilot-code-review
https://github.com/github/codeql/pull/20082/files#diff-b57ea093b8b785bab86e9fbe961a3c476494bd2087c8b5bedafbcefea559bec2
https://github.com/github/codeql/blob/main/CODEOWNERS#L27
swift/ql/lib/codeql/swift/security/InsecureTLSQuery.qllhttps://github.com/github/codeql/pull/20082/files#diff-1ede93da633bea9c9530bd9bff3bd8c485ec8c79f1372d4f64b730f6ebd85389
View file https://github.com/d10c/codeql/blob/4342b2b799aa7877ee1131fe3f5b6db0045cc85e/swift/ql/lib/codeql/swift/security/InsecureTLSQuery.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/20082/{{ revealButtonHref }}
https://github.com/github/codeql/pull/20082/files#diff-1ede93da633bea9c9530bd9bff3bd8c485ec8c79f1372d4f64b730f6ebd85389
geoffw0https://github.com/geoffw0
Jul 21, 2025https://github.com/github/codeql/pull/20082/files#r2218673882
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/20082/files
d10chttps://github.com/d10c
Jul 22, 2025https://github.com/github/codeql/pull/20082/files#r2221867289
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
the use of UnknownLocationhttps://github.com/github/codeql/blob/main/swift/ql/lib/codeql/swift/elements/internal/LocatableImpl.qll#L12
Please reload this pagehttps://github.com/github/codeql/pull/20082/files
geoffw0https://github.com/geoffw0
Jul 23, 2025https://github.com/github/codeql/pull/20082/files#r2225010948
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/20082/files
geoffw0https://github.com/geoffw0
Jul 23, 2025https://github.com/github/codeql/pull/20082/files#r2226031430
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/20082/files
https://github.com/github/codeql/blob/main/CODEOWNERS#L27
swift/ql/lib/codeql/swift/security/UnsafeWebViewFetchQuery.qllhttps://github.com/github/codeql/pull/20082/files#diff-327c69ce7b80a9e1e8a0fd1d37dc32f282984d7f66a557a44aa76eb98e8a105f
View file https://github.com/d10c/codeql/blob/4342b2b799aa7877ee1131fe3f5b6db0045cc85e/swift/ql/lib/codeql/swift/security/UnsafeWebViewFetchQuery.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/20082/{{ revealButtonHref }}
https://github.com/github/codeql/pull/20082/files#diff-327c69ce7b80a9e1e8a0fd1d37dc32f282984d7f66a557a44aa76eb98e8a105f
geoffw0https://github.com/geoffw0
Jul 21, 2025https://github.com/github/codeql/pull/20082/files#r2218679435
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/20082/files
d10chttps://github.com/d10c
Jul 22, 2025https://github.com/github/codeql/pull/20082/files#r2221918427
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
the third disjuncthttps://github.com/d10c/codeql/blob/main/swift/ql/src/queries/Security/CWE-079/UnsafeWebViewFetch.ql#L36C5-L36C39
Please reload this pagehttps://github.com/github/codeql/pull/20082/files
geoffw0https://github.com/geoffw0
Jul 23, 2025https://github.com/github/codeql/pull/20082/files#r2225013295
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/20082/files
https://github.com/github/codeql/pull/20082/files#diff-327c69ce7b80a9e1e8a0fd1d37dc32f282984d7f66a557a44aa76eb98e8a105f
Please reload this pagehttps://github.com/github/codeql/pull/20082/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.