René's URL Explorer Experiment


Title: Swift: Diff-informed queries: phase 3 (non-trivial locations) by d10c · Pull Request #20082 · github/codeql · GitHub

Open Graph Title: Swift: Diff-informed queries: phase 3 (non-trivial locations) by d10c · Pull Request #20082 · github/codeql

X Title: Swift: Diff-informed queries: phase 3 (non-trivial locations) by d10c · Pull Request #20082 · github/codeql

Description: CodeQL: the libraries and queries that power security researchers around the world, as well as code scanning in GitHub Advanced Security - Swift: Diff-informed queries: phase 3 (non-trivial locations) by d10c · Pull Request #20082 · github/codeql

Open Graph Description: This PR enables diff-informed mode on queries that select a location other than dataflow source or sink. This entails adding a non-trivial location override that returns the locations that are actu...

X Description: This PR enables diff-informed mode on queries that select a location other than dataflow source or sink. This entails adding a non-trivial location override that returns the locations that are actu...

Opengraph URL: https://github.com/github/codeql/pull/20082

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:14c276f2-a903-007b-9665-eb3ade10b066
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAEA2:84CF1:C2A249:11B7FB3:6A579332
html-safe-nonce114ebdcedafd451d37a6f4970d54ccd516ec22980ebc6c46e4d90f0116c4c153
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUEyOjg0Q0YxOkMyQTI0OToxMUI3RkIzOjZBNTc5MzMyIiwidmlzaXRvcl9pZCI6IjcxNTI4NDg0NTc5MTY5Nzc5NzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac560cc35312aeb36f16f9c4bac78d0b0adb95126afb59923c53d182b40caed0ac
hovercard-subject-tagpull_request:2673921790
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/github/codeql/20082/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/aa52ca1c10da30b89a72991dc534f97abcdb44b00e65aeea9f8f176d90f26c3b/github/codeql/pull/20082
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/aa52ca1c10da30b89a72991dc534f97abcdb44b00e65aeea9f8f176d90f26c3b/github/codeql/pull/20082
og:image:altThis PR enables diff-informed mode on queries that select a location other than dataflow source or sink. This entails adding a non-trivial location override that returns the locations that are actu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamed10c
hostnamegithub.com
expected-hostnamegithub.com
Nonea87fc68e9bdf22e1c7e48ac6a60b98882f4bb103314b3f26b3460c61fc5441ae
turbo-cache-controlno-cache
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea2198d0212ed703af207673eb4d0868d4f867a5b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/20082#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F20082
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F20082
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/20082
Reloadhttps://github.com/github/codeql/pull/20082
Reloadhttps://github.com/github/codeql/pull/20082
Please reload this pagehttps://github.com/github/codeql/pull/20082
github https://github.com/github
codeqlhttps://github.com/github/codeql
Notifications https://github.com/login?return_to=%2Fgithub%2Fcodeql
Fork 2k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Star 9.8k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Code https://github.com/github/codeql
Issues 990 https://github.com/github/codeql/issues
Pull requests 428 https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality 0 https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Code https://github.com/github/codeql
Issues https://github.com/github/codeql/issues
Pull requests https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
d10chttps://github.com/d10c
github:mainhttps://github.com/github/codeql/tree/main
d10c:d10c/diff-informed-phase-3-swifthttps://github.com/d10c/codeql/tree/d10c/diff-informed-phase-3-swift
Conversationhttps://github.com/github/codeql/pull/20082
Commits4 (4)https://github.com/github/codeql/pull/20082/commits
Checkshttps://github.com/github/codeql/pull/20082/checks
Files changedhttps://github.com/github/codeql/pull/20082/files
Swift: Diff-informed queries: phase 3 (non-trivial locations)https://github.com/github/codeql/pull/20082#top
d10chttps://github.com/d10c
github:mainhttps://github.com/github/codeql/tree/main
d10c:d10c/diff-informed-phase-3-swifthttps://github.com/d10c/codeql/tree/d10c/diff-informed-phase-3-swift
https://github.com/d10c
d10chttps://github.com/d10c
Jul 17, 2025https://github.com/github/codeql/pull/20082#issue-3239529501
#19663https://github.com/github/codeql/pull/19663
#19759https://github.com/github/codeql/pull/19759
#19817https://github.com/github/codeql/pull/19817
Please reload this pagehttps://github.com/github/codeql/pull/20082
d10chttps://github.com/d10c
July 17, 2025 14:59https://github.com/github/codeql/pull/20082#commits-pushed-cd3fa64
https://github.com/d10c
[DIFF-INFORMED] Swift: CleartextStorageDatabasehttps://github.com/github/codeql/pull/20082/commits/cd3fa64ee3f2427dc32a866e6b1541a5fb269bcb
cd3fa64https://github.com/github/codeql/pull/20082/commits/cd3fa64ee3f2427dc32a866e6b1541a5fb269bcb
https://github.com/d10c/codeql/blob/d10c/diff-informed-phase-3/swift/ql/src/queries/Security/CWE-311/CleartextStorageDatabase.ql#L33https://github.com/d10c/codeql/blob/d10c/diff-informed-phase-3/swift/ql/src/queries/Security/CWE-311/CleartextStorageDatabase.ql#L33
https://github.com/d10c
[DIFF-INFORMED] Swift: CleartextStoragePreferenceshttps://github.com/github/codeql/pull/20082/commits/6dea73b08138c0464d5dbfd37f97f1da554dcef8
6dea73bhttps://github.com/github/codeql/pull/20082/commits/6dea73b08138c0464d5dbfd37f97f1da554dcef8
https://github.com/d10c/codeql/blob/d10c/diff-informed-phase-3/swift/ql/src/queries/Security/CWE-312/CleartextStoragePreferences.ql#L32https://github.com/d10c/codeql/blob/d10c/diff-informed-phase-3/swift/ql/src/queries/Security/CWE-312/CleartextStoragePreferences.ql#L32
https://github.com/d10c
[DIFF-INFORMED] Swift: InsecureTLShttps://github.com/github/codeql/pull/20082/commits/b1e723991e52eb137279f9cf6eb9dea6839ff488
b1e7239https://github.com/github/codeql/pull/20082/commits/b1e723991e52eb137279f9cf6eb9dea6839ff488
https://github.com/d10c/codeql/blob/d10c/diff-informed-phase-3/swift/ql/src/queries/Security/CWE-757/InsecureTLS.ql#L18https://github.com/d10c/codeql/blob/d10c/diff-informed-phase-3/swift/ql/src/queries/Security/CWE-757/InsecureTLS.ql#L18
https://github.com/d10c
[DIFF-INFORMED] Swift: UnsafeWebViewFetchhttps://github.com/github/codeql/pull/20082/commits/4342b2b799aa7877ee1131fe3f5b6db0045cc85e
4342b2bhttps://github.com/github/codeql/pull/20082/commits/4342b2b799aa7877ee1131fe3f5b6db0045cc85e
https://github.com/d10c/codeql/blob/d10c/diff-informed-phase-3/swift/ql/src/queries/Security/CWE-079/UnsafeWebViewFetch.ql#L24https://github.com/d10c/codeql/blob/d10c/diff-informed-phase-3/swift/ql/src/queries/Security/CWE-079/UnsafeWebViewFetch.ql#L24
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Swift https://github.com/github/codeql/issues?q=state%3Aopen%20label%3ASwift
Jul 17, 2025https://github.com/github/codeql/pull/20082#event-18679994177
https://github.com/d10c
d10chttps://github.com/d10c
no-change-note-required https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Ano-change-note-required
Jul 17, 2025https://github.com/github/codeql/pull/20082#event-18679995676
https://github.com/d10c
d10chttps://github.com/d10c
July 17, 2025 15:17https://github.com/github/codeql/pull/20082#event-18682632100
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
July 17, 2025 15:17https://github.com/github/codeql/pull/20082#event-18682632346
https://github.com/d10c
d10chttps://github.com/d10c
code ownerhttps://github.com/github/codeql/blob/1485d7072d3546251bb628e2c4a258073abefb4c/CODEOWNERS#L12
July 17, 2025 15:17https://github.com/github/codeql/pull/20082#event-18682632498
https://github.com/d10c
d10chttps://github.com/d10c
michaelnebelhttps://github.com/michaelnebel
July 17, 2025 15:17https://github.com/github/codeql/pull/20082#event-18682633894
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Jul 17, 2025 https://github.com/github/codeql/pull/20082#pullrequestreview-3029991862
View reviewed changes https://github.com/github/codeql/pull/20082/files/4342b2b799aa7877ee1131fe3f5b6db0045cc85e
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/github/codeql/pull/20082#pullrequestreview-3029991862
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/20082
swift/ql/lib/codeql/swift/security/CleartextStoragePreferencesQuery.qllhttps://github.com/github/codeql/pull/20082/files/4342b2b799aa7877ee1131fe3f5b6db0045cc85e#diff-b57ea093b8b785bab86e9fbe961a3c476494bd2087c8b5bedafbcefea559bec2
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Jul 17, 2025https://github.com/github/codeql/pull/20082#discussion_r2213643729
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/20082
Copilothttps://docs.github.com/copilot/responsible-use-of-github-copilot-features/responsible-use-of-github-copilot-code-review
https://github.com/d10c
d10chttps://github.com/d10c
geoffw0https://github.com/geoffw0
July 18, 2025 13:11https://github.com/github/codeql/pull/20082#event-18700528637
https://github.com/geoffw0
geoffw0https://github.com/geoffw0
Jul 21, 2025 https://github.com/github/codeql/pull/20082#pullrequestreview-3037292194
View reviewed changes https://github.com/github/codeql/pull/20082/files/4342b2b799aa7877ee1131fe3f5b6db0045cc85e
geoffw0https://github.com/geoffw0
https://github.com/github/codeql/pull/20082#pullrequestreview-3037292194
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/20082
swift/ql/lib/codeql/swift/security/InsecureTLSQuery.qllhttps://github.com/github/codeql/pull/20082/files/6dea73b08138c0464d5dbfd37f97f1da554dcef8..b1e723991e52eb137279f9cf6eb9dea6839ff488#diff-1ede93da633bea9c9530bd9bff3bd8c485ec8c79f1372d4f64b730f6ebd85389
geoffw0https://github.com/geoffw0
Jul 21, 2025https://github.com/github/codeql/pull/20082#discussion_r2218673882
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/20082
d10chttps://github.com/d10c
Jul 22, 2025https://github.com/github/codeql/pull/20082#discussion_r2221867289
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
the use of UnknownLocationhttps://github.com/github/codeql/blob/main/swift/ql/lib/codeql/swift/elements/internal/LocatableImpl.qll#L12
Please reload this pagehttps://github.com/github/codeql/pull/20082
geoffw0https://github.com/geoffw0
Jul 23, 2025https://github.com/github/codeql/pull/20082#discussion_r2225010948
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/20082
geoffw0https://github.com/geoffw0
Jul 23, 2025https://github.com/github/codeql/pull/20082#discussion_r2226031430
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/20082
swift/ql/lib/codeql/swift/security/UnsafeWebViewFetchQuery.qllhttps://github.com/github/codeql/pull/20082/files/b1e723991e52eb137279f9cf6eb9dea6839ff488..4342b2b799aa7877ee1131fe3f5b6db0045cc85e#diff-327c69ce7b80a9e1e8a0fd1d37dc32f282984d7f66a557a44aa76eb98e8a105f
geoffw0https://github.com/geoffw0
Jul 21, 2025https://github.com/github/codeql/pull/20082#discussion_r2218679435
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/20082
d10chttps://github.com/d10c
Jul 22, 2025https://github.com/github/codeql/pull/20082#discussion_r2221918427
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
the third disjuncthttps://github.com/d10c/codeql/blob/main/swift/ql/src/queries/Security/CWE-079/UnsafeWebViewFetch.ql#L36C5-L36C39
Please reload this pagehttps://github.com/github/codeql/pull/20082
geoffw0https://github.com/geoffw0
Jul 23, 2025https://github.com/github/codeql/pull/20082#discussion_r2225013295
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/20082
https://github.com/geoffw0
geoffw0https://github.com/geoffw0
Jul 23, 2025 https://github.com/github/codeql/pull/20082#pullrequestreview-3046566867
View reviewed changes https://github.com/github/codeql/pull/20082/files/4342b2b799aa7877ee1131fe3f5b6db0045cc85e
https://github.com/d10c
d10chttps://github.com/d10c
766b0bfhttps://github.com/github/codeql/commit/766b0bf7734d4bf8784937463c3f6e3e4a973db2
Jul 23, 2025https://github.com/github/codeql/pull/20082#event-18770522346
Please reload this pagehttps://github.com/github/codeql/pull/20082
https://github.co/hiddenchars
https://github.com/github/codeql/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F20082
https://github.com/geoffw0
geoffw0 https://github.com/geoffw0
https://github.com/github/codeql/pull/20082/files/b1e723991e52eb137279f9cf6eb9dea6839ff488
Copilot code review https://github.com/apps/copilot-pull-request-reviewer
Copilot https://github.com/apps/copilot-pull-request-reviewer
https://github.com/github/codeql/pull/20082/files/4342b2b799aa7877ee1131fe3f5b6db0045cc85e
https://github.com/michaelnebel
michaelnebel https://github.com/michaelnebel
no-change-note-required https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Ano-change-note-required
Swift https://github.com/github/codeql/issues?q=state%3Aopen%20label%3ASwift
Please reload this pagehttps://github.com/github/codeql/pull/20082
https://github.com/d10c
https://github.com/geoffw0
https://github.com/apps/copilot-pull-request-reviewer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.