Title: Python: Diff-informed queries: phase 3 (non-trivial locations) by d10c · Pull Request #20079 · github/codeql · GitHub
Open Graph Title: Python: Diff-informed queries: phase 3 (non-trivial locations) by d10c · Pull Request #20079 · github/codeql
X Title: Python: Diff-informed queries: phase 3 (non-trivial locations) by d10c · Pull Request #20079 · github/codeql
Description: This PR enables diff-informed mode on queries that select a location other than dataflow source or sink. This entails adding a non-trivial location override that returns the locations that are actually selected. Prior work includes PRs like #19663, #19759, and #19817. This PR uses the same patch script as those PRs to find candidate queries to convert to diff-enabled. This is the final step in mass-enabling diff-informed queries on all the languages. Commit-by-commit reviewing is recommended. I have split the commits that add/modify tests from the ones that enable/disable diff-informed queries. If the commit modifies a .qll file, in the commit message I've included links to the queries that depend on that .qll for easier reviewing. Feel free to delegate parts of the review to others who may be more specialized in certain languages. Potentially tricky cases: Python TimingAttackAgainstHash test: I wasn't able to get alerts to show up for the qhelp-based tests; can someone from the language team chip in to what a useful test would look like? Something with MaD? In contrast, in [TEST] Java: CWE-020/ExternalAPI I was able to get alerts just from the qhelp example, and in [TEST] C++: CleartextSqliteDatabase I was able to get alerts from a mostly Copilot-written test. If it's too complicated, let's just drop this query.
Open Graph Description: This PR enables diff-informed mode on queries that select a location other than dataflow source or sink. This entails adding a non-trivial location override that returns the locations that are actu...
X Description: This PR enables diff-informed mode on queries that select a location other than dataflow source or sink. This entails adding a non-trivial location override that returns the locations that are actu...
Opengraph URL: https://github.com/github/codeql/pull/20079
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:754c70b0-7cd9-4f12-be22-199850ad62a4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C54C:A2F1B:2EBE04:3F539B:6A57FAAF |
| html-safe-nonce | 6f1bd29f5bf60d44046c960b8271728d481ea9b7650f1e17a8dc022e56bedd86 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTRDOkEyRjFCOjJFQkUwNDozRjUzOUI6NkE1N0ZBQUYiLCJ2aXNpdG9yX2lkIjoiNDQ2Nzc5MTIxNDM3NTA2MjIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 4d41de04958649199d94291ffaea7e0211b9d254c606c57281381fe216ba9686 |
| hovercard-subject-tag | pull_request:2673857152 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql/pull/20079/files |
| twitter:image | https://avatars.githubusercontent.com/u/9970661?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/9970661?s=400&v=4 |
| og:image:alt | This PR enables diff-informed mode on queries that select a location other than dataflow source or sink. This entails adding a non-trivial location override that returns the locations that are actu... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 49c8c15fabcbf356d607a90ca115c13b273e42ff8b74155de050fd229a9b0121 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql git https://github.com/github/codeql.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 143040428 |
| octolytics-dimension-repository_nwo | github/codeql |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 143040428 |
| octolytics-dimension-repository_network_root_nwo | github/codeql |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3fb1f684e7a833eb1b2d01d39875a2b52cb4fe9b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width