René's URL Explorer Experiment


Title: JS: Diff-informed queries: phase 3 (non-trivial locations) by d10c · Pull Request #20078 · github/codeql · GitHub

Open Graph Title: JS: Diff-informed queries: phase 3 (non-trivial locations) by d10c · Pull Request #20078 · github/codeql

X Title: JS: Diff-informed queries: phase 3 (non-trivial locations) by d10c · Pull Request #20078 · github/codeql

Description: This PR enables diff-informed mode on queries that select a location other than dataflow source or sink. This entails adding a non-trivial location override that returns the locations that are actually selected. Prior work includes PRs like #19663, #19759, and #19817. This PR uses the same patch script as those PRs to find candidate queries to convert to diff-enabled. This is the final step in mass-enabling diff-informed queries on all the languages. Commit-by-commit reviewing is recommended. I have split the commits that add/modify tests from the ones that enable/disable diff-informed queries. If the commit modifies a .qll file, in the commit message I've included links to the queries that depend on that .qll for easier reviewing. Feel free to delegate parts of the review to others who may be more specialized in certain languages.

Open Graph Description: This PR enables diff-informed mode on queries that select a location other than dataflow source or sink. This entails adding a non-trivial location override that returns the locations that are actu...

X Description: This PR enables diff-informed mode on queries that select a location other than dataflow source or sink. This entails adding a non-trivial location override that returns the locations that are actu...

Opengraph URL: https://github.com/github/codeql/pull/20078

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d9a81a4d-c5fb-c64a-18fb-eeb52b1ab3c5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE8C0:21D998:12C0BE9:1B4CB52:6A5766AE
html-safe-nonce9611811feb788d281c0111e51560410dc677baf91db418be74e3c6c61967a2d8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOEMwOjIxRDk5ODoxMkMwQkU5OjFCNENCNTI6NkE1NzY2QUUiLCJ2aXNpdG9yX2lkIjoiMTUwNTIwMzAyMTg4NTY5NTY2MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb38bc71ae999d196bef29bd2633e46d961902321511fc49b8ae0c401a4458b88
hovercard-subject-tagpull_request:2673837761
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql/pull/20078/files
twitter:imagehttps://avatars.githubusercontent.com/u/9970661?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9970661?s=400&v=4
og:image:altThis PR enables diff-informed mode on queries that select a location other than dataflow source or sink. This entails adding a non-trivial location override that returns the locations that are actu...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1b5a9c55f39dd27607a574cdc272552f20236b44
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/20078/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F20078%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F20078%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/20078/files
Reloadhttps://github.com/github/codeql/pull/20078/files
Reloadhttps://github.com/github/codeql/pull/20078/files
Please reload this pagehttps://github.com/github/codeql/pull/20078/files
github https://github.com/github
codeqlhttps://github.com/github/codeql
Notifications https://github.com/login?return_to=%2Fgithub%2Fcodeql
Fork 2k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Star 9.8k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Code https://github.com/github/codeql
Issues 990 https://github.com/github/codeql/issues
Pull requests 428 https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality 0 https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Code https://github.com/github/codeql
Issues https://github.com/github/codeql/issues
Pull requests https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
d10chttps://github.com/d10c
github:mainhttps://github.com/github/codeql/tree/main
d10c:d10c/diff-informed-phase-3-jshttps://github.com/d10c/codeql/tree/d10c/diff-informed-phase-3-js
Conversation 7 https://github.com/github/codeql/pull/20078
Findings https://github.com/github/codeql/pull/20078/findings
Commits 4 https://github.com/github/codeql/pull/20078/commits
Checks 14 https://github.com/github/codeql/pull/20078/checks
Files changed https://github.com/github/codeql/pull/20078/files
Please reload this pagehttps://github.com/github/codeql/pull/20078/files
JS: Diff-informed queries: phase 3 (non-trivial locations) https://github.com/github/codeql/pull/20078/files#top
Show all changes 4 commits https://github.com/github/codeql/pull/20078/files
43e318f [DIFF-INFORMED] JS: IndirectCommandInjection d10c Jul 16, 2025 https://github.com/github/codeql/pull/20078/commits/43e318fb60d57fda0bea74bd03f4456554686e01
f3974c3 [DIFF-INFORMED] JS: ShellCommandInjectionFromEnvironment d10c Jul 16, 2025 https://github.com/github/codeql/pull/20078/commits/f3974c3c343ac341f1ea008cdd522b32be6d8fea
4b43cf4 [DIFF-INFORMED] JS: EnvValueAndKeyInjection d10c Jul 16, 2025 https://github.com/github/codeql/pull/20078/commits/4b43cf4834ad4ed4666851622436ef6d6b7632e3
bd6b27e [DIFF-INFORMED] JS: decodeJwtWithoutVerification d10c Jul 16, 2025 https://github.com/github/codeql/pull/20078/commits/bd6b27e6061b0bba16e0d2d2818df6aead98e90c
Clear filters https://github.com/github/codeql/pull/20078/files
Please reload this pagehttps://github.com/github/codeql/pull/20078/files
Please reload this pagehttps://github.com/github/codeql/pull/20078/files
IndirectCommandInjectionQuery.qll https://github.com/github/codeql/pull/20078/files#diff-2a8084279cb040ea8d0b95ee61f2dadac4dc8540a9b8d4020429ca6e8b1a4701
ShellCommandInjectionFromEnvironmentQuery.qll https://github.com/github/codeql/pull/20078/files#diff-f7327eb0e824a3200b476734ac1582ed39289cde256cabaecfc45f3387048e48
EnvValueAndKeyInjection.ql https://github.com/github/codeql/pull/20078/files#diff-5b3698792000b0264ce0ce426651fdf3a9faef22e09369c8878cc6b0f6d8abd5
decodeJwtWithoutVerification.ql https://github.com/github/codeql/pull/20078/files#diff-8b17c4937d1824177f151316f07747b8a3ef7118688adb5a7a72ca150c2a4ed4
https://github.com/github/codeql/blob/main/CODEOWNERS#L17
javascript/ql/lib/semmle/javascript/security/dataflow/IndirectCommandInjectionQuery.qllhttps://github.com/github/codeql/pull/20078/files#diff-2a8084279cb040ea8d0b95ee61f2dadac4dc8540a9b8d4020429ca6e8b1a4701
View file https://github.com/d10c/codeql/blob/bd6b27e6061b0bba16e0d2d2818df6aead98e90c/javascript/ql/lib/semmle/javascript/security/dataflow/IndirectCommandInjectionQuery.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/20078/{{ revealButtonHref }}
https://github.com/github/codeql/pull/20078/files#diff-2a8084279cb040ea8d0b95ee61f2dadac4dc8540a9b8d4020429ca6e8b1a4701
michaelnebelhttps://github.com/michaelnebel
Aug 13, 2025https://github.com/github/codeql/pull/20078/files#r2273657387
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/20078/files
asgerfhttps://github.com/asgerf
Aug 14, 2025https://github.com/github/codeql/pull/20078/files#r2276384686
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/20078/files
d10chttps://github.com/d10c
Aug 14, 2025https://github.com/github/codeql/pull/20078/files#r2276450689
Please reload this pagehttps://github.com/github/codeql/pull/20078/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/20078/files
https://github.com/github/codeql/pull/20078/files#diff-2a8084279cb040ea8d0b95ee61f2dadac4dc8540a9b8d4020429ca6e8b1a4701
https://github.com/github/codeql/blob/main/CODEOWNERS#L17
.../ql/lib/semmle/javascript/security/dataflow/ShellCommandInjectionFromEnvironmentQuery.qllhttps://github.com/github/codeql/pull/20078/files#diff-f7327eb0e824a3200b476734ac1582ed39289cde256cabaecfc45f3387048e48
View file https://github.com/d10c/codeql/blob/bd6b27e6061b0bba16e0d2d2818df6aead98e90c/javascript/ql/lib/semmle/javascript/security/dataflow/ShellCommandInjectionFromEnvironmentQuery.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/20078/{{ revealButtonHref }}
https://github.com/github/codeql/pull/20078/files#diff-f7327eb0e824a3200b476734ac1582ed39289cde256cabaecfc45f3387048e48
michaelnebelhttps://github.com/michaelnebel
Aug 13, 2025https://github.com/github/codeql/pull/20078/files#r2273657914
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/20078/files
https://github.com/github/codeql/pull/20078/files#diff-f7327eb0e824a3200b476734ac1582ed39289cde256cabaecfc45f3387048e48
https://github.com/github/codeql/blob/main/CODEOWNERS#L17
javascript/ql/src/experimental/Security/CWE-099/EnvValueAndKeyInjection.qlhttps://github.com/github/codeql/pull/20078/files#diff-5b3698792000b0264ce0ce426651fdf3a9faef22e09369c8878cc6b0f6d8abd5
View file https://github.com/d10c/codeql/blob/bd6b27e6061b0bba16e0d2d2818df6aead98e90c/javascript/ql/src/experimental/Security/CWE-099/EnvValueAndKeyInjection.ql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/20078/{{ revealButtonHref }}
https://github.com/github/codeql/pull/20078/files#diff-5b3698792000b0264ce0ce426651fdf3a9faef22e09369c8878cc6b0f6d8abd5
https://github.com/github/codeql/pull/20078/files#diff-5b3698792000b0264ce0ce426651fdf3a9faef22e09369c8878cc6b0f6d8abd5
https://github.com/github/codeql/blob/main/CODEOWNERS#L17
javascript/ql/src/experimental/Security/CWE-347/decodeJwtWithoutVerification.qlhttps://github.com/github/codeql/pull/20078/files#diff-8b17c4937d1824177f151316f07747b8a3ef7118688adb5a7a72ca150c2a4ed4
View file https://github.com/d10c/codeql/blob/bd6b27e6061b0bba16e0d2d2818df6aead98e90c/javascript/ql/src/experimental/Security/CWE-347/decodeJwtWithoutVerification.ql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/20078/{{ revealButtonHref }}
https://github.com/github/codeql/pull/20078/files#diff-8b17c4937d1824177f151316f07747b8a3ef7118688adb5a7a72ca150c2a4ed4
https://github.com/github/codeql/pull/20078/files#diff-8b17c4937d1824177f151316f07747b8a3ef7118688adb5a7a72ca150c2a4ed4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.