René's URL Explorer Experiment


Title: Java: Diff-informed CleartextStorageCookie.ql by jbj · Pull Request #19846 · github/codeql · GitHub

Open Graph Title: Java: Diff-informed CleartextStorageCookie.ql by jbj · Pull Request #19846 · github/codeql

X Title: Java: Diff-informed CleartextStorageCookie.ql by jbj · Pull Request #19846 · github/codeql

Description: I picked this commit out of #17846 because it doesn't rely on any of the controversial API changes that are holding back that PR. It appears there are no tests for CleartextStorageCookie.ql. This query shares implementation with several other queries about cleartext storage, but it's the only one of them that's in the code-scanning suite. The sharing mechanism remains the same as before, but now each query has to override getASelectedLocation to become diff-informed. Two other data-flow configurations are used in this query, but they can't easily be made diff-informed.

Open Graph Description: I picked this commit out of #17846 because it doesn't rely on any of the controversial API changes that are holding back that PR. It appears there are no tests for CleartextStorageCookie.ql. T...

X Description: I picked this commit out of #17846 because it doesn't rely on any of the controversial API changes that are holding back that PR. It appears there are no tests for CleartextStorageCookie.ql...

Opengraph URL: https://github.com/github/codeql/pull/19846

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fb4791d4-546e-7d9f-dbf9-eb4220c2669d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC61C:25C9D0:F0E4D1:146A419:6A583657
html-safe-nonce7101feab50aa4797f778abc4e47841b0e6e4065f77f83fdc74f2198e65455c01
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjFDOjI1QzlEMDpGMEU0RDE6MTQ2QTQxOTo2QTU4MzY1NyIsInZpc2l0b3JfaWQiOiI2Nzg0MDQyMTU4ODMwMTM4OTY3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac25c8ab95a3b8d3ff9e152c5dec1f23f6b09ef14d8aa1b8c90874a970acb93c7c
hovercard-subject-tagpull_request:2611355761
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql/pull/19846/files
twitter:imagehttps://avatars.githubusercontent.com/u/308293?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/308293?s=400&v=4
og:image:altI picked this commit out of #17846 because it doesn't rely on any of the controversial API changes that are holding back that PR. It appears there are no tests for CleartextStorageCookie.ql. T...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/19846/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F19846%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F19846%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/19846/files
Reloadhttps://github.com/github/codeql/pull/19846/files
Reloadhttps://github.com/github/codeql/pull/19846/files
Please reload this pagehttps://github.com/github/codeql/pull/19846/files
github https://github.com/github
codeqlhttps://github.com/github/codeql
Notifications https://github.com/login?return_to=%2Fgithub%2Fcodeql
Fork 2k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Star 9.8k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Code https://github.com/github/codeql
Issues 991 https://github.com/github/codeql/issues
Pull requests 430 https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality 0 https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Code https://github.com/github/codeql
Issues https://github.com/github/codeql/issues
Pull requests https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
jbjhttps://github.com/jbj
github:mainhttps://github.com/github/codeql/tree/main
jbj:diff-informed-CleartextStorageCookiehttps://github.com/jbj/ql/tree/diff-informed-CleartextStorageCookie
Conversation 3 https://github.com/github/codeql/pull/19846
Findings https://github.com/github/codeql/pull/19846/findings
Commits 1 https://github.com/github/codeql/pull/19846/commits
Checks 9 https://github.com/github/codeql/pull/19846/checks
Files changed https://github.com/github/codeql/pull/19846/files
Please reload this pagehttps://github.com/github/codeql/pull/19846/files
Java: Diff-informed CleartextStorageCookie.ql https://github.com/github/codeql/pull/19846/files#top
Show all changes 1 commit https://github.com/github/codeql/pull/19846/files
fc2b18a Java: Diff-informed CleartextStorageCookie.ql jbj Oct 7, 2024 https://github.com/github/codeql/pull/19846/commits/fc2b18ae8a7a4005c348abb15d6a70d40fd31659
Clear filters https://github.com/github/codeql/pull/19846/files
Please reload this pagehttps://github.com/github/codeql/pull/19846/files
Please reload this pagehttps://github.com/github/codeql/pull/19846/files
CleartextStorageCookieQuery.qll https://github.com/github/codeql/pull/19846/files#diff-c00be663ef41d9f37888f5c75dc16ef65ce2d84725f06edd16bd261d651a598d
CleartextStorageQuery.qll https://github.com/github/codeql/pull/19846/files#diff-b317189aa469ce7200bccffeaac500e3445c20300e15ec741f695a0808bcc8d8
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
java/ql/lib/semmle/code/java/security/CleartextStorageCookieQuery.qllhttps://github.com/github/codeql/pull/19846/files#diff-c00be663ef41d9f37888f5c75dc16ef65ce2d84725f06edd16bd261d651a598d
View file https://github.com/jbj/ql/blob/fc2b18ae8a7a4005c348abb15d6a70d40fd31659/java/ql/lib/semmle/code/java/security/CleartextStorageCookieQuery.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/19846/{{ revealButtonHref }}
https://github.com/github/codeql/pull/19846/files#diff-c00be663ef41d9f37888f5c75dc16ef65ce2d84725f06edd16bd261d651a598d
https://github.com/github/codeql/pull/19846/files#diff-c00be663ef41d9f37888f5c75dc16ef65ce2d84725f06edd16bd261d651a598d
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
java/ql/lib/semmle/code/java/security/CleartextStorageQuery.qllhttps://github.com/github/codeql/pull/19846/files#diff-b317189aa469ce7200bccffeaac500e3445c20300e15ec741f695a0808bcc8d8
View file https://github.com/jbj/ql/blob/fc2b18ae8a7a4005c348abb15d6a70d40fd31659/java/ql/lib/semmle/code/java/security/CleartextStorageQuery.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/19846/{{ revealButtonHref }}
https://github.com/github/codeql/pull/19846/files#diff-b317189aa469ce7200bccffeaac500e3445c20300e15ec741f695a0808bcc8d8
https://github.com/github/codeql/pull/19846/files#diff-b317189aa469ce7200bccffeaac500e3445c20300e15ec741f695a0808bcc8d8
https://github.com/github/codeql/pull/19846/files#diff-b317189aa469ce7200bccffeaac500e3445c20300e15ec741f695a0808bcc8d8
https://github.com/github/codeql/pull/19846/files#diff-b317189aa469ce7200bccffeaac500e3445c20300e15ec741f695a0808bcc8d8
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.