René's URL Explorer Experiment


Title: Diff-informed queries via primary/secondary abstractions by jbj · Pull Request #19586 · github/codeql · GitHub

Open Graph Title: Diff-informed queries via primary/secondary abstractions by jbj · Pull Request #19586 · github/codeql

X Title: Diff-informed queries via primary/secondary abstractions by jbj · Pull Request #19586 · github/codeql

Description: This PR is a proof of concept for how diff-informed queries could be made more high level, reducing hard-to-remember design patterns and simultaneously reducing reverse dependencies and the "module soup" I proposed in #17846. I've only implemented what's necessary for XSS.ql so far since I expect a lot of changes to names and APIs.

Open Graph Description: This PR is a proof of concept for how diff-informed queries could be made more high level, reducing hard-to-remember design patterns and simultaneously reducing reverse dependencies and the "m...

X Description: This PR is a proof of concept for how diff-informed queries could be made more high level, reducing hard-to-remember design patterns and simultaneously reducing reverse dependencies and the &qu...

Opengraph URL: https://github.com/github/codeql/pull/19586

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ed803e74-df04-3a48-0a2c-7520dca01fff
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE5BE:23F271:30381:3FEC8:6A591532
html-safe-nonce11412f3a44e26b17aa7966e9da08c953fdb46108fee611eb77c6fcce8069ba82
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNUJFOjIzRjI3MTozMDM4MTozRkVDODo2QTU5MTUzMiIsInZpc2l0b3JfaWQiOiI0ODkzNTM3NTE1MjMwMjcwNzcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2a4de111301eebfcd6b547e90db48f50d347a6b12c7a5ca09eb1ebdce8163001
hovercard-subject-tagpull_request:2545588683
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql/pull/19586/files
twitter:imagehttps://avatars.githubusercontent.com/u/308293?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/308293?s=400&v=4
og:image:altThis PR is a proof of concept for how diff-informed queries could be made more high level, reducing hard-to-remember design patterns and simultaneously reducing reverse dependencies and the "m...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4eb8ea312922ccce63e833964f9606d971cffb2d5b6c10a62c4a7dcc48d826e2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release886a6c6fbce3d3caad5b3b995ef09ff6ca23f10e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/19586/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F19586%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F19586%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/19586/files
Reloadhttps://github.com/github/codeql/pull/19586/files
Reloadhttps://github.com/github/codeql/pull/19586/files
Please reload this pagehttps://github.com/github/codeql/pull/19586/files
github https://github.com/github
codeqlhttps://github.com/github/codeql
Notifications https://github.com/login?return_to=%2Fgithub%2Fcodeql
Fork 2k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Star 9.8k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Code https://github.com/github/codeql
Issues 991 https://github.com/github/codeql/issues
Pull requests 433 https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality 0 https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Code https://github.com/github/codeql
Issues https://github.com/github/codeql/issues
Pull requests https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
jbjhttps://github.com/jbj
github:mainhttps://github.com/github/codeql/tree/main
jbj:DiffInformedQuery-unit-classhttps://github.com/jbj/ql/tree/DiffInformedQuery-unit-class
Conversation 8 https://github.com/github/codeql/pull/19586
Findings https://github.com/github/codeql/pull/19586/findings
Commits 4 https://github.com/github/codeql/pull/19586/commits
Checks 0 https://github.com/github/codeql/pull/19586/checks
Files changed https://github.com/github/codeql/pull/19586/files
Please reload this pagehttps://github.com/github/codeql/pull/19586/files
Diff-informed queries via primary/secondary abstractions https://github.com/github/codeql/pull/19586/files#top
Show all changes 4 commits https://github.com/github/codeql/pull/19586/files
7c7d639 DataFlow: Single-inheritance activation jbj May 19, 2025 https://github.com/github/codeql/pull/19586/commits/7c7d6395b9df8fa0c0d8e873b8b2b33cb6c556d6
f8922f1 Java: XSS with abstract class (some duplication) jbj May 20, 2025 https://github.com/github/codeql/pull/19586/commits/f8922f10237144bb5aa393897f45f68729f211c0
7600a73 DataFlow: primary and secondary configurations jbj May 26, 2025 https://github.com/github/codeql/pull/19586/commits/7600a73f827cd453296dd61d0a90e15bde3016e7
be3bd4a Java: avoid some duplication in XSS.qll jbj May 26, 2025 https://github.com/github/codeql/pull/19586/commits/be3bd4a6385c0c05ec97e12b2e939735060e6695
Clear filters https://github.com/github/codeql/pull/19586/files
Please reload this pagehttps://github.com/github/codeql/pull/19586/files
Please reload this pagehttps://github.com/github/codeql/pull/19586/files
XSS.qll https://github.com/github/codeql/pull/19586/files#diff-ef42ee67fb4420d5c9293d16d6116139d5a82aa7e6ae4b3ce03ce612dbe0b26a
XssQuery.qll https://github.com/github/codeql/pull/19586/files#diff-e10b53ef78ec0e596f3b7255eff437bd59534551ce426d32786e7dc7d15b5582
XSS.ql https://github.com/github/codeql/pull/19586/files#diff-d912564428bb731beba3829a388c1c06b8fa0a436d663814eee6f01ec0dad278
DataFlow.qll https://github.com/github/codeql/pull/19586/files#diff-518023a19a22b29249dfbdb30a6705a5c1d9f376061a5d2edb5058c9ebecda0c
TaintTracking.qll https://github.com/github/codeql/pull/19586/files#diff-ae3e02f927cf72903707f069a0e8851b522d420fea28b83b367a2162c532deeb
DataFlowImpl.qll https://github.com/github/codeql/pull/19586/files#diff-422b0d1a44600cc15b2eb443f63e43d442017e3c5320c50a8d341433b41b1db7
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
java/ql/lib/semmle/code/java/security/XSS.qllhttps://github.com/github/codeql/pull/19586/files#diff-ef42ee67fb4420d5c9293d16d6116139d5a82aa7e6ae4b3ce03ce612dbe0b26a
View file https://github.com/jbj/ql/blob/be3bd4a6385c0c05ec97e12b2e939735060e6695/java/ql/lib/semmle/code/java/security/XSS.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/19586/{{ revealButtonHref }}
https://github.com/github/codeql/pull/19586/files#diff-ef42ee67fb4420d5c9293d16d6116139d5a82aa7e6ae4b3ce03ce612dbe0b26a
https://github.com/github/codeql/pull/19586/files#diff-ef42ee67fb4420d5c9293d16d6116139d5a82aa7e6ae4b3ce03ce612dbe0b26a
https://github.com/github/codeql/pull/19586/files#diff-ef42ee67fb4420d5c9293d16d6116139d5a82aa7e6ae4b3ce03ce612dbe0b26a
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
java/ql/lib/semmle/code/java/security/XssQuery.qllhttps://github.com/github/codeql/pull/19586/files#diff-e10b53ef78ec0e596f3b7255eff437bd59534551ce426d32786e7dc7d15b5582
View file https://github.com/jbj/ql/blob/be3bd4a6385c0c05ec97e12b2e939735060e6695/java/ql/lib/semmle/code/java/security/XssQuery.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/19586/{{ revealButtonHref }}
https://github.com/github/codeql/pull/19586/files#diff-e10b53ef78ec0e596f3b7255eff437bd59534551ce426d32786e7dc7d15b5582
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
java/ql/src/Security/CWE/CWE-079/XSS.qlhttps://github.com/github/codeql/pull/19586/files#diff-d912564428bb731beba3829a388c1c06b8fa0a436d663814eee6f01ec0dad278
View file https://github.com/jbj/ql/blob/be3bd4a6385c0c05ec97e12b2e939735060e6695/java/ql/src/Security/CWE/CWE-079/XSS.ql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/19586/{{ revealButtonHref }}
https://github.com/github/codeql/pull/19586/files#diff-d912564428bb731beba3829a388c1c06b8fa0a436d663814eee6f01ec0dad278
https://github.com/github/codeql/pull/19586/files#diff-d912564428bb731beba3829a388c1c06b8fa0a436d663814eee6f01ec0dad278
https://github.com/github/codeql/blob/main/CODEOWNERS#L26
shared/dataflow/codeql/dataflow/DataFlow.qllhttps://github.com/github/codeql/pull/19586/files#diff-518023a19a22b29249dfbdb30a6705a5c1d9f376061a5d2edb5058c9ebecda0c
View file https://github.com/jbj/ql/blob/be3bd4a6385c0c05ec97e12b2e939735060e6695/shared/dataflow/codeql/dataflow/DataFlow.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/19586/{{ revealButtonHref }}
https://github.com/github/codeql/pull/19586/files#diff-518023a19a22b29249dfbdb30a6705a5c1d9f376061a5d2edb5058c9ebecda0c
https://github.com/github/codeql/pull/19586/files#diff-518023a19a22b29249dfbdb30a6705a5c1d9f376061a5d2edb5058c9ebecda0c
https://github.com/github/codeql/pull/19586/files#diff-518023a19a22b29249dfbdb30a6705a5c1d9f376061a5d2edb5058c9ebecda0c
https://github.com/github/codeql/pull/19586/files#diff-518023a19a22b29249dfbdb30a6705a5c1d9f376061a5d2edb5058c9ebecda0c
https://github.com/github/codeql/blob/main/CODEOWNERS#L26
shared/dataflow/codeql/dataflow/TaintTracking.qllhttps://github.com/github/codeql/pull/19586/files#diff-ae3e02f927cf72903707f069a0e8851b522d420fea28b83b367a2162c532deeb
View file https://github.com/jbj/ql/blob/be3bd4a6385c0c05ec97e12b2e939735060e6695/shared/dataflow/codeql/dataflow/TaintTracking.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/19586/{{ revealButtonHref }}
https://github.com/github/codeql/pull/19586/files#diff-ae3e02f927cf72903707f069a0e8851b522d420fea28b83b367a2162c532deeb
https://github.com/github/codeql/pull/19586/files#diff-ae3e02f927cf72903707f069a0e8851b522d420fea28b83b367a2162c532deeb
https://github.com/github/codeql/blob/main/CODEOWNERS#L26
shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qllhttps://github.com/github/codeql/pull/19586/files#diff-422b0d1a44600cc15b2eb443f63e43d442017e3c5320c50a8d341433b41b1db7
View file https://github.com/jbj/ql/blob/be3bd4a6385c0c05ec97e12b2e939735060e6695/shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/19586/{{ revealButtonHref }}
https://github.com/github/codeql/pull/19586/files#diff-422b0d1a44600cc15b2eb443f63e43d442017e3c5320c50a8d341433b41b1db7
https://github.com/github/codeql/pull/19586/files#diff-422b0d1a44600cc15b2eb443f63e43d442017e3c5320c50a8d341433b41b1db7
https://github.com/github/codeql/pull/19586/files#diff-422b0d1a44600cc15b2eb443f63e43d442017e3c5320c50a8d341433b41b1db7
https://github.com/github/codeql/pull/19586/files#diff-422b0d1a44600cc15b2eb443f63e43d442017e3c5320c50a8d341433b41b1db7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.