Title: JS: fix and improve diff-informed queries by asgerf · Pull Request #18574 · github/codeql · GitHub
Open Graph Title: JS: fix and improve diff-informed queries by asgerf · Pull Request #18574 · github/codeql
X Title: JS: fix and improve diff-informed queries by asgerf · Pull Request #18574 · github/codeql
Description: There was a bug in the patch query which meant some queries were inadvertently marked as "obviously" safe for diff-informed queries, even though they select a related location. This PR starts by re-running the new fixed version of the patch query, which also does a better job of mentioning which related location is selected. The inserted TODOs are then resolved using the new getASelectedSinkLocation and getASelectedSourceLocation API.
Open Graph Description: There was a bug in the patch query which meant some queries were inadvertently marked as "obviously" safe for diff-informed queries, even though they select a related location. This PR st...
X Description: There was a bug in the patch query which meant some queries were inadvertently marked as "obviously" safe for diff-informed queries, even though they select a related location. Th...
Opengraph URL: https://github.com/github/codeql/pull/18574
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:09b7d913-a3f6-246c-b789-4924b656e1dd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D050:3DB69D:5E5F1C:834F10:6A57C091 |
| html-safe-nonce | 3f4abbbdded9625b408eaabfb0b2d92a6774976c083c2d1f4b76e8ded8747180 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDUwOjNEQjY5RDo1RTVGMUM6ODM0RjEwOjZBNTdDMDkxIiwidmlzaXRvcl9pZCI6IjI2Mjg5MzY4MzkyODIwMTY0MDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a513388b1e60fb1d905b1ef3b22d1465e0c5f96a127d9b1fbf0583119c9afc36 |
| hovercard-subject-tag | pull_request:2294334759 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql/pull/18574/files |
| twitter:image | https://avatars.githubusercontent.com/u/316427?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/316427?s=400&v=4 |
| og:image:alt | There was a bug in the patch query which meant some queries were inadvertently marked as "obviously" safe for diff-informed queries, even though they select a related location. This PR st... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5bf9f84655de1d0e9aa064cd3b2bc9703556c68ae53b94e21b872b7e9f1f7cc1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql git https://github.com/github/codeql.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 143040428 |
| octolytics-dimension-repository_nwo | github/codeql |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 143040428 |
| octolytics-dimension-repository_network_root_nwo | github/codeql |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9e5a4d2583d61726264f5ec9440b26ec7a94eb3f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width