| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:43a86bd4-9909-80e0-70b1-3cc31500e3ea |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EAA0:1EEB:BD34D8:116BDB1:6A4CE15C |
| html-safe-nonce | a92a07fd3704ff6d950605612de8fb2446d1ab5ef2c4269b24e28b1998ed97ef |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUEwOjFFRUI6QkQzNEQ4OjExNkJEQjE6NkE0Q0UxNUMiLCJ2aXNpdG9yX2lkIjoiNjU2OTQ3MDYwNDk0ODA3MDc0OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7e6482d81db27d8fab695efbef61dc261d07cb32a5023dcd5bcfbf910622d6dd |
| hovercard-subject-tag | pull_request:1983656942 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/github/codeql/17053/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5b2df99e17889ce731b708a619a3fccab2e0a7ca7daf479da14058d6607c42a8/github/codeql/pull/17053 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5b2df99e17889ce731b708a619a3fccab2e0a7ca7daf479da14058d6607c42a8/github/codeql/pull/17053 |
| og:image:alt | The sink kind regex-use doesn't match the code which parses regex-use sink kinds for regex injection. It turns out this is intentional, but not clearly documented. This PR adds comments explain... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | owen-mc |
| hostname | github.com |
| expected-hostname | github.com |
| None | 299b43bca6e02ad35197ffeba30d2466846d5fb02ab96fbced5b5e6cec589fb8 |
| turbo-cache-control | no-cache |
| go-import | github.com/github/codeql git https://github.com/github/codeql.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 143040428 |
| octolytics-dimension-repository_nwo | github/codeql |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 143040428 |
| octolytics-dimension-repository_network_root_nwo | github/codeql |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c5a57f04eeb310f57c73fd6d751d957e2ca27ed2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/github/codeql/pull/17053#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F17053 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F17053 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=github%2Fcodeql |
| Reload | https://github.com/github/codeql/pull/17053 |
| Reload | https://github.com/github/codeql/pull/17053 |
| Reload | https://github.com/github/codeql/pull/17053 |
| Please reload this page | https://github.com/github/codeql/pull/17053 |
|
github
| https://github.com/github |
| codeql | https://github.com/github/codeql |
|
Notifications
| https://github.com/login?return_to=%2Fgithub%2Fcodeql |
|
Fork
2k
| https://github.com/login?return_to=%2Fgithub%2Fcodeql |
|
Star
9.8k
| https://github.com/login?return_to=%2Fgithub%2Fcodeql |
|
Code
| https://github.com/github/codeql |
|
Issues
987
| https://github.com/github/codeql/issues |
|
Pull requests
424
| https://github.com/github/codeql/pulls |
|
Discussions
| https://github.com/github/codeql/discussions |
|
Actions
| https://github.com/github/codeql/actions |
|
Projects
| https://github.com/github/codeql/projects |
|
Models
| https://github.com/github/codeql/models |
|
Security and quality
0
| https://github.com/github/codeql/security |
|
Insights
| https://github.com/github/codeql/pulse |
|
Code
| https://github.com/github/codeql |
|
Issues
| https://github.com/github/codeql/issues |
|
Pull requests
| https://github.com/github/codeql/pulls |
|
Discussions
| https://github.com/github/codeql/discussions |
|
Actions
| https://github.com/github/codeql/actions |
|
Projects
| https://github.com/github/codeql/projects |
|
Models
| https://github.com/github/codeql/models |
|
Security and quality
| https://github.com/github/codeql/security |
|
Insights
| https://github.com/github/codeql/pulse |
| owen-mc | https://github.com/owen-mc |
| github:main | https://github.com/github/codeql/tree/main |
| owen-mc:java/fix/regex-use-sink-kind | https://github.com/owen-mc/codeql/tree/java/fix/regex-use-sink-kind |
| Conversation | https://github.com/github/codeql/pull/17053 |
| Commits2 (2) | https://github.com/github/codeql/pull/17053/commits |
| Checks | https://github.com/github/codeql/pull/17053/checks |
| Files changed | https://github.com/github/codeql/pull/17053/files |
| Java: Add comments about use of sink kind regex-use | https://github.com/github/codeql/pull/17053#top |
| owen-mc | https://github.com/owen-mc |
| github:main | https://github.com/github/codeql/tree/main |
| owen-mc:java/fix/regex-use-sink-kind | https://github.com/owen-mc/codeql/tree/java/fix/regex-use-sink-kind |
|
| https://github.com/owen-mc |
| owen-mc | https://github.com/owen-mc |
| Jul 23, 2024 | https://github.com/github/codeql/pull/17053#issue-2425563948 |
| Please reload this page | https://github.com/github/codeql/pull/17053 |
| the code which parses regex-use sink kinds | https://github.com/github/codeql/blob/4c8da54b64d67aa958ed8875492f962bb1c5c5af/java/ql/lib/semmle/code/java/regex/RegexFlowConfigs.qll#L20-L49 |
| Please reload this page | https://github.com/github/codeql/pull/17053 |
| https://github.com/owen-mc |
| owen-mc | https://github.com/owen-mc |
| code owner | https://github.com/github/codeql/blob/4c8da54b64d67aa958ed8875492f962bb1c5c5af/CODEOWNERS#L6 |
| July 23, 2024 15:58 | https://github.com/github/codeql/pull/17053#event-13618101728 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Java
| https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AJava |
| Jul 23, 2024 | https://github.com/github/codeql/pull/17053#event-13618104092 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Jul 23, 2024 | https://github.com/github/codeql/pull/17053#issuecomment-2245641532 |
| Please reload this page | https://github.com/github/codeql/pull/17053 |
| Please reload this page | https://github.com/github/codeql/pull/17053 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
documentation
| https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Adocumentation |
| Jul 23, 2024 | https://github.com/github/codeql/pull/17053#event-13618143027 |
| https://github.com/jcogs33 |
| jcogs33 | https://github.com/jcogs33 |
|
Jul 23, 2024
| https://github.com/github/codeql/pull/17053#pullrequestreview-2194615722 |
|
View reviewed changes
| https://github.com/github/codeql/pull/17053/files |
| jcogs33 | https://github.com/jcogs33 |
| https://github.com/github/codeql/pull/17053#pullrequestreview-2194615722 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @owen-mc | https://github.com/owen-mc |
| here | https://github.com/github/codeql/pull/11070#discussion_r1015494987 |
| Please reload this page | https://github.com/github/codeql/pull/17053 |
| owen-mc | https://github.com/owen-mc |
| July 23, 2024 21:38 | https://github.com/github/codeql/pull/17053#commits-pushed-89f9581 |
|
| https://github.com/owen-mc |
| Mention regex-use sink kind in QLDoc for regexSinkKindInfo | https://github.com/github/codeql/pull/17053/commits/89f958105a3ffba24eea6d24ac90669b0fa25dc8 |
| 89f9581 | https://github.com/github/codeql/pull/17053/commits/89f958105a3ffba24eea6d24ac90669b0fa25dc8 |
|
| https://github.com/owen-mc |
| Add comment by models using regex-use sink kind | https://github.com/github/codeql/pull/17053/commits/3edeb82d5b9b332f89eb4e9fd4bc55c2f78ebcca |
| 3edeb82 | https://github.com/github/codeql/pull/17053/commits/3edeb82d5b9b332f89eb4e9fd4bc55c2f78ebcca |
| https://github.com/owen-mc |
| owen-mc | https://github.com/owen-mc |
| force-pushed | https://github.com/github/codeql/compare/01f78cd9393ecfeb94a48760228d267c4938e368..3edeb82d5b9b332f89eb4e9fd4bc55c2f78ebcca |
| 01f78cd | https://github.com/github/codeql/commit/01f78cd9393ecfeb94a48760228d267c4938e368 |
| 3edeb82 | https://github.com/github/codeql/commit/3edeb82d5b9b332f89eb4e9fd4bc55c2f78ebcca |
|
Compare
| https://github.com/github/codeql/compare/01f78cd9393ecfeb94a48760228d267c4938e368..3edeb82d5b9b332f89eb4e9fd4bc55c2f78ebcca |
| July 23, 2024 20:40 | https://github.com/github/codeql/pull/17053#event-13621316151 |
| https://github.com/owen-mc |
| owen-mc | https://github.com/owen-mc |
|
no-change-note-required
| https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Ano-change-note-required |
| Jul 23, 2024 | https://github.com/github/codeql/pull/17053#event-13621317874 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
documentation
| https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Adocumentation |
|
no-change-note-required
| https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Ano-change-note-required |
| Jul 23, 2024 | https://github.com/github/codeql/pull/17053#event-13621317979 |
| https://github.com/owen-mc |
| owen-mc | https://github.com/owen-mc |
| Jul 23, 2024 | https://github.com/github/codeql/pull/17053#issuecomment-2246273638 |
| @jcogs33 | https://github.com/jcogs33 |
| Please reload this page | https://github.com/github/codeql/pull/17053 |
| https://github.com/owen-mc |
| owen-mc | https://github.com/owen-mc |
| Jul 23, 2024 | https://github.com/github/codeql/pull/17053#event-13621328999 |
| https://github.com/owen-mc |
| owen-mc | https://github.com/owen-mc |
|
no-change-note-required
| https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Ano-change-note-required |
| Jul 23, 2024 | https://github.com/github/codeql/pull/17053#event-13621336584 |
| https://github.com/jcogs33 |
| jcogs33 | https://github.com/jcogs33 |
|
Jul 24, 2024
| https://github.com/github/codeql/pull/17053#pullrequestreview-2197361048 |
|
View reviewed changes
| https://github.com/github/codeql/pull/17053/files/3edeb82d5b9b332f89eb4e9fd4bc55c2f78ebcca |
| https://github.com/owen-mc |
| owen-mc | https://github.com/owen-mc |
| 5a39610 | https://github.com/github/codeql/commit/5a39610ba72bc22ef06d7a531eb50ec5f5936db1 |
| Jul 24, 2024 | https://github.com/github/codeql/pull/17053#event-13635847199 |
| https://github.com/owen-mc |
| owen-mc | https://github.com/owen-mc |
| July 24, 2024 20:08 | https://github.com/github/codeql/pull/17053#event-13635847479 |
| https://github.com/joefarebrother |
| joefarebrother | https://github.com/joefarebrother |
| Jul 24, 2024 | https://github.com/github/codeql/pull/17053#issuecomment-2248874305 |
| Please reload this page | https://github.com/github/codeql/pull/17053 |
| https://github.com/jcogs33 |
| jcogs33 | https://github.com/jcogs33 |
| Jul 25, 2024 | https://github.com/github/codeql/pull/17053#issuecomment-2250489692 |
| @owen-mc | https://github.com/owen-mc |
| @joefarebrother | https://github.com/joefarebrother |
| Please reload this page | https://github.com/github/codeql/pull/17053 |
| https://github.com/jcogs33 |
| jcogs33 | https://github.com/jcogs33 |
|
Jul 25, 2024
| https://github.com/github/codeql/pull/17053#ref-pullrequest-2430157907 |
|
Java: fix comments about use of sink kind regex-use
#17074
| https://github.com/github/codeql/pull/17074 |
| https://github.co/hiddenchars |
| https://github.com/github/codeql/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F17053 |
|
| https://github.com/jcogs33 |
|
jcogs33
| https://github.com/jcogs33 |
|
| https://github.com/github/codeql/pull/17053/files/3edeb82d5b9b332f89eb4e9fd4bc55c2f78ebcca |
|
Java
| https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AJava |
|
no-change-note-required
| https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Ano-change-note-required |
| Please reload this page | https://github.com/github/codeql/pull/17053 |
|
| https://github.com/owen-mc |
|
| https://github.com/joefarebrother |
|
| https://github.com/jcogs33 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |