René's URL Explorer Experiment


Title: Go: Fix test expectations by owen-mc · Pull Request #16464 · github/codeql · GitHub

Open Graph Title: Go: Fix test expectations by owen-mc · Pull Request #16464 · github/codeql

X Title: Go: Fix test expectations by owen-mc · Pull Request #16464 · github/codeql

Description: I'm pretty sure this is what happened: #16457 was merged #16458 was merged without rebasing or merging in main the combination of the two meant that the test in question can now find paths using the existing taint flow using old-style go function models or value flow using the new-style go MaD models. This leads to extra edges and nodes without any extra results. This will be fixed when #16413 is merged, which removes the old-style models. (Both of the above PRs were bug-fixes that I pulled out of #16413.)

Open Graph Description: I'm pretty sure this is what happened: #16457 was merged #16458 was merged without rebasing or merging in main the combination of the two meant that the test in question can now find paths usi...

X Description: I'm pretty sure this is what happened: #16457 was merged #16458 was merged without rebasing or merging in main the combination of the two meant that the test in question can now find paths...

Opengraph URL: https://github.com/github/codeql/pull/16464

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f2dde365-6436-e56a-c9ee-59f622bb489e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB5C8:223194:D2FF3C:11736D2:6AF8652B
html-safe-noncefd08f270fb8a0a45f3894144b28ec5124f8d30cccaeefe82ff70019907c1b548
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNUM4OjIyMzE5NDpEMkZGM0M6MTE3MzZEMjo2QUY4NjUyQiIsInZpc2l0b3JfaWQiOiI2NjA1MzM5MjcxNjg0NjgyNjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac27d4e81acda9246d9b3f818ebadabdd2e2a23fc95f8bbeff22c80672f86acffd
hovercard-subject-tagpull_request:1862328140
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql/pull/16464/files
twitter:imagehttps://avatars.githubusercontent.com/u/62447351?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/62447351?s=400&v=4
og:image:altI'm pretty sure this is what happened: #16457 was merged #16458 was merged without rebasing or merging in main the combination of the two meant that the test in question can now find paths usi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5713ecd83001b2f55c3509fb7a292bf7d66d0f167c7ae87a9f7eaec5a52bf8db
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release653be32ff5c755082a4db662491bfbbcfc9112c1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/16464/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F16464%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F16464%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/16464/files
Reloadhttps://github.com/github/codeql/pull/16464/files
Reloadhttps://github.com/github/codeql/pull/16464/files
githubhttps://github.com/github
codeqlhttps://github.com/github/codeql
Codehttps://github.com/github/codeql
Issues1k (1k)https://github.com/github/codeql/issues
Pull requests516 (516)https://github.com/github/codeql/pulls
Discussionshttps://github.com/github/codeql/discussions
Actionshttps://github.com/github/codeql/actions
Projectshttps://github.com/github/codeql/projects
Security and qualityhttps://github.com/github/codeql/security
Insightshttps://github.com/github/codeql/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
owen-mchttps://github.com/owen-mc
github:mainhttps://github.com/github/codeql/tree/main
owen-mc:go/fix-broken-testhttps://github.com/owen-mc/codeql/tree/go/fix-broken-test
Conversation 1 https://github.com/github/codeql/pull/16464
Commits 1 https://github.com/github/codeql/pull/16464/commits
Checks 0 https://github.com/github/codeql/pull/16464/checks
Findings https://github.com/github/codeql/pull/16464/findings
Files changed https://github.com/github/codeql/pull/16464/files
Please reload this pagehttps://github.com/github/codeql/pull/16464/files
Go: Fix test expectations https://github.com/github/codeql/pull/16464/files#top
Show all changes 1 commit https://github.com/github/codeql/pull/16464/files
674e65e Fix test expectations owen-mc May 9, 2024 https://github.com/github/codeql/pull/16464/commits/674e65e134d95b9b78a254b99df6dab0f0b7e730
Clear filters https://github.com/github/codeql/pull/16464/files
Please reload this pagehttps://github.com/github/codeql/pull/16464/files
Please reload this pagehttps://github.com/github/codeql/pull/16464/files
https://github.com/github/codeql/blob/main/CODEOWNERS#L10
go/ql/test/query-tests/Security/CWE-078/CommandInjection.expectedhttps://github.com/github/codeql/pull/16464/files#diff-cc031605d31e05587fee04c1b1900ef5d4ebaed669fe795a5474f28b97118ea4
View file https://github.com/owen-mc/codeql/blob/674e65e134d95b9b78a254b99df6dab0f0b7e730/go/ql/test/query-tests/Security/CWE-078/CommandInjection.expected
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/16464/{{ revealButtonHref }}
https://github.com/github/codeql/pull/16464/files#diff-cc031605d31e05587fee04c1b1900ef5d4ebaed669fe795a5474f28b97118ea4
https://github.com/github/codeql/pull/16464/files#diff-cc031605d31e05587fee04c1b1900ef5d4ebaed669fe795a5474f28b97118ea4
https://github.com/github/codeql/pull/16464/files#diff-cc031605d31e05587fee04c1b1900ef5d4ebaed669fe795a5474f28b97118ea4
https://github.com/github/codeql/pull/16464/files#diff-cc031605d31e05587fee04c1b1900ef5d4ebaed669fe795a5474f28b97118ea4
https://github.com/github/codeql/pull/16464/files#diff-cc031605d31e05587fee04c1b1900ef5d4ebaed669fe795a5474f28b97118ea4
https://github.com/github/codeql/pull/16464/files#diff-cc031605d31e05587fee04c1b1900ef5d4ebaed669fe795a5474f28b97118ea4
https://github.com/github/codeql/pull/16464/files#diff-cc031605d31e05587fee04c1b1900ef5d4ebaed669fe795a5474f28b97118ea4
https://github.com/github/codeql/pull/16464/files#diff-cc031605d31e05587fee04c1b1900ef5d4ebaed669fe795a5474f28b97118ea4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.