René's URL Explorer Experiment

Title: Go: fix `hasQualifiedName` and models-as-data for built-in functions by owen-mc · Pull Request #16458 · github/codeql · GitHub

Open Graph Title: Go: fix `hasQualifiedName` and models-as-data for built-in functions by owen-mc · Pull Request #16458 · github/codeql

X Title: Go: fix `hasQualifiedName` and models-as-data for built-in functions by owen-mc · Pull Request #16458 · github/codeql

Description: Fixed a bug that stopped built-in functions from being referenced using the predicate hasQualifiedName because technically they do not belong to any package. Now you can use the empty string as the package, e.g. f.hasQualifiedName("", "len"). Fixed a bug that stopped data flow models for built-in functions from having any effect because the package "" was not parsed correctly. I've pulled this commit out of #16413 so that it can be reviewed in isolation. I don't think it needs a test because it is tested by that PR, which gets our only MaD models for built-in functions working properly. I don't think there is any need for performance testing, but I can do it if someone wants it.

Open Graph Description: Fixed a bug that stopped built-in functions from being referenced using the predicate hasQualifiedName because technically they do not belong to any package. Now you can use the empty string as the...

X Description: Fixed a bug that stopped built-in functions from being referenced using the predicate hasQualifiedName because technically they do not belong to any package. Now you can use the empty string as the...

Opengraph URL: https://github.com/github/codeql/pull/16458

X: @github

direct link

Domain: github.com

react-profiling	0
react-import-map	react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern	/:user_id/:repository/pull/:id/files(.:format)
route-controller	pull_requests
route-action	files
fetch-nonce	v2:5809456e-4b7f-a89d-b8ce-25fec2e17dcc
current-catalog-service-hash	ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id	AEE4:1E44FA:96FA05:D0E495:6AF8651F
html-safe-nonce	be8568c20349ec0f7a793f4c1a9bbb58c510900d49e540ff914d6686c9c2464e
visitor-payload	eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUU0OjFFNDRGQTo5NkZBMDU6RDBFNDk1OjZBRjg2NTFGIiwidmlzaXRvcl9pZCI6IjUwMzgyNTk2MzM3MzUwOTk2NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac	5de5c64479f4fa9ad39e82f2095289bbe67d485f41924a156a368aa3d4b29bc5
hovercard-subject-tag	pull_request:1860431435
github-keyboard-shortcuts	repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verification	Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-url	https://collector.github.com/github/collect
analytics-location	///pull_requests/show/files
fb:app_id	1401488693436528
apple-itunes-app	app-id=1477376905, app-argument=https://github.com/github/codeql/pull/16458/files
twitter:image	https://avatars.githubusercontent.com/u/62447351?s=400&v=4
twitter:card	summary_large_image
og:image	https://avatars.githubusercontent.com/u/62447351?s=400&v=4
og:image:alt	Fixed a bug that stopped built-in functions from being referenced using the predicate hasQualifiedName because technically they do not belong to any package. Now you can use the empty string as the...
og:site_name	GitHub
og:type	object
hostname	github.com
expected-hostname	github.com
None	5713ecd83001b2f55c3509fb7a292bf7d66d0f167c7ae87a9f7eaec5a52bf8db
turbo-cache-control	no-preview
diff-view	unified
go-import	github.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id	9919
octolytics-dimension-user_login	github
octolytics-dimension-repository_id	143040428
octolytics-dimension-repository_nwo	github/codeql
octolytics-dimension-repository_public	true
octolytics-dimension-repository_is_fork	false
octolytics-dimension-repository_network_root_id	143040428
octolytics-dimension-repository_network_root_nwo	github/codeql
turbo-body-classes	logged-out env-production page-responsive full-width
disable-turbo	true
browser-stats-url	https://api.github.com/_private/browser/stats
browser-errors-url	https://api.github.com/_private/browser/errors
release	653be32ff5c755082a4db662491bfbbcfc9112c1
ui-target	full
theme-color	#1e2327
color-scheme	light dark

Links:

Skip to content	https://github.com/github/codeql/pull/16458/files#start-of-content
	https://github.com/
Sign in	https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F16458%2Ffiles
GitHubRepository hosting, code review, and collaboration	https://github.com/platform
CopilotAI coding agent for tasks, projects, and automated work	https://github.com/features/copilot
ActionsCI/CD and automation	https://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcement	https://github.com/features/code-quality
CodespacesCloud development environments	https://github.com/features/codespaces
Code SecurityVulnerability detection and remediation	https://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak prevention	https://github.com/security/advanced-security/secret-protection
All Features	https://github.com/features
Documentation	https://docs.github.com/en
Training	https://learn.github.com/skills
Certifications	https://learn.github.com/credentials
Build with Copilot	https://github.com/features/ai
Customize Copilot	https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrations	https://github.com/marketplace
Trending repos	https://github.com/trending
GitHub Sponsors	https://github.com/open-source/sponsors
Developer articles	https://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.	https://github.blog/changelog/
Enterprises	https://github.com/enterprise
Team	https://github.com/team
Startups	https://github.com/enterprise/startups
Nonprofits	https://github.com/solutions/industry/nonprofits
Healthcare	https://github.com/solutions/industry/healthcare
Financial services	https://github.com/solutions/industry/financial-services
Manufacturing	https://github.com/solutions/industry/manufacturing
Government	https://github.com/solutions/industry/government
See all industries	https://github.com/solutions/industry
Why GitHub	https://github.com/why-github
Customer Stories	https://github.com/customer-stories
Business insights	https://github.com/solutions/executive-insights
Trust Center	https://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code security	https://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI features	https://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 support	https://github.com/enterprise/premium-support
Documentation	https://docs.github.com/en
Resource center	https://github.com/resources
Blog	https://github.blog/
Events & webinars	https://github.com/resources/events
Community Forum	https://github.com/orgs/community/discussions
Customer Stories	https://github.com/customer-stories
Integrations	https://github.com/marketplace
Customer support	https://help.github.com/
Training	https://learn.github.com/skills
GitHub Status	https://www.githubstatus.com/
About	https://github.com/about
Partners	https://github.com/partners
Changelog	https://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.	https://githubuniverse.com/
Pricing	https://github.com/pricing
Sign in	https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F16458%2Ffiles
Sign up	https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql
Reload	https://github.com/github/codeql/pull/16458/files
Reload	https://github.com/github/codeql/pull/16458/files
Reload	https://github.com/github/codeql/pull/16458/files
github	https://github.com/github
codeql	https://github.com/github/codeql
Code	https://github.com/github/codeql
Issues1k (1k)	https://github.com/github/codeql/issues
Pull requests516 (516)	https://github.com/github/codeql/pulls
Discussions	https://github.com/github/codeql/discussions
Actions	https://github.com/github/codeql/actions
Projects	https://github.com/github/codeql/projects
Security and quality	https://github.com/github/codeql/security
Insights	https://github.com/github/codeql/pulse
Sign up for GitHub	https://github.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
terms of service	https://docs.github.com/terms
privacy statement	https://docs.github.com/privacy
Sign in	https://github.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
owen-mc	https://github.com/owen-mc
github:main	https://github.com/github/codeql/tree/main
owen-mc:go/fix-mad-for-builtin-functions	https://github.com/owen-mc/codeql/tree/go/fix-mad-for-builtin-functions
Conversation 0	https://github.com/github/codeql/pull/16458
Commits 5	https://github.com/github/codeql/pull/16458/commits
Checks 0	https://github.com/github/codeql/pull/16458/checks
Findings	https://github.com/github/codeql/pull/16458/findings
Files changed	https://github.com/github/codeql/pull/16458/files
Please reload this page	https://github.com/github/codeql/pull/16458/files
Go: fix hasQualifiedName and models-as-data for built-in functions	https://github.com/github/codeql/pull/16458/files#top
Show all changes 5 commits	https://github.com/github/codeql/pull/16458/files
fb74a2a Use "" in qualified name for entities without a package owen-mc May 6, 2024	https://github.com/github/codeql/pull/16458/commits/fb74a2a170246090195da7e8fa806a47e9580939
f6f594e parse empty string as package name owen-mc May 6, 2024	https://github.com/github/codeql/pull/16458/commits/f6f594e4b580a7ba50b4591f87fa104502524388
1ccea88 Add change note owen-mc May 8, 2024	https://github.com/github/codeql/pull/16458/commits/1ccea884ff37e261ebea4c9bab34aa6d6f6229a4
57ff30c Update tests: built-in models now work owen-mc May 8, 2024	https://github.com/github/codeql/pull/16458/commits/57ff30c5f3510319313c8521514bf4e502b597a1
4f10cb5 Local flow tests: do not list summary models owen-mc May 8, 2024	https://github.com/github/codeql/pull/16458/commits/4f10cb5fa08688c3f61413a88b9f286f1d3bd9f7
Clear filters	https://github.com/github/codeql/pull/16458/files
Please reload this page	https://github.com/github/codeql/pull/16458/files
Please reload this page	https://github.com/github/codeql/pull/16458/files
2024-05-08-builtin-functions-no-package.md	https://github.com/github/codeql/pull/16458/files#diff-aa3704a727fa01be974dede561460406be7883ad303390bbba0fb68a6fb0d0aa
Scopes.qll	https://github.com/github/codeql/pull/16458/files#diff-46e38116c1c54c6a7b2ca7cfb2f2ad52edf170531a180630c8a0052e7f49c943
ExternalFlow.qll	https://github.com/github/codeql/pull/16458/files#diff-871e92b3cb5f0b3624e585a1f9dbbab7e383d29439bd01d358f0ea072306790e
LocalFlowStep.ql	https://github.com/github/codeql/pull/16458/files#diff-4b3cd8df6a18adfcb08f6ff75e52142c7b25d77073c219276cb5e39f4841ea5d
LocalFlowStep.ql	https://github.com/github/codeql/pull/16458/files#diff-03f763dab02df77f915b4944e2185af03f9313b7e5b0c64e7d68442cfa855214
CommandInjection.expected	https://github.com/github/codeql/pull/16458/files#diff-cc031605d31e05587fee04c1b1900ef5d4ebaed669fe795a5474f28b97118ea4
	https://github.com/github/codeql/blob/main/CODEOWNERS#L10
go/ql/lib/change-notes/2024-05-08-builtin-functions-no-package.md	https://github.com/github/codeql/pull/16458/files#diff-aa3704a727fa01be974dede561460406be7883ad303390bbba0fb68a6fb0d0aa
View file	https://github.com/owen-mc/codeql/blob/4f10cb5fa08688c3f61413a88b9f286f1d3bd9f7/go/ql/lib/change-notes/2024-05-08-builtin-functions-no-package.md
Open in desktop	https://desktop.github.com
	https://github.co/hiddenchars
	https://github.com/github/codeql/pull/16458/{{ revealButtonHref }}
	https://github.com/github/codeql/blob/main/CODEOWNERS#L10
go/ql/lib/semmle/go/Scopes.qll	https://github.com/github/codeql/pull/16458/files#diff-46e38116c1c54c6a7b2ca7cfb2f2ad52edf170531a180630c8a0052e7f49c943
View file	https://github.com/owen-mc/codeql/blob/4f10cb5fa08688c3f61413a88b9f286f1d3bd9f7/go/ql/lib/semmle/go/Scopes.qll
Open in desktop	https://desktop.github.com
	https://github.co/hiddenchars
	https://github.com/github/codeql/pull/16458/{{ revealButtonHref }}
	https://github.com/github/codeql/pull/16458/files#diff-46e38116c1c54c6a7b2ca7cfb2f2ad52edf170531a180630c8a0052e7f49c943
	https://github.com/github/codeql/pull/16458/files#diff-46e38116c1c54c6a7b2ca7cfb2f2ad52edf170531a180630c8a0052e7f49c943
	https://github.com/github/codeql/blob/main/CODEOWNERS#L10
go/ql/lib/semmle/go/dataflow/ExternalFlow.qll	https://github.com/github/codeql/pull/16458/files#diff-871e92b3cb5f0b3624e585a1f9dbbab7e383d29439bd01d358f0ea072306790e
View file	https://github.com/owen-mc/codeql/blob/4f10cb5fa08688c3f61413a88b9f286f1d3bd9f7/go/ql/lib/semmle/go/dataflow/ExternalFlow.qll
Open in desktop	https://desktop.github.com
	https://github.co/hiddenchars
	https://github.com/github/codeql/pull/16458/{{ revealButtonHref }}
	https://github.com/github/codeql/pull/16458/files#diff-871e92b3cb5f0b3624e585a1f9dbbab7e383d29439bd01d358f0ea072306790e
	https://github.com/github/codeql/pull/16458/files#diff-871e92b3cb5f0b3624e585a1f9dbbab7e383d29439bd01d358f0ea072306790e
	https://github.com/github/codeql/blob/main/CODEOWNERS#L10
go/ql/test/library-tests/semmle/go/dataflow/FlowSteps/LocalFlowStep.ql	https://github.com/github/codeql/pull/16458/files#diff-4b3cd8df6a18adfcb08f6ff75e52142c7b25d77073c219276cb5e39f4841ea5d
View file	https://github.com/owen-mc/codeql/blob/4f10cb5fa08688c3f61413a88b9f286f1d3bd9f7/go/ql/test/library-tests/semmle/go/dataflow/FlowSteps/LocalFlowStep.ql
Open in desktop	https://desktop.github.com
	https://github.co/hiddenchars
	https://github.com/github/codeql/pull/16458/{{ revealButtonHref }}
	https://github.com/github/codeql/blob/main/CODEOWNERS#L10
go/ql/test/library-tests/semmle/go/dataflow/PromotedFields/LocalFlowStep.ql	https://github.com/github/codeql/pull/16458/files#diff-03f763dab02df77f915b4944e2185af03f9313b7e5b0c64e7d68442cfa855214
View file	https://github.com/owen-mc/codeql/blob/4f10cb5fa08688c3f61413a88b9f286f1d3bd9f7/go/ql/test/library-tests/semmle/go/dataflow/PromotedFields/LocalFlowStep.ql
Open in desktop	https://desktop.github.com
	https://github.co/hiddenchars
	https://github.com/github/codeql/pull/16458/{{ revealButtonHref }}
	https://github.com/github/codeql/blob/main/CODEOWNERS#L10
go/ql/test/query-tests/Security/CWE-078/CommandInjection.expected	https://github.com/github/codeql/pull/16458/files#diff-cc031605d31e05587fee04c1b1900ef5d4ebaed669fe795a5474f28b97118ea4
View file	https://github.com/owen-mc/codeql/blob/4f10cb5fa08688c3f61413a88b9f286f1d3bd9f7/go/ql/test/query-tests/Security/CWE-078/CommandInjection.expected
Open in desktop	https://desktop.github.com
	https://github.co/hiddenchars
	https://github.com/github/codeql/pull/16458/{{ revealButtonHref }}
	https://github.com/github/codeql/pull/16458/files#diff-cc031605d31e05587fee04c1b1900ef5d4ebaed669fe795a5474f28b97118ea4
	https://github.com/github/codeql/pull/16458/files#diff-cc031605d31e05587fee04c1b1900ef5d4ebaed669fe795a5474f28b97118ea4
	https://github.com/github/codeql/pull/16458/files#diff-cc031605d31e05587fee04c1b1900ef5d4ebaed669fe795a5474f28b97118ea4
	https://github.com/github/codeql/pull/16458/files#diff-cc031605d31e05587fee04c1b1900ef5d4ebaed669fe795a5474f28b97118ea4
	https://github.com/github/codeql/pull/16458/files#diff-cc031605d31e05587fee04c1b1900ef5d4ebaed669fe795a5474f28b97118ea4
	https://github.com/github/codeql/pull/16458/files#diff-cc031605d31e05587fee04c1b1900ef5d4ebaed669fe795a5474f28b97118ea4
	https://github.com/github/codeql/pull/16458/files#diff-cc031605d31e05587fee04c1b1900ef5d4ebaed669fe795a5474f28b97118ea4
	https://github.com/github/codeql/pull/16458/files#diff-cc031605d31e05587fee04c1b1900ef5d4ebaed669fe795a5474f28b97118ea4
	https://github.com/github/codeql/pull/16458/files#diff-cc031605d31e05587fee04c1b1900ef5d4ebaed669fe795a5474f28b97118ea4
	https://github.com
Terms	https://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacy	https://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Security	https://github.com/security
Status	https://www.githubstatus.com/
Community	https://github.community/
Docs	https://docs.github.com/
Contact	https://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.