René's URL Explorer Experiment


Title: Go: fix models for built-in functions by owen-mc · Pull Request #16413 · github/codeql · GitHub

Open Graph Title: Go: fix models for built-in functions by owen-mc · Pull Request #16413 · github/codeql

X Title: Go: fix models for built-in functions by owen-mc · Pull Request #16413 · github/codeql

Description: CodeQL: the libraries and queries that power security researchers around the world, as well as code scanning in GitHub Advanced Security - Go: fix models for built-in functions by owen-mc · Pull Request #16413 · github/codeql

Open Graph Description: Our model for append was wrong, as append is variadic. We were missing a model for copy. Here are the package docs and the relevant part of the spec. I had to fix two bugs which I made into separat...

X Description: Our model for append was wrong, as append is variadic. We were missing a model for copy. Here are the package docs and the relevant part of the spec. I had to fix two bugs which I made into separat...

Opengraph URL: https://github.com/github/codeql/pull/16413

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:10e1c5ab-30cc-82ac-4e04-4ec0eeb6157f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB206:1E4D9D:921DF5:CA1A35:6AF862DB
html-safe-nonce36cbc48d27ad1122162c827c26f2309e905202df231a02d5b5098eeb3a7478ac
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjA2OjFFNEQ5RDo5MjFERjU6Q0ExQTM1OjZBRjg2MkRCIiwidmlzaXRvcl9pZCI6IjU3Nzk2ODU4ODM2OTQ4MzQzOTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacec432908fcdbf7577b3c5fbce6cd01c51b21e079b213368cd2b04ab831a80cbd
hovercard-subject-tagpull_request:1853222092
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql/pull/16413/commits
twitter:imagehttps://opengraph.githubassets.com/b76a4bc261bbce1404bc70e92904908cfc84ab92167b784432d35145542fb0da/github/codeql/pull/16413
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b76a4bc261bbce1404bc70e92904908cfc84ab92167b784432d35145542fb0da/github/codeql/pull/16413
og:image:altOur model for append was wrong, as append is variadic. We were missing a model for copy. Here are the package docs and the relevant part of the spec. I had to fix two bugs which I made into separat...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameowen-mc
hostnamegithub.com
expected-hostnamegithub.com
None5713ecd83001b2f55c3509fb7a292bf7d66d0f167c7ae87a9f7eaec5a52bf8db
turbo-cache-controlno-cache
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release653be32ff5c755082a4db662491bfbbcfc9112c1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/github/codeql/pull/16413/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F16413%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F16413%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/16413/commits
Reloadhttps://github.com/github/codeql/pull/16413/commits
Reloadhttps://github.com/github/codeql/pull/16413/commits
githubhttps://github.com/github
codeqlhttps://github.com/github/codeql
Codehttps://github.com/github/codeql
Issues1k (1k)https://github.com/github/codeql/issues
Pull requests516 (516)https://github.com/github/codeql/pulls
Discussionshttps://github.com/github/codeql/discussions
Actionshttps://github.com/github/codeql/actions
Projectshttps://github.com/github/codeql/projects
Security and qualityhttps://github.com/github/codeql/security
Insightshttps://github.com/github/codeql/pulse
https://github.com/github/codeql
owen-mchttps://github.com/owen-mc
github:mainhttps://github.com/github/codeql/tree/main
owen-mc:go/fix-builtin-modelshttps://github.com/owen-mc/codeql/tree/go/fix-builtin-models
Conversationhttps://github.com/github/codeql/pull/16413
Commits16 (16)https://github.com/github/codeql/pull/16413/commits
Checkshttps://github.com/github/codeql/pull/16413/checks
Findingshttps://github.com/github/codeql/pull/16413/findings
Files changedhttps://github.com/github/codeql/pull/16413/files
Go: fix models for built-in functionshttps://github.com/github/codeql/pull/16413/commits#top
owen-mchttps://github.com/owen-mc
github:mainhttps://github.com/github/codeql/tree/main
owen-mc:go/fix-builtin-modelshttps://github.com/owen-mc/codeql/tree/go/fix-builtin-models
Fix model for `append` - it is variadichttps://github.com/github/codeql/pull/16413/commits/e857eedd4a5c8b0105729e653ec94f862e57e4b7
https://github.com/owen-mc
owen-mchttps://github.com/github/codeql/commits?author=owen-mc
e857eedhttps://github.com/github/codeql/pull/16413/commits/e857eedd4a5c8b0105729e653ec94f862e57e4b7
https://github.com/github/codeql/tree/e857eedd4a5c8b0105729e653ec94f862e57e4b7
Add model for built-in function `copy`https://github.com/github/codeql/pull/16413/commits/1322ce35d6285ee392ea887b0f25a68eb565b416
https://github.com/owen-mc
owen-mchttps://github.com/github/codeql/commits?author=owen-mc
1322ce3https://github.com/github/codeql/pull/16413/commits/1322ce35d6285ee392ea887b0f25a68eb565b416
https://github.com/github/codeql/tree/1322ce35d6285ee392ea887b0f25a68eb565b416
Add models for `min` and `max` built-in functionshttps://github.com/github/codeql/pull/16413/commits/fcdac0aeb0a7eae4993cec9bbcae19f59a331bd5
https://github.com/owen-mc
owen-mchttps://github.com/github/codeql/commits?author=owen-mc
fcdac0ahttps://github.com/github/codeql/pull/16413/commits/fcdac0aeb0a7eae4993cec9bbcae19f59a331bd5
https://github.com/github/codeql/tree/fcdac0aeb0a7eae4993cec9bbcae19f59a331bd5
Remove old-style models of built-in functionshttps://github.com/github/codeql/pull/16413/commits/f95ccd242f2867cf13773dadab516784962b42b1
https://github.com/owen-mc
owen-mchttps://github.com/github/codeql/commits?author=owen-mc
f95ccd2https://github.com/github/codeql/pull/16413/commits/f95ccd242f2867cf13773dadab516784962b42b1
https://github.com/github/codeql/tree/f95ccd242f2867cf13773dadab516784962b42b1
Rename test folder `ExternalFlow` to `ExternalTaintFlow`https://github.com/github/codeql/pull/16413/commits/84b7319688c9ea7b4c3d921b4db6e6948ae0dbd5
https://github.com/owen-mc
owen-mchttps://github.com/github/codeql/commits?author=owen-mc
84b7319https://github.com/github/codeql/pull/16413/commits/84b7319688c9ea7b4c3d921b4db6e6948ae0dbd5
https://github.com/github/codeql/tree/84b7319688c9ea7b4c3d921b4db6e6948ae0dbd5
Create copy of `ExternalTaintFlow` called `ExternalValueFlow`https://github.com/github/codeql/pull/16413/commits/c81641279558295baa8c05fb45f9e1eec370ffc7
https://github.com/owen-mc
owen-mchttps://github.com/github/codeql/commits?author=owen-mc
c816412https://github.com/github/codeql/pull/16413/commits/c81641279558295baa8c05fb45f9e1eec370ffc7
https://github.com/github/codeql/tree/c81641279558295baa8c05fb45f9e1eec370ffc7
Update `ExternalValueFlow` to use value flowhttps://github.com/github/codeql/pull/16413/commits/eab156934241d402b9baabab7aaa75528920d2ae
https://github.com/owen-mc
owen-mchttps://github.com/github/codeql/commits?author=owen-mc
eab1569https://github.com/github/codeql/pull/16413/commits/eab156934241d402b9baabab7aaa75528920d2ae
https://github.com/github/codeql/tree/eab156934241d402b9baabab7aaa75528920d2ae
Add tests for `copy` (taint passes, value fails)https://github.com/github/codeql/pull/16413/commits/86e2b845f32a97a82717cdb5f9e8c636f15a00ce
https://github.com/owen-mc
owen-mchttps://github.com/github/codeql/commits?author=owen-mc
86e2b84https://github.com/github/codeql/pull/16413/commits/86e2b845f32a97a82717cdb5f9e8c636f15a00ce
https://github.com/github/codeql/tree/86e2b845f32a97a82717cdb5f9e8c636f15a00ce
Local flow steps for flow summaries for built-in functionshttps://github.com/github/codeql/pull/16413/commits/d5aa08dbf35e0a30cff658a279ccc60a98b83ed1
https://github.com/owen-mc
owen-mchttps://github.com/github/codeql/commits?author=owen-mc
d5aa08dhttps://github.com/github/codeql/pull/16413/commits/d5aa08dbf35e0a30cff658a279ccc60a98b83ed1
https://github.com/github/codeql/tree/d5aa08dbf35e0a30cff658a279ccc60a98b83ed1
Add change notehttps://github.com/github/codeql/pull/16413/commits/8cc9838628ab337794130a569dd46fc936137194
https://github.com/owen-mc
owen-mchttps://github.com/github/codeql/commits?author=owen-mc
8cc9838https://github.com/github/codeql/pull/16413/commits/8cc9838628ab337794130a569dd46fc936137194
https://github.com/github/codeql/tree/8cc9838628ab337794130a569dd46fc936137194
Fix `elementWrite` to include flow summarieshttps://github.com/github/codeql/pull/16413/commits/e1c85e3581d590470dcd9959f9eac0320a623860
https://github.com/owen-mc
owen-mchttps://github.com/github/codeql/commits?author=owen-mc
e1c85e3https://github.com/github/codeql/pull/16413/commits/e1c85e3581d590470dcd9959f9eac0320a623860
https://github.com/github/codeql/tree/e1c85e3581d590470dcd9959f9eac0320a623860
Accept MaD renumbering for edge provenancehttps://github.com/github/codeql/pull/16413/commits/76946184de6b3e611d8b4e35d45fc347594911a5
https://github.com/owen-mc
owen-mchttps://github.com/github/codeql/commits?author=owen-mc
7694618https://github.com/github/codeql/pull/16413/commits/76946184de6b3e611d8b4e35d45fc347594911a5
https://github.com/github/codeql/tree/76946184de6b3e611d8b4e35d45fc347594911a5
Accept expected test changeshttps://github.com/github/codeql/pull/16413/commits/f8e17fe8cc91bb89d1905ae0486b79559e8af7dd
https://github.com/owen-mc
owen-mchttps://github.com/github/codeql/commits?author=owen-mc
f8e17fehttps://github.com/github/codeql/pull/16413/commits/f8e17fe8cc91bb89d1905ae0486b79559e8af7dd
https://github.com/github/codeql/tree/f8e17fe8cc91bb89d1905ae0486b79559e8af7dd
Two tests have different paths but same resultshttps://github.com/github/codeql/pull/16413/commits/f7e6bf7ef52f26719f27742c8e7976174b09fc86
https://github.com/owen-mc
owen-mchttps://github.com/github/codeql/commits?author=owen-mc
f7e6bf7https://github.com/github/codeql/pull/16413/commits/f7e6bf7ef52f26719f27742c8e7976174b09fc86
https://github.com/github/codeql/tree/f7e6bf7ef52f26719f27742c8e7976174b09fc86
Fix models for `min` and `max` and improve testshttps://github.com/github/codeql/pull/16413/commits/ab5e1f8a69a725956f86bdcef67db8ab4ffe8354
https://github.com/owen-mc
owen-mchttps://github.com/github/codeql/commits?author=owen-mc
ab5e1f8https://github.com/github/codeql/pull/16413/commits/ab5e1f8a69a725956f86bdcef67db8ab4ffe8354
https://github.com/github/codeql/tree/ab5e1f8a69a725956f86bdcef67db8ab4ffe8354
Test changes due to model renumberinghttps://github.com/github/codeql/pull/16413/commits/827d15aaa0f7f6b1a95cbcb593eef899ae6b9fbc
https://github.com/owen-mc
owen-mchttps://github.com/github/codeql/commits?author=owen-mc
827d15ahttps://github.com/github/codeql/pull/16413/commits/827d15aaa0f7f6b1a95cbcb593eef899ae6b9fbc
https://github.com/github/codeql/tree/827d15aaa0f7f6b1a95cbcb593eef899ae6b9fbc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.