René's URL Explorer Experiment


Title: Go: fix models for built-in functions by owen-mc · Pull Request #16413 · github/codeql · GitHub

Open Graph Title: Go: fix models for built-in functions by owen-mc · Pull Request #16413 · github/codeql

X Title: Go: fix models for built-in functions by owen-mc · Pull Request #16413 · github/codeql

Description: CodeQL: the libraries and queries that power security researchers around the world, as well as code scanning in GitHub Advanced Security - Go: fix models for built-in functions by owen-mc · Pull Request #16413 · github/codeql

Open Graph Description: Our model for append was wrong, as append is variadic. We were missing a model for copy. Here are the package docs and the relevant part of the spec. I had to fix two bugs which I made into separat...

X Description: Our model for append was wrong, as append is variadic. We were missing a model for copy. Here are the package docs and the relevant part of the spec. I had to fix two bugs which I made into separat...

Opengraph URL: https://github.com/github/codeql/pull/16413

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:26c15f19-3514-8822-a8dc-723f3e386b4c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8342:1EDECA:B84D32:F26D67:6AF85E5B
html-safe-nonce3fba679a6218f116d82ddde4254091ef8594006c4444deff4f3e7309bf1a4b9f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzQyOjFFREVDQTpCODREMzI6RjI2RDY3OjZBRjg1RTVCIiwidmlzaXRvcl9pZCI6IjcxMzExNDYxNTk5Nzk1MTk1NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac57899c4a0d4314d3d584e136282b8ffd5b74c174bb69dae36b9cf0874fe6c957
hovercard-subject-tagpull_request:1853222092
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/github/codeql/16413/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b76a4bc261bbce1404bc70e92904908cfc84ab92167b784432d35145542fb0da/github/codeql/pull/16413
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b76a4bc261bbce1404bc70e92904908cfc84ab92167b784432d35145542fb0da/github/codeql/pull/16413
og:image:altOur model for append was wrong, as append is variadic. We were missing a model for copy. Here are the package docs and the relevant part of the spec. I had to fix two bugs which I made into separat...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameowen-mc
hostnamegithub.com
expected-hostnamegithub.com
None5713ecd83001b2f55c3509fb7a292bf7d66d0f167c7ae87a9f7eaec5a52bf8db
turbo-cache-controlno-cache
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release653be32ff5c755082a4db662491bfbbcfc9112c1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/github/codeql/pull/16413#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F16413
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F16413
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/16413
Reloadhttps://github.com/github/codeql/pull/16413
Reloadhttps://github.com/github/codeql/pull/16413
githubhttps://github.com/github
codeqlhttps://github.com/github/codeql
Codehttps://github.com/github/codeql
Issues1k (1k)https://github.com/github/codeql/issues
Pull requests516 (516)https://github.com/github/codeql/pulls
Discussionshttps://github.com/github/codeql/discussions
Actionshttps://github.com/github/codeql/actions
Projectshttps://github.com/github/codeql/projects
Security and qualityhttps://github.com/github/codeql/security
Insightshttps://github.com/github/codeql/pulse
https://github.com/github/codeql
owen-mchttps://github.com/owen-mc
github:mainhttps://github.com/github/codeql/tree/main
owen-mc:go/fix-builtin-modelshttps://github.com/owen-mc/codeql/tree/go/fix-builtin-models
Conversationhttps://github.com/github/codeql/pull/16413
Commits16 (16)https://github.com/github/codeql/pull/16413/commits
Checkshttps://github.com/github/codeql/pull/16413/checks
Findingshttps://github.com/github/codeql/pull/16413/findings
Files changedhttps://github.com/github/codeql/pull/16413/files
Go: fix models for built-in functionshttps://github.com/github/codeql/pull/16413#top
owen-mchttps://github.com/owen-mc
github:mainhttps://github.com/github/codeql/tree/main
owen-mc:go/fix-builtin-modelshttps://github.com/owen-mc/codeql/tree/go/fix-builtin-models
https://github.com/owen-mc
owen-mchttps://github.com/owen-mc
May 3, 2024https://github.com/github/codeql/pull/16413#issue-2277431925
Please reload this pagehttps://github.com/github/codeql/pull/16413
package docshttps://pkg.go.dev/builtin
the relevant part of the spechttps://go.dev/ref/spec#Appending_and_copying_slices
Go: Fix getType on ImplicitVarArgsSlicehttps://github.com/github/codeql/pull/16457
Go: fix hasQualifiedName and models-as-data for built-in functionshttps://github.com/github/codeql/pull/16458
#16444https://github.com/github/codeql/pull/16444
Please reload this pagehttps://github.com/github/codeql/pull/16413
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Go https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AGo
May 3, 2024https://github.com/github/codeql/pull/16413#event-12694963422
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 3, 2024https://github.com/github/codeql/pull/16413#issuecomment-2092773380
Please reload this pagehttps://github.com/github/codeql/pull/16413
artifacts of this workflow runhttps://github.com/github/codeql/actions/runs/9078811158
Please reload this pagehttps://github.com/github/codeql/pull/16413
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
documentation https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Adocumentation
May 3, 2024https://github.com/github/codeql/pull/16413#event-12695935168
https://github.com/owen-mc
owen-mchttps://github.com/owen-mc
force-pushedhttps://github.com/github/codeql/compare/0a0d54dfdb612a51c1db65124b88a4cfaf8e5ead..95eeefdcedd0faa5debe52b61bab53bc416c4d27
0a0d54dhttps://github.com/github/codeql/commit/0a0d54dfdb612a51c1db65124b88a4cfaf8e5ead
95eeefdhttps://github.com/github/codeql/commit/95eeefdcedd0faa5debe52b61bab53bc416c4d27
Compare https://github.com/github/codeql/compare/0a0d54dfdb612a51c1db65124b88a4cfaf8e5ead..95eeefdcedd0faa5debe52b61bab53bc416c4d27
May 7, 2024 15:05https://github.com/github/codeql/pull/16413#event-12731087703
https://github.com/owen-mc
owen-mchttps://github.com/owen-mc
May 7, 2024 15:06https://github.com/github/codeql/pull/16413#event-12731096741
https://github.com/owen-mc
owen-mchttps://github.com/owen-mc
code ownerhttps://github.com/github/codeql/blob/99940a6084e088529e0441ae06bd5586518e1957/CODEOWNERS#L4
May 7, 2024 15:06https://github.com/github/codeql/pull/16413#event-12731096886
https://github.com/smowton
smowtonhttps://github.com/smowton
May 7, 2024 https://github.com/github/codeql/pull/16413#pullrequestreview-2043782678
View reviewed changes https://github.com/github/codeql/pull/16413/files
smowtonhttps://github.com/smowton
https://github.com/github/codeql/pull/16413#pullrequestreview-2043782678
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/16413
go/ql/lib/semmle/go/dataflow/internal/DataFlowNodes.qllhttps://github.com/github/codeql/pull/16413/files#diff-0e88a7c83f8a54ab6b7ca14b00cdf25bfa1e10aafbee6ad39929fcdd462ff6c9
smowtonhttps://github.com/smowton
May 7, 2024https://github.com/github/codeql/pull/16413#discussion_r1592835535
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/16413
https://github.com/smowton
smowtonhttps://github.com/smowton
May 7, 2024https://github.com/github/codeql/pull/16413#issuecomment-2098954576
Please reload this pagehttps://github.com/github/codeql/pull/16413
https://github.com/owen-mc
owen-mchttps://github.com/owen-mc
smowtonhttps://github.com/smowton
stale reviewhttps://github.com/github/codeql/pull/16413#pullrequestreview-2043782678
79cdec8https://github.com/github/codeql/commit/79cdec8cdc599355459c8fe76b4861c6582b6cc4
May 7, 2024 20:20https://github.com/github/codeql/pull/16413#event-12734902466
Go: Fix getType on ImplicitVarArgsSlice #16457 https://github.com/github/codeql/pull/16457
Go: fix hasQualifiedName and models-as-data for built-in functions #16458 https://github.com/github/codeql/pull/16458
https://github.com/owen-mc
owen-mchttps://github.com/owen-mc
May 8, 2024 14:48https://github.com/github/codeql/pull/16413#event-12745193897
https://github.com/owen-mc
owen-mchttps://github.com/owen-mc
May 8, 2024 https://github.com/github/codeql/pull/16413#ref-pullrequest-2258595038
Go: Use value flow instead of taint flow for go/incorrect-integer-conversion #16305 https://github.com/github/codeql/pull/16305
https://github.com/owen-mc
owen-mchttps://github.com/owen-mc
force-pushedhttps://github.com/github/codeql/compare/79cdec8cdc599355459c8fe76b4861c6582b6cc4..694c89610d9473eff93101cf5657160530bcb95d
79cdec8https://github.com/github/codeql/commit/79cdec8cdc599355459c8fe76b4861c6582b6cc4
694c896https://github.com/github/codeql/commit/694c89610d9473eff93101cf5657160530bcb95d
Compare https://github.com/github/codeql/compare/79cdec8cdc599355459c8fe76b4861c6582b6cc4..694c89610d9473eff93101cf5657160530bcb95d
May 8, 2024 20:14https://github.com/github/codeql/pull/16413#event-12748845181
https://github.com/owen-mc
owen-mchttps://github.com/owen-mc
May 9, 2024 https://github.com/github/codeql/pull/16413#ref-pullrequest-2287925881
Go: Fix test expectations #16464 https://github.com/github/codeql/pull/16464
https://github.com/owen-mc
owen-mchttps://github.com/owen-mc
force-pushedhttps://github.com/github/codeql/compare/694c89610d9473eff93101cf5657160530bcb95d..610099525330b3af6b872268eeabd3db24fc8363
694c896https://github.com/github/codeql/commit/694c89610d9473eff93101cf5657160530bcb95d
6100995https://github.com/github/codeql/commit/610099525330b3af6b872268eeabd3db24fc8363
Compare https://github.com/github/codeql/compare/694c89610d9473eff93101cf5657160530bcb95d..610099525330b3af6b872268eeabd3db24fc8363
May 9, 2024 15:47https://github.com/github/codeql/pull/16413#event-12759026536
owen-mchttps://github.com/owen-mc
May 10, 2024 23:40https://github.com/github/codeql/pull/16413#commits-pushed-e857eed
https://github.com/owen-mc
Fix model for append - it is variadichttps://github.com/github/codeql/pull/16413/commits/e857eedd4a5c8b0105729e653ec94f862e57e4b7
e857eedhttps://github.com/github/codeql/pull/16413/commits/e857eedd4a5c8b0105729e653ec94f862e57e4b7
https://github.com/owen-mc
Add model for built-in function copyhttps://github.com/github/codeql/pull/16413/commits/1322ce35d6285ee392ea887b0f25a68eb565b416
1322ce3https://github.com/github/codeql/pull/16413/commits/1322ce35d6285ee392ea887b0f25a68eb565b416
https://github.com/owen-mc
Add models for min and max built-in functionshttps://github.com/github/codeql/pull/16413/commits/fcdac0aeb0a7eae4993cec9bbcae19f59a331bd5
fcdac0ahttps://github.com/github/codeql/pull/16413/commits/fcdac0aeb0a7eae4993cec9bbcae19f59a331bd5
https://github.com/owen-mc
Remove old-style models of built-in functionshttps://github.com/github/codeql/pull/16413/commits/f95ccd242f2867cf13773dadab516784962b42b1
f95ccd2https://github.com/github/codeql/pull/16413/commits/f95ccd242f2867cf13773dadab516784962b42b1
https://github.com/owen-mc
Rename test folder ExternalFlow to ExternalTaintFlowhttps://github.com/github/codeql/pull/16413/commits/84b7319688c9ea7b4c3d921b4db6e6948ae0dbd5
84b7319https://github.com/github/codeql/pull/16413/commits/84b7319688c9ea7b4c3d921b4db6e6948ae0dbd5
https://github.com/owen-mc
Create copy of ExternalTaintFlow called ExternalValueFlowhttps://github.com/github/codeql/pull/16413/commits/c81641279558295baa8c05fb45f9e1eec370ffc7
c816412https://github.com/github/codeql/pull/16413/commits/c81641279558295baa8c05fb45f9e1eec370ffc7
https://github.com/owen-mc
Update ExternalValueFlow to use value flowhttps://github.com/github/codeql/pull/16413/commits/eab156934241d402b9baabab7aaa75528920d2ae
eab1569https://github.com/github/codeql/pull/16413/commits/eab156934241d402b9baabab7aaa75528920d2ae
https://github.com/owen-mc
Add tests for copy (taint passes, value fails)https://github.com/github/codeql/pull/16413/commits/86e2b845f32a97a82717cdb5f9e8c636f15a00ce
86e2b84https://github.com/github/codeql/pull/16413/commits/86e2b845f32a97a82717cdb5f9e8c636f15a00ce
https://github.com/owen-mc
Local flow steps for flow summaries for built-in functionshttps://github.com/github/codeql/pull/16413/commits/d5aa08dbf35e0a30cff658a279ccc60a98b83ed1
d5aa08dhttps://github.com/github/codeql/pull/16413/commits/d5aa08dbf35e0a30cff658a279ccc60a98b83ed1
https://github.com/owen-mc
Add change notehttps://github.com/github/codeql/pull/16413/commits/8cc9838628ab337794130a569dd46fc936137194
8cc9838https://github.com/github/codeql/pull/16413/commits/8cc9838628ab337794130a569dd46fc936137194
https://github.com/owen-mc
Fix elementWrite to include flow summarieshttps://github.com/github/codeql/pull/16413/commits/e1c85e3581d590470dcd9959f9eac0320a623860
e1c85e3https://github.com/github/codeql/pull/16413/commits/e1c85e3581d590470dcd9959f9eac0320a623860
https://github.com/owen-mc
Accept MaD renumbering for edge provenancehttps://github.com/github/codeql/pull/16413/commits/76946184de6b3e611d8b4e35d45fc347594911a5
7694618https://github.com/github/codeql/pull/16413/commits/76946184de6b3e611d8b4e35d45fc347594911a5
owen-mchttps://github.com/owen-mc
May 10, 2024 23:40https://github.com/github/codeql/pull/16413#commits-pushed-f8e17fe
https://github.com/owen-mc
Accept expected test changeshttps://github.com/github/codeql/pull/16413/commits/f8e17fe8cc91bb89d1905ae0486b79559e8af7dd
f8e17fehttps://github.com/github/codeql/pull/16413/commits/f8e17fe8cc91bb89d1905ae0486b79559e8af7dd
https://github.com/owen-mc
Two tests have different paths but same resultshttps://github.com/github/codeql/pull/16413/commits/f7e6bf7ef52f26719f27742c8e7976174b09fc86
f7e6bf7https://github.com/github/codeql/pull/16413/commits/f7e6bf7ef52f26719f27742c8e7976174b09fc86
https://github.com/owen-mc
owen-mchttps://github.com/owen-mc
force-pushedhttps://github.com/github/codeql/compare/610099525330b3af6b872268eeabd3db24fc8363..f7e6bf7ef52f26719f27742c8e7976174b09fc86
6100995https://github.com/github/codeql/commit/610099525330b3af6b872268eeabd3db24fc8363
f7e6bf7https://github.com/github/codeql/commit/f7e6bf7ef52f26719f27742c8e7976174b09fc86
Compare https://github.com/github/codeql/compare/610099525330b3af6b872268eeabd3db24fc8363..f7e6bf7ef52f26719f27742c8e7976174b09fc86
May 10, 2024 22:42https://github.com/github/codeql/pull/16413#event-12774573928
https://github.com/owen-mc
owen-mchttps://github.com/owen-mc
May 11, 2024 06:49https://github.com/github/codeql/pull/16413#event-12775676615
https://github.com/owen-mc
owen-mchttps://github.com/owen-mc
May 11, 2024https://github.com/github/codeql/pull/16413#issuecomment-2105601282
Please reload this pagehttps://github.com/github/codeql/pull/16413
https://github.com/smowton
smowtonhttps://github.com/smowton
May 13, 2024 https://github.com/github/codeql/pull/16413#pullrequestreview-2052643492
View reviewed changes https://github.com/github/codeql/pull/16413/files/f7e6bf7ef52f26719f27742c8e7976174b09fc86
go/ql/lib/ext/builtin.model.ymlhttps://github.com/github/codeql/pull/16413/files/f7e6bf7ef52f26719f27742c8e7976174b09fc86#diff-49acfb1300f7330ae5b9809c5c5d03160b0490040271c671201b11afcb8972da
smowtonhttps://github.com/smowton
May 13, 2024https://github.com/github/codeql/pull/16413#discussion_r1598445227
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://pkg.go.dev/builtin#maxhttps://pkg.go.dev/builtin#max
Please reload this pagehttps://github.com/github/codeql/pull/16413
owen-mchttps://github.com/owen-mc
May 14, 2024https://github.com/github/codeql/pull/16413#discussion_r1599767565
Please reload this pagehttps://github.com/github/codeql/pull/16413
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/16413
owen-mchttps://github.com/owen-mc
May 14, 2024https://github.com/github/codeql/pull/16413#discussion_r1599817498
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
this commenthttps://github.com/golang/go/issues/59488#issuecomment-1548505279
Please reload this pagehttps://github.com/github/codeql/pull/16413
https://github.com/smowton
smowtonhttps://github.com/smowton
May 13, 2024 https://github.com/github/codeql/pull/16413#pullrequestreview-2052644722
View reviewed changes https://github.com/github/codeql/pull/16413/files/f7e6bf7ef52f26719f27742c8e7976174b09fc86
go/ql/test/library-tests/semmle/go/dataflow/FlowSteps/LocalFlowStep.expectedhttps://github.com/github/codeql/pull/16413/files/f7e6bf7ef52f26719f27742c8e7976174b09fc86#diff-a20f3d9ae0b54640a499d558d18f4086e924e685f7da0cde43bc0590d9877abb
smowtonhttps://github.com/smowton
May 13, 2024https://github.com/github/codeql/pull/16413#discussion_r1598445872
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/16413
owen-mchttps://github.com/owen-mc
May 14, 2024https://github.com/github/codeql/pull/16413#discussion_r1600271099
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/16413
https://github.com/smowton
smowtonhttps://github.com/smowton
May 13, 2024 https://github.com/github/codeql/pull/16413#pullrequestreview-2052647567
View reviewed changes https://github.com/github/codeql/pull/16413/files/f7e6bf7ef52f26719f27742c8e7976174b09fc86
go/ql/test/library-tests/semmle/go/dataflow/FlowSteps/LocalTaintStep.expectedhttps://github.com/github/codeql/pull/16413/files/f7e6bf7ef52f26719f27742c8e7976174b09fc86#diff-bd65c452287be4d1adcf18ef7dd74222f17b8ebb162f0616ae31e532b4999b21
smowtonhttps://github.com/smowton
May 13, 2024https://github.com/github/codeql/pull/16413#discussion_r1598447118
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/16413
owen-mchttps://github.com/owen-mc
May 14, 2024https://github.com/github/codeql/pull/16413#discussion_r1600248312
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/16413
https://github.com/owen-mc
owen-mchttps://github.com/owen-mc
force-pushedhttps://github.com/github/codeql/compare/dc4cbf23259938972bec1860adf2fef08e05d7d9..31e34221a16cf3b4ec32bff3c3af7084c89ea7ca
dc4cbf2https://github.com/github/codeql/commit/dc4cbf23259938972bec1860adf2fef08e05d7d9
31e3422https://github.com/github/codeql/commit/31e34221a16cf3b4ec32bff3c3af7084c89ea7ca
Compare https://github.com/github/codeql/compare/dc4cbf23259938972bec1860adf2fef08e05d7d9..31e34221a16cf3b4ec32bff3c3af7084c89ea7ca
May 14, 2024 13:19https://github.com/github/codeql/pull/16413#event-12802282446
owen-mchttps://github.com/owen-mc
May 14, 2024 14:40https://github.com/github/codeql/pull/16413#commits-pushed-ab5e1f8
https://github.com/owen-mc
Fix models for min and max and improve testshttps://github.com/github/codeql/pull/16413/commits/ab5e1f8a69a725956f86bdcef67db8ab4ffe8354
ab5e1f8https://github.com/github/codeql/pull/16413/commits/ab5e1f8a69a725956f86bdcef67db8ab4ffe8354
https://github.com/owen-mc
Test changes due to model renumberinghttps://github.com/github/codeql/pull/16413/commits/827d15aaa0f7f6b1a95cbcb593eef899ae6b9fbc
827d15ahttps://github.com/github/codeql/pull/16413/commits/827d15aaa0f7f6b1a95cbcb593eef899ae6b9fbc
https://github.com/owen-mc
owen-mchttps://github.com/owen-mc
force-pushedhttps://github.com/github/codeql/compare/31e34221a16cf3b4ec32bff3c3af7084c89ea7ca..827d15aaa0f7f6b1a95cbcb593eef899ae6b9fbc
31e3422https://github.com/github/codeql/commit/31e34221a16cf3b4ec32bff3c3af7084c89ea7ca
827d15ahttps://github.com/github/codeql/commit/827d15aaa0f7f6b1a95cbcb593eef899ae6b9fbc
Compare https://github.com/github/codeql/compare/31e34221a16cf3b4ec32bff3c3af7084c89ea7ca..827d15aaa0f7f6b1a95cbcb593eef899ae6b9fbc
May 14, 2024 13:41https://github.com/github/codeql/pull/16413#event-12802620229
https://github.com/smowton
smowtonhttps://github.com/smowton
May 14, 2024 https://github.com/github/codeql/pull/16413#pullrequestreview-2055976691
View reviewed changes https://github.com/github/codeql/pull/16413/files/827d15aaa0f7f6b1a95cbcb593eef899ae6b9fbc
https://github.com/owen-mc
owen-mchttps://github.com/owen-mc
145873fhttps://github.com/github/codeql/commit/145873f562c0c892014dacbb75641a4d042d4e7c
May 14, 2024https://github.com/github/codeql/pull/16413#event-12807678966
https://github.com/owen-mc
owen-mchttps://github.com/owen-mc
May 14, 2024 20:03https://github.com/github/codeql/pull/16413#event-12807679137
https://github.com/owen-mc
owen-mchttps://github.com/owen-mc
May 30, 2024 https://github.com/github/codeql/pull/16413#ref-pullrequest-2325768748
Go: Add back taint models for append and copy #16624 https://github.com/github/codeql/pull/16624
https://github.com/owen-mc
owen-mchttps://github.com/owen-mc
Jan 23, 2025 https://github.com/github/codeql/pull/16413#ref-issue-1876663748
Go: Tainted data does not propagate data flow after append function #14116 https://github.com/github/codeql/issues/14116
https://github.co/hiddenchars
https://github.com/github/codeql/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F16413
https://github.com/smowton
smowton https://github.com/smowton
https://github.com/github/codeql/pull/16413/files/827d15aaa0f7f6b1a95cbcb593eef899ae6b9fbc
Please reload this pagehttps://github.com/github/codeql/pull/16413
documentation https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Adocumentation
Go https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AGo
Please reload this pagehttps://github.com/github/codeql/pull/16413
https://github.com/owen-mc
https://github.com/smowton
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.