René's URL Explorer Experiment


Title: Typescript full mode fixes by asger-semmle · Pull Request #1295 · github/codeql · GitHub

Open Graph Title: Typescript full mode fixes by asger-semmle · Pull Request #1295 · github/codeql

X Title: Typescript full mode fixes by asger-semmle · Pull Request #1295 · github/codeql

Description: Fixes some crashes in the 14 projects that started failing after TypeScript full mode became the default on LGTM.com this week. Some issues that came from the TypeScript compiler itself: Some internal debug assertions failed, but went way after upgrading to 3.4.5. Calling getProperties() on the type typeof globalThis | {} caused it to crash. I've worked around it by catching the exception. Calling typeSignatureToString on this type signature caused an out-of-memory error for some reason. I suspect this has something to do with the use of infer types, so I've disabled type extraction inside conditional types (which are where infer types are introduced). Lastly, we didn't handle export= correctly when the right-hand side was an expression. I've fixed that. I'll run an evaluation as well.

Open Graph Description: Fixes some crashes in the 14 projects that started failing after TypeScript full mode became the default on LGTM.com this week. Some issues that came from the TypeScript compiler itself: Some inte...

X Description: Fixes some crashes in the 14 projects that started failing after TypeScript full mode became the default on LGTM.com this week. Some issues that came from the TypeScript compiler itself: Some inte...

Opengraph URL: https://github.com/github/codeql/pull/1295

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:62be17b3-1bd5-8dc0-0e97-73f00777f8c6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB52C:19E4BB:746156:966AC8:6B00E4CF
html-safe-noncebd149299b63e9b8081c998fd7da161e9ff744ff155a692e5cb6f429db194160a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTJDOjE5RTRCQjo3NDYxNTY6OTY2QUM4OjZCMDBFNENGIiwidmlzaXRvcl9pZCI6IjI2OTcwMzM4MDc3NjQxODYzMTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfeb5e2ceaa7d0302050b97e94c4462ef3a6b212edad6b64d427010d65bc63f43
hovercard-subject-tagpull_request:274774363
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql/pull/1295/files
twitter:imagehttps://avatars.githubusercontent.com/u/42069257?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/42069257?s=400&v=4
og:image:altFixes some crashes in the 14 projects that started failing after TypeScript full mode became the default on LGTM.com this week. Some issues that came from the TypeScript compiler itself: Some inte...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/1295/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F1295%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F1295%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/1295/files
Reloadhttps://github.com/github/codeql/pull/1295/files
Reloadhttps://github.com/github/codeql/pull/1295/files
githubhttps://github.com/github
codeqlhttps://github.com/github/codeql
Codehttps://github.com/github/codeql
Issues1k (1k)https://github.com/github/codeql/issues
Pull requests507 (507)https://github.com/github/codeql/pulls
Discussionshttps://github.com/github/codeql/discussions
Actionshttps://github.com/github/codeql/actions
Projectshttps://github.com/github/codeql/projects
Security and qualityhttps://github.com/github/codeql/security
Insightshttps://github.com/github/codeql/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
xiemaisihttps://github.com/xiemaisi
github:masterhttps://github.com/github/codeql/tree/master
asger-semmle:typescript-full-mode-fixeshttps://github.com/asger-semmle/ql/tree/typescript-full-mode-fixes
Conversation 1 https://github.com/github/codeql/pull/1295
Commits 4 https://github.com/github/codeql/pull/1295/commits
Checks 0 https://github.com/github/codeql/pull/1295/checks
Findings https://github.com/github/codeql/pull/1295/findings
Files changed https://github.com/github/codeql/pull/1295/files
Please reload this pagehttps://github.com/github/codeql/pull/1295/files
Typescript full mode fixes https://github.com/github/codeql/pull/1295/files#top
Show all changes 4 commits https://github.com/github/codeql/pull/1295/files
11c07a3 TS: Update to TypeScript 3.4.5 asger-semmle Apr 29, 2019 https://github.com/github/codeql/pull/1295/commits/11c07a321734bb5862d13c79ca02c06978dc4a9d
686d72c TS: Fix handling of 'export =' asger-semmle Apr 30, 2019 https://github.com/github/codeql/pull/1295/commits/686d72c356dd342246e593ee5db7cb1a6d07074a
5c8dd7e TS: Add workaround for 'globalThis' getProperties() crash asger-semmle Apr 30, 2019 https://github.com/github/codeql/pull/1295/commits/5c8dd7eeddfd58ca373f491138fb722ee413a3a8
15299ab TS: Workaround issue with `infer` types asger-semmle Apr 30, 2019 https://github.com/github/codeql/pull/1295/commits/15299aba7d9632c2c799ccad81792f357cd99b5e
Clear filters https://github.com/github/codeql/pull/1295/files
Please reload this pagehttps://github.com/github/codeql/pull/1295/files
Please reload this pagehttps://github.com/github/codeql/pull/1295/files
package.json https://github.com/github/codeql/pull/1295/files#diff-683e5feb284d00ab4fce2a4cbfb0f53fb410acc6ae2ddf04db60daa79ad4399e
ast_extractor.ts https://github.com/github/codeql/pull/1295/files#diff-fb9abbf10d9e177b0cc800c0819871f2cd997c3b504914cbf2185274efc8253a
main.ts https://github.com/github/codeql/pull/1295/files#diff-ae9cb8c7ab2b8622a84b032f9529817adc5c06f123ad107e03e0cef73c9a52bb
type_table.ts https://github.com/github/codeql/pull/1295/files#diff-e85f5fd29f76a5ef27e0f467c31f6955e7c14ef75be5990b3e888dc137ce9ef6
yarn.lock https://github.com/github/codeql/pull/1295/files#diff-194c0548f88d51225d2a67f57efee7109c1291907a3f7c8d72ea5564a160bf23
extern.d.ts https://github.com/github/codeql/pull/1295/files#diff-bc48c1be90965e776d40d82cf2f96ee235e617e10689392b8bc1286eea6a279f
test.expected https://github.com/github/codeql/pull/1295/files#diff-707d606cbb2b3d10c8b97cf9972afa367e84bd47578ee0a200332f83e6fac71c
test.ql https://github.com/github/codeql/pull/1295/files#diff-a949a0a5f073106be5c91dc3f5d9186d7a750a2f0817e7e2827411104e7b3519
tsconfig.json https://github.com/github/codeql/pull/1295/files#diff-b181af271ed1a82d9e225b8f51262a30f079e6a87b303f8c4d0dd3b2130e0030
tst.ts https://github.com/github/codeql/pull/1295/files#diff-8fbf57e484bbd6c9f09d58e6bad2a223c6e58ebb199187c237d54743e038a216
test.expected https://github.com/github/codeql/pull/1295/files#diff-6ad165844fbd62c08e580fe4eef95d4652236db38117261ccf68ea42ff733f86
test.ql https://github.com/github/codeql/pull/1295/files#diff-fc9e971d3e9a270b4b0e628e6c11667f84f57ec8f4a026d36839e6ea7209f83f
tsconfig.json https://github.com/github/codeql/pull/1295/files#diff-012b56d6cb6e898466e7a508870bf2bfa48f3363a9416ba519bdee662dd588b5
tst.ts https://github.com/github/codeql/pull/1295/files#diff-5b82b16fb6c3b1df43c65b671d08dc9c39b83267561d84c548db0d796301b942
javascript/extractor/lib/typescript/package.jsonhttps://github.com/github/codeql/pull/1295/files#diff-683e5feb284d00ab4fce2a4cbfb0f53fb410acc6ae2ddf04db60daa79ad4399e
View file https://github.com/asger-semmle/ql/blob/15299aba7d9632c2c799ccad81792f357cd99b5e/javascript/extractor/lib/typescript/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/1295/{{ revealButtonHref }}
https://github.com/github/codeql/pull/1295/files#diff-683e5feb284d00ab4fce2a4cbfb0f53fb410acc6ae2ddf04db60daa79ad4399e
https://github.com/github/codeql/pull/1295/files#diff-683e5feb284d00ab4fce2a4cbfb0f53fb410acc6ae2ddf04db60daa79ad4399e
javascript/extractor/lib/typescript/src/ast_extractor.tshttps://github.com/github/codeql/pull/1295/files#diff-fb9abbf10d9e177b0cc800c0819871f2cd997c3b504914cbf2185274efc8253a
View file https://github.com/asger-semmle/ql/blob/15299aba7d9632c2c799ccad81792f357cd99b5e/javascript/extractor/lib/typescript/src/ast_extractor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/1295/{{ revealButtonHref }}
https://github.com/github/codeql/pull/1295/files#diff-fb9abbf10d9e177b0cc800c0819871f2cd997c3b504914cbf2185274efc8253a
https://github.com/github/codeql/pull/1295/files#diff-fb9abbf10d9e177b0cc800c0819871f2cd997c3b504914cbf2185274efc8253a
https://github.com/github/codeql/pull/1295/files#diff-fb9abbf10d9e177b0cc800c0819871f2cd997c3b504914cbf2185274efc8253a
https://github.com/github/codeql/pull/1295/files#diff-fb9abbf10d9e177b0cc800c0819871f2cd997c3b504914cbf2185274efc8253a
https://github.com/github/codeql/pull/1295/files#diff-fb9abbf10d9e177b0cc800c0819871f2cd997c3b504914cbf2185274efc8253a
javascript/extractor/lib/typescript/src/main.tshttps://github.com/github/codeql/pull/1295/files#diff-ae9cb8c7ab2b8622a84b032f9529817adc5c06f123ad107e03e0cef73c9a52bb
View file https://github.com/asger-semmle/ql/blob/15299aba7d9632c2c799ccad81792f357cd99b5e/javascript/extractor/lib/typescript/src/main.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/1295/{{ revealButtonHref }}
https://github.com/github/codeql/pull/1295/files#diff-ae9cb8c7ab2b8622a84b032f9529817adc5c06f123ad107e03e0cef73c9a52bb
https://github.com/github/codeql/pull/1295/files#diff-ae9cb8c7ab2b8622a84b032f9529817adc5c06f123ad107e03e0cef73c9a52bb
javascript/extractor/lib/typescript/src/type_table.tshttps://github.com/github/codeql/pull/1295/files#diff-e85f5fd29f76a5ef27e0f467c31f6955e7c14ef75be5990b3e888dc137ce9ef6
View file https://github.com/asger-semmle/ql/blob/15299aba7d9632c2c799ccad81792f357cd99b5e/javascript/extractor/lib/typescript/src/type_table.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/1295/{{ revealButtonHref }}
https://github.com/github/codeql/pull/1295/files#diff-e85f5fd29f76a5ef27e0f467c31f6955e7c14ef75be5990b3e888dc137ce9ef6
https://github.com/github/codeql/pull/1295/files#diff-e85f5fd29f76a5ef27e0f467c31f6955e7c14ef75be5990b3e888dc137ce9ef6
javascript/extractor/lib/typescript/yarn.lockhttps://github.com/github/codeql/pull/1295/files#diff-194c0548f88d51225d2a67f57efee7109c1291907a3f7c8d72ea5564a160bf23
View file https://github.com/asger-semmle/ql/blob/15299aba7d9632c2c799ccad81792f357cd99b5e/javascript/extractor/lib/typescript/yarn.lock
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/1295/{{ revealButtonHref }}
https://github.com/github/codeql/pull/1295/files#diff-194c0548f88d51225d2a67f57efee7109c1291907a3f7c8d72ea5564a160bf23
https://github.com/github/codeql/pull/1295/files#diff-194c0548f88d51225d2a67f57efee7109c1291907a3f7c8d72ea5564a160bf23
javascript/ql/test/library-tests/TypeScript/RegressionTests/ExportEqualsExpr/extern.d.tshttps://github.com/github/codeql/pull/1295/files#diff-bc48c1be90965e776d40d82cf2f96ee235e617e10689392b8bc1286eea6a279f
View file https://github.com/asger-semmle/ql/blob/15299aba7d9632c2c799ccad81792f357cd99b5e/javascript/ql/test/library-tests/TypeScript/RegressionTests/ExportEqualsExpr/extern.d.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/1295/{{ revealButtonHref }}
javascript/ql/test/library-tests/TypeScript/RegressionTests/ExportEqualsExpr/test.expectedhttps://github.com/github/codeql/pull/1295/files#diff-707d606cbb2b3d10c8b97cf9972afa367e84bd47578ee0a200332f83e6fac71c
View file https://github.com/asger-semmle/ql/blob/15299aba7d9632c2c799ccad81792f357cd99b5e/javascript/ql/test/library-tests/TypeScript/RegressionTests/ExportEqualsExpr/test.expected
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/1295/{{ revealButtonHref }}
javascript/ql/test/library-tests/TypeScript/RegressionTests/ExportEqualsExpr/test.qlhttps://github.com/github/codeql/pull/1295/files#diff-a949a0a5f073106be5c91dc3f5d9186d7a750a2f0817e7e2827411104e7b3519
View file https://github.com/asger-semmle/ql/blob/15299aba7d9632c2c799ccad81792f357cd99b5e/javascript/ql/test/library-tests/TypeScript/RegressionTests/ExportEqualsExpr/test.ql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/1295/{{ revealButtonHref }}
javascript/ql/test/library-tests/TypeScript/RegressionTests/ExportEqualsExpr/tsconfig.jsonhttps://github.com/github/codeql/pull/1295/files#diff-b181af271ed1a82d9e225b8f51262a30f079e6a87b303f8c4d0dd3b2130e0030
View file https://github.com/asger-semmle/ql/blob/15299aba7d9632c2c799ccad81792f357cd99b5e/javascript/ql/test/library-tests/TypeScript/RegressionTests/ExportEqualsExpr/tsconfig.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/1295/{{ revealButtonHref }}
javascript/ql/test/library-tests/TypeScript/RegressionTests/ExportEqualsExpr/tst.tshttps://github.com/github/codeql/pull/1295/files#diff-8fbf57e484bbd6c9f09d58e6bad2a223c6e58ebb199187c237d54743e038a216
View file https://github.com/asger-semmle/ql/blob/15299aba7d9632c2c799ccad81792f357cd99b5e/javascript/ql/test/library-tests/TypeScript/RegressionTests/ExportEqualsExpr/tst.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/1295/{{ revealButtonHref }}
javascript/ql/test/library-tests/TypeScript/RegressionTests/GlobalThis/test.expectedhttps://github.com/github/codeql/pull/1295/files#diff-6ad165844fbd62c08e580fe4eef95d4652236db38117261ccf68ea42ff733f86
View file https://github.com/asger-semmle/ql/blob/15299aba7d9632c2c799ccad81792f357cd99b5e/javascript/ql/test/library-tests/TypeScript/RegressionTests/GlobalThis/test.expected
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/1295/{{ revealButtonHref }}
javascript/ql/test/library-tests/TypeScript/RegressionTests/GlobalThis/test.qlhttps://github.com/github/codeql/pull/1295/files#diff-fc9e971d3e9a270b4b0e628e6c11667f84f57ec8f4a026d36839e6ea7209f83f
View file https://github.com/asger-semmle/ql/blob/15299aba7d9632c2c799ccad81792f357cd99b5e/javascript/ql/test/library-tests/TypeScript/RegressionTests/GlobalThis/test.ql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/1295/{{ revealButtonHref }}
javascript/ql/test/library-tests/TypeScript/RegressionTests/GlobalThis/tsconfig.jsonhttps://github.com/github/codeql/pull/1295/files#diff-012b56d6cb6e898466e7a508870bf2bfa48f3363a9416ba519bdee662dd588b5
View file https://github.com/asger-semmle/ql/blob/15299aba7d9632c2c799ccad81792f357cd99b5e/javascript/ql/test/library-tests/TypeScript/RegressionTests/GlobalThis/tsconfig.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/1295/{{ revealButtonHref }}
javascript/ql/test/library-tests/TypeScript/RegressionTests/GlobalThis/tst.tshttps://github.com/github/codeql/pull/1295/files#diff-5b82b16fb6c3b1df43c65b671d08dc9c39b83267561d84c548db0d796301b942
View file https://github.com/asger-semmle/ql/blob/15299aba7d9632c2c799ccad81792f357cd99b5e/javascript/ql/test/library-tests/TypeScript/RegressionTests/GlobalThis/tst.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/1295/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.