René's URL Explorer Experiment


Title: JS: model property projection calls · Pull Request #113 · github/codeql · GitHub

Open Graph Title: JS: model property projection calls · Pull Request #113 · github/codeql

X Title: JS: model property projection calls · Pull Request #113 · github/codeql

Description: This PR adds a taint step for property reads done through calls that projects selected properties of an object. The property projections that have been modeled have slightly different features. So I have adopted @asger-semmle's extensible architecture proposal immediately. We may want to discuss how we generally document the intended usage of the architecture, I have simply added an explanation to the module docstring for now. This PR only makes use of the object-argument in the models. For the record, the libraries support various features for the selector-argument: access path strings like 'a.b[42].c' access path arrays like ['a', 'b', 42, 'c'] search strings like 'a.\*.c' property predicate functions We can consider implementing support for these once our general heap treatment is better. An evaluation with the security suite on big-apps.slugs flags nothing new, and it does not have a significant performance impact (internal link).

Open Graph Description: This PR adds a taint step for property reads done through calls that projects selected properties of an object. The property projections that have been modeled have slightly different features. So ...

X Description: This PR adds a taint step for property reads done through calls that projects selected properties of an object. The property projections that have been modeled have slightly different features. So ...

Opengraph URL: https://github.com/github/codeql/pull/113

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e1543ef6-e3fa-9e6b-7351-acc397e10352
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE4DE:1661F0:131B23:19F28B:6A5252BB
html-safe-nonce64d10b5c4c39c0b50e65bb66bc2317bffc166bdab7b2dda76aac95a1742b3113
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNERFOjE2NjFGMDoxMzFCMjM6MTlGMjhCOjZBNTI1MkJCIiwidmlzaXRvcl9pZCI6IjY3NDI5NTMxMjU4MzE5MjIzNjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac91a2ff8be7571dc2f1482e7d32179ad50d982034e3764f1f3061dc29bfc7e5b9
hovercard-subject-tagpull_request:211704112
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql/pull/113/files
twitter:imagehttps://avatars.githubusercontent.com/u/10137?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10137?s=400&v=4
og:image:altThis PR adds a taint step for property reads done through calls that projects selected properties of an object. The property projections that have been modeled have slightly different features. So ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/113/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F113%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F113%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/113/files
Reloadhttps://github.com/github/codeql/pull/113/files
Reloadhttps://github.com/github/codeql/pull/113/files
Please reload this pagehttps://github.com/github/codeql/pull/113/files
github https://github.com/github
codeqlhttps://github.com/github/codeql
Notifications https://github.com/login?return_to=%2Fgithub%2Fcodeql
Fork 2k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Star 9.8k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Code https://github.com/github/codeql
Issues 988 https://github.com/github/codeql/issues
Pull requests 428 https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality 0 https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Code https://github.com/github/codeql
Issues https://github.com/github/codeql/issues
Pull requests https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
xiemaisihttps://github.com/xiemaisi
github:masterhttps://github.com/github/codeql/tree/master
Conversation 10 https://github.com/github/codeql/pull/113
Findings https://github.com/github/codeql/pull/113/findings
Commits 3 https://github.com/github/codeql/pull/113/commits
Checks 0 https://github.com/github/codeql/pull/113/checks
Files changed https://github.com/github/codeql/pull/113/files
Please reload this pagehttps://github.com/github/codeql/pull/113/files
JS: model property projection calls https://github.com/github/codeql/pull/113/files#top
Show all changes 3 commits https://github.com/github/codeql/pull/113/files
df97132 JS: add model for property projection Aug 28, 2018 https://github.com/github/codeql/pull/113/commits/df97132519d84ceb3a2584d48c16993cb61ed5b0
90b3902 JS: add a taint step for property projection Aug 28, 2018 https://github.com/github/codeql/pull/113/commits/90b390224459977a21f87abb38545e26530b0581
6ee8f71 JS: add change notes for property projection libraries Aug 28, 2018 https://github.com/github/codeql/pull/113/commits/6ee8f71d09a16006ce3e228512b807e4d4029052
Clear filters https://github.com/github/codeql/pull/113/files
Please reload this pagehttps://github.com/github/codeql/pull/113/files
Please reload this pagehttps://github.com/github/codeql/pull/113/files
analysis-javascript.md https://github.com/github/codeql/pull/113/files#diff-3d5878546af195b26c47c317e967a3a89aa5e27d769dfa9d98178cced97f7ead
javascript.qll https://github.com/github/codeql/pull/113/files#diff-e0e7cb728b15e6b6ee0dd9ce145f460aec7e3571962b5e2a3503104658d4cecc
PropertyProjection.qll https://github.com/github/codeql/pull/113/files#diff-e0dc5242279b13a569a516176712c01b377897a98aa492760db1273e42b68478
PropertyInjectionTaint.expected https://github.com/github/codeql/pull/113/files#diff-68695366fd8dcaa797c6568489c29845f3255f72a0c247edd38a51b954719f8d
PropertyInjectionTaint.ql https://github.com/github/codeql/pull/113/files#diff-9eaa18ff5bcc70f55a338e7bd79cc735d048adb72fdcc4dee88c628f94575304
PropertyProjection.expected https://github.com/github/codeql/pull/113/files#diff-1dff4e824f276f4003efd3b1d84284c2744cbbe68a4be201ea9c4d1b38e31688
PropertyProjection.ql https://github.com/github/codeql/pull/113/files#diff-8ea4a9c7631530a97b35106072d487362a1473748caa6e7b797a050422a468c6
tst.js https://github.com/github/codeql/pull/113/files#diff-983da5070d0ae93f15afb0c9a28a1de8461b363765ae6caca76867d22594a4c1
change-notes/1.18/analysis-javascript.mdhttps://github.com/github/codeql/pull/113/files#diff-3d5878546af195b26c47c317e967a3a89aa5e27d769dfa9d98178cced97f7ead
View file https://github.com/github/codeql/blob/6ee8f71d09a16006ce3e228512b807e4d4029052/change-notes/1.18/analysis-javascript.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/113/{{ revealButtonHref }}
https://github.com/github/codeql/pull/113/files#diff-3d5878546af195b26c47c317e967a3a89aa5e27d769dfa9d98178cced97f7ead
https://github.com/github/codeql/pull/113/files#diff-3d5878546af195b26c47c317e967a3a89aa5e27d769dfa9d98178cced97f7ead
javascript/ql/src/javascript.qllhttps://github.com/github/codeql/pull/113/files#diff-e0e7cb728b15e6b6ee0dd9ce145f460aec7e3571962b5e2a3503104658d4cecc
View file https://github.com/github/codeql/blob/6ee8f71d09a16006ce3e228512b807e4d4029052/javascript/ql/src/javascript.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/113/{{ revealButtonHref }}
https://github.com/github/codeql/pull/113/files#diff-e0e7cb728b15e6b6ee0dd9ce145f460aec7e3571962b5e2a3503104658d4cecc
https://github.com/github/codeql/pull/113/files#diff-e0e7cb728b15e6b6ee0dd9ce145f460aec7e3571962b5e2a3503104658d4cecc
javascript/ql/src/semmle/javascript/frameworks/PropertyProjection.qllhttps://github.com/github/codeql/pull/113/files#diff-e0dc5242279b13a569a516176712c01b377897a98aa492760db1273e42b68478
View file https://github.com/github/codeql/blob/6ee8f71d09a16006ce3e228512b807e4d4029052/javascript/ql/src/semmle/javascript/frameworks/PropertyProjection.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/113/{{ revealButtonHref }}
...cript/ql/test/library-tests/frameworks/PropertyProjection/PropertyInjectionTaint.expectedhttps://github.com/github/codeql/pull/113/files#diff-68695366fd8dcaa797c6568489c29845f3255f72a0c247edd38a51b954719f8d
View file https://github.com/github/codeql/blob/6ee8f71d09a16006ce3e228512b807e4d4029052/javascript/ql/test/library-tests/frameworks/PropertyProjection/PropertyInjectionTaint.expected
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/113/{{ revealButtonHref }}
javascript/ql/test/library-tests/frameworks/PropertyProjection/PropertyInjectionTaint.qlhttps://github.com/github/codeql/pull/113/files#diff-9eaa18ff5bcc70f55a338e7bd79cc735d048adb72fdcc4dee88c628f94575304
View file https://github.com/github/codeql/blob/6ee8f71d09a16006ce3e228512b807e4d4029052/javascript/ql/test/library-tests/frameworks/PropertyProjection/PropertyInjectionTaint.ql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/113/{{ revealButtonHref }}
javascript/ql/test/library-tests/frameworks/PropertyProjection/PropertyProjection.expectedhttps://github.com/github/codeql/pull/113/files#diff-1dff4e824f276f4003efd3b1d84284c2744cbbe68a4be201ea9c4d1b38e31688
View file https://github.com/github/codeql/blob/6ee8f71d09a16006ce3e228512b807e4d4029052/javascript/ql/test/library-tests/frameworks/PropertyProjection/PropertyProjection.expected
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/113/{{ revealButtonHref }}
javascript/ql/test/library-tests/frameworks/PropertyProjection/PropertyProjection.qlhttps://github.com/github/codeql/pull/113/files#diff-8ea4a9c7631530a97b35106072d487362a1473748caa6e7b797a050422a468c6
View file https://github.com/github/codeql/blob/6ee8f71d09a16006ce3e228512b807e4d4029052/javascript/ql/test/library-tests/frameworks/PropertyProjection/PropertyProjection.ql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/113/{{ revealButtonHref }}
javascript/ql/test/library-tests/frameworks/PropertyProjection/tst.jshttps://github.com/github/codeql/pull/113/files#diff-983da5070d0ae93f15afb0c9a28a1de8461b363765ae6caca76867d22594a4c1
View file https://github.com/github/codeql/blob/6ee8f71d09a16006ce3e228512b807e4d4029052/javascript/ql/test/library-tests/frameworks/PropertyProjection/tst.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/113/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.