René's URL Explorer Experiment


Title: Dataflow: Fix implicit reads in taint tracking when FlowStates are used by atorralba · Pull Request #10360 · github/codeql · GitHub

Open Graph Title: Dataflow: Fix implicit reads in taint tracking when FlowStates are used by atorralba · Pull Request #10360 · github/codeql

X Title: Dataflow: Fix implicit reads in taint tracking when FlowStates are used by atorralba · Pull Request #10360 · github/codeql

Description: CodeQL: the libraries and queries that power security researchers around the world, as well as code scanning in GitHub Advanced Security - Dataflow: Fix implicit reads in taint tracking when FlowStates are used by atorralba · Pull Request #10360 · github/codeql

Open Graph Description: The first commit adds a test that fails because implicit reads weren't allowed in sinks or additional taint steps that used FlowStates. The second commit fixes the issue.

X Description: The first commit adds a test that fails because implicit reads weren't allowed in sinks or additional taint steps that used FlowStates. The second commit fixes the issue.

Opengraph URL: https://github.com/github/codeql/pull/10360

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:06ea319d-cd62-1e3e-907c-4f544012c298
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idABCC:380818:12E0A8:1A6B3C:6A4D14D1
html-safe-nonce8aa8e98d8fc508c2bf77ccd430201cc28de3ddb99fd33d4b886a2529e993b305
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkNDOjM4MDgxODoxMkUwQTg6MUE2QjNDOjZBNEQxNEQxIiwidmlzaXRvcl9pZCI6IjI1NjgyMDczMjM0MzY4NjM1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac22a93e785894205e9a90bcf9de0c5fce59122a61eebc08ac996dfeb432217961
hovercard-subject-tagpull_request:1050467268
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/github/codeql/10360/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/747877772f58aa800885582de74caa67fb362f700412342f310457551ef7c172/github/codeql/pull/10360
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/747877772f58aa800885582de74caa67fb362f700412342f310457551ef7c172/github/codeql/pull/10360
og:image:altThe first commit adds a test that fails because implicit reads weren't allowed in sinks or additional taint steps that used FlowStates. The second commit fixes the issue.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameatorralba
hostnamegithub.com
expected-hostnamegithub.com
Nonebcb4661e6fb4fe8b394c51ea02ccdb2236d40dc59afc75a3bbba50bf6517134c
turbo-cache-controlno-cache
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefb70bd3c4b2bec429781b65419e912c66e2d5581
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/10360#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F10360
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F10360
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/10360
Reloadhttps://github.com/github/codeql/pull/10360
Reloadhttps://github.com/github/codeql/pull/10360
Please reload this pagehttps://github.com/github/codeql/pull/10360
github https://github.com/github
codeqlhttps://github.com/github/codeql
Notifications https://github.com/login?return_to=%2Fgithub%2Fcodeql
Fork 2k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Star 9.8k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Code https://github.com/github/codeql
Issues 987 https://github.com/github/codeql/issues
Pull requests 424 https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality 0 https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Code https://github.com/github/codeql
Issues https://github.com/github/codeql/issues
Pull requests https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
atorralbahttps://github.com/atorralba
github:mainhttps://github.com/github/codeql/tree/main
atorralba:atorralba/fix-taint-implicit-readshttps://github.com/atorralba/codeql/tree/atorralba/fix-taint-implicit-reads
Conversationhttps://github.com/github/codeql/pull/10360
Commits4 (4)https://github.com/github/codeql/pull/10360/commits
Checkshttps://github.com/github/codeql/pull/10360/checks
Files changedhttps://github.com/github/codeql/pull/10360/files
Dataflow: Fix implicit reads in taint tracking when FlowStates are usedhttps://github.com/github/codeql/pull/10360#top
atorralbahttps://github.com/atorralba
github:mainhttps://github.com/github/codeql/tree/main
atorralba:atorralba/fix-taint-implicit-readshttps://github.com/atorralba/codeql/tree/atorralba/fix-taint-implicit-reads
https://github.com/atorralba
atorralbahttps://github.com/atorralba
Sep 8, 2022https://github.com/github/codeql/pull/10360#issue-1366567469
Please reload this pagehttps://github.com/github/codeql/pull/10360
atorralbahttps://github.com/atorralba
September 8, 2022 17:19https://github.com/github/codeql/pull/10360#commits-pushed-d5f101d
https://github.com/atorralba
Add implicit read FlowState testhttps://github.com/github/codeql/pull/10360/commits/d5f101d7e669af0e99d73d307f9eb7e729498b9d
d5f101dhttps://github.com/github/codeql/pull/10360/commits/d5f101d7e669af0e99d73d307f9eb7e729498b9d
https://github.com/atorralba
Add implicit reads for FlowState sinks and stepshttps://github.com/github/codeql/pull/10360/commits/1b87167d966fc2e12130edfcd8fcc04bee2ef01b
1b87167https://github.com/github/codeql/pull/10360/commits/1b87167d966fc2e12130edfcd8fcc04bee2ef01b
https://github.com/atorralba
atorralbahttps://github.com/atorralba
code ownerhttps://github.com/github/codeql/blob/0feeafd0acaaf583d146269430c45aea1b286b65/CODEOWNERS#L4
September 8, 2022 15:28https://github.com/github/codeql/pull/10360#event-7348969570
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
documentation https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Adocumentation
Java https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AJava
Sep 8, 2022https://github.com/github/codeql/pull/10360#event-7348972775
https://github.com/atorralba
Sync fileshttps://github.com/github/codeql/pull/10360/commits/7db1eb98f5fc274190f99e645c813e2f4f803a9d
7db1eb9https://github.com/github/codeql/pull/10360/commits/7db1eb98f5fc274190f99e645c813e2f4f803a9d
https://github.com/atorralba
atorralbahttps://github.com/atorralba
code ownershttps://github.com/github/codeql/blob/0feeafd0acaaf583d146269430c45aea1b286b65/CODEOWNERS#L8
September 8, 2022 15:32https://github.com/github/codeql/pull/10360#event-7349013079
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
C# https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AC%23
C++ https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AC%2B%2B
Python https://github.com/github/codeql/issues?q=state%3Aopen%20label%3APython
Ruby https://github.com/github/codeql/issues?q=state%3Aopen%20label%3ARuby
Swift https://github.com/github/codeql/issues?q=state%3Aopen%20label%3ASwift
Sep 8, 2022https://github.com/github/codeql/pull/10360#event-7349016280
https://github.com/MathiasVP
MathiasVPhttps://github.com/MathiasVP
Sep 8, 2022 https://github.com/github/codeql/pull/10360#pullrequestreview-1100979194
View reviewed changes https://github.com/github/codeql/pull/10360/files/7db1eb98f5fc274190f99e645c813e2f4f803a9d
https://github.com/atorralba
atorralbahttps://github.com/atorralba
Sep 8, 2022https://github.com/github/codeql/pull/10360#event-7349137766
https://github.com/aschackmull
aschackmullhttps://github.com/aschackmull
Sep 9, 2022 https://github.com/github/codeql/pull/10360#pullrequestreview-1101859095
View reviewed changes https://github.com/github/codeql/pull/10360/files/7db1eb98f5fc274190f99e645c813e2f4f803a9d
java/ql/lib/change-notes/2022-09-08-implicit-read-flowstates.mdhttps://github.com/github/codeql/pull/10360/files/7db1eb98f5fc274190f99e645c813e2f4f803a9d#diff-667937f3807d9876c94d3bab9ea16ef4d7b6b7c881a3737076f18dccffd11252
Please reload this pagehttps://github.com/github/codeql/pull/10360
https://github.com/atorralba
atorralbahttps://github.com/atorralba
MathiasVPhttps://github.com/MathiasVP
stale reviewhttps://github.com/github/codeql/pull/10360#pullrequestreview-1100979194
6f9b856https://github.com/github/codeql/commit/6f9b85626212e8833e80dc05adf259f1cacf5fbe
September 9, 2022 08:26https://github.com/github/codeql/pull/10360#event-7354354051
https://github.com/atorralba
atorralbahttps://github.com/atorralba
code ownerhttps://github.com/github/codeql/blob/9893650f7cd3f8634c4ad5feca127d69fed61dbc/CODEOWNERS#L5
September 9, 2022 08:26https://github.com/github/codeql/pull/10360#event-7354354065
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
JS https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AJS
Sep 9, 2022https://github.com/github/codeql/pull/10360#event-7354356253
https://github.com/aschackmull
aschackmullhttps://github.com/aschackmull
Sep 9, 2022 https://github.com/github/codeql/pull/10360#pullrequestreview-1101906375
View reviewed changes https://github.com/github/codeql/pull/10360/files
javascript/ql/lib/change-notes/2022-09-08-implicit-read-flowstates.mdhttps://github.com/github/codeql/pull/10360/files#diff-d3d3772006042dbd81a27639e7e5271c2d061164bbdd082d7ce5b18ebb34cade
Please reload this pagehttps://github.com/github/codeql/pull/10360
https://github.com/atorralba
Add change notes for all languageshttps://github.com/github/codeql/pull/10360/commits/1078cf091ee98a99d824ed6555c5698641ef72b3
1078cf0https://github.com/github/codeql/pull/10360/commits/1078cf091ee98a99d824ed6555c5698641ef72b3
https://github.com/atorralba
atorralbahttps://github.com/atorralba
force-pushedhttps://github.com/github/codeql/compare/6f9b85626212e8833e80dc05adf259f1cacf5fbe..1078cf091ee98a99d824ed6555c5698641ef72b3
6f9b856https://github.com/github/codeql/commit/6f9b85626212e8833e80dc05adf259f1cacf5fbe
1078cf0https://github.com/github/codeql/commit/1078cf091ee98a99d824ed6555c5698641ef72b3
Compare https://github.com/github/codeql/compare/6f9b85626212e8833e80dc05adf259f1cacf5fbe..1078cf091ee98a99d824ed6555c5698641ef72b3
September 9, 2022 08:28https://github.com/github/codeql/pull/10360#event-7354368971
https://github.com/atorralba
atorralbahttps://github.com/atorralba
JS https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AJS
Sep 9, 2022https://github.com/github/codeql/pull/10360#event-7354370415
https://github.com/atorralba
atorralbahttps://github.com/atorralba
September 9, 2022 08:29https://github.com/github/codeql/pull/10360#event-7354371506
https://github.com/aschackmull
aschackmullhttps://github.com/aschackmull
Sep 9, 2022 https://github.com/github/codeql/pull/10360#pullrequestreview-1101909222
View reviewed changes https://github.com/github/codeql/pull/10360/files/1078cf091ee98a99d824ed6555c5698641ef72b3
https://github.com/atorralba
atorralbahttps://github.com/atorralba
569fad6https://github.com/github/codeql/commit/569fad667af319dd9a649637e0ccdca072229ce5
Sep 9, 2022https://github.com/github/codeql/pull/10360#event-7355996672
https://github.com/atorralba
atorralbahttps://github.com/atorralba
September 9, 2022 12:28https://github.com/github/codeql/pull/10360#event-7355997085
https://github.com/atorralba
atorralbahttps://github.com/atorralba
Sep 16, 2022 https://github.com/github/codeql/pull/10360#ref-pullrequest-1366171312
Java: Promote Server-side template injection from experimental #10352 https://github.com/github/codeql/pull/10352
https://github.com/owen-mc
owen-mchttps://github.com/owen-mc
DataFlow Library https://github.com/github/codeql/issues?q=state%3Aopen%20label%3A%22DataFlow%20Library%22
Nov 10, 2022https://github.com/github/codeql/pull/10360#event-7784623102
owen-mchttps://github.com/owen-mc
Nov 29, 2022 https://github.com/github/codeql/pull/10360#ref-commit-6db037f
https://github.com/owen-mc
Update shared library files for go to PRhttps://github.com/owen-mc/codeql/commit/6db037fa9377546d83faa1880ffbb064c065073b
github#10360https://github.com/github/codeql/pull/10360
6db037fhttps://github.com/owen-mc/codeql/commit/6db037fa9377546d83faa1880ffbb064c065073b
569fad6https://github.com/owen-mc/codeql/commit/569fad667af319dd9a649637e0ccdca072229ce5
owen-mchttps://github.com/owen-mc
Nov 29, 2022 https://github.com/github/codeql/pull/10360#ref-commit-de9fc06
https://github.com/owen-mc
Update shared library files for go to PRhttps://github.com/owen-mc/codeql/commit/de9fc06f332cd09bbe2f2b63a398cf3281379416
github#10360https://github.com/github/codeql/pull/10360
de9fc06https://github.com/owen-mc/codeql/commit/de9fc06f332cd09bbe2f2b63a398cf3281379416
569fad6https://github.com/owen-mc/codeql/commit/569fad667af319dd9a649637e0ccdca072229ce5
owen-mchttps://github.com/owen-mc
Nov 29, 2022 https://github.com/github/codeql/pull/10360#ref-commit-e100141
https://github.com/owen-mc
Update shared library files for go to PRhttps://github.com/owen-mc/codeql/commit/e100141adfc9cc3d06d1741fff9aa934900bfb9b
github#10360https://github.com/github/codeql/pull/10360
e100141https://github.com/owen-mc/codeql/commit/e100141adfc9cc3d06d1741fff9aa934900bfb9b
569fad6https://github.com/owen-mc/codeql/commit/569fad667af319dd9a649637e0ccdca072229ce5
owen-mchttps://github.com/owen-mc
Nov 29, 2022 https://github.com/github/codeql/pull/10360#ref-commit-628230f
https://github.com/owen-mc
Update shared library files for go to PRhttps://github.com/owen-mc/codeql/commit/628230f14c15d6cee2ce231b5f696769d4ddf0ed
github#10360https://github.com/github/codeql/pull/10360
628230fhttps://github.com/owen-mc/codeql/commit/628230f14c15d6cee2ce231b5f696769d4ddf0ed
569fad6https://github.com/owen-mc/codeql/commit/569fad667af319dd9a649637e0ccdca072229ce5
https://github.co/hiddenchars
https://github.com/github/codeql/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F10360
https://github.com/aschackmull
aschackmull https://github.com/aschackmull
https://github.com/github/codeql/pull/10360/files/1078cf091ee98a99d824ed6555c5698641ef72b3
https://github.com/MathiasVP
MathiasVP https://github.com/MathiasVP
https://github.com/github/codeql/pull/10360/files/7db1eb98f5fc274190f99e645c813e2f4f803a9d
C# https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AC%23
C++ https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AC%2B%2B
DataFlow Library https://github.com/github/codeql/issues?q=state%3Aopen%20label%3A%22DataFlow%20Library%22
documentation https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Adocumentation
Java https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AJava
Python https://github.com/github/codeql/issues?q=state%3Aopen%20label%3APython
Ruby https://github.com/github/codeql/issues?q=state%3Aopen%20label%3ARuby
Swift https://github.com/github/codeql/issues?q=state%3Aopen%20label%3ASwift
Please reload this pagehttps://github.com/github/codeql/pull/10360
https://github.com/atorralba
https://github.com/MathiasVP
https://github.com/aschackmull
https://github.com/owen-mc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.