| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ce289986-07c4-be05-d292-8cb3a4442305 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A17E:3FF092:C48F56:10DDB6C:6A4DCBEA |
| html-safe-nonce | ea01e5c8b9b3e0869104c0c8af189e86e109a654964f0f557271f172c54cb3c3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTdFOjNGRjA5MjpDNDhGNTY6MTBEREI2Qzo2QTREQ0JFQSIsInZpc2l0b3JfaWQiOiI5MjAwNjI1MzM3Nzg3ODYxOTk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 42992c1cf72fa89b4716c23f42d8e1e46685fb2a9455b3ca66d0ec5ee1d17594 |
| hovercard-subject-tag | pull_request:1050103168 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql/pull/10352/files |
| twitter:image | https://avatars.githubusercontent.com/u/11612352?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/11612352?s=400&v=4 |
| og:image:alt | Promotes #5935 to the main query pack.
DCA and MRVA runs look uneventful. |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql git https://github.com/github/codeql.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 143040428 |
| octolytics-dimension-repository_nwo | github/codeql |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 143040428 |
| octolytics-dimension-repository_network_root_nwo | github/codeql |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/github/codeql/pull/10352/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F10352%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F10352%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql |
| Reload | https://github.com/github/codeql/pull/10352/files |
| Reload | https://github.com/github/codeql/pull/10352/files |
| Reload | https://github.com/github/codeql/pull/10352/files |
| Please reload this page | https://github.com/github/codeql/pull/10352/files |
|
github
| https://github.com/github |
| codeql | https://github.com/github/codeql |
|
Notifications
| https://github.com/login?return_to=%2Fgithub%2Fcodeql |
|
Fork
2k
| https://github.com/login?return_to=%2Fgithub%2Fcodeql |
|
Star
9.8k
| https://github.com/login?return_to=%2Fgithub%2Fcodeql |
|
Code
| https://github.com/github/codeql |
|
Issues
987
| https://github.com/github/codeql/issues |
|
Pull requests
426
| https://github.com/github/codeql/pulls |
|
Discussions
| https://github.com/github/codeql/discussions |
|
Actions
| https://github.com/github/codeql/actions |
|
Projects
| https://github.com/github/codeql/projects |
|
Models
| https://github.com/github/codeql/models |
|
Security and quality
0
| https://github.com/github/codeql/security |
|
Insights
| https://github.com/github/codeql/pulse |
|
Code
| https://github.com/github/codeql |
|
Issues
| https://github.com/github/codeql/issues |
|
Pull requests
| https://github.com/github/codeql/pulls |
|
Discussions
| https://github.com/github/codeql/discussions |
|
Actions
| https://github.com/github/codeql/actions |
|
Projects
| https://github.com/github/codeql/projects |
|
Models
| https://github.com/github/codeql/models |
|
Security and quality
| https://github.com/github/codeql/security |
|
Insights
| https://github.com/github/codeql/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose |
| atorralba | https://github.com/atorralba |
| github:main | https://github.com/github/codeql/tree/main |
| atorralba:atorralba/promote-template-injection | https://github.com/atorralba/codeql/tree/atorralba/promote-template-injection |
|
Conversation
20
| https://github.com/github/codeql/pull/10352 |
|
Findings
| https://github.com/github/codeql/pull/10352/findings |
|
Commits
14
| https://github.com/github/codeql/pull/10352/commits |
|
Checks
0
| https://github.com/github/codeql/pull/10352/checks |
|
Files changed
| https://github.com/github/codeql/pull/10352/files |
| Please reload this page | https://github.com/github/codeql/pull/10352/files |
|
Java: Promote Server-side template injection from experimental
| https://github.com/github/codeql/pull/10352/files#top |
|
Show all changes
14 commits
| https://github.com/github/codeql/pull/10352/files |
|
cd61bd0
Move files from experimental
atorralba Sep 7, 2022
| https://github.com/github/codeql/pull/10352/commits/cd61bd06060987eac7fbb3d1b70f9a5da6544c0a |
|
c972809
Generate stubs, adapt tests
atorralba Sep 8, 2022
| https://github.com/github/codeql/pull/10352/commits/c9728098efd3a4dac04c4ad2d5dc67302b32ab8d |
|
b68e666
Refactor TemplateInjection libraries
atorralba Sep 8, 2022
| https://github.com/github/codeql/pull/10352/commits/b68e6669b8763f2559a5a2e853f227fa5299bb33 |
|
e311155
Use InlineExpectationsTest
atorralba Sep 8, 2022
| https://github.com/github/codeql/pull/10352/commits/e311155acdd405d39b13c46a29c8e047ef8a1f5f |
|
fb13e7f
Docs changes
atorralba Sep 8, 2022
| https://github.com/github/codeql/pull/10352/commits/fb13e7f307ceb1b948db82b8acded3ea49d81846 |
|
6413de6
Add change note
atorralba Sep 8, 2022
| https://github.com/github/codeql/pull/10352/commits/6413de6c20f39f68bcae1f49fd83cfe5a4e7f11e |
|
d748fb5
Fix bad models, add tests for those
atorralba Sep 9, 2022
| https://github.com/github/codeql/pull/10352/commits/d748fb5648b5e67267f1eb4003b976dce9437c31 |
|
409a123
Tainting the velocity context isn't exploitable
atorralba Sep 12, 2022
| https://github.com/github/codeql/pull/10352/commits/409a123490849cda6f8b3f6115b9b4bf3ac7aba2 |
|
dd6257c
Add security-severity
atorralba Sep 12, 2022
| https://github.com/github/codeql/pull/10352/commits/dd6257c7576b2dd4eead5fcbd799450bdaea1b2b |
|
79a32f1
Tainting the freemarker dataModel isn't exploitable
atorralba Sep 12, 2022
| https://github.com/github/codeql/pull/10352/commits/79a32f1a3e1f9091117535e21f401721bbf6d5bc |
|
f412f43
Add thymeleaf steps
atorralba Sep 12, 2022
| https://github.com/github/codeql/pull/10352/commits/f412f433bfbf468bd12d8aa877e3188cebdd33a4 |
|
3141fda
Address review comments re: flow states
atorralba Sep 16, 2022
| https://github.com/github/codeql/pull/10352/commits/3141fdae722e575eccb5aa8c32d855665cb7ef88 |
|
4997f36
Apply suggestions from code review
atorralba Sep 20, 2022
| https://github.com/github/codeql/pull/10352/commits/4997f36f0534314ac724921a7b1a10027e4f763b |
|
4af29e6
Update java/ql/src/Security/CWE/CWE-094/TemplateInjection.qhelp
atorralba Sep 20, 2022
| https://github.com/github/codeql/pull/10352/commits/4af29e6abfda56282d4c960047711ada204e7f01 |
|
Clear filters
| https://github.com/github/codeql/pull/10352/files |
| Please reload this page | https://github.com/github/codeql/pull/10352/files |
| Please reload this page | https://github.com/github/codeql/pull/10352/files |
|
| https://github.com/github/codeql/blob/main/CODEOWNERS#L16 |
| java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll | https://github.com/github/codeql/pull/10352/files#diff-c12750860861137019d9be853f5693171c9017570071f9b68cca059edd9ae7b1 |
|
View file
| https://github.com/atorralba/codeql/blob/4af29e6abfda56282d4c960047711ada204e7f01/java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/github/codeql/pull/10352/{{ revealButtonHref }} |
|
| https://github.com/github/codeql/pull/10352/files#diff-c12750860861137019d9be853f5693171c9017570071f9b68cca059edd9ae7b1 |
|
| https://github.com/github/codeql/pull/10352/files#diff-c12750860861137019d9be853f5693171c9017570071f9b68cca059edd9ae7b1 |
|
| https://github.com/github/codeql/pull/10352/files#diff-c12750860861137019d9be853f5693171c9017570071f9b68cca059edd9ae7b1 |
|
| https://github.com/github/codeql/pull/10352/files#diff-c12750860861137019d9be853f5693171c9017570071f9b68cca059edd9ae7b1 |
|
| https://github.com/github/codeql/pull/10352/files#diff-c12750860861137019d9be853f5693171c9017570071f9b68cca059edd9ae7b1 |
|
| https://github.com/github/codeql/blob/main/CODEOWNERS#L16 |
| java/ql/lib/semmle/code/java/frameworks/Thymeleaf.qll | https://github.com/github/codeql/pull/10352/files#diff-6cfbf5d7536dfc52108097e8d49442fb6f679ee2ed8c0708e7c6810434777cd1 |
|
View file
| https://github.com/atorralba/codeql/blob/4af29e6abfda56282d4c960047711ada204e7f01/java/ql/lib/semmle/code/java/frameworks/Thymeleaf.qll |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/github/codeql/pull/10352/{{ revealButtonHref }} |
|
| https://github.com/github/codeql/blob/main/CODEOWNERS#L16 |
| java/ql/lib/semmle/code/java/security/TemplateInjection.qll | https://github.com/github/codeql/pull/10352/files#diff-5cf1cfffce8ca1bb40a1e7c6795556316fd06912863b602e951f8aa35c2eff43 |
|
View file
| https://github.com/atorralba/codeql/blob/4af29e6abfda56282d4c960047711ada204e7f01/java/ql/lib/semmle/code/java/security/TemplateInjection.qll |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/github/codeql/pull/10352/{{ revealButtonHref }} |
|
| https://github.com/github/codeql/blob/main/CODEOWNERS#L16 |
| java/ql/lib/semmle/code/java/security/TemplateInjectionQuery.qll | https://github.com/github/codeql/pull/10352/files#diff-3a65180d20bbee8940fd84a0e2c0889500cff78b5f31f5d66e8b9a426ebd35ce |
|
View file
| https://github.com/atorralba/codeql/blob/4af29e6abfda56282d4c960047711ada204e7f01/java/ql/lib/semmle/code/java/security/TemplateInjectionQuery.qll |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/github/codeql/pull/10352/{{ revealButtonHref }} |
|
| https://github.com/github/codeql/blob/main/CODEOWNERS#L16 |
| ...imental/Security/CWE/CWE-094/SSTIBad.java → .../ql/src/Security/CWE/CWE-094/SSTIBad.java | https://github.com/github/codeql/pull/10352/files#diff-77ea8f3c17a7d80f0bbeb3778d84b8ada6ebef947d58ca2d6b1802433ca1f4ad |
|
View file
| https://github.com/atorralba/codeql/blob/4af29e6abfda56282d4c960047711ada204e7f01/java/ql/src/Security/CWE/CWE-094/SSTIBad.java |
|
Open in desktop
| https://desktop.github.com |
|
| https://github.com/github/codeql/blob/main/CODEOWNERS#L16 |
| ...mental/Security/CWE/CWE-094/SSTIGood.java → ...ql/src/Security/CWE/CWE-094/SSTIGood.java | https://github.com/github/codeql/pull/10352/files#diff-91245d3ddb172b9473ccdeafdaff52e9153bce7ba382f2503db501e4976c9b1f |
|
View file
| https://github.com/atorralba/codeql/blob/4af29e6abfda56282d4c960047711ada204e7f01/java/ql/src/Security/CWE/CWE-094/SSTIGood.java |
|
Open in desktop
| https://desktop.github.com |
|
| https://github.com/github/codeql/blob/main/CODEOWNERS#L16 |
| java/ql/src/Security/CWE/CWE-094/TemplateInjection.qhelp | https://github.com/github/codeql/pull/10352/files#diff-a9eb20b9e7f64d44e717e03d4498db2891da733f8e7d8b5dd2a9d0a5b7f3febd |
|
View file
| https://github.com/atorralba/codeql/blob/4af29e6abfda56282d4c960047711ada204e7f01/java/ql/src/Security/CWE/CWE-094/TemplateInjection.qhelp |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/github/codeql/pull/10352/{{ revealButtonHref }} |
|
| https://github.com/github/codeql/blob/main/CODEOWNERS#L16 |
| ...Security/CWE/CWE-094/TemplateInjection.ql → ...Security/CWE/CWE-094/TemplateInjection.ql | https://github.com/github/codeql/pull/10352/files#diff-07f94c95d44a389f12d92fc2a29b6b968718383a75b1994f82e06e6136926f47 |
|
View file
| https://github.com/atorralba/codeql/blob/4af29e6abfda56282d4c960047711ada204e7f01/java/ql/src/Security/CWE/CWE-094/TemplateInjection.ql |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/github/codeql/pull/10352/{{ revealButtonHref }} |
|
| https://github.com/github/codeql/pull/10352/files#diff-07f94c95d44a389f12d92fc2a29b6b968718383a75b1994f82e06e6136926f47 |
|
| https://github.com/github/codeql/blob/main/CODEOWNERS#L16 |
| java/ql/src/change-notes/2022-09-08-server-side-template-injection-query.md | https://github.com/github/codeql/pull/10352/files#diff-1d6b314766ed536ff5c56392a1efafb6247fcbe8784d8a4557cd3135cc6502dd |
|
View file
| https://github.com/atorralba/codeql/blob/4af29e6abfda56282d4c960047711ada204e7f01/java/ql/src/change-notes/2022-09-08-server-side-template-injection-query.md |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/github/codeql/pull/10352/{{ revealButtonHref }} |
|
| https://github.com/github/codeql/blob/main/CODEOWNERS#L16 |
| java/ql/src/experimental/Security/CWE/CWE-094/TemplateInjection.qhelp | https://github.com/github/codeql/pull/10352/files#diff-dd77196f810568db2dae23d913fb564d03377d10948b92f69a17ad32079b5e28 |
|
View file
| https://github.com/github/codeql/blob/95a9faf1f94186eeb5339b31c28402789ee06f60/java/ql/src/experimental/Security/CWE/CWE-094/TemplateInjection.qhelp |
|
Open in desktop
| https://desktop.github.com |
| Please reload this page | https://github.com/github/codeql/pull/10352/files |
| Please reload this page | https://github.com/github/codeql/pull/10352/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |