René's URL Explorer Experiment


Title: JS: Enable type extraction inside conditional types again by asgerf · Pull Request #10202 · github/codeql · GitHub

Open Graph Title: JS: Enable type extraction inside conditional types again by asgerf · Pull Request #10202 · github/codeql

X Title: JS: Enable type extraction inside conditional types again by asgerf · Pull Request #10202 · github/codeql

Description: This re-enables type extraction inside conditional types, i.e. types of form X extends Y ? A : B, which are relevant for extracting MaD typings from .d.ts files. This was originally disabled in #1295 to avoid divergence issues when extracting the type property graph. However, in #3781 we stopped extracting the type property graph entirely, so the previous mitigation should no longer be needed. I verified that this code, which originally caused problems, still works after this change. Evaluation also looks fine.

Open Graph Description: This re-enables type extraction inside conditional types, i.e. types of form X extends Y ? A : B, which are relevant for extracting MaD typings from .d.ts files. This was originally disabled in #12...

X Description: This re-enables type extraction inside conditional types, i.e. types of form X extends Y ? A : B, which are relevant for extracting MaD typings from .d.ts files. This was originally disabled in #12...

Opengraph URL: https://github.com/github/codeql/pull/10202

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:450d53a0-5c0d-7d97-cf3b-863df7fdaa76
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA4C:16AB79:54E64E:6D9379:6B00DAF2
html-safe-nonce46095b0e7663a09ea6cec2fbf2b251b08d15b1a4b3f198d3e3fbf2af40058bb5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTRDOjE2QUI3OTo1NEU2NEU6NkQ5Mzc5OjZCMDBEQUYyIiwidmlzaXRvcl9pZCI6IjIzNDEwNTcwNjk5MTE2OTQwNjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac24161e5fedefa5d18d299fbbd004c202e078cc2b043711f756435e4bdd040ee1
hovercard-subject-tagpull_request:1039320961
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql/pull/10202/files
twitter:imagehttps://avatars.githubusercontent.com/u/316427?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/316427?s=400&v=4
og:image:altThis re-enables type extraction inside conditional types, i.e. types of form X extends Y ? A : B, which are relevant for extracting MaD typings from .d.ts files. This was originally disabled in #12...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonea481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84c8c5cc25e2fb7f2308428458538436baecc6d2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/10202/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F10202%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F10202%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/10202/files
Reloadhttps://github.com/github/codeql/pull/10202/files
Reloadhttps://github.com/github/codeql/pull/10202/files
githubhttps://github.com/github
codeqlhttps://github.com/github/codeql
Codehttps://github.com/github/codeql
Issues1k (1k)https://github.com/github/codeql/issues
Pull requests507 (507)https://github.com/github/codeql/pulls
Discussionshttps://github.com/github/codeql/discussions
Actionshttps://github.com/github/codeql/actions
Projectshttps://github.com/github/codeql/projects
Security and qualityhttps://github.com/github/codeql/security
Insightshttps://github.com/github/codeql/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
asgerfhttps://github.com/asgerf
github:mainhttps://github.com/github/codeql/tree/main
asgerf:js/typescript-conditional-typeshttps://github.com/asgerf/codeql/tree/js/typescript-conditional-types
Conversation 1 https://github.com/github/codeql/pull/10202
Commits 2 https://github.com/github/codeql/pull/10202/commits
Checks 0 https://github.com/github/codeql/pull/10202/checks
Findings https://github.com/github/codeql/pull/10202/findings
Files changed https://github.com/github/codeql/pull/10202/files
Please reload this pagehttps://github.com/github/codeql/pull/10202/files
JS: Enable type extraction inside conditional types again https://github.com/github/codeql/pull/10202/files#top
Show all changes 2 commits https://github.com/github/codeql/pull/10202/files
1a0abfa JS: Enable type extraction inside conditional types again asgerf Aug 20, 2022 https://github.com/github/codeql/pull/10202/commits/1a0abfa7a5931d2c73fde4e55b585ab39fe9eae8
45d64c4 JS: Update test output asgerf Aug 29, 2022 https://github.com/github/codeql/pull/10202/commits/45d64c48e3de1b9320847316ec7cd05dd35382f6
Clear filters https://github.com/github/codeql/pull/10202/files
Please reload this pagehttps://github.com/github/codeql/pull/10202/files
Please reload this pagehttps://github.com/github/codeql/pull/10202/files
ast_extractor.ts https://github.com/github/codeql/pull/10202/files#diff-fb9abbf10d9e177b0cc800c0819871f2cd997c3b504914cbf2185274efc8253a
tests.expected https://github.com/github/codeql/pull/10202/files#diff-3875ffc188d22382fe8522d0ee9db9fa50f225224c6ccd7ddeadb419a66b8236
https://github.com/github/codeql/blob/main/CODEOWNERS#L17
javascript/extractor/lib/typescript/src/ast_extractor.tshttps://github.com/github/codeql/pull/10202/files#diff-fb9abbf10d9e177b0cc800c0819871f2cd997c3b504914cbf2185274efc8253a
View file https://github.com/asgerf/codeql/blob/45d64c48e3de1b9320847316ec7cd05dd35382f6/javascript/extractor/lib/typescript/src/ast_extractor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/10202/{{ revealButtonHref }}
https://github.com/github/codeql/pull/10202/files#diff-fb9abbf10d9e177b0cc800c0819871f2cd997c3b504914cbf2185274efc8253a
https://github.com/github/codeql/pull/10202/files#diff-fb9abbf10d9e177b0cc800c0819871f2cd997c3b504914cbf2185274efc8253a
https://github.com/github/codeql/pull/10202/files#diff-fb9abbf10d9e177b0cc800c0819871f2cd997c3b504914cbf2185274efc8253a
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
javascript/ql/test/library-tests/TypeScript/Types/tests.expectedhttps://github.com/github/codeql/pull/10202/files#diff-3875ffc188d22382fe8522d0ee9db9fa50f225224c6ccd7ddeadb419a66b8236
View file https://github.com/asgerf/codeql/blob/45d64c48e3de1b9320847316ec7cd05dd35382f6/javascript/ql/test/library-tests/TypeScript/Types/tests.expected
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/10202/{{ revealButtonHref }}
https://github.com/github/codeql/pull/10202/files#diff-3875ffc188d22382fe8522d0ee9db9fa50f225224c6ccd7ddeadb419a66b8236
https://github.com/github/codeql/pull/10202/files#diff-3875ffc188d22382fe8522d0ee9db9fa50f225224c6ccd7ddeadb419a66b8236
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.