René's URL Explorer Experiment


Title: JavaScript: Update to TypeScript 4.8 by erik-krogh · Pull Request #10184 · github/codeql · GitHub

Open Graph Title: JavaScript: Update to TypeScript 4.8 by erik-krogh · Pull Request #10184 · github/codeql

X Title: JavaScript: Update to TypeScript 4.8 by erik-krogh · Pull Request #10184 · github/codeql

Description: https://devblogs.microsoft.com/typescript/announcing-typescript-4-8 The most tricky part was a change to the syntax tree representation. The modifiers property that we rely on in TypeScriptASTConverter.java might disappear at a later time. The fix at that point will be to use ts.canHaveModifiers() and ts.getModifiers(). TypeScript changed how illegal decorators are stored between 4.8.1-RC and 4.8.2 (this PR). So I had to fix that. Otherwise it was an uneventful update. There's not much new, and what's new doesn't affect us, except that we get slightly more precise types from TypeScript. Evaluation will appear here.

Open Graph Description: https://devblogs.microsoft.com/typescript/announcing-typescript-4-8 The most tricky part was a change to the syntax tree representation. The modifiers property that we rely on in TypeScriptASTConve...

X Description: https://devblogs.microsoft.com/typescript/announcing-typescript-4-8 The most tricky part was a change to the syntax tree representation. The modifiers property that we rely on in TypeScriptASTConve...

Opengraph URL: https://github.com/github/codeql/pull/10184

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0cb52b44-c2a1-8889-2e3e-55fab7a27739
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD24C:65478:6A69D8:8F789C:6B00D6FC
html-safe-nonce2864ec453dc7760f170f936fc9b2e6aa6e708d345d2efba2ca84097381cacf66
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjRDOjY1NDc4OjZBNjlEODo4Rjc4OUM6NkIwMEQ2RkMiLCJ2aXNpdG9yX2lkIjoiNzU3NzA3MjYwNDA3MTEyMjY4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd93f270e41feb1b7fd5a270675dfac1b74343618a1728d3fd011b6cc7f548864
hovercard-subject-tagpull_request:1037567644
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql/pull/10184/files
twitter:imagehttps://avatars.githubusercontent.com/u/54990334?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/54990334?s=400&v=4
og:image:althttps://devblogs.microsoft.com/typescript/announcing-typescript-4-8 The most tricky part was a change to the syntax tree representation. The modifiers property that we rely on in TypeScriptASTConve...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonea481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84c8c5cc25e2fb7f2308428458538436baecc6d2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/10184/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F10184%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F10184%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/10184/files
Reloadhttps://github.com/github/codeql/pull/10184/files
Reloadhttps://github.com/github/codeql/pull/10184/files
githubhttps://github.com/github
codeqlhttps://github.com/github/codeql
Codehttps://github.com/github/codeql
Issues1k (1k)https://github.com/github/codeql/issues
Pull requests507 (507)https://github.com/github/codeql/pulls
Discussionshttps://github.com/github/codeql/discussions
Actionshttps://github.com/github/codeql/actions
Projectshttps://github.com/github/codeql/projects
Security and qualityhttps://github.com/github/codeql/security
Insightshttps://github.com/github/codeql/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
erik-kroghhttps://github.com/erik-krogh
github:mainhttps://github.com/github/codeql/tree/main
erik-krogh:ts48https://github.com/erik-krogh/ql/tree/ts48
Conversation 2 https://github.com/github/codeql/pull/10184
Commits 6 https://github.com/github/codeql/pull/10184/commits
Checks 0 https://github.com/github/codeql/pull/10184/checks
Findings https://github.com/github/codeql/pull/10184/findings
Files changed https://github.com/github/codeql/pull/10184/files
Please reload this pagehttps://github.com/github/codeql/pull/10184/files
JavaScript: Update to TypeScript 4.8 https://github.com/github/codeql/pull/10184/files#top
Show all changes 6 commits https://github.com/github/codeql/pull/10184/files
b7367ca update to TypeScript 4.8RC erik-krogh Aug 20, 2022 https://github.com/github/codeql/pull/10184/commits/b7367ca649d90548a366c8652b9cab12e8589af1
97ffd2d add change-note erik-krogh Aug 25, 2022 https://github.com/github/codeql/pull/10184/commits/97ffd2d4d9d5f5ce8ab8598f5e15a493d1e36327
e0ff273 bump extractor version erik-krogh Aug 25, 2022 https://github.com/github/codeql/pull/10184/commits/e0ff27331fadfe9c4d12630cfaaf39b8ad18616b
50734c7 bump the TypeScript version in the list of supported languages erik-krogh Aug 25, 2022 https://github.com/github/codeql/pull/10184/commits/50734c7c6a558bbd082d518f583fca45b204b918
6aca9b9 fix support for illegal decorators in the TypeScript extractor erik-krogh Aug 29, 2022 https://github.com/github/codeql/pull/10184/commits/6aca9b9f49496a4d072025dbc26eaabd6488e446
56292ca don't modify the TypeScript nodes, instead forward illegalDecorators … erik-krogh Aug 29, 2022 https://github.com/github/codeql/pull/10184/commits/56292cad2672b2eb4108edd189ca8668adf99bfc
Clear filters https://github.com/github/codeql/pull/10184/files
Please reload this pagehttps://github.com/github/codeql/pull/10184/files
Please reload this pagehttps://github.com/github/codeql/pull/10184/files
versions-compilers.rst https://github.com/github/codeql/pull/10184/files#diff-06c3e6a6db5dfe666a9dd385535d43a5b860677ea8741fd928ef01515f1d6b42
package.json https://github.com/github/codeql/pull/10184/files#diff-683e5feb284d00ab4fce2a4cbfb0f53fb410acc6ae2ddf04db60daa79ad4399e
main.ts https://github.com/github/codeql/pull/10184/files#diff-ae9cb8c7ab2b8622a84b032f9529817adc5c06f123ad107e03e0cef73c9a52bb
type_table.ts https://github.com/github/codeql/pull/10184/files#diff-e85f5fd29f76a5ef27e0f467c31f6955e7c14ef75be5990b3e888dc137ce9ef6
yarn.lock https://github.com/github/codeql/pull/10184/files#diff-194c0548f88d51225d2a67f57efee7109c1291907a3f7c8d72ea5564a160bf23
Main.java https://github.com/github/codeql/pull/10184/files#diff-7d2f65585212078eaf8063085cea23a530dd479378804beb85874d20877aa97b
TypeScriptASTConverter.java https://github.com/github/codeql/pull/10184/files#diff-cc44112c6e8d612ffee22a5f3601bb288df186b8cd4c39cbf5b0b58cc8181af4
2022-05-24-typescript-4-8.md https://github.com/github/codeql/pull/10184/files#diff-b859ab031bf8b50870187248d23560215cfb06ba3291a0d37a0263b69dfe2383
printAst.expected https://github.com/github/codeql/pull/10184/files#diff-21269dde04a4bbb152c18ff23466b5f59cd3daf8459af97f7d672a0a917e61f0
tests.expected https://github.com/github/codeql/pull/10184/files#diff-3875ffc188d22382fe8522d0ee9db9fa50f225224c6ccd7ddeadb419a66b8236
tst.ts https://github.com/github/codeql/pull/10184/files#diff-62f3e5ed4cc5ea7545da1ea6857f1ccfef979b3b86ad9c9f9875930d58fb5bf3
https://github.com/github/codeql/blob/main/CODEOWNERS#L2
docs/codeql/support/reusables/versions-compilers.rsthttps://github.com/github/codeql/pull/10184/files#diff-06c3e6a6db5dfe666a9dd385535d43a5b860677ea8741fd928ef01515f1d6b42
View file https://github.com/erik-krogh/ql/blob/56292cad2672b2eb4108edd189ca8668adf99bfc/docs/codeql/support/reusables/versions-compilers.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/10184/{{ revealButtonHref }}
https://github.com/github/codeql/pull/10184/files#diff-06c3e6a6db5dfe666a9dd385535d43a5b860677ea8741fd928ef01515f1d6b42
https://github.com/github/codeql/pull/10184/files#diff-06c3e6a6db5dfe666a9dd385535d43a5b860677ea8741fd928ef01515f1d6b42
https://github.com/github/codeql/blob/main/CODEOWNERS#L17
javascript/extractor/lib/typescript/package.jsonhttps://github.com/github/codeql/pull/10184/files#diff-683e5feb284d00ab4fce2a4cbfb0f53fb410acc6ae2ddf04db60daa79ad4399e
View file https://github.com/erik-krogh/ql/blob/56292cad2672b2eb4108edd189ca8668adf99bfc/javascript/extractor/lib/typescript/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/10184/{{ revealButtonHref }}
https://github.com/github/codeql/pull/10184/files#diff-683e5feb284d00ab4fce2a4cbfb0f53fb410acc6ae2ddf04db60daa79ad4399e
https://github.com/github/codeql/pull/10184/files#diff-683e5feb284d00ab4fce2a4cbfb0f53fb410acc6ae2ddf04db60daa79ad4399e
https://github.com/github/codeql/blob/main/CODEOWNERS#L17
javascript/extractor/lib/typescript/src/main.tshttps://github.com/github/codeql/pull/10184/files#diff-ae9cb8c7ab2b8622a84b032f9529817adc5c06f123ad107e03e0cef73c9a52bb
View file https://github.com/erik-krogh/ql/blob/56292cad2672b2eb4108edd189ca8668adf99bfc/javascript/extractor/lib/typescript/src/main.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/10184/{{ revealButtonHref }}
https://github.com/github/codeql/pull/10184/files#diff-ae9cb8c7ab2b8622a84b032f9529817adc5c06f123ad107e03e0cef73c9a52bb
https://github.com/github/codeql/pull/10184/files#diff-ae9cb8c7ab2b8622a84b032f9529817adc5c06f123ad107e03e0cef73c9a52bb
https://github.com/github/codeql/blob/main/CODEOWNERS#L17
javascript/extractor/lib/typescript/src/type_table.tshttps://github.com/github/codeql/pull/10184/files#diff-e85f5fd29f76a5ef27e0f467c31f6955e7c14ef75be5990b3e888dc137ce9ef6
View file https://github.com/erik-krogh/ql/blob/56292cad2672b2eb4108edd189ca8668adf99bfc/javascript/extractor/lib/typescript/src/type_table.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/10184/{{ revealButtonHref }}
https://github.com/github/codeql/pull/10184/files#diff-e85f5fd29f76a5ef27e0f467c31f6955e7c14ef75be5990b3e888dc137ce9ef6
https://github.com/github/codeql/pull/10184/files#diff-e85f5fd29f76a5ef27e0f467c31f6955e7c14ef75be5990b3e888dc137ce9ef6
https://github.com/github/codeql/blob/main/CODEOWNERS#L17
javascript/extractor/lib/typescript/yarn.lockhttps://github.com/github/codeql/pull/10184/files#diff-194c0548f88d51225d2a67f57efee7109c1291907a3f7c8d72ea5564a160bf23
View file https://github.com/erik-krogh/ql/blob/56292cad2672b2eb4108edd189ca8668adf99bfc/javascript/extractor/lib/typescript/yarn.lock
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/10184/{{ revealButtonHref }}
https://github.com/github/codeql/pull/10184/files#diff-194c0548f88d51225d2a67f57efee7109c1291907a3f7c8d72ea5564a160bf23
https://github.com/github/codeql/blob/main/CODEOWNERS#L17
javascript/extractor/src/com/semmle/js/extractor/Main.javahttps://github.com/github/codeql/pull/10184/files#diff-7d2f65585212078eaf8063085cea23a530dd479378804beb85874d20877aa97b
View file https://github.com/erik-krogh/ql/blob/56292cad2672b2eb4108edd189ca8668adf99bfc/javascript/extractor/src/com/semmle/js/extractor/Main.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/10184/{{ revealButtonHref }}
https://github.com/github/codeql/pull/10184/files#diff-7d2f65585212078eaf8063085cea23a530dd479378804beb85874d20877aa97b
https://github.com/github/codeql/pull/10184/files#diff-7d2f65585212078eaf8063085cea23a530dd479378804beb85874d20877aa97b
https://github.com/github/codeql/blob/main/CODEOWNERS#L17
javascript/extractor/src/com/semmle/ts/extractor/TypeScriptASTConverter.javahttps://github.com/github/codeql/pull/10184/files#diff-cc44112c6e8d612ffee22a5f3601bb288df186b8cd4c39cbf5b0b58cc8181af4
View file https://github.com/erik-krogh/ql/blob/56292cad2672b2eb4108edd189ca8668adf99bfc/javascript/extractor/src/com/semmle/ts/extractor/TypeScriptASTConverter.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/10184/{{ revealButtonHref }}
https://github.com/github/codeql/pull/10184/files#diff-cc44112c6e8d612ffee22a5f3601bb288df186b8cd4c39cbf5b0b58cc8181af4
https://github.com/github/codeql/pull/10184/files#diff-cc44112c6e8d612ffee22a5f3601bb288df186b8cd4c39cbf5b0b58cc8181af4
https://github.com/github/codeql/pull/10184/files#diff-cc44112c6e8d612ffee22a5f3601bb288df186b8cd4c39cbf5b0b58cc8181af4
https://github.com/github/codeql/pull/10184/files#diff-cc44112c6e8d612ffee22a5f3601bb288df186b8cd4c39cbf5b0b58cc8181af4
https://github.com/github/codeql/pull/10184/files#diff-cc44112c6e8d612ffee22a5f3601bb288df186b8cd4c39cbf5b0b58cc8181af4
https://github.com/github/codeql/pull/10184/files#diff-cc44112c6e8d612ffee22a5f3601bb288df186b8cd4c39cbf5b0b58cc8181af4
https://github.com/github/codeql/pull/10184/files#diff-cc44112c6e8d612ffee22a5f3601bb288df186b8cd4c39cbf5b0b58cc8181af4
https://github.com/github/codeql/pull/10184/files#diff-cc44112c6e8d612ffee22a5f3601bb288df186b8cd4c39cbf5b0b58cc8181af4
https://github.com/github/codeql/pull/10184/files#diff-cc44112c6e8d612ffee22a5f3601bb288df186b8cd4c39cbf5b0b58cc8181af4
https://github.com/github/codeql/pull/10184/files#diff-cc44112c6e8d612ffee22a5f3601bb288df186b8cd4c39cbf5b0b58cc8181af4
https://github.com/github/codeql/pull/10184/files#diff-cc44112c6e8d612ffee22a5f3601bb288df186b8cd4c39cbf5b0b58cc8181af4
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
javascript/ql/lib/change-notes/2022-05-24-typescript-4-8.mdhttps://github.com/github/codeql/pull/10184/files#diff-b859ab031bf8b50870187248d23560215cfb06ba3291a0d37a0263b69dfe2383
View file https://github.com/erik-krogh/ql/blob/56292cad2672b2eb4108edd189ca8668adf99bfc/javascript/ql/lib/change-notes/2022-05-24-typescript-4-8.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/10184/{{ revealButtonHref }}
Please reload this pagehttps://github.com/github/codeql/pull/10184/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.