| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b96324e7-6c0d-d99d-1fb1-6f3713ba7102 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E9F2:27D3AD:3E93A0:50EB52:6B00D3CE |
| html-safe-nonce | a157670210b11c732bfdf5cad0e2da986201851cefae0edab9fabf44776315bc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOUYyOjI3RDNBRDozRTkzQTA6NTBFQjUyOjZCMDBEM0NFIiwidmlzaXRvcl9pZCI6IjI1NDQxOTMyOTkxMzcyMjE1ODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c1f04365dd878fa53d41f6af302f54a23bfe6da53e5a364f1ba168ab6508284f |
| hovercard-subject-tag | pull_request:1037567644 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/github/codeql/10184/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a30ea92afa518e62d52d3ab11cbc2ab8dfc123d3dec08730d938ce5877e49bd2/github/codeql/pull/10184 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a30ea92afa518e62d52d3ab11cbc2ab8dfc123d3dec08730d938ce5877e49bd2/github/codeql/pull/10184 |
| og:image:alt | https://devblogs.microsoft.com/typescript/announcing-typescript-4-8
The most tricky part was a change to the syntax tree representation.
The modifiers property that we rely on in TypeScriptASTConve... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | erik-krogh |
| hostname | github.com |
| expected-hostname | github.com |
| None | 85bbdfe2b6ba16e234513bc6ceff5d848ef8449820c900692a2b4e67061931e5 |
| turbo-cache-control | no-cache |
| go-import | github.com/github/codeql git https://github.com/github/codeql.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 143040428 |
| octolytics-dimension-repository_nwo | github/codeql |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 143040428 |
| octolytics-dimension-repository_network_root_nwo | github/codeql |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4943239a6d2c591325dad6e5c313e1cafda877f6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/github/codeql/pull/10184#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F10184 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F10184 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=github%2Fcodeql |
| Reload | https://github.com/github/codeql/pull/10184 |
| Reload | https://github.com/github/codeql/pull/10184 |
| Reload | https://github.com/github/codeql/pull/10184 |
| github | https://github.com/github |
| codeql | https://github.com/github/codeql |
| Code | https://github.com/github/codeql |
| Issues1k (1k) | https://github.com/github/codeql/issues |
| Pull requests507 (507) | https://github.com/github/codeql/pulls |
| Discussions | https://github.com/github/codeql/discussions |
| Actions | https://github.com/github/codeql/actions |
| Projects | https://github.com/github/codeql/projects |
| Security and quality | https://github.com/github/codeql/security |
| Insights | https://github.com/github/codeql/insights |
| https://github.com/github/codeql |
| erik-krogh | https://github.com/erik-krogh |
| github:main | https://github.com/github/codeql/tree/main |
| erik-krogh:ts48 | https://github.com/erik-krogh/ql/tree/ts48 |
| Conversation | https://github.com/github/codeql/pull/10184 |
| Commits6 (6) | https://github.com/github/codeql/pull/10184/commits |
| Checks | https://github.com/github/codeql/pull/10184/checks |
| Findings | https://github.com/github/codeql/pull/10184/findings |
| Files changed | https://github.com/github/codeql/pull/10184/files |
| JavaScript: Update to TypeScript 4.8 | https://github.com/github/codeql/pull/10184#top |
| erik-krogh | https://github.com/erik-krogh |
| github:main | https://github.com/github/codeql/tree/main |
| erik-krogh:ts48 | https://github.com/erik-krogh/ql/tree/ts48 |
|
| https://github.com/erik-krogh |
| erik-krogh | https://github.com/erik-krogh |
| Aug 26, 2022 | https://github.com/github/codeql/pull/10184#issue-1351814631 |
| Please reload this page | https://github.com/github/codeql/pull/10184 |
| https://devblogs.microsoft.com/typescript/announcing-typescript-4-8 | https://devblogs.microsoft.com/typescript/announcing-typescript-4-8 |
| a change to the syntax tree representation | https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/#decorators-are-placed-on-modifiers-on-typescripts-syntax-trees |
| this PR | https://github.com/microsoft/TypeScript/pull/50343 |
| here | https://github.com/github/codeql-dca-main/tree/data/erik-krogh/ts48__typescript-full__code-scanning__1/reports |
| Please reload this page | https://github.com/github/codeql/pull/10184 |
| https://github.com/erik-krogh |
| erik-krogh | https://github.com/erik-krogh |
| Aug 26, 2022 | https://github.com/github/codeql/pull/10184#event-7264973218 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
documentation
| https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Adocumentation |
|
JS
| https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AJS |
| Aug 26, 2022 | https://github.com/github/codeql/pull/10184#event-7264973363 |
| erik-krogh | https://github.com/erik-krogh |
| August 29, 2022 12:14 | https://github.com/github/codeql/pull/10184#commits-pushed-b7367ca |
|
| https://github.com/erik-krogh |
| update to TypeScript 4.8RC | https://github.com/github/codeql/pull/10184/commits/b7367ca649d90548a366c8652b9cab12e8589af1 |
| b7367ca | https://github.com/github/codeql/pull/10184/commits/b7367ca649d90548a366c8652b9cab12e8589af1 |
|
| https://github.com/erik-krogh |
| add change-note | https://github.com/github/codeql/pull/10184/commits/97ffd2d4d9d5f5ce8ab8598f5e15a493d1e36327 |
| 97ffd2d | https://github.com/github/codeql/pull/10184/commits/97ffd2d4d9d5f5ce8ab8598f5e15a493d1e36327 |
|
| https://github.com/erik-krogh |
| bump extractor version | https://github.com/github/codeql/pull/10184/commits/e0ff27331fadfe9c4d12630cfaaf39b8ad18616b |
| e0ff273 | https://github.com/github/codeql/pull/10184/commits/e0ff27331fadfe9c4d12630cfaaf39b8ad18616b |
|
| https://github.com/erik-krogh |
| bump the TypeScript version in the list of supported languages | https://github.com/github/codeql/pull/10184/commits/50734c7c6a558bbd082d518f583fca45b204b918 |
| 50734c7 | https://github.com/github/codeql/pull/10184/commits/50734c7c6a558bbd082d518f583fca45b204b918 |
|
| https://github.com/erik-krogh |
| fix support for illegal decorators in the TypeScript extractor | https://github.com/github/codeql/pull/10184/commits/6aca9b9f49496a4d072025dbc26eaabd6488e446 |
| 6aca9b9 | https://github.com/github/codeql/pull/10184/commits/6aca9b9f49496a4d072025dbc26eaabd6488e446 |
| https://github.com/erik-krogh |
| erik-krogh | https://github.com/erik-krogh |
| force-pushed | https://github.com/github/codeql/compare/cabeeddb752323b67dbfbebe532c0910f390b94c..6aca9b9f49496a4d072025dbc26eaabd6488e446 |
| cabeedd | https://github.com/github/codeql/commit/cabeeddb752323b67dbfbebe532c0910f390b94c |
| 6aca9b9 | https://github.com/github/codeql/commit/6aca9b9f49496a4d072025dbc26eaabd6488e446 |
|
Compare
| https://github.com/github/codeql/compare/cabeeddb752323b67dbfbebe532c0910f390b94c..6aca9b9f49496a4d072025dbc26eaabd6488e446 |
| August 29, 2022 10:20 | https://github.com/github/codeql/pull/10184#event-7277260804 |
| https://github.com/erik-krogh |
| erik-krogh | https://github.com/erik-krogh |
| August 29, 2022 10:26 | https://github.com/github/codeql/pull/10184#event-7277305109 |
| https://github.com/erik-krogh |
| erik-krogh | https://github.com/erik-krogh |
| code owner | https://github.com/github/codeql/blob/68bf9f39b9434f490017f48d902bc54140e7d67a/CODEOWNERS#L5 |
| August 29, 2022 10:26 | https://github.com/github/codeql/pull/10184#event-7277305163 |
| https://github.com/asgerf |
| asgerf | https://github.com/asgerf |
|
Aug 29, 2022
| https://github.com/github/codeql/pull/10184#pullrequestreview-1088439195 |
|
View reviewed changes
| https://github.com/github/codeql/pull/10184/files/6aca9b9f49496a4d072025dbc26eaabd6488e446 |
| javascript/extractor/lib/typescript/src/ast_extractor.ts | https://github.com/github/codeql/pull/10184/files/50734c7c6a558bbd082d518f583fca45b204b918..6aca9b9f49496a4d072025dbc26eaabd6488e446#diff-fb9abbf10d9e177b0cc800c0819871f2cd997c3b504914cbf2185274efc8253a |
| Please reload this page | https://github.com/github/codeql/pull/10184 |
|
| https://github.com/erik-krogh |
| don't modify the TypeScript nodes, instead forward illegalDecorators … | https://github.com/github/codeql/pull/10184/commits/56292cad2672b2eb4108edd189ca8668adf99bfc |
| 56292ca | https://github.com/github/codeql/pull/10184/commits/56292cad2672b2eb4108edd189ca8668adf99bfc |
| https://github.com/asgerf |
| asgerf | https://github.com/asgerf |
|
Aug 29, 2022
| https://github.com/github/codeql/pull/10184#pullrequestreview-1088581176 |
|
View reviewed changes
| https://github.com/github/codeql/pull/10184/files/56292cad2672b2eb4108edd189ca8668adf99bfc |
| asgerf | https://github.com/asgerf |
| https://github.com/github/codeql/pull/10184#pullrequestreview-1088581176 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/github/codeql/pull/10184 |
| https://github.com/erik-krogh |
| erik-krogh | https://github.com/erik-krogh |
| 27bc698 | https://github.com/github/codeql/commit/27bc69883c05daf01d33f3bfaa1cef53f5a08a5d |
| Aug 29, 2022 | https://github.com/github/codeql/pull/10184#event-7278436482 |
| erik-krogh | https://github.com/erik-krogh |
|
Aug 30, 2022
| https://github.com/github/codeql/pull/10184#ref-commit-9963def |
|
| https://github.com/erik-krogh |
| update expected output of test that was failing on main. semantic mer… | https://github.com/erik-krogh/ql/commit/9963def3007d4e6d7aeb6e2015c550f38b7e861f |
| 9963def | https://github.com/erik-krogh/ql/commit/9963def3007d4e6d7aeb6e2015c550f38b7e861f |
| github#10202 | https://github.com/github/codeql/pull/10202 |
| github#10184 | https://github.com/github/codeql/pull/10184 |
| https://github.co/hiddenchars |
| https://github.com/github/codeql/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F10184 |
|
| https://github.com/asgerf |
|
asgerf
| https://github.com/asgerf |
|
| https://github.com/github/codeql/pull/10184/files/56292cad2672b2eb4108edd189ca8668adf99bfc |
| Please reload this page | https://github.com/github/codeql/pull/10184 |
|
documentation
| https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Adocumentation |
|
JS
| https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AJS |
| Please reload this page | https://github.com/github/codeql/pull/10184 |
|
| https://github.com/erik-krogh |
|
| https://github.com/asgerf |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |