| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fd58aed0-4725-a337-588a-36ad9011bd32 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9FC2:12F7EE:516402:6DC870:6A628FA6 |
| html-safe-nonce | e089e5d9aaacd7f4ec68df5cce4392c149a76e138d51ae1dc537bc45f9f4f023 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkMyOjEyRjdFRTo1MTY0MDI6NkRDODcwOjZBNjI4RkE2IiwidmlzaXRvcl9pZCI6IjI5NzY2NjY4NDkwODQ4NzA1NjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 899ab02278d0e3944b0236ce499aec31e507b133b8969560b7a67a742f41bb4a |
| hovercard-subject-tag | pull_request:899245039 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/github/catalyst/197/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9c0ea1dd8484e03a2f2aa5e8c628d2be5710fde28ebdb190669bde43cb1f1438/github/catalyst/pull/197 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9c0ea1dd8484e03a2f2aa5e8c628d2be5710fde28ebdb190669bde43cb1f1438/github/catalyst/pull/197 |
| og:image:alt | I want to allow CustomElements to be redefined when using an HMR plugin. Most plugins override the define method on customElements to not raise an error on redefinition.
Running the .define call in... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | manuelpuyol |
| hostname | github.com |
| expected-hostname | github.com |
| None | ac2209d8cb6970a1bd08cb0a3f821d7166ac544c2ca1c87819c335bb84310ecd |
| turbo-cache-control | no-cache |
| go-import | github.com/github/catalyst git https://github.com/github/catalyst.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 240087376 |
| octolytics-dimension-repository_nwo | github/catalyst |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 240087376 |
| octolytics-dimension-repository_network_root_nwo | github/catalyst |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2fca8cd598678aaa64706088ad13b4e19177e108 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/github/catalyst/pull/197#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcatalyst%2Fpull%2F197 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcatalyst%2Fpull%2F197 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=github%2Fcatalyst |
| Reload | https://github.com/github/catalyst/pull/197 |
| Reload | https://github.com/github/catalyst/pull/197 |
| Reload | https://github.com/github/catalyst/pull/197 |
| Please reload this page | https://github.com/github/catalyst/pull/197 |
|
github
| https://github.com/github |
| catalyst | https://github.com/github/catalyst |
|
Notifications
| https://github.com/login?return_to=%2Fgithub%2Fcatalyst |
|
Fork
57
| https://github.com/login?return_to=%2Fgithub%2Fcatalyst |
|
Star
1.4k
| https://github.com/login?return_to=%2Fgithub%2Fcatalyst |
|
Code
| https://github.com/github/catalyst |
|
Issues
18
| https://github.com/github/catalyst/issues |
|
Pull requests
4
| https://github.com/github/catalyst/pulls |
|
Discussions
| https://github.com/github/catalyst/discussions |
|
Actions
| https://github.com/github/catalyst/actions |
|
Models
| https://github.com/github/catalyst/models |
|
Security and quality
0
| https://github.com/github/catalyst/security |
|
Insights
| https://github.com/github/catalyst/pulse |
|
Code
| https://github.com/github/catalyst |
|
Issues
| https://github.com/github/catalyst/issues |
|
Pull requests
| https://github.com/github/catalyst/pulls |
|
Discussions
| https://github.com/github/catalyst/discussions |
|
Actions
| https://github.com/github/catalyst/actions |
|
Models
| https://github.com/github/catalyst/models |
|
Security and quality
| https://github.com/github/catalyst/security |
|
Insights
| https://github.com/github/catalyst/pulse |
| manuelpuyol | https://github.com/manuelpuyol |
| main | https://github.com/github/catalyst/tree/main |
| allow-hmr-plugins | https://github.com/github/catalyst/tree/allow-hmr-plugins |
| Conversation | https://github.com/github/catalyst/pull/197 |
| Findings | https://github.com/github/catalyst/pull/197/findings |
| Commits8 (8) | https://github.com/github/catalyst/pull/197/commits |
| Checks | https://github.com/github/catalyst/pull/197/checks |
| Files changed | https://github.com/github/catalyst/pull/197/files |
| Allow CustomElements to be redefined | https://github.com/github/catalyst/pull/197#top |
| manuelpuyol | https://github.com/manuelpuyol |
| main | https://github.com/github/catalyst/tree/main |
| allow-hmr-plugins | https://github.com/github/catalyst/tree/allow-hmr-plugins |
|
| https://github.com/manuelpuyol |
| manuelpuyol | https://github.com/manuelpuyol |
| Apr 4, 2022 | https://github.com/github/catalyst/pull/197#issue-1192039219 |
| Please reload this page | https://github.com/github/catalyst/pull/197 |
| manuelpuyol | https://github.com/manuelpuyol |
| April 4, 2022 16:27 | https://github.com/github/catalyst/pull/197#commits-pushed-6e4b571 |
|
| https://github.com/manuelpuyol |
| Use try/catch instead of checking if element is registered | https://github.com/github/catalyst/pull/197/commits/6e4b571a8fe5916261e2c7e4973a3a3c030524c7 |
| 6e4b571 | https://github.com/github/catalyst/pull/197/commits/6e4b571a8fe5916261e2c7e4973a3a3c030524c7 |
|
| https://github.com/manuelpuyol |
| Make sure window is in sync with CustomElements registration | https://github.com/github/catalyst/pull/197/commits/113eddaff42e248ca4328d9ddd5f89d1655a4398 |
| 113edda | https://github.com/github/catalyst/pull/197/commits/113eddaff42e248ca4328d9ddd5f89d1655a4398 |
| https://github.com/manuelpuyol |
| manuelpuyol | https://github.com/manuelpuyol |
| code owner | https://github.com/github/catalyst/blob/a8fb3ba59a4ac258d0fe64a50ecd3b6997f5f016/CODEOWNERS#L1 |
| April 4, 2022 16:33 | https://github.com/github/catalyst/pull/197#event-6364591582 |
| https://github.com/manuelpuyol |
| manuelpuyol | https://github.com/manuelpuyol |
| keithamus | https://github.com/keithamus |
| April 4, 2022 16:33 | https://github.com/github/catalyst/pull/197#event-6364591610 |
| https://github.com/koddsson |
| koddsson | https://github.com/koddsson |
|
Apr 4, 2022
| https://github.com/github/catalyst/pull/197#pullrequestreview-930930366 |
|
View reviewed changes
| https://github.com/github/catalyst/pull/197/files/113eddaff42e248ca4328d9ddd5f89d1655a4398 |
| koddsson | https://github.com/koddsson |
| https://github.com/github/catalyst/pull/197#pullrequestreview-930930366 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/github/catalyst/pull/197 |
| manuelpuyol | https://github.com/manuelpuyol |
| April 25, 2022 16:26 | https://github.com/github/catalyst/pull/197#commits-pushed-4979d09 |
|
| https://github.com/manuelpuyol |
| rethrow errors unless its specifically about redefining | https://github.com/github/catalyst/pull/197/commits/4979d0989a7953e78bede72b6c3ce7f293427a90 |
| 4979d09 | https://github.com/github/catalyst/pull/197/commits/4979d0989a7953e78bede72b6c3ce7f293427a90 |
|
| https://github.com/manuelpuyol |
| change any to unknown | https://github.com/github/catalyst/pull/197/commits/bc02a16aec553b8c17cef8358998a0c79dd8ba97 |
| bc02a16 | https://github.com/github/catalyst/pull/197/commits/bc02a16aec553b8c17cef8358998a0c79dd8ba97 |
| https://github.com/keithamus |
| keithamus | https://github.com/keithamus |
|
Apr 25, 2022
| https://github.com/github/catalyst/pull/197#pullrequestreview-952150157 |
|
View reviewed changes
| https://github.com/github/catalyst/pull/197/files/bc02a16aec553b8c17cef8358998a0c79dd8ba97 |
| keithamus | https://github.com/keithamus |
| https://github.com/github/catalyst/pull/197#pullrequestreview-952150157 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/github/catalyst/pull/197 |
| https://github.com/koddsson |
| koddsson | https://github.com/koddsson |
|
Apr 26, 2022
| https://github.com/github/catalyst/pull/197#pullrequestreview-953464489 |
|
View reviewed changes
| https://github.com/github/catalyst/pull/197/files/bc02a16aec553b8c17cef8358998a0c79dd8ba97 |
|
| https://github.com/manuelpuyol |
| Merge branch 'main' into allow-hmr-plugins | https://github.com/github/catalyst/pull/197/commits/93d40359be54b7d85a8b3bdaf52eb18ebf636b34 |
| 93d4035 | https://github.com/github/catalyst/pull/197/commits/93d40359be54b7d85a8b3bdaf52eb18ebf636b34 |
| https://github.com/manuelpuyol |
| manuelpuyol | https://github.com/manuelpuyol |
| April 27, 2022 14:48 | https://github.com/github/catalyst/pull/197#event-6507697765 |
|
| https://github.com/keithamus |
| Merge branch 'main' into allow-hmr-plugins | https://github.com/github/catalyst/pull/197/commits/ea5d2b65f6b1db0d15ea85e5591e18002702a023 |
| ea5d2b6 | https://github.com/github/catalyst/pull/197/commits/ea5d2b65f6b1db0d15ea85e5591e18002702a023 |
| https://github.com/keithamus |
| keithamus | https://github.com/keithamus |
| code owner | https://github.com/github/catalyst/blob/ec2419827eb0eeda1075982e64ba1ab178cf65c8/CODEOWNERS#L1 |
| April 30, 2022 07:20 | https://github.com/github/catalyst/pull/197#event-6527716026 |
| keithamus | https://github.com/keithamus |
| April 30, 2022 08:24 | https://github.com/github/catalyst/pull/197#commits-pushed-1b48919 |
|
| https://github.com/keithamus |
| Bump size-limit to 1.6.3kb | https://github.com/github/catalyst/pull/197/commits/1b489195f933553103070b06a8d3077c5585a589 |
| 1b48919 | https://github.com/github/catalyst/pull/197/commits/1b489195f933553103070b06a8d3077c5585a589 |
|
| https://github.com/keithamus |
| Update size to 1.64kb | https://github.com/github/catalyst/pull/197/commits/8b986327e062e20c1cbc2b0f8ca863640ac5dc00 |
| 8b98632 | https://github.com/github/catalyst/pull/197/commits/8b986327e062e20c1cbc2b0f8ca863640ac5dc00 |
| https://github.com/keithamus |
| keithamus | https://github.com/keithamus |
|
Apr 30, 2022
| https://github.com/github/catalyst/pull/197#pullrequestreview-958466385 |
|
View reviewed changes
| https://github.com/github/catalyst/pull/197/files/8b986327e062e20c1cbc2b0f8ca863640ac5dc00 |
| https://github.com/manuelpuyol |
| manuelpuyol | https://github.com/manuelpuyol |
| 0775b42 | https://github.com/github/catalyst/commit/0775b4271d06f8a96d69a002f9a29109a6b57d51 |
| Apr 30, 2022 | https://github.com/github/catalyst/pull/197#event-6527737156 |
| https://github.com/manuelpuyol |
| manuelpuyol | https://github.com/manuelpuyol |
| April 30, 2022 07:36 | https://github.com/github/catalyst/pull/197#event-6527737198 |
| https://github.com/keithamus |
| keithamus | https://github.com/keithamus |
|
Apr 30, 2022
| https://github.com/github/catalyst/pull/197#ref-pullrequest-1221775971 |
|
clean up register tests, use register like decorator
#214
| https://github.com/github/catalyst/pull/214 |
| keithamus | https://github.com/keithamus |
|
Nov 22, 2022
| https://github.com/github/catalyst/pull/197#ref-commit-a885458 |
|
| https://github.com/keithamus |
| move customElements define calls to index.js and refactor | https://github.com/github/relative-time-element/commit/a88545812e08ca617dd3f33174c91b824e0481f1 |
| a885458 | https://github.com/github/relative-time-element/commit/a88545812e08ca617dd3f33174c91b824e0481f1 |
| github/catalyst#197 | https://github.com/github/catalyst/pull/197 |
| https://github.com/keithamus |
| keithamus | https://github.com/keithamus |
|
Nov 22, 2022
| https://github.com/github/catalyst/pull/197#ref-pullrequest-1460317487 |
|
move customElements define calls to index.js and refactor
github/relative-time-element#209
| https://github.com/github/relative-time-element/pull/209 |
| https://github.com/keithamus |
| keithamus | https://github.com/keithamus |
|
Nov 30, 2022
| https://github.com/github/catalyst/pull/197#ref-pullrequest-1469928005 |
|
allow defining custom elements in a try/catch
github/eslint-plugin-custom-elements#51
| https://github.com/github/eslint-plugin-custom-elements/pull/51 |
| https://github.co/hiddenchars |
| https://github.com/github/catalyst/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcatalyst%2Fpull%2F197 |
|
| https://github.com/keithamus |
|
keithamus
| https://github.com/keithamus |
|
| https://github.com/github/catalyst/pull/197/files/8b986327e062e20c1cbc2b0f8ca863640ac5dc00 |
|
| https://github.com/koddsson |
|
koddsson
| https://github.com/koddsson |
|
| https://github.com/github/catalyst/pull/197/files/bc02a16aec553b8c17cef8358998a0c79dd8ba97 |
| Please reload this page | https://github.com/github/catalyst/pull/197 |
|
| https://github.com/manuelpuyol |
|
| https://github.com/keithamus |
|
| https://github.com/koddsson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |