Title: ref(compat): Remove unused with_metaclass helper by sentry-junior[bot] · Pull Request #8153 · getsentry/sentry-python · GitHub
Open Graph Title: ref(compat): Remove unused with_metaclass helper by sentry-junior[bot] · Pull Request #8153 · getsentry/sentry-python
X Title: ref(compat): Remove unused with_metaclass helper by sentry-junior[bot] · Pull Request #8153 · getsentry/sentry-python
Description: Description Removes with_metaclass() from sentry_sdk/_compat.py. Nothing on major/3.0 uses it anymore. It's a Python 2 / six-style helper for declaring a metaclass across Python versions; on Python 3 you just write class Foo(metaclass=Meta). Its only caller was class Hub(with_metaclass(HubMeta)) in sentry_sdk/hub.py. #6919 ("Drop hub related code in new major") deleted Hub and the import, but left the helper behind. With the helper gone, the TYPE_CHECKING block in _compat.py (Any, TypeVar, T) is unused too, so it's removed as well. T wasn't used before this change either. Evidence On major/3.0, git grep with_metaclass matches only the definition. There are no callers in sentry_sdk, tests, scripts or docs. Nothing imports T or Any from sentry_sdk._compat. #6091 and #7421 (against master) proposed the same removal as part of larger Python 2 cleanups. Both were closed without being merged, one for inactivity. Neither raised an objection to this change. On master, Hub still uses the helper, so this only applies to major/3.0. _compat is a private module, so this doesn't touch the public API. Issues n/a via Ivana Kellyer. -- View Junior Session [Sentry]
Open Graph Description: Description Removes with_metaclass() from sentry_sdk/_compat.py. Nothing on major/3.0 uses it anymore. It's a Python 2 / six-style helper for declaring a metaclass across Python versions; on Py...
X Description: Description Removes with_metaclass() from sentry_sdk/_compat.py. Nothing on major/3.0 uses it anymore. It's a Python 2 / six-style helper for declaring a metaclass across Python versions; o...
Opengraph URL: https://github.com/getsentry/sentry-python/pull/8153
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d48b2107-bc97-4913-e7e0-b35305448bbb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A36A:215B92:736CB9:9B504D:6B00DBA5 |
| html-safe-nonce | f6cb99dfc8625067b6f1a2e27448ce196d23e947481427254a3e041f11bdea75 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzZBOjIxNUI5Mjo3MzZDQjk6OUI1MDREOjZCMDBEQkE1IiwidmlzaXRvcl9pZCI6Ijg2MjcyMzg4MTU3MTI0Njc4NzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 86f3dcafb6c3661c74181df455e649a736aa22667a577ce7a7ff9fc8ca310552 |
| hovercard-subject-tag | pull_request:5067319198 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/getsentry/sentry-python/pull/8153/files |
| twitter:image | https://avatars.githubusercontent.com/in/2960336?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/in/2960336?s=400&v=4 |
| og:image:alt | Description Removes with_metaclass() from sentry_sdk/_compat.py. Nothing on major/3.0 uses it anymore. It's a Python 2 / six-style helper for declaring a metaclass across Python versions; on Py... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git |
| octolytics-dimension-user_id | 1396951 |
| octolytics-dimension-user_login | getsentry |
| octolytics-dimension-repository_id | 137814779 |
| octolytics-dimension-repository_nwo | getsentry/sentry-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 137814779 |
| octolytics-dimension-repository_network_root_nwo | getsentry/sentry-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5425dc24e8bd8d6fca9641a12afc984825a43875 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width