René's URL Explorer Experiment


Title: fix(batcher): Serialize flushed items outside the batcher lock by NicoHinderling · Pull Request #7776 · getsentry/sentry-python · GitHub

Open Graph Title: fix(batcher): Serialize flushed items outside the batcher lock by NicoHinderling · Pull Request #7776 · getsentry/sentry-python

X Title: fix(batcher): Serialize flushed items outside the batcher lock by NicoHinderling · Pull Request #7776 · getsentry/sentry-python

Description: Batcher._flush held _lock while serializing the buffered items. Serializing can trigger GC, and if a collected object's finalizer logs, the flush thread needs the logging handler lock, which another thread already holds while it waits for _lock in add(). That lock-order inversion freezes every later log call in the process; it's what was hard-killing Seer's Celery tasks (#7775). _flush now swaps the buffer out under the lock (the replacement list is allocated before taking it) and builds the envelope after releasing it. Applies to LogBatcher and MetricsBatcher. New regression test asserts the lock isn't held while items are serialized; the repro in #7775 goes from deadlocking in ~5s to none in 5 runs of 30–40s. Behavior change: a batch whose serialization raises is now dropped instead of being retried on every flush. Not covered here: SpanBatcher._flush serializes under its own lock the same way, and add() calls _record_lost under the lock once the buffer is full. Happy to follow up on both. Fixes #7775

Open Graph Description: Batcher._flush held _lock while serializing the buffered items. Serializing can trigger GC, and if a collected object's finalizer logs, the flush thread needs the logging handler lock, which an...

X Description: Batcher._flush held _lock while serializing the buffered items. Serializing can trigger GC, and if a collected object's finalizer logs, the flush thread needs the logging handler lock, whic...

Opengraph URL: https://github.com/getsentry/sentry-python/pull/7776

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:187ea266-5132-faca-a7a9-37deaa63bcaf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB8A2:D5AA4:D4DB2F:11D6998:6B00F6B8
html-safe-nonce44aa8aa48bd6b8a3a3dc7874d192d1ceb536d6a540d361b08861611680990c96
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEEyOkQ1QUE0OkQ0REIyRjoxMUQ2OTk4OjZCMDBGNkI4IiwidmlzaXRvcl9pZCI6IjM0MzcxNTgxMDcxMDc2MjA1MzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac68da7e4b391b3188bcf7ede268212e87326cee3c58103361f3fb6fd44c010dc0
hovercard-subject-tagpull_request:4683245847
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/getsentry/sentry-python/pull/7776/files
twitter:imagehttps://avatars.githubusercontent.com/u/9902528?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9902528?s=400&v=4
og:image:altBatcher._flush held _lock while serializing the buffered items. Serializing can trigger GC, and if a collected object's finalizer logs, the flush thread needs the logging handler lock, which an...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/7776/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F7776%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F7776%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/7776/files
Reloadhttps://github.com/getsentry/sentry-python/pull/7776/files
Reloadhttps://github.com/getsentry/sentry-python/pull/7776/files
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
NicoHinderlinghttps://github.com/NicoHinderling
masterhttps://github.com/getsentry/sentry-python/tree/master
nico/batcher-serialize-outside-lockhttps://github.com/getsentry/sentry-python/tree/nico/batcher-serialize-outside-lock
Conversation 4 https://github.com/getsentry/sentry-python/pull/7776
Commits 1 https://github.com/getsentry/sentry-python/pull/7776/commits
Checks 166 https://github.com/getsentry/sentry-python/pull/7776/checks
Files changed https://github.com/getsentry/sentry-python/pull/7776/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/7776/files
fix(batcher): Serialize flushed items outside the batcher lock https://github.com/getsentry/sentry-python/pull/7776/files#top
Show all changes 1 commit https://github.com/getsentry/sentry-python/pull/7776/files
1f3b6f0 fix(batcher): Serialize flushed items outside the batcher lock NicoHinderling Sep 29, 2026 https://github.com/getsentry/sentry-python/pull/7776/commits/1f3b6f0f03beadff930a68b7f2098c3f6c9fb166
Clear filters https://github.com/getsentry/sentry-python/pull/7776/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/7776/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/7776/files
_batcher.py https://github.com/getsentry/sentry-python/pull/7776/files#diff-7dbecac92865baa900639d0a3286da7b5efc6403923ebc49ab7ed8815fc1fe03
test_logs.py https://github.com/getsentry/sentry-python/pull/7776/files#diff-468e98ba4b95217b47e2ca8259cbf73fba8256acd034d22ae6ba68c74be5aaca
https://github.com/getsentry/sentry-python/blob/master/.github/CODEOWNERS#L1
sentry_sdk/_batcher.pyhttps://github.com/getsentry/sentry-python/pull/7776/files#diff-7dbecac92865baa900639d0a3286da7b5efc6403923ebc49ab7ed8815fc1fe03
View file https://github.com/getsentry/sentry-python/blob/1f3b6f0f03beadff930a68b7f2098c3f6c9fb166/sentry_sdk/_batcher.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/7776/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/7776/files#diff-7dbecac92865baa900639d0a3286da7b5efc6403923ebc49ab7ed8815fc1fe03
https://github.com/getsentry/sentry-python/pull/7776/files#diff-7dbecac92865baa900639d0a3286da7b5efc6403923ebc49ab7ed8815fc1fe03
https://github.com/getsentry/sentry-python/blob/master/.github/CODEOWNERS#L1
tests/test_logs.pyhttps://github.com/getsentry/sentry-python/pull/7776/files#diff-468e98ba4b95217b47e2ca8259cbf73fba8256acd034d22ae6ba68c74be5aaca
View file https://github.com/getsentry/sentry-python/blob/1f3b6f0f03beadff930a68b7f2098c3f6c9fb166/tests/test_logs.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/7776/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/7776/files#diff-468e98ba4b95217b47e2ca8259cbf73fba8256acd034d22ae6ba68c74be5aaca
https://github.com/getsentry/sentry-python/pull/7776/files#diff-468e98ba4b95217b47e2ca8259cbf73fba8256acd034d22ae6ba68c74be5aaca
https://github.com/getsentry/sentry-python/pull/7776/files#diff-468e98ba4b95217b47e2ca8259cbf73fba8256acd034d22ae6ba68c74be5aaca
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/7776/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.