René's URL Explorer Experiment


Title: fix(sessions): Only crash session if the error is unhandled, not if it is fatal by untitaker · Pull Request #754 · getsentry/sentry-python · GitHub

Open Graph Title: fix(sessions): Only crash session if the error is unhandled, not if it is fatal by untitaker · Pull Request #754 · getsentry/sentry-python

X Title: fix(sessions): Only crash session if the error is unhandled, not if it is fatal by untitaker · Pull Request #754 · getsentry/sentry-python

Description: The official Python SDK for Sentry.io. Contribute to getsentry/sentry-python development by creating an account on GitHub.

Open Graph Description: Exceptions that are fatal but handled are probably log messages. Log messages are not really crashes. If we capture crashes as log messages only, we should fix that first by writing more integratio...

X Description: Exceptions that are fatal but handled are probably log messages. Log messages are not really crashes. If we capture crashes as log messages only, we should fix that first by writing more integratio...

Opengraph URL: https://github.com/getsentry/sentry-python/pull/754

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:68d08282-12a6-ed24-c98c-67a2b1563181
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE234:31D8FB:1AA063:2513B7:6B0083BC
html-safe-nonce05f3b055e3f40066a3dc282518c8ef65a16ba8f52914cdd7c0470e583c2cd390
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjM0OjMxRDhGQjoxQUEwNjM6MjUxM0I3OjZCMDA4M0JDIiwidmlzaXRvcl9pZCI6IjIzNzg3NzUxMDMzMzc5NTYyODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccaf032babcadcd46305fc104ad3ee485c318240a4e11359dab960fc5fed31d8f
hovercard-subject-tagpull_request:443510245
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/getsentry/sentry-python/754/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8018c8d7ac209cc863d9f2fb30beaf604966b6dfec2ba30040c528b94af20296/getsentry/sentry-python/pull/754
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8018c8d7ac209cc863d9f2fb30beaf604966b6dfec2ba30040c528b94af20296/getsentry/sentry-python/pull/754
og:image:altExceptions that are fatal but handled are probably log messages. Log messages are not really crashes. If we capture crashes as log messages only, we should fix that first by writing more integratio...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameuntitaker
hostnamegithub.com
expected-hostnamegithub.com
None4d3d8e50f02c1d7bf86d5acfa1d3bfe9366abd6528a6b429eb07a168429d2b61
turbo-cache-controlno-cache
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedb758f8e02b8257935fb03edf81a3e76eb3abd11
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/754#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F754
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F754
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/754
Reloadhttps://github.com/getsentry/sentry-python/pull/754
Reloadhttps://github.com/getsentry/sentry-python/pull/754
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests41 (41)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
https://github.com/getsentry/sentry-python
untitakerhttps://github.com/untitaker
masterhttps://github.com/getsentry/sentry-python/tree/master
fix/fatal-session-crashedhttps://github.com/getsentry/sentry-python/tree/fix/fatal-session-crashed
Conversationhttps://github.com/getsentry/sentry-python/pull/754
Commits1 (1)https://github.com/getsentry/sentry-python/pull/754/commits
Checkshttps://github.com/getsentry/sentry-python/pull/754/checks
Files changedhttps://github.com/getsentry/sentry-python/pull/754/files
fix(sessions): Only crash session if the error is unhandled, not if it is fatalhttps://github.com/getsentry/sentry-python/pull/754#top
untitakerhttps://github.com/untitaker
masterhttps://github.com/getsentry/sentry-python/tree/master
fix/fatal-session-crashedhttps://github.com/getsentry/sentry-python/tree/fix/fatal-session-crashed
https://github.com/untitaker
untitakerhttps://github.com/untitaker
Jul 2, 2020https://github.com/getsentry/sentry-python/pull/754#issue-649923034
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/754
https://github.com/untitaker
fix(sessions): Only crash session if the error is unhandled, not if i…https://github.com/getsentry/sentry-python/pull/754/commits/b4201fb4f406fd4531e362d8c4b62aaf594c0ff5
b4201fbhttps://github.com/getsentry/sentry-python/pull/754/commits/b4201fb4f406fd4531e362d8c4b62aaf594c0ff5
https://github.com/untitaker
untitakerhttps://github.com/untitaker
mitsuhikohttps://github.com/mitsuhiko
July 2, 2020 13:16https://github.com/getsentry/sentry-python/pull/754#event-3507056517
https://github.com/mitsuhiko
mitsuhikohttps://github.com/mitsuhiko
Jul 2, 2020 https://github.com/getsentry/sentry-python/pull/754#pullrequestreview-441683929
View reviewed changes https://github.com/getsentry/sentry-python/pull/754/files/b4201fb4f406fd4531e362d8c4b62aaf594c0ff5
https://github.com/untitaker
untitakerhttps://github.com/untitaker
c510cedhttps://github.com/getsentry/sentry-python/commit/c510cede8f75c10d516b0c6470b11f5816fef72b
Jul 2, 2020https://github.com/getsentry/sentry-python/pull/754#event-3507466212
https://github.com/untitaker
untitakerhttps://github.com/untitaker
July 2, 2020 14:47https://github.com/getsentry/sentry-python/pull/754#event-3507466302
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F754
https://github.com/mitsuhiko
mitsuhiko https://github.com/mitsuhiko
https://github.com/getsentry/sentry-python/pull/754/files/b4201fb4f406fd4531e362d8c4b62aaf594c0ff5
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/754
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/754
https://github.com/untitaker
https://github.com/mitsuhiko
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.