René's URL Explorer Experiment


Title: fix(batcher): Add global flush trigger based on the span number by alexander-alderman-webb · Pull Request #7150 · getsentry/sentry-python · GitHub

Open Graph Title: fix(batcher): Add global flush trigger based on the span number by alexander-alderman-webb · Pull Request #7150 · getsentry/sentry-python

X Title: fix(batcher): Add global flush trigger based on the span number by alexander-alderman-webb · Pull Request #7150 · getsentry/sentry-python

Description: Description I realized we would be dropping spans if we reach GLOBAL_MAX_BEFORE_DROP spans before reaching the bytes limit at which we flush spans. Add a global span limit to trigger a batcher flush. This mirrors the per-bucket logic. Add a test for the global span limit based on the test for the per-bucket limit. Add test_span_number_reset_after_length_based_flushing() to ensure accurate bookkeeping of the total estimated size of spans in the batcher. Issues Reminders Please add tests to validate your changes, and lint your code using uv run ruff. Add GH Issue ID & Linear ID (if applicable) PR title should use conventional commit style (feat:, fix:, ref:, meta:) For external contributors: CONTRIBUTING.md, Sentry SDK development docs, Discord community

Open Graph Description: Description I realized we would be dropping spans if we reach GLOBAL_MAX_BEFORE_DROP spans before reaching the bytes limit at which we flush spans. Add a global span limit to trigger a batcher flu...

X Description: Description I realized we would be dropping spans if we reach GLOBAL_MAX_BEFORE_DROP spans before reaching the bytes limit at which we flush spans. Add a global span limit to trigger a batcher flu...

Opengraph URL: https://github.com/getsentry/sentry-python/pull/7150

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:25c582c4-d9ed-c9b8-9674-11204cdc5361
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB5F8:154D88:232AA4:2C883E:6B00FED7
html-safe-noncebde95b5f2f5c6b5b08ee5858cb52a9d8505697e02746779ac30f3b2eb861054f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNUY4OjE1NEQ4ODoyMzJBQTQ6MkM4ODNFOjZCMDBGRUQ3IiwidmlzaXRvcl9pZCI6IjgzMzY3NTA5Mjc0NDA1NzYyMTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacdd1b7cf4710593b71738f6d97a7dd20aa8365566922ed8970429d0a6350a952d
hovercard-subject-tagpull_request:4244629662
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/getsentry/sentry-python/pull/7150/files
twitter:imagehttps://avatars.githubusercontent.com/u/224035503?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/224035503?s=400&v=4
og:image:altDescription I realized we would be dropping spans if we reach GLOBAL_MAX_BEFORE_DROP spans before reaching the bytes limit at which we flush spans. Add a global span limit to trigger a batcher flu...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/7150/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F7150%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F7150%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/7150/files
Reloadhttps://github.com/getsentry/sentry-python/pull/7150/files
Reloadhttps://github.com/getsentry/sentry-python/pull/7150/files
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
alexander-alderman-webbhttps://github.com/alexander-alderman-webb
masterhttps://github.com/getsentry/sentry-python/tree/master
webb/batcher/add-global-flush-triggerhttps://github.com/getsentry/sentry-python/tree/webb/batcher/add-global-flush-trigger
Conversation 1 https://github.com/getsentry/sentry-python/pull/7150
Commits 2 https://github.com/getsentry/sentry-python/pull/7150/commits
Checks 145 https://github.com/getsentry/sentry-python/pull/7150/checks
Files changed https://github.com/getsentry/sentry-python/pull/7150/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/7150/files
fix(batcher): Add global flush trigger based on the span number https://github.com/getsentry/sentry-python/pull/7150/files#top
Show all changes 2 commits https://github.com/getsentry/sentry-python/pull/7150/files
bbcddca fix(batcher): Add global flush trigger based on span number alexander-alderman-webb Aug 10, 2026 https://github.com/getsentry/sentry-python/pull/7150/commits/bbcddcaf4fc93c0e94c10b6fa154987e9c578b35
e8637c2 rename test alexander-alderman-webb Aug 10, 2026 https://github.com/getsentry/sentry-python/pull/7150/commits/e8637c222e7cc366e0b2e2fc9d8c86cc213b21b8
Clear filters https://github.com/getsentry/sentry-python/pull/7150/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/7150/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/7150/files
_span_batcher.py https://github.com/getsentry/sentry-python/pull/7150/files#diff-f400f2b5275be953a87e1a2fa25659221ab46d1f696f7d1104694c55ea621189
test_span_batcher.py https://github.com/getsentry/sentry-python/pull/7150/files#diff-770f63c0b84ba5cc921a4cde924003962d60143916fb5eab5e8b901f6f25458d
https://github.com/getsentry/sentry-python/blob/master/.github/CODEOWNERS#L1
sentry_sdk/_span_batcher.pyhttps://github.com/getsentry/sentry-python/pull/7150/files#diff-f400f2b5275be953a87e1a2fa25659221ab46d1f696f7d1104694c55ea621189
View file https://github.com/getsentry/sentry-python/blob/e8637c222e7cc366e0b2e2fc9d8c86cc213b21b8/sentry_sdk/_span_batcher.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/7150/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/7150/files#diff-f400f2b5275be953a87e1a2fa25659221ab46d1f696f7d1104694c55ea621189
https://github.com/getsentry/sentry-python/pull/7150/files#diff-f400f2b5275be953a87e1a2fa25659221ab46d1f696f7d1104694c55ea621189
https://github.com/getsentry/sentry-python/pull/7150/files#diff-f400f2b5275be953a87e1a2fa25659221ab46d1f696f7d1104694c55ea621189
https://github.com/getsentry/sentry-python/pull/7150/files#diff-f400f2b5275be953a87e1a2fa25659221ab46d1f696f7d1104694c55ea621189
https://github.com/getsentry/sentry-python/pull/7150/files#diff-f400f2b5275be953a87e1a2fa25659221ab46d1f696f7d1104694c55ea621189
https://github.com/getsentry/sentry-python/pull/7150/files#diff-f400f2b5275be953a87e1a2fa25659221ab46d1f696f7d1104694c55ea621189
https://github.com/getsentry/sentry-python/blob/master/.github/CODEOWNERS#L1
tests/tracing/test_span_batcher.pyhttps://github.com/getsentry/sentry-python/pull/7150/files#diff-770f63c0b84ba5cc921a4cde924003962d60143916fb5eab5e8b901f6f25458d
View file https://github.com/getsentry/sentry-python/blob/e8637c222e7cc366e0b2e2fc9d8c86cc213b21b8/tests/tracing/test_span_batcher.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/7150/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/7150/files#diff-770f63c0b84ba5cc921a4cde924003962d60143916fb5eab5e8b901f6f25458d
https://github.com/getsentry/sentry-python/pull/7150/files#diff-770f63c0b84ba5cc921a4cde924003962d60143916fb5eab5e8b901f6f25458d
https://github.com/getsentry/sentry-python/pull/7150/files#diff-770f63c0b84ba5cc921a4cde924003962d60143916fb5eab5e8b901f6f25458d
https://github.com/getsentry/sentry-python/pull/7150/files#diff-770f63c0b84ba5cc921a4cde924003962d60143916fb5eab5e8b901f6f25458d
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/7150/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.