René's URL Explorer Experiment


Title: feat(starlette): Support span streaming by ericapisani · Pull Request #6123 · getsentry/sentry-python · GitHub

Open Graph Title: feat(starlette): Support span streaming by ericapisani · Pull Request #6123 · getsentry/sentry-python

X Title: feat(starlette): Support span streaming by ericapisani · Pull Request #6123 · getsentry/sentry-python

Description: Bring the Starlette integration to span-streaming parity with the FastAPI change that landed in #6118. Under the trace_lifecycle: "stream" experiment the scope's transaction is None and the scope instead holds a StreamedSpan, so the existing middleware instrumentation (which called start_span(op=..., origin=...) + set_tag) and the profiler's current_scope.transaction.update_active_thread() hook in patch_request_response didn't function under streaming. This PR routes both through the streaming APIs when streaming is enabled while leaving the legacy transaction-based path untouched: _enable_span_for_middleware now uses a _start_middleware_span helper that calls sentry_sdk.traces.start_span with sentry.op, sentry.origin, and starlette.middleware_name attributes under streaming, and the existing sentry_sdk.start_span(op=..., origin=...) + set_tag otherwise. The profiler hook detects StreamedSpan (excluding NoOpStreamedSpan) and calls _segment._update_active_thread(); otherwise it takes the legacy current_scope.transaction.update_active_thread() branch. Tests are parametrized across streaming and static modes for test_middleware_spans, test_middleware_spans_disabled, test_middleware_callback_spans, and test_span_origin. A new test_active_thread_id_span_streaming covers the segment's thread.id attribute under streaming. auto_enabling_integrations=False is set in streaming tests where auto-instrumented spans would otherwise leak into the captured span stream. Refs PY-2362

Open Graph Description: Bring the Starlette integration to span-streaming parity with the FastAPI change that landed in #6118. Under the trace_lifecycle: "stream" experiment the scope's transaction is None a...

X Description: Bring the Starlette integration to span-streaming parity with the FastAPI change that landed in #6118. Under the trace_lifecycle: "stream" experiment the scope's transacti...

Opengraph URL: https://github.com/getsentry/sentry-python/pull/6123

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:27719f0c-abcb-783b-d74e-41d1f3f13a9a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE43A:2279A:9A70DB:CCC628:6B00B731
html-safe-nonce9a6b2bc56cc55d6a2b7979ccc4de120881620a438676fd2348ffb3b3f4e1a796
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDNBOjIyNzlBOjlBNzBEQjpDQ0M2Mjg6NkIwMEI3MzEiLCJ2aXNpdG9yX2lkIjoiODg5OTEyMzI5MjYzNjkxNTY5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5a5dbae6a2bf25ccd4d868ad691f0454a4d80ec61bf0e55586ccdff9f7840d56
hovercard-subject-tagpull_request:3563167569
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/getsentry/sentry-python/pull/6123/files
twitter:imagehttps://avatars.githubusercontent.com/u/5655473?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5655473?s=400&v=4
og:image:altBring the Starlette integration to span-streaming parity with the FastAPI change that landed in #6118. Under the trace_lifecycle: "stream" experiment the scope's transaction is None a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None1d07c25977adfc5ff6acb0a962a9bc168c07afbda6fef765f9761c350c2ae4a2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5429cbfc6aca8c7b9a086a3c8f47400346f38cc9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/6123/changes#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F6123%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F6123%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/6123/changes
Reloadhttps://github.com/getsentry/sentry-python/pull/6123/changes
Reloadhttps://github.com/getsentry/sentry-python/pull/6123/changes
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
ericapisanihttps://github.com/ericapisani
masterhttps://github.com/getsentry/sentry-python/tree/master
ep/py-2362-2mwhttps://github.com/getsentry/sentry-python/tree/ep/py-2362-2mw
Conversation 30 https://github.com/getsentry/sentry-python/pull/6123
Commits 11 https://github.com/getsentry/sentry-python/pull/6123/commits
Checks 156 https://github.com/getsentry/sentry-python/pull/6123/checks
Files changed https://github.com/getsentry/sentry-python/pull/6123/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/6123/changes
feat(starlette): Support span streaming https://github.com/getsentry/sentry-python/pull/6123/changes#top
Show all changes 11 commits https://github.com/getsentry/sentry-python/pull/6123/files
f50e1ab feat(starlette): Support span streaming ericapisani Apr 21, 2026 https://github.com/getsentry/sentry-python/pull/6123/commits/f50e1abb98a6e2b8117e7768ed1e1e6082992303
32286b8 feat(starlette): Capture request body on segment span under streaming ericapisani Apr 23, 2026 https://github.com/getsentry/sentry-python/pull/6123/commits/32286b8c4789648664115064f6961465fe065501
50352ea skip test in earlier version of starlette since it does not support c… ericapisani Apr 23, 2026 https://github.com/getsentry/sentry-python/pull/6123/commits/50352ea975155e21ccd0436c5d0a30141d3a9905
6eacecc fix(starlette): Set request body data on segment under streaming ericapisani Apr 24, 2026 https://github.com/getsentry/sentry-python/pull/6123/commits/6eacecc6f909cc217ffc4178e685540d6f0472bb
943c3d4 Merge branch 'master' into ep/py-2362-2mw ericapisani Apr 24, 2026 https://github.com/getsentry/sentry-python/pull/6123/commits/943c3d406c5ef0791dd74c3d2aeeedfcad7246a8
4493974 fix(starlette): Rename middleware name attribute on streaming spans ericapisani Apr 24, 2026 https://github.com/getsentry/sentry-python/pull/6123/commits/449397426f1250c113e19cad97d380cdd7b1e552
92b4121 Rename test because it's not accurate ericapisani Apr 24, 2026 https://github.com/getsentry/sentry-python/pull/6123/commits/92b4121588c2c6f0f213209be351dbf0362d3e26
29de949 Address code review comments regarding the middleware tests ericapisani Apr 27, 2026 https://github.com/getsentry/sentry-python/pull/6123/commits/29de94942dec392d8011e92ad9c0050b79b862f5
48415ad Catch any raised exceptions from the serialization json.dumps call an… ericapisani Apr 27, 2026 https://github.com/getsentry/sentry-python/pull/6123/commits/48415adf14b1b3e5d95ee4e11163cbbf20ea993a
3ae7b8a Remove metadata returned from serialization of body data method, whos… ericapisani Apr 28, 2026 https://github.com/getsentry/sentry-python/pull/6123/commits/3ae7b8a11be79f6bd08a1aa186a8247636ad22d3
35c6906 Missed a test that needed updating ericapisani Apr 28, 2026 https://github.com/getsentry/sentry-python/pull/6123/commits/35c6906132415c2c4ee321ee4966767d5d8a2652
Clear filters https://github.com/getsentry/sentry-python/pull/6123/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/6123/changes
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/6123/changes
starlette.py https://github.com/getsentry/sentry-python/pull/6123/changes#diff-6f6cf0fb18998238da86355c38e101792b5fe0582ea0c09c615a68eb82fbea57
test_starlette.py https://github.com/getsentry/sentry-python/pull/6123/changes#diff-56b3e242aecca53f7fabd6934da2ef813f66ca929852af57d6fa71beab3e856e
https://github.com/getsentry/sentry-python/blob/master/.github/CODEOWNERS#L1
sentry_sdk/integrations/starlette.pyhttps://github.com/getsentry/sentry-python/pull/6123/changes#diff-6f6cf0fb18998238da86355c38e101792b5fe0582ea0c09c615a68eb82fbea57
View file https://github.com/getsentry/sentry-python/blob/35c6906132415c2c4ee321ee4966767d5d8a2652/sentry_sdk/integrations/starlette.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/6123/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/6123/changes#diff-6f6cf0fb18998238da86355c38e101792b5fe0582ea0c09c615a68eb82fbea57
https://github.com/getsentry/sentry-python/pull/6123/changes#diff-6f6cf0fb18998238da86355c38e101792b5fe0582ea0c09c615a68eb82fbea57
https://github.com/getsentry/sentry-python/pull/6123/changes#diff-6f6cf0fb18998238da86355c38e101792b5fe0582ea0c09c615a68eb82fbea57
https://github.com/getsentry/sentry-python/pull/6123/changes#diff-6f6cf0fb18998238da86355c38e101792b5fe0582ea0c09c615a68eb82fbea57
ericapisanihttps://github.com/ericapisani
Apr 24, 2026https://github.com/getsentry/sentry-python/pull/6123/changes#r3138668519
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
convention PRhttps://github.com/getsentry/sentry-conventions/pull/337
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/6123/changes
https://github.com/getsentry/sentry-python/pull/6123/changes#diff-6f6cf0fb18998238da86355c38e101792b5fe0582ea0c09c615a68eb82fbea57
https://github.com/getsentry/sentry-python/pull/6123/changes#diff-6f6cf0fb18998238da86355c38e101792b5fe0582ea0c09c615a68eb82fbea57
sentrivanahttps://github.com/sentrivana
Apr 27, 2026https://github.com/getsentry/sentry-python/pull/6123/changes#r3145955018
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/6123/changes
ericapisanihttps://github.com/ericapisani
Apr 27, 2026https://github.com/getsentry/sentry-python/pull/6123/changes#r3146826805
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
comment abovehttps://github.com/getsentry/sentry-python/pull/6123#discussion_r3146805519
this threadhttps://sentry.slack.com/archives/C09RR0KD2N7/p1776951331206129?thread_ts=1776951227.440659&cid=C09RR0KD2N7
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/6123/changes
sentrivanahttps://github.com/sentrivana
Apr 28, 2026https://github.com/getsentry/sentry-python/pull/6123/changes#r3151965692
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/getsentry/sentry-python/pull/6123/changes#r3151943009https://github.com/getsentry/sentry-python/pull/6123/changes#r3151943009
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/6123/changes
https://github.com/getsentry/sentry-python/pull/6123/changes#diff-6f6cf0fb18998238da86355c38e101792b5fe0582ea0c09c615a68eb82fbea57
https://github.com/getsentry/sentry-python/pull/6123/changes#diff-6f6cf0fb18998238da86355c38e101792b5fe0582ea0c09c615a68eb82fbea57
https://github.com/getsentry/sentry-python/pull/6123/changes#diff-6f6cf0fb18998238da86355c38e101792b5fe0582ea0c09c615a68eb82fbea57
https://github.com/getsentry/sentry-python/pull/6123/changes#diff-6f6cf0fb18998238da86355c38e101792b5fe0582ea0c09c615a68eb82fbea57
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/6123/changes
https://github.com/getsentry/sentry-python/pull/6123/changes#diff-6f6cf0fb18998238da86355c38e101792b5fe0582ea0c09c615a68eb82fbea57
https://github.com/getsentry/sentry-python/pull/6123/changes#diff-6f6cf0fb18998238da86355c38e101792b5fe0582ea0c09c615a68eb82fbea57
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/6123/changes
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/6123/changes
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.