René's URL Explorer Experiment


Title: fix: Add cycle detection to exceptions_from_error by ericapisani · Pull Request #5880 · getsentry/sentry-python · GitHub

Open Graph Title: fix: Add cycle detection to exceptions_from_error by ericapisani · Pull Request #5880 · getsentry/sentry-python

X Title: fix: Add cycle detection to exceptions_from_error by ericapisani · Pull Request #5880 · getsentry/sentry-python

Description: Summary Add cycle detection to exceptions_from_error() to prevent infinite recursion when exception chains contain cycles This fixes a production issue where FastAPI + multiple BaseHTTPMiddleware instances cause Starlette's collapse_excgroups() to create cyclic __context__ references (ExceptionGroup → inner exception → __context__ → ExceptionGroup) Without this fix, the SDK silently drops the event due to a RecursionError Test plan test_exceptiongroup_starlette_collapse — realistic reproduction of the Starlette collapse_excgroups() pattern with exact expected exception values test_cyclic_exception_group_cause — verifies cycle detection works for __cause__ chains test_deeply_nested_cyclic_exception_group — verifies cycle detection across multiple nested ExceptionGroups Fixes #5025 and PY-1949 🤖 Generated with Claude Code

Open Graph Description: Summary Add cycle detection to exceptions_from_error() to prevent infinite recursion when exception chains contain cycles This fixes a production issue where FastAPI + multiple BaseHTTPMiddleware ...

X Description: Summary Add cycle detection to exceptions_from_error() to prevent infinite recursion when exception chains contain cycles This fixes a production issue where FastAPI + multiple BaseHTTPMiddleware ...

Opengraph URL: https://github.com/getsentry/sentry-python/pull/5880

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d895f241-62d9-d430-34d8-6a15e2105806
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA1AA:26ECEB:98E2B4:C63BD7:6B00DF7B
html-safe-noncedd002d08074a9ee83bc0210b2ff9d0eb01681cbca360a5c9a0ccad39676b18b1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMUFBOjI2RUNFQjo5OEUyQjQ6QzYzQkQ3OjZCMDBERjdCIiwidmlzaXRvcl9pZCI6Ijc3MzgxNTc1NTQ4MDI5MzI0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac716b7b11fd8c8f6676acfe20af00c18db3cc6fe0e4bb0cb2ae46cd1649615c11
hovercard-subject-tagpull_request:3450518495
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/getsentry/sentry-python/pull/5880/files
twitter:imagehttps://avatars.githubusercontent.com/u/5655473?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5655473?s=400&v=4
og:image:altSummary Add cycle detection to exceptions_from_error() to prevent infinite recursion when exception chains contain cycles This fixes a production issue where FastAPI + multiple BaseHTTPMiddleware ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/5880/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F5880%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F5880%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/5880/files
Reloadhttps://github.com/getsentry/sentry-python/pull/5880/files
Reloadhttps://github.com/getsentry/sentry-python/pull/5880/files
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
ericapisanihttps://github.com/ericapisani
masterhttps://github.com/getsentry/sentry-python/tree/master
ep/py-1949-recursive-fastapi-exception-m4qhttps://github.com/getsentry/sentry-python/tree/ep/py-1949-recursive-fastapi-exception-m4q
Conversation 11 https://github.com/getsentry/sentry-python/pull/5880
Commits 5 https://github.com/getsentry/sentry-python/pull/5880/commits
Checks 158 https://github.com/getsentry/sentry-python/pull/5880/checks
Files changed https://github.com/getsentry/sentry-python/pull/5880/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/5880/files
fix: Add cycle detection to exceptions_from_error https://github.com/getsentry/sentry-python/pull/5880/files#top
Show all changes 5 commits https://github.com/getsentry/sentry-python/pull/5880/files
cacf35c fix: Add cycle detection to exceptions_from_error ericapisani Mar 25, 2026 https://github.com/getsentry/sentry-python/pull/5880/commits/cacf35c4c8744edb841c5bcc02cc14bf86a8ad95
26e9947 test: Replace synthetic cycle test with realistic Starlette reproduction ericapisani Mar 26, 2026 https://github.com/getsentry/sentry-python/pull/5880/commits/26e99472b498471cc7c38a9a8e83a669d420efa9
4cc2672 ref: Improve typing and initialization in cycle detection ericapisani Mar 26, 2026 https://github.com/getsentry/sentry-python/pull/5880/commits/4cc2672f1a6e40385edb32a5e86cf940400eed35
90df082 cleanup ericapisani Mar 26, 2026 https://github.com/getsentry/sentry-python/pull/5880/commits/90df082a12fcad41ca9c185e9ee59a943e12a362
d516f1a docs: Clarify exception_id and parent_id parameters in ericapisani Mar 30, 2026 https://github.com/getsentry/sentry-python/pull/5880/commits/d516f1a8f40ab0c24c1f62e0a70bb19369398710
Clear filters https://github.com/getsentry/sentry-python/pull/5880/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/5880/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/5880/files
utils.py https://github.com/getsentry/sentry-python/pull/5880/files#diff-e9f88ca6368ce622839e078ed26c741a927752c01ceae64cd504d3ae86de6fd2
test_exceptiongroup.py https://github.com/getsentry/sentry-python/pull/5880/files#diff-6c8f7aeed6c3a52a6937730c937250c46392cbd78afe9fcddf39295d51d63597
https://github.com/getsentry/sentry-python/blob/master/.github/CODEOWNERS#L1
sentry_sdk/utils.pyhttps://github.com/getsentry/sentry-python/pull/5880/files#diff-e9f88ca6368ce622839e078ed26c741a927752c01ceae64cd504d3ae86de6fd2
View file https://github.com/getsentry/sentry-python/blob/d516f1a8f40ab0c24c1f62e0a70bb19369398710/sentry_sdk/utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/5880/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/5880/files#diff-e9f88ca6368ce622839e078ed26c741a927752c01ceae64cd504d3ae86de6fd2
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/5880/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/5880/files
https://github.com/getsentry/sentry-python/pull/5880/files#diff-e9f88ca6368ce622839e078ed26c741a927752c01ceae64cd504d3ae86de6fd2
https://github.com/getsentry/sentry-python/pull/5880/files#diff-e9f88ca6368ce622839e078ed26c741a927752c01ceae64cd504d3ae86de6fd2
https://github.com/getsentry/sentry-python/pull/5880/files#diff-e9f88ca6368ce622839e078ed26c741a927752c01ceae64cd504d3ae86de6fd2
https://github.com/getsentry/sentry-python/pull/5880/files#diff-e9f88ca6368ce622839e078ed26c741a927752c01ceae64cd504d3ae86de6fd2
https://github.com/getsentry/sentry-python/pull/5880/files#diff-e9f88ca6368ce622839e078ed26c741a927752c01ceae64cd504d3ae86de6fd2
https://github.com/getsentry/sentry-python/blob/master/.github/CODEOWNERS#L1
tests/test_exceptiongroup.pyhttps://github.com/getsentry/sentry-python/pull/5880/files#diff-6c8f7aeed6c3a52a6937730c937250c46392cbd78afe9fcddf39295d51d63597
View file https://github.com/getsentry/sentry-python/blob/d516f1a8f40ab0c24c1f62e0a70bb19369398710/tests/test_exceptiongroup.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/5880/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/5880/files#diff-6c8f7aeed6c3a52a6937730c937250c46392cbd78afe9fcddf39295d51d63597
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/5880/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.