René's URL Explorer Experiment


Title: fix(utils): Avoid double serialization of strings in safe_serialize by ericapisani · Pull Request #5587 · getsentry/sentry-python · GitHub

Open Graph Title: fix(utils): Avoid double serialization of strings in safe_serialize by ericapisani · Pull Request #5587 · getsentry/sentry-python

X Title: fix(utils): Avoid double serialization of strings in safe_serialize by ericapisani · Pull Request #5587 · getsentry/sentry-python

Description: When serialize_item() inside safe_serialize() already returns a string (for plain strings, callables, or objects with __dict__), the subsequent json.dumps() call wraps it in extra quotes with escaped characters. For example, a JSON string '{"param": "value"}' becomes '"{\\"param\\": \\"value\\"}"'. This was causing double-serialized tool arguments in pydantic-ai integrations. The fix skips json.dumps when serialize_item has already produced a string, and adds tests covering plain strings, JSON strings, dicts, callables, and objects. Part of PY-2114

Open Graph Description: When serialize_item() inside safe_serialize() already returns a string (for plain strings, callables, or objects with __dict__), the subsequent json.dumps() call wraps it in extra quotes with escap...

X Description: When serialize_item() inside safe_serialize() already returns a string (for plain strings, callables, or objects with __dict__), the subsequent json.dumps() call wraps it in extra quotes with escap...

Opengraph URL: https://github.com/getsentry/sentry-python/pull/5587

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:80ebde6d-d096-19cf-e39e-0f4fc7077a73
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9D30:1F7384:7163FD:98293A:6B00D822
html-safe-nonce81a6922f2f4ad84545f44d5dd86d1b316ca0eadf5154dbd1e13abf19acc49bdd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDMwOjFGNzM4NDo3MTYzRkQ6OTgyOTNBOjZCMDBEODIyIiwidmlzaXRvcl9pZCI6IjY1NTk1OTM4ODA5ODYxMTQwODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac972d143e4bb038460c9d619209374ca125cabfdfe6c09bea6aa28956a568ec27
hovercard-subject-tagpull_request:3354866845
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/getsentry/sentry-python/pull/5587/files
twitter:imagehttps://avatars.githubusercontent.com/u/5655473?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5655473?s=400&v=4
og:image:altWhen serialize_item() inside safe_serialize() already returns a string (for plain strings, callables, or objects with __dict__), the subsequent json.dumps() call wraps it in extra quotes with escap...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonea481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84c8c5cc25e2fb7f2308428458538436baecc6d2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/5587/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F5587%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F5587%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/5587/files
Reloadhttps://github.com/getsentry/sentry-python/pull/5587/files
Reloadhttps://github.com/getsentry/sentry-python/pull/5587/files
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
ericapisanihttps://github.com/ericapisani
masterhttps://github.com/getsentry/sentry-python/tree/master
ep/fix-double-serialization-in-pydantic-ai-tools-62hhttps://github.com/getsentry/sentry-python/tree/ep/fix-double-serialization-in-pydantic-ai-tools-62h
Conversation 7 https://github.com/getsentry/sentry-python/pull/5587
Commits 4 https://github.com/getsentry/sentry-python/pull/5587/commits
Checks 160 https://github.com/getsentry/sentry-python/pull/5587/checks
Files changed https://github.com/getsentry/sentry-python/pull/5587/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/5587/files
fix(utils): Avoid double serialization of strings in safe_serialize https://github.com/getsentry/sentry-python/pull/5587/files#top
Show all changes 4 commits https://github.com/getsentry/sentry-python/pull/5587/files
5937e9c fix(utils): Avoid double serialization of strings in safe_serialize ericapisani Mar 4, 2026 https://github.com/getsentry/sentry-python/pull/5587/commits/5937e9c401a13f552e67608f520555822ed98f90
09eafa4 test(google_genai): Update expected values after safe_serialize fix ericapisani Mar 4, 2026 https://github.com/getsentry/sentry-python/pull/5587/commits/09eafa48d2e825482e27e104874ab8d56ed38247
b9f312c test(mcp): Update expected values after safe_serialize fix ericapisani Mar 4, 2026 https://github.com/getsentry/sentry-python/pull/5587/commits/b9f312cb2826a9c41e3db226a6f071fee575b6e8
c67af6a Merge branch 'master' into ep/fix-double-serialization-in-pydantic-ai… ericapisani Mar 5, 2026 https://github.com/getsentry/sentry-python/pull/5587/commits/c67af6a02842d7b510416da23a8c4c2f72b3f537
Clear filters https://github.com/getsentry/sentry-python/pull/5587/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/5587/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/5587/files
utils.py https://github.com/getsentry/sentry-python/pull/5587/files#diff-e9f88ca6368ce622839e078ed26c741a927752c01ceae64cd504d3ae86de6fd2
test_google_genai.py https://github.com/getsentry/sentry-python/pull/5587/files#diff-21884bfbc4ccc958eb4ada7c821f54ed57345449e8d862b581d84345e63f1e5d
test_mcp.py https://github.com/getsentry/sentry-python/pull/5587/files#diff-e64066cfcbfbe50ec059ca5a597edfc31702327dac3c44a863df86f145914da5
test_utils.py https://github.com/getsentry/sentry-python/pull/5587/files#diff-33c13e0b177bacd2f02e29bcb8aea5b49e7ce34901fd8f41fefb65defba1bd33
https://github.com/getsentry/sentry-python/blob/master/.github/CODEOWNERS#L1
sentry_sdk/utils.pyhttps://github.com/getsentry/sentry-python/pull/5587/files#diff-e9f88ca6368ce622839e078ed26c741a927752c01ceae64cd504d3ae86de6fd2
View file https://github.com/getsentry/sentry-python/blob/c67af6a02842d7b510416da23a8c4c2f72b3f537/sentry_sdk/utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/5587/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/5587/files#diff-e9f88ca6368ce622839e078ed26c741a927752c01ceae64cd504d3ae86de6fd2
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/5587/files
https://github.com/getsentry/sentry-python/pull/5587/files#diff-e9f88ca6368ce622839e078ed26c741a927752c01ceae64cd504d3ae86de6fd2
https://github.com/getsentry/sentry-python/blob/master/.github/CODEOWNERS#L1
tests/integrations/google_genai/test_google_genai.pyhttps://github.com/getsentry/sentry-python/pull/5587/files#diff-21884bfbc4ccc958eb4ada7c821f54ed57345449e8d862b581d84345e63f1e5d
View file https://github.com/getsentry/sentry-python/blob/c67af6a02842d7b510416da23a8c4c2f72b3f537/tests/integrations/google_genai/test_google_genai.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/5587/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/5587/files#diff-21884bfbc4ccc958eb4ada7c821f54ed57345449e8d862b581d84345e63f1e5d
https://github.com/getsentry/sentry-python/pull/5587/files#diff-21884bfbc4ccc958eb4ada7c821f54ed57345449e8d862b581d84345e63f1e5d
https://github.com/getsentry/sentry-python/pull/5587/files#diff-21884bfbc4ccc958eb4ada7c821f54ed57345449e8d862b581d84345e63f1e5d
https://github.com/getsentry/sentry-python/pull/5587/files#diff-21884bfbc4ccc958eb4ada7c821f54ed57345449e8d862b581d84345e63f1e5d
https://github.com/getsentry/sentry-python/pull/5587/files#diff-21884bfbc4ccc958eb4ada7c821f54ed57345449e8d862b581d84345e63f1e5d
https://github.com/getsentry/sentry-python/blob/master/.github/CODEOWNERS#L1
tests/integrations/mcp/test_mcp.pyhttps://github.com/getsentry/sentry-python/pull/5587/files#diff-e64066cfcbfbe50ec059ca5a597edfc31702327dac3c44a863df86f145914da5
View file https://github.com/getsentry/sentry-python/blob/c67af6a02842d7b510416da23a8c4c2f72b3f537/tests/integrations/mcp/test_mcp.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/5587/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/5587/files#diff-e64066cfcbfbe50ec059ca5a597edfc31702327dac3c44a863df86f145914da5
https://github.com/getsentry/sentry-python/pull/5587/files#diff-e64066cfcbfbe50ec059ca5a597edfc31702327dac3c44a863df86f145914da5
https://github.com/getsentry/sentry-python/pull/5587/files#diff-e64066cfcbfbe50ec059ca5a597edfc31702327dac3c44a863df86f145914da5
https://github.com/getsentry/sentry-python/pull/5587/files#diff-e64066cfcbfbe50ec059ca5a597edfc31702327dac3c44a863df86f145914da5
https://github.com/getsentry/sentry-python/pull/5587/files#diff-e64066cfcbfbe50ec059ca5a597edfc31702327dac3c44a863df86f145914da5
https://github.com/getsentry/sentry-python/pull/5587/files#diff-e64066cfcbfbe50ec059ca5a597edfc31702327dac3c44a863df86f145914da5
https://github.com/getsentry/sentry-python/pull/5587/files#diff-e64066cfcbfbe50ec059ca5a597edfc31702327dac3c44a863df86f145914da5
https://github.com/getsentry/sentry-python/pull/5587/files#diff-e64066cfcbfbe50ec059ca5a597edfc31702327dac3c44a863df86f145914da5
https://github.com/getsentry/sentry-python/blob/master/.github/CODEOWNERS#L1
tests/test_utils.pyhttps://github.com/getsentry/sentry-python/pull/5587/files#diff-33c13e0b177bacd2f02e29bcb8aea5b49e7ce34901fd8f41fefb65defba1bd33
View file https://github.com/getsentry/sentry-python/blob/c67af6a02842d7b510416da23a8c4c2f72b3f537/tests/test_utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/5587/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/5587/files#diff-33c13e0b177bacd2f02e29bcb8aea5b49e7ce34901fd8f41fefb65defba1bd33
https://github.com/getsentry/sentry-python/pull/5587/files#diff-33c13e0b177bacd2f02e29bcb8aea5b49e7ce34901fd8f41fefb65defba1bd33
https://github.com/getsentry/sentry-python/pull/5587/files#diff-33c13e0b177bacd2f02e29bcb8aea5b49e7ce34901fd8f41fefb65defba1bd33
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/5587/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.