René's URL Explorer Experiment


Title: fix(tests): Don't assume release is set by sentrivana · Pull Request #4879 · getsentry/sentry-python · GitHub

Open Graph Title: fix(tests): Don't assume release is set by sentrivana · Pull Request #4879 · getsentry/sentry-python

X Title: fix(tests): Don't assume release is set by sentrivana · Pull Request #4879 · getsentry/sentry-python

Description: Description Even though we try to figure out the current release automatically if it's not provided, it can still end up being None. If that's the case, it won't be attached to logs. The test_logs_attributes test assumes there always is a release, which is incorrect. I opted for conditionally checking for sentry.release in the test instead of removing the check altogether, even though the test itself is supposed to test custom user provided attributes. The reason is that there is no other generic logs test testing sentry.release. Issues Closes #4878 Reminders Please add tests to validate your changes, and lint your code using tox -e linters. Add GH Issue ID & Linear ID (if applicable) PR title should use conventional commit style (feat:, fix:, ref:, meta:) For external contributors: CONTRIBUTING.md, Sentry SDK development docs, Discord community

Open Graph Description: Description Even though we try to figure out the current release automatically if it's not provided, it can still end up being None. If that's the case, it won't be attached to logs. Th...

X Description: Description Even though we try to figure out the current release automatically if it's not provided, it can still end up being None. If that's the case, it won't be attached...

Opengraph URL: https://github.com/getsentry/sentry-python/pull/4879

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1137f680-5bb4-c4d0-ca4e-e84de7c23910
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id93FC:29FFA9:6CE67B:8BAE01:6B00E170
html-safe-nonce76482ba552b94eced34b41a11bb80ceaf2bd99ea1c2c89036fca802bb9b3d813
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0ZDOjI5RkZBOTo2Q0U2N0I6OEJBRTAxOjZCMDBFMTcwIiwidmlzaXRvcl9pZCI6Ijg2Mjg2NTEyMTU3MDc3NTg5NjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb33dc90877efef36481533fe625b0873b3511c0a76170955687ce072da4a6ea2
hovercard-subject-tagpull_request:2881938389
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/getsentry/sentry-python/pull/4879/files
twitter:imagehttps://avatars.githubusercontent.com/u/131587164?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/131587164?s=400&v=4
og:image:altDescription Even though we try to figure out the current release automatically if it's not provided, it can still end up being None. If that's the case, it won't be attached to logs. Th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/4879/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F4879%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F4879%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/4879/files
Reloadhttps://github.com/getsentry/sentry-python/pull/4879/files
Reloadhttps://github.com/getsentry/sentry-python/pull/4879/files
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
sentrivanahttps://github.com/sentrivana
masterhttps://github.com/getsentry/sentry-python/tree/master
ivana/fix-test-failureshttps://github.com/getsentry/sentry-python/tree/ivana/fix-test-failures
Conversation 0 https://github.com/getsentry/sentry-python/pull/4879
Commits 2 https://github.com/getsentry/sentry-python/pull/4879/commits
Checks 0 https://github.com/getsentry/sentry-python/pull/4879/checks
Files changed https://github.com/getsentry/sentry-python/pull/4879/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/4879/files
fix(tests): Don't assume release is set https://github.com/getsentry/sentry-python/pull/4879/files#top
Show all changes 2 commits https://github.com/getsentry/sentry-python/pull/4879/files
e964133 Do not check for sentry.release in test_logs_attributes sentrivana Oct 2, 2025 https://github.com/getsentry/sentry-python/pull/4879/commits/e964133813b9c6f6480c2b47991980a4896cf003
830eda4 fix: Do not assume sentry.release is set sentrivana Oct 2, 2025 https://github.com/getsentry/sentry-python/pull/4879/commits/830eda423fe7fdfcc1b5cfaf2a20e0ea1ece270e
Clear filters https://github.com/getsentry/sentry-python/pull/4879/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/4879/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/4879/files
https://github.com/getsentry/sentry-python/blob/master/.github/CODEOWNERS#L1
tests/test_logs.pyhttps://github.com/getsentry/sentry-python/pull/4879/files#diff-468e98ba4b95217b47e2ca8259cbf73fba8256acd034d22ae6ba68c74be5aaca
View file https://github.com/getsentry/sentry-python/blob/830eda423fe7fdfcc1b5cfaf2a20e0ea1ece270e/tests/test_logs.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/4879/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/4879/files#diff-468e98ba4b95217b47e2ca8259cbf73fba8256acd034d22ae6ba68c74be5aaca
https://github.com/getsentry/sentry-python/pull/4879/files#diff-468e98ba4b95217b47e2ca8259cbf73fba8256acd034d22ae6ba68c74be5aaca
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.