René's URL Explorer Experiment


Title: Add custom sampling context testcases by sentrivana · Pull Request #4579 · getsentry/sentry-python · GitHub

Open Graph Title: Add custom sampling context testcases by sentrivana · Pull Request #4579 · getsentry/sentry-python

X Title: Add custom sampling context testcases by sentrivana · Pull Request #4579 · getsentry/sentry-python

Description: Noticed we don't actually have tests for whether custom attributes provided at span start appear in the sampling context. We were only testing if each integration adds some automatically.

Open Graph Description: Noticed we don't actually have tests for whether custom attributes provided at span start appear in the sampling context. We were only testing if each integration adds some automatically.

X Description: Noticed we don't actually have tests for whether custom attributes provided at span start appear in the sampling context. We were only testing if each integration adds some automatically.

Opengraph URL: https://github.com/getsentry/sentry-python/pull/4579

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9045d175-e880-d343-7299-bedb9893c2da
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9EB0:1148D3:98874:C8D61:6B00C5D9
html-safe-noncee4a00d89577ade8f8a3ed7adc913ca87c7ac6e9b616843bbab304b3c53b2381f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUIwOjExNDhEMzo5ODg3NDpDOEQ2MTo2QjAwQzVEOSIsInZpc2l0b3JfaWQiOiI0NTc1MjA0NTg5NDg1MjEzMTQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6f3b2b0762706686348762a88ffa0482f27e68bfe6763a15e68383d0ce91043d
hovercard-subject-tagpull_request:2664092592
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/getsentry/sentry-python/pull/4579/files
twitter:imagehttps://avatars.githubusercontent.com/u/131587164?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/131587164?s=400&v=4
og:image:altNoticed we don't actually have tests for whether custom attributes provided at span start appear in the sampling context. We were only testing if each integration adds some automatically.
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None98dc00e171c204462a6f367482a0f8c3c6b5dbca99cd7390e82d2df49ce096e4
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseef013399cf0a3c324bea644a685d7c1e0f06b5b7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/4579/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F4579%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F4579%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/4579/files
Reloadhttps://github.com/getsentry/sentry-python/pull/4579/files
Reloadhttps://github.com/getsentry/sentry-python/pull/4579/files
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
sentrivanahttps://github.com/sentrivana
potel-basehttps://github.com/getsentry/sentry-python/tree/potel-base
ivana/potel/custom-sampling-context-test-casehttps://github.com/getsentry/sentry-python/tree/ivana/potel/custom-sampling-context-test-case
Conversation 1 https://github.com/getsentry/sentry-python/pull/4579
Commits 3 https://github.com/getsentry/sentry-python/pull/4579/commits
Checks 0 https://github.com/getsentry/sentry-python/pull/4579/checks
Files changed https://github.com/getsentry/sentry-python/pull/4579/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/4579/files
Add custom sampling context testcases https://github.com/getsentry/sentry-python/pull/4579/files#top
Show all changes 3 commits https://github.com/getsentry/sentry-python/pull/4579/files
4a8dbe3 Add custom sampling context testcases sentrivana Jul 14, 2025 https://github.com/getsentry/sentry-python/pull/4579/commits/4a8dbe37e8256ab65f0f871e8aa49bfa5a7f383a
64bcb87 naming sentrivana Jul 14, 2025 https://github.com/getsentry/sentry-python/pull/4579/commits/64bcb8708471d6db59d438e52b0ee2db20d90208
e60fad4 cleanup sentrivana Jul 14, 2025 https://github.com/getsentry/sentry-python/pull/4579/commits/e60fad47adb71edd7099f132ccf698780e02b5f8
Clear filters https://github.com/getsentry/sentry-python/pull/4579/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/4579/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/4579/files
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
tests/tracing/test_sampling.pyhttps://github.com/getsentry/sentry-python/pull/4579/files#diff-b51eab357bbfb00b250fe03b91239ec6bb40d7f11d4c0f22944f1b23d3d24fcc
View file https://github.com/getsentry/sentry-python/blob/e60fad47adb71edd7099f132ccf698780e02b5f8/tests/tracing/test_sampling.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/4579/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/4579/files#diff-b51eab357bbfb00b250fe03b91239ec6bb40d7f11d4c0f22944f1b23d3d24fcc
https://github.com/getsentry/sentry-python/pull/4579/files#diff-b51eab357bbfb00b250fe03b91239ec6bb40d7f11d4c0f22944f1b23d3d24fcc
https://github.com/getsentry/sentry-python/pull/4579/files#diff-b51eab357bbfb00b250fe03b91239ec6bb40d7f11d4c0f22944f1b23d3d24fcc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.