René's URL Explorer Experiment


Title: Add custom sampling context testcases by sentrivana · Pull Request #4579 · getsentry/sentry-python · GitHub

Open Graph Title: Add custom sampling context testcases by sentrivana · Pull Request #4579 · getsentry/sentry-python

X Title: Add custom sampling context testcases by sentrivana · Pull Request #4579 · getsentry/sentry-python

Description: The official Python SDK for Sentry.io. Contribute to getsentry/sentry-python development by creating an account on GitHub.

Open Graph Description: Noticed we don't actually have tests for whether custom attributes provided at span start appear in the sampling context. We were only testing if each integration adds some automatically.

X Description: Noticed we don't actually have tests for whether custom attributes provided at span start appear in the sampling context. We were only testing if each integration adds some automatically.

Opengraph URL: https://github.com/getsentry/sentry-python/pull/4579

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f844644a-d6b5-4a38-173c-1ad6f70f74fe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D1A:26DF39:87DE6F:B48CC1:6B00B265
html-safe-nonce08fd0b707d2c4a79a80d380c8f0c308a47768ecd836abb2e702ddd80b77c2840
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDFBOjI2REYzOTo4N0RFNkY6QjQ4Q0MxOjZCMDBCMjY1IiwidmlzaXRvcl9pZCI6IjExODA1NzczMjQ4MDcwMDg4NjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb5bc4c848531cb252b525374c8cddc44230282444b35b8cfb0897afcd0643ad1
hovercard-subject-tagpull_request:2664092592
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/getsentry/sentry-python/4579/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5e36f8242b3c99c178901029348030274a6c0205b7f4f9778523624df80bda17/getsentry/sentry-python/pull/4579
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5e36f8242b3c99c178901029348030274a6c0205b7f4f9778523624df80bda17/getsentry/sentry-python/pull/4579
og:image:altNoticed we don't actually have tests for whether custom attributes provided at span start appear in the sampling context. We were only testing if each integration adds some automatically.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesentrivana
hostnamegithub.com
expected-hostnamegithub.com
Nonec0dd5f5d6f515a591019ecd66df2c4eab3379c2d3b0777568a90d8c7ae10b79e
turbo-cache-controlno-cache
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release729d8cda69b3d267995675dfbf89ff27ccf61bf6
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/4579#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F4579
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F4579
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/4579
Reloadhttps://github.com/getsentry/sentry-python/pull/4579
Reloadhttps://github.com/getsentry/sentry-python/pull/4579
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
https://github.com/getsentry/sentry-python
sentrivanahttps://github.com/sentrivana
potel-basehttps://github.com/getsentry/sentry-python/tree/potel-base
ivana/potel/custom-sampling-context-test-casehttps://github.com/getsentry/sentry-python/tree/ivana/potel/custom-sampling-context-test-case
Conversationhttps://github.com/getsentry/sentry-python/pull/4579
Commits3 (3)https://github.com/getsentry/sentry-python/pull/4579/commits
Checkshttps://github.com/getsentry/sentry-python/pull/4579/checks
Files changedhttps://github.com/getsentry/sentry-python/pull/4579/files
Add custom sampling context testcaseshttps://github.com/getsentry/sentry-python/pull/4579#top
sentrivanahttps://github.com/sentrivana
potel-basehttps://github.com/getsentry/sentry-python/tree/potel-base
ivana/potel/custom-sampling-context-test-casehttps://github.com/getsentry/sentry-python/tree/ivana/potel/custom-sampling-context-test-case
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
Jul 14, 2025https://github.com/getsentry/sentry-python/pull/4579#issue-3228563955
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/4579
https://github.com/sentrivana
Add custom sampling context testcaseshttps://github.com/getsentry/sentry-python/pull/4579/commits/4a8dbe37e8256ab65f0f871e8aa49bfa5a7f383a
4a8dbe3https://github.com/getsentry/sentry-python/pull/4579/commits/4a8dbe37e8256ab65f0f871e8aa49bfa5a7f383a
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
code ownerhttps://github.com/getsentry/sentry-python/blob/17d866ae6b2a36b8f6d83188a6a74f4f3969182b/.github/CODEOWNERS#L1
July 14, 2025 12:18https://github.com/getsentry/sentry-python/pull/4579#event-18616908048
https://github.com/sentrivana
naminghttps://github.com/getsentry/sentry-python/pull/4579/commits/64bcb8708471d6db59d438e52b0ee2db20d90208
64bcb87https://github.com/getsentry/sentry-python/pull/4579/commits/64bcb8708471d6db59d438e52b0ee2db20d90208
https://github.com/sl0thentr0py
sl0thentr0pyhttps://github.com/sl0thentr0py
Jul 14, 2025 https://github.com/getsentry/sentry-python/pull/4579#pullrequestreview-3016123882
View reviewed changes https://github.com/getsentry/sentry-python/pull/4579/files/64bcb8708471d6db59d438e52b0ee2db20d90208
https://github.com/sentrivana
cleanuphttps://github.com/getsentry/sentry-python/pull/4579/commits/e60fad47adb71edd7099f132ccf698780e02b5f8
e60fad4https://github.com/getsentry/sentry-python/pull/4579/commits/e60fad47adb71edd7099f132ccf698780e02b5f8
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
f8d88bbhttps://github.com/getsentry/sentry-python/commit/f8d88bbce8038ac9b3fe2d95f88544f844e91106
Jul 14, 2025https://github.com/getsentry/sentry-python/pull/4579#event-18617093522
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
July 14, 2025 12:27https://github.com/getsentry/sentry-python/pull/4579#event-18617094000
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
Jul 14, 2025 https://github.com/getsentry/sentry-python/pull/4579#ref-pullrequest-2344614538
POtel implementation base branch (aka SDK 3.0.0) #3152 https://github.com/getsentry/sentry-python/pull/3152
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jul 14, 2025https://github.com/getsentry/sentry-python/pull/4579#issuecomment-3069349393
Codecovhttps://app.codecov.io/gh/getsentry/sentry-python/pull/4579?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry
(17d866a)https://app.codecov.io/gh/getsentry/sentry-python/commit/17d866ae6b2a36b8f6d83188a6a74f4f3969182b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry
(e60fad4)https://app.codecov.io/gh/getsentry/sentry-python/commit/e60fad47adb71edd7099f132ccf698780e02b5f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry
see 1 file with indirect coverage changeshttps://app.codecov.io/gh/getsentry/sentry-python/pull/4579/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/4579
https://github.com/BYK
BYKhttps://github.com/BYK
Sep 3, 2025 https://github.com/getsentry/sentry-python/pull/4579#ref-pullrequest-3379689704
breaking: Remove Spotlight Django integration #4747 https://github.com/getsentry/sentry-python/pull/4747
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F4579
https://github.com/sl0thentr0py
sl0thentr0py https://github.com/sl0thentr0py
https://github.com/getsentry/sentry-python/pull/4579/files/64bcb8708471d6db59d438e52b0ee2db20d90208
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/4579
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/4579
https://github.com/sentrivana
https://github.com/sl0thentr0py
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.