René's URL Explorer Experiment


Title: Respect parent_sampled decision in propagation_context sentry-trace header by sl0thentr0py · Pull Request #4356 · getsentry/sentry-python · GitHub

Open Graph Title: Respect parent_sampled decision in propagation_context sentry-trace header by sl0thentr0py · Pull Request #4356 · getsentry/sentry-python

X Title: Respect parent_sampled decision in propagation_context sentry-trace header by sl0thentr0py · Pull Request #4356 · getsentry/sentry-python

Description: Since we don't automatically have unsampled spans running, this caused a change in behavior when an upstream sampling decision needs to be propagated further downstream. Explanation of problem When an incoming trace has sampled set to 0 (trace_id-span_id-0), in the past we would propagate this since we would have an active span/transaction running but just not sampled, so downstream would also receive trace_id-span_id-0 from that active span. Now, we actually don't have an active span since we don't sample (just how otel works), so instead of sending the trace_id-span_id-0 as before, we would have sent trace_id-other_span_id from the propagation_context instead. This would cause the downstream service to not receive the -0 flag and would thus sample independently, which is a regression.

Open Graph Description: Since we don't automatically have unsampled spans running, this caused a change in behavior when an upstream sampling decision needs to be propagated further downstream. Explanation of problem ...

X Description: Since we don't automatically have unsampled spans running, this caused a change in behavior when an upstream sampling decision needs to be propagated further downstream. Explanation of prob...

Opengraph URL: https://github.com/getsentry/sentry-python/pull/4356

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a336c6bb-1f2a-55c8-3018-3286fff54d77
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9616:F7C4C:4F2828:6C18E6:6B00D050
html-safe-nonce249382327a19687b13098eb66d0634e67c23e68a7a4bacf659215128f2b7b35f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjE2OkY3QzRDOjRGMjgyODo2QzE4RTY6NkIwMEQwNTAiLCJ2aXNpdG9yX2lkIjoiOTEzNDQ3NTA3MTg0NTM1NTYwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd63c2134f43d91ffe67d8a9a82324dc35f50235b9a9d082d63352ded9fd3a25c
hovercard-subject-tagpull_request:2495681792
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/getsentry/sentry-python/pull/4356/files
twitter:imagehttps://avatars.githubusercontent.com/u/6536764?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6536764?s=400&v=4
og:image:altSince we don't automatically have unsampled spans running, this caused a change in behavior when an upstream sampling decision needs to be propagated further downstream. Explanation of problem ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None85bbdfe2b6ba16e234513bc6ceff5d848ef8449820c900692a2b4e67061931e5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4943239a6d2c591325dad6e5c313e1cafda877f6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/4356/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F4356%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F4356%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/4356/files
Reloadhttps://github.com/getsentry/sentry-python/pull/4356/files
Reloadhttps://github.com/getsentry/sentry-python/pull/4356/files
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
sl0thentr0pyhttps://github.com/sl0thentr0py
potel-basehttps://github.com/getsentry/sentry-python/tree/potel-base
neel/fix-prop-context-traceparenthttps://github.com/getsentry/sentry-python/tree/neel/fix-prop-context-traceparent
Conversation 2 https://github.com/getsentry/sentry-python/pull/4356
Commits 2 https://github.com/getsentry/sentry-python/pull/4356/commits
Checks 0 https://github.com/getsentry/sentry-python/pull/4356/checks
Files changed https://github.com/getsentry/sentry-python/pull/4356/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/4356/files
Respect parent_sampled decision in propagation_context sentry-trace header https://github.com/getsentry/sentry-python/pull/4356/files#top
Show all changes 2 commits https://github.com/getsentry/sentry-python/pull/4356/files
01f4ceb Add logger.debug for sampler decisions for root spans sl0thentr0py May 2, 2025 https://github.com/getsentry/sentry-python/pull/4356/commits/01f4ceb2f7feafd440ecf2da33f80af77224d204
454cafd Respect parent_sampled decision in propagation_context sentry-trace h… sl0thentr0py May 2, 2025 https://github.com/getsentry/sentry-python/pull/4356/commits/454cafd7d9f32fd8885417cd976421a5632166ef
Clear filters https://github.com/getsentry/sentry-python/pull/4356/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/4356/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/4356/files
sampler.py https://github.com/getsentry/sentry-python/pull/4356/files#diff-ef184bb5bba74385bb8d68aae99dab8541769ec94efa3293e6fe78ce2f115384
scope.py https://github.com/getsentry/sentry-python/pull/4356/files#diff-c935006d78056bc518dd6e898d31d972c130c63119df74edf122e2cf4a5733bc
tracing_utils.py https://github.com/getsentry/sentry-python/pull/4356/files#diff-7c64294459f5053c93d44e0e33e4e73ffcef0adefcd77ba91f4031aa461a8c42
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
sentry_sdk/opentelemetry/sampler.pyhttps://github.com/getsentry/sentry-python/pull/4356/files#diff-ef184bb5bba74385bb8d68aae99dab8541769ec94efa3293e6fe78ce2f115384
View file https://github.com/getsentry/sentry-python/blob/454cafd7d9f32fd8885417cd976421a5632166ef/sentry_sdk/opentelemetry/sampler.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/4356/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/4356/files#diff-ef184bb5bba74385bb8d68aae99dab8541769ec94efa3293e6fe78ce2f115384
https://github.com/getsentry/sentry-python/pull/4356/files#diff-ef184bb5bba74385bb8d68aae99dab8541769ec94efa3293e6fe78ce2f115384
https://github.com/getsentry/sentry-python/pull/4356/files#diff-ef184bb5bba74385bb8d68aae99dab8541769ec94efa3293e6fe78ce2f115384
https://github.com/getsentry/sentry-python/pull/4356/files#diff-ef184bb5bba74385bb8d68aae99dab8541769ec94efa3293e6fe78ce2f115384
https://github.com/getsentry/sentry-python/pull/4356/files#diff-ef184bb5bba74385bb8d68aae99dab8541769ec94efa3293e6fe78ce2f115384
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
sentry_sdk/scope.pyhttps://github.com/getsentry/sentry-python/pull/4356/files#diff-c935006d78056bc518dd6e898d31d972c130c63119df74edf122e2cf4a5733bc
View file https://github.com/getsentry/sentry-python/blob/454cafd7d9f32fd8885417cd976421a5632166ef/sentry_sdk/scope.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/4356/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/4356/files#diff-c935006d78056bc518dd6e898d31d972c130c63119df74edf122e2cf4a5733bc
https://github.com/getsentry/sentry-python/pull/4356/files#diff-c935006d78056bc518dd6e898d31d972c130c63119df74edf122e2cf4a5733bc
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
sentry_sdk/tracing_utils.pyhttps://github.com/getsentry/sentry-python/pull/4356/files#diff-7c64294459f5053c93d44e0e33e4e73ffcef0adefcd77ba91f4031aa461a8c42
View file https://github.com/getsentry/sentry-python/blob/454cafd7d9f32fd8885417cd976421a5632166ef/sentry_sdk/tracing_utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/4356/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/4356/files#diff-7c64294459f5053c93d44e0e33e4e73ffcef0adefcd77ba91f4031aa461a8c42
https://github.com/getsentry/sentry-python/pull/4356/files#diff-7c64294459f5053c93d44e0e33e4e73ffcef0adefcd77ba91f4031aa461a8c42
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.