| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:595fc55a-dbdb-9879-ed03-d3cc9794bec8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C588:2F4BD9:36EB2F:4A9305:6B00C5F7 |
| html-safe-nonce | 29471fb3d8b95ddc8fe330e070d6e5c26f3271f9e9e96b8393093d79c572b790 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTg4OjJGNEJEOTozNkVCMkY6NEE5MzA1OjZCMDBDNUY3IiwidmlzaXRvcl9pZCI6IjUzNTIxMjkzODQwOTY1MTU1NzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5fd1a9eec0c846030fd9589797e4b65a516f0c7454b162b71d3ff2dcd0ce6152 |
| hovercard-subject-tag | pull_request:2453022689 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/getsentry/sentry-python/pull/4281/files |
| twitter:image | https://avatars.githubusercontent.com/u/202325?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/202325?s=400&v=4 |
| og:image:alt | It is possible to leak data from started threads into the main thread via the scopes. (Because the same scope object from the main thread could be changed in the started thread.)
This change always... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 98dc00e171c204462a6f367482a0f8c3c6b5dbca99cd7390e82d2df49ce096e4 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git |
| octolytics-dimension-user_id | 1396951 |
| octolytics-dimension-user_login | getsentry |
| octolytics-dimension-repository_id | 137814779 |
| octolytics-dimension-repository_nwo | getsentry/sentry-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 137814779 |
| octolytics-dimension-repository_network_root_nwo | getsentry/sentry-python |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ef013399cf0a3c324bea644a685d7c1e0f06b5b7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/getsentry/sentry-python/pull/4281/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F4281%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F4281%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=getsentry%2Fsentry-python |
| Reload | https://github.com/getsentry/sentry-python/pull/4281/files |
| Reload | https://github.com/getsentry/sentry-python/pull/4281/files |
| Reload | https://github.com/getsentry/sentry-python/pull/4281/files |
| getsentry | https://github.com/getsentry |
| sentry-python | https://github.com/getsentry/sentry-python |
| Code | https://github.com/getsentry/sentry-python |
| Issues345 (345) | https://github.com/getsentry/sentry-python/issues |
| Pull requests42 (42) | https://github.com/getsentry/sentry-python/pulls |
| Discussions | https://github.com/getsentry/sentry-python/discussions |
| Actions | https://github.com/getsentry/sentry-python/actions |
| Security and quality2 (2) | https://github.com/getsentry/sentry-python/security |
| Insights | https://github.com/getsentry/sentry-python/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose |
| antonpirker | https://github.com/antonpirker |
| master | https://github.com/getsentry/sentry-python/tree/master |
| antonpirker/threading-tests | https://github.com/getsentry/sentry-python/tree/antonpirker/threading-tests |
|
Conversation
9
| https://github.com/getsentry/sentry-python/pull/4281 |
|
Commits
36
| https://github.com/getsentry/sentry-python/pull/4281/commits |
|
Checks
0
| https://github.com/getsentry/sentry-python/pull/4281/checks |
|
Files changed
| https://github.com/getsentry/sentry-python/pull/4281/files |
| Please reload this page | https://github.com/getsentry/sentry-python/pull/4281/files |
|
fix: Data leak in ThreadingIntegration between threads
| https://github.com/getsentry/sentry-python/pull/4281/files#top |
|
Show all changes
36 commits
| https://github.com/getsentry/sentry-python/pull/4281/files |
|
7d14008
Some test showing trx in trx is a bad idea
antonpirker Apr 11, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/7d14008477fff7a2f580c8cf951e456c54217a4d |
|
9c35e83
test that shows we are leaking scope changes
antonpirker Apr 11, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/9c35e83a91ed5c9ce42a7fb4ee0a41bdaaca2291 |
|
664f0e0
remove flaky tests, it does more harm then it helps
antonpirker Apr 11, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/664f0e08306cfad1eca435cd995c1160b4c48f3e |
|
0d9a221
better readability
antonpirker Apr 11, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/0d9a2214f4386519ab6b7d854ecd71f30beb0f27 |
|
0100bdb
better readable
antonpirker Apr 11, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/0100bdb6e8f7f721dc4fbc20827df3f3edfdcc39 |
|
bd44959
Propagate a copy of the scopes to threads
antonpirker Apr 11, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/bd449590ee6107dc071fa2f68d6030afb75a1b84 |
|
0e92608
More tests
antonpirker Apr 11, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/0e92608f230914105a284aace037eefa6b20e2fb |
|
fd69f64
better span names
antonpirker Apr 11, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/fd69f64331f011ad69cbfc38961c0eff90794bb0 |
|
e4d94a5
what is happening?
antonpirker Apr 11, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/e4d94a5917931b0d6911281abfce8ab8a4b6d5da |
|
c7af4b9
back to forking
antonpirker Apr 11, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/c7af4b9171472e92f1da343a426282cbd668c617 |
|
678f515
trigger ci
antonpirker Apr 14, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/678f515a9175063ff37a24c0d4a6c898ca45d2ae |
|
eef7ff6
trying without new tests
antonpirker Apr 14, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/eef7ff6538b5f234352d14b0cf0efff27136b607 |
|
518dc04
Revert all the changes
antonpirker Apr 14, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/518dc04865c0666840da24699ec2f7e892787374 |
|
24ea433
Trying somethign
antonpirker Apr 14, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/24ea43378a7aac0a3ad1d43a647685de925354c7 |
|
0d5b3fb
Reenable tests
antonpirker Apr 14, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/0d5b3fbc8adee1d2a34108156d4b9b73e5711540 |
|
d3585a3
cleanup
antonpirker Apr 14, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/d3585a32aff08370219dd67d26b6906bd5505a51 |
|
5bcba35
trying test forking
antonpirker Apr 14, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/5bcba35ca6a43cc98464c46feb066f34607d0785 |
|
4c2f7d9
Removed some stuff again
antonpirker Apr 14, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/4c2f7d93c1c125ef09516c8459eecc7e20c86b43 |
|
890640f
commented wrong lines
antonpirker Apr 14, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/890640f1debf9765da8013f43c6609d4c1d9ebda |
|
957d7bb
does it work in django 3.0?
antonpirker Apr 14, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/957d7bb4c17b38dccae3be4f92c1ded395c5bfab |
|
07d44c9
no channels in django 3.0
antonpirker Apr 14, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/07d44c910e32d074fd5322cc0a72ee2daaa446da |
|
2a2cde1
trying without channels
antonpirker Apr 14, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/2a2cde194527e13222eafa2bbb773b216e600a41 |
|
8cd789b
No channels for newer Django versions
antonpirker Apr 14, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/8cd789b0d61350e15428a81f10463859d8578cbf |
|
6982479
Warning
antonpirker Apr 14, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/6982479882b00bd1b554a132065606985741d94e |
|
3b85ef4
Better error message
antonpirker Apr 15, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/3b85ef4c2bb433b166b5765518933bcfe0227ab5 |
|
e783af9
.
antonpirker Apr 15, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/e783af9c7263e600a52bff465407130f4832b1d7 |
|
160e430
checking for warning
antonpirker Apr 15, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/160e430d6c7ed13be40c81d8a9b69fa352c79dd1 |
|
8cd1584
Merge branch 'master' into antonpirker/threading-tests
antonpirker Apr 15, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/8cd158450b389b0122363178b127eac022c74033 |
|
9aad099
linting
antonpirker Apr 15, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/9aad0995a0e85cd1ba7c9ff640adaa6c9af3f48d |
|
0da1c2e
explanation
antonpirker Apr 15, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/0da1c2eee99702223f511c7ffb660f3493d0a693 |
|
096579e
Revert tox to version in master
antonpirker Apr 15, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/096579e4bf9b00578124b9dacae6069da5b4b1ea |
|
33d9f3d
Merge branch 'master' into antonpirker/threading-tests
antonpirker Apr 15, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/33d9f3d6614c0410452a07fe81b16f6f2f8b00eb |
|
815e930
Better checks and importing only once
antonpirker Apr 15, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/815e930f49359a2fff24b0c6ed5ad27f02a89d4a |
|
5d306ee
Merge branch 'antonpirker/threading-tests' of github.com:getsentry/se…
antonpirker Apr 15, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/5d306eee68c8b378007c3c79b639f0cf438a67b0 |
|
8aa5edf
Better check
antonpirker Apr 15, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/8aa5edfaf43d18414b6b722027df16150131889d |
|
ca8aa30
Merge branch 'master' into antonpirker/threading-tests
antonpirker Apr 15, 2025
| https://github.com/getsentry/sentry-python/pull/4281/commits/ca8aa30c54d6f1668336ff5146574a0def4d42b5 |
|
Clear filters
| https://github.com/getsentry/sentry-python/pull/4281/files |
| Please reload this page | https://github.com/getsentry/sentry-python/pull/4281/files |
| Please reload this page | https://github.com/getsentry/sentry-python/pull/4281/files |
|
threading.py
| https://github.com/getsentry/sentry-python/pull/4281/files#diff-0b1ea412615fb9f2383679598c1dce3757fd2d2421524ddc6678b2d8e2a9add9 |
|
test_asgi.py
| https://github.com/getsentry/sentry-python/pull/4281/files#diff-d25227399f4a56d115c5c7bd50be40a62705595aa4c206b23177b97b89abf893 |
|
test_threading.py
| https://github.com/getsentry/sentry-python/pull/4281/files#diff-05ef905985071594481e064ccf4a7371dd2513a786877db328cbdd6305c7ab8f |
|
| https://github.com/getsentry/sentry-python/blob/master/.github/CODEOWNERS#L1 |
| sentry_sdk/integrations/threading.py | https://github.com/getsentry/sentry-python/pull/4281/files#diff-0b1ea412615fb9f2383679598c1dce3757fd2d2421524ddc6678b2d8e2a9add9 |
|
View file
| https://github.com/getsentry/sentry-python/blob/ca8aa30c54d6f1668336ff5146574a0def4d42b5/sentry_sdk/integrations/threading.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/getsentry/sentry-python/pull/4281/{{ revealButtonHref }} |
|
| https://github.com/getsentry/sentry-python/pull/4281/files#diff-0b1ea412615fb9f2383679598c1dce3757fd2d2421524ddc6678b2d8e2a9add9 |
|
| https://github.com/getsentry/sentry-python/pull/4281/files#diff-0b1ea412615fb9f2383679598c1dce3757fd2d2421524ddc6678b2d8e2a9add9 |
|
| https://github.com/getsentry/sentry-python/pull/4281/files#diff-0b1ea412615fb9f2383679598c1dce3757fd2d2421524ddc6678b2d8e2a9add9 |
| sentrivana | https://github.com/sentrivana |
| Apr 15, 2025 | https://github.com/getsentry/sentry-python/pull/4281/files#r2044134038 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/getsentry/sentry-python/pull/4281/files |
| antonpirker | https://github.com/antonpirker |
| Apr 15, 2025 | https://github.com/getsentry/sentry-python/pull/4281/files#r2044167997 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/getsentry/sentry-python/pull/4281/files |
| sentrivana | https://github.com/sentrivana |
| Apr 15, 2025 | https://github.com/getsentry/sentry-python/pull/4281/files#r2044201850 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/getsentry/sentry-python/pull/4281/files |
| antonpirker | https://github.com/antonpirker |
| Apr 15, 2025 | https://github.com/getsentry/sentry-python/pull/4281/files#r2044207846 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/getsentry/sentry-python/pull/4281/files |
|
| https://github.com/getsentry/sentry-python/pull/4281/files#diff-0b1ea412615fb9f2383679598c1dce3757fd2d2421524ddc6678b2d8e2a9add9 |
|
| https://github.com/getsentry/sentry-python/blob/master/.github/CODEOWNERS#L1 |
| tests/integrations/django/asgi/test_asgi.py | https://github.com/getsentry/sentry-python/pull/4281/files#diff-d25227399f4a56d115c5c7bd50be40a62705595aa4c206b23177b97b89abf893 |
|
View file
| https://github.com/getsentry/sentry-python/blob/ca8aa30c54d6f1668336ff5146574a0def4d42b5/tests/integrations/django/asgi/test_asgi.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/getsentry/sentry-python/pull/4281/{{ revealButtonHref }} |
|
| https://github.com/getsentry/sentry-python/pull/4281/files#diff-d25227399f4a56d115c5c7bd50be40a62705595aa4c206b23177b97b89abf893 |
|
| https://github.com/getsentry/sentry-python/pull/4281/files#diff-d25227399f4a56d115c5c7bd50be40a62705595aa4c206b23177b97b89abf893 |
|
| https://github.com/getsentry/sentry-python/blob/master/.github/CODEOWNERS#L1 |
| tests/integrations/threading/test_threading.py | https://github.com/getsentry/sentry-python/pull/4281/files#diff-05ef905985071594481e064ccf4a7371dd2513a786877db328cbdd6305c7ab8f |
|
View file
| https://github.com/getsentry/sentry-python/blob/ca8aa30c54d6f1668336ff5146574a0def4d42b5/tests/integrations/threading/test_threading.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/getsentry/sentry-python/pull/4281/{{ revealButtonHref }} |
|
| https://github.com/getsentry/sentry-python/pull/4281/files#diff-05ef905985071594481e064ccf4a7371dd2513a786877db328cbdd6305c7ab8f |
|
| https://github.com/getsentry/sentry-python/pull/4281/files#diff-05ef905985071594481e064ccf4a7371dd2513a786877db328cbdd6305c7ab8f |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |