René's URL Explorer Experiment


Title: Extract span attrs from RQ job object & fix tests by sentrivana · Pull Request #3786 · getsentry/sentry-python · GitHub

Open Graph Title: Extract span attrs from RQ job object & fix tests by sentrivana · Pull Request #3786 · getsentry/sentry-python

X Title: Extract span attrs from RQ job object & fix tests by sentrivana · Pull Request #3786 · getsentry/sentry-python

Description: replace rq_job with some span attrs to populate the sampling context in traces sampler make test_rq pass do not use generic op like message if we already explicitly set op This is not great since we have to serialize everything (args, kwargs, function to be executed). But it's the best we can do with span attrs.

Open Graph Description: replace rq_job with some span attrs to populate the sampling context in traces sampler make test_rq pass do not use generic op like message if we already explicitly set op This is not great since ...

X Description: replace rq_job with some span attrs to populate the sampling context in traces sampler make test_rq pass do not use generic op like message if we already explicitly set op This is not great since ...

Opengraph URL: https://github.com/getsentry/sentry-python/pull/3786

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:af544934-d10a-a06a-f96f-8820acd33b22
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC18E:EA06E:608C0F:7E6260:6B00CE42
html-safe-nonce3a0631dfe7509e270b8d9fb2d7483039bd80025205798d577e6929b8bb6984b6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMThFOkVBMDZFOjYwOEMwRjo3RTYyNjA6NkIwMENFNDIiLCJ2aXNpdG9yX2lkIjoiMzA4NTY2MDg4NzAwMDg2MjI3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5337372ce4f6cc4caf94365fbeb4cc7cd605eb827418259b8915dcac02a148f0
hovercard-subject-tagpull_request:2181847379
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/getsentry/sentry-python/pull/3786/files
twitter:imagehttps://avatars.githubusercontent.com/u/131587164?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/131587164?s=400&v=4
og:image:altreplace rq_job with some span attrs to populate the sampling context in traces sampler make test_rq pass do not use generic op like message if we already explicitly set op This is not great since ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None85bbdfe2b6ba16e234513bc6ceff5d848ef8449820c900692a2b4e67061931e5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4943239a6d2c591325dad6e5c313e1cafda877f6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/3786/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F3786%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F3786%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/3786/files
Reloadhttps://github.com/getsentry/sentry-python/pull/3786/files
Reloadhttps://github.com/getsentry/sentry-python/pull/3786/files
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
sentrivanahttps://github.com/sentrivana
potel-basehttps://github.com/getsentry/sentry-python/tree/potel-base
ivana/potel/custom-sampling-context-rqhttps://github.com/getsentry/sentry-python/tree/ivana/potel/custom-sampling-context-rq
Conversation 3 https://github.com/getsentry/sentry-python/pull/3786
Commits 9 https://github.com/getsentry/sentry-python/pull/3786/commits
Checks 0 https://github.com/getsentry/sentry-python/pull/3786/checks
Files changed https://github.com/getsentry/sentry-python/pull/3786/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3786/files
Extract span attrs from RQ job object & fix tests https://github.com/getsentry/sentry-python/pull/3786/files#top
Show all changes 9 commits https://github.com/getsentry/sentry-python/pull/3786/files
8a9da80 start sentrivana Nov 15, 2024 https://github.com/getsentry/sentry-python/pull/3786/commits/8a9da8033cda73a7417cbf623609e21dcefaa6b6
7376a7f Merge branch 'potel-base' into ivana/potel/custom-sampling-context-rq sentrivana Nov 18, 2024 https://github.com/getsentry/sentry-python/pull/3786/commits/7376a7f05b529f1463b36a1f8b0b54d17c0ef049
ddb05b2 Merge branch 'potel-base' into ivana/potel/custom-sampling-context-rq sentrivana Nov 20, 2024 https://github.com/getsentry/sentry-python/pull/3786/commits/ddb05b278bd5d483b473089f58f28505a01b13bb
df95074 . sentrivana Nov 21, 2024 https://github.com/getsentry/sentry-python/pull/3786/commits/df95074498f78b9623ccef153381ab1cc28a6885
cf54da0 . sentrivana Nov 21, 2024 https://github.com/getsentry/sentry-python/pull/3786/commits/cf54da0a0982e21eb6651cf417dd4a0ac2c95823
d4fd755 . sentrivana Nov 21, 2024 https://github.com/getsentry/sentry-python/pull/3786/commits/d4fd7551f7e29e63c29fda231a15e2b1f6b4063d
d0377c1 . sentrivana Nov 21, 2024 https://github.com/getsentry/sentry-python/pull/3786/commits/d0377c14735940690bedd8bf70979aa3abba984b
b72844a Merge branch 'potel-base' into ivana/potel/custom-sampling-context-rq sentrivana Nov 21, 2024 https://github.com/getsentry/sentry-python/pull/3786/commits/b72844afba420bf29bb4dc9f150faa2f71b7f44f
621b856 migration guide sentrivana Nov 21, 2024 https://github.com/getsentry/sentry-python/pull/3786/commits/621b8564fa8ff57900f744af50df2e356741a2af
Clear filters https://github.com/getsentry/sentry-python/pull/3786/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3786/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3786/files
MIGRATION_GUIDE.md https://github.com/getsentry/sentry-python/pull/3786/files#diff-45651f4c3460b0f20be048556615842a07ec86d262fe5d3d346b5e4a9ce56d6a
potel_span_processor.py https://github.com/getsentry/sentry-python/pull/3786/files#diff-59b422d7cd5ecd8dbb3b5807ea60246f5840ed5f4d9594d324c06f860545d85e
utils.py https://github.com/getsentry/sentry-python/pull/3786/files#diff-098bd930fca510a54bd7d50fc04d8d962141b80c9c2cf654d0eee73e0bc9bab3
rq.py https://github.com/getsentry/sentry-python/pull/3786/files#diff-2ad737333882fadd22dca252f9159daa9560a2107827749f583728c61544cf90
test_rq.py https://github.com/getsentry/sentry-python/pull/3786/files#diff-9074243ce4b40e9134339688306dc4603d09f4deeb8a25135b17ef0165205466
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
MIGRATION_GUIDE.mdhttps://github.com/getsentry/sentry-python/pull/3786/files#diff-45651f4c3460b0f20be048556615842a07ec86d262fe5d3d346b5e4a9ce56d6a
View file https://github.com/getsentry/sentry-python/blob/621b8564fa8ff57900f744af50df2e356741a2af/MIGRATION_GUIDE.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3786/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3786/files#diff-45651f4c3460b0f20be048556615842a07ec86d262fe5d3d346b5e4a9ce56d6a
https://github.com/getsentry/sentry-python/pull/3786/files#diff-45651f4c3460b0f20be048556615842a07ec86d262fe5d3d346b5e4a9ce56d6a
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
sentry_sdk/integrations/opentelemetry/potel_span_processor.pyhttps://github.com/getsentry/sentry-python/pull/3786/files#diff-59b422d7cd5ecd8dbb3b5807ea60246f5840ed5f4d9594d324c06f860545d85e
View file https://github.com/getsentry/sentry-python/blob/621b8564fa8ff57900f744af50df2e356741a2af/sentry_sdk/integrations/opentelemetry/potel_span_processor.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3786/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3786/files#diff-59b422d7cd5ecd8dbb3b5807ea60246f5840ed5f4d9594d324c06f860545d85e
https://github.com/getsentry/sentry-python/pull/3786/files#diff-59b422d7cd5ecd8dbb3b5807ea60246f5840ed5f4d9594d324c06f860545d85e
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
sentry_sdk/integrations/opentelemetry/utils.pyhttps://github.com/getsentry/sentry-python/pull/3786/files#diff-098bd930fca510a54bd7d50fc04d8d962141b80c9c2cf654d0eee73e0bc9bab3
View file https://github.com/getsentry/sentry-python/blob/621b8564fa8ff57900f744af50df2e356741a2af/sentry_sdk/integrations/opentelemetry/utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3786/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3786/files#diff-098bd930fca510a54bd7d50fc04d8d962141b80c9c2cf654d0eee73e0bc9bab3
https://github.com/getsentry/sentry-python/pull/3786/files#diff-098bd930fca510a54bd7d50fc04d8d962141b80c9c2cf654d0eee73e0bc9bab3
https://github.com/getsentry/sentry-python/pull/3786/files#diff-098bd930fca510a54bd7d50fc04d8d962141b80c9c2cf654d0eee73e0bc9bab3
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
sentry_sdk/integrations/rq.pyhttps://github.com/getsentry/sentry-python/pull/3786/files#diff-2ad737333882fadd22dca252f9159daa9560a2107827749f583728c61544cf90
View file https://github.com/getsentry/sentry-python/blob/621b8564fa8ff57900f744af50df2e356741a2af/sentry_sdk/integrations/rq.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3786/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3786/files#diff-2ad737333882fadd22dca252f9159daa9560a2107827749f583728c61544cf90
https://github.com/getsentry/sentry-python/pull/3786/files#diff-2ad737333882fadd22dca252f9159daa9560a2107827749f583728c61544cf90
https://github.com/getsentry/sentry-python/pull/3786/files#diff-2ad737333882fadd22dca252f9159daa9560a2107827749f583728c61544cf90
https://github.com/getsentry/sentry-python/pull/3786/files#diff-2ad737333882fadd22dca252f9159daa9560a2107827749f583728c61544cf90
sentrivanahttps://github.com/sentrivana
Nov 21, 2024https://github.com/getsentry/sentry-python/pull/3786/files#r1852353741
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3786/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3786/files
https://github.com/getsentry/sentry-python/pull/3786/files#diff-2ad737333882fadd22dca252f9159daa9560a2107827749f583728c61544cf90
https://github.com/getsentry/sentry-python/pull/3786/files#diff-2ad737333882fadd22dca252f9159daa9560a2107827749f583728c61544cf90
https://github.com/getsentry/sentry-python/pull/3786/files#diff-2ad737333882fadd22dca252f9159daa9560a2107827749f583728c61544cf90
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
tests/integrations/rq/test_rq.pyhttps://github.com/getsentry/sentry-python/pull/3786/files#diff-9074243ce4b40e9134339688306dc4603d09f4deeb8a25135b17ef0165205466
View file https://github.com/getsentry/sentry-python/blob/621b8564fa8ff57900f744af50df2e356741a2af/tests/integrations/rq/test_rq.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3786/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3786/files#diff-9074243ce4b40e9134339688306dc4603d09f4deeb8a25135b17ef0165205466
https://github.com/getsentry/sentry-python/pull/3786/files#diff-9074243ce4b40e9134339688306dc4603d09f4deeb8a25135b17ef0165205466
https://github.com/getsentry/sentry-python/pull/3786/files#diff-9074243ce4b40e9134339688306dc4603d09f4deeb8a25135b17ef0165205466
https://github.com/getsentry/sentry-python/pull/3786/files#diff-9074243ce4b40e9134339688306dc4603d09f4deeb8a25135b17ef0165205466
https://github.com/getsentry/sentry-python/pull/3786/files#diff-9074243ce4b40e9134339688306dc4603d09f4deeb8a25135b17ef0165205466
https://github.com/getsentry/sentry-python/pull/3786/files#diff-9074243ce4b40e9134339688306dc4603d09f4deeb8a25135b17ef0165205466
https://github.com/getsentry/sentry-python/pull/3786/files#diff-9074243ce4b40e9134339688306dc4603d09f4deeb8a25135b17ef0165205466
https://github.com/getsentry/sentry-python/pull/3786/files#diff-9074243ce4b40e9134339688306dc4603d09f4deeb8a25135b17ef0165205466
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.