René's URL Explorer Experiment


Title: Use semantic attributes in traces sampler for ASGI spans by sentrivana · Pull Request #3774 · getsentry/sentry-python · GitHub

Open Graph Title: Use semantic attributes in traces sampler for ASGI spans by sentrivana · Pull Request #3774 · getsentry/sentry-python

X Title: Use semantic attributes in traces sampler for ASGI spans by sentrivana · Pull Request #3774 · getsentry/sentry-python

Description: Instead of just naming the new span attrs asgi_scope.{property}, use OTel's semantic attributes where appropriate

Open Graph Description: Instead of just naming the new span attrs asgi_scope.{property}, use OTel's semantic attributes where appropriate

X Description: Instead of just naming the new span attrs asgi_scope.{property}, use OTel's semantic attributes where appropriate

Opengraph URL: https://github.com/getsentry/sentry-python/pull/3774

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:393808ce-bde1-bc7c-ce21-11a48be70958
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9214:1AE20C:3A4EC0:4B633E:6B00D292
html-safe-nonce0a0984c27b27c0d89f06e0980ee77d21f7a70ab9fa3573f5d753b4ea659abb2c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjE0OjFBRTIwQzozQTRFQzA6NEI2MzNFOjZCMDBEMjkyIiwidmlzaXRvcl9pZCI6IjU3MTAyMDc5NTg2ODQ1ODY2NDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc43ea6961c43749921fe03143d871fb31e1ae47f932eb2da07c317214a6b27a8
hovercard-subject-tagpull_request:2179492486
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/getsentry/sentry-python/pull/3774/files
twitter:imagehttps://avatars.githubusercontent.com/u/131587164?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/131587164?s=400&v=4
og:image:altInstead of just naming the new span attrs asgi_scope.{property}, use OTel's semantic attributes where appropriate
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None85bbdfe2b6ba16e234513bc6ceff5d848ef8449820c900692a2b4e67061931e5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4943239a6d2c591325dad6e5c313e1cafda877f6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/3774/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F3774%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F3774%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/3774/files
Reloadhttps://github.com/getsentry/sentry-python/pull/3774/files
Reloadhttps://github.com/getsentry/sentry-python/pull/3774/files
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
sentrivanahttps://github.com/sentrivana
potel-basehttps://github.com/getsentry/sentry-python/tree/potel-base
ivana/custom-sampling-context-integrations-extra-stuffhttps://github.com/getsentry/sentry-python/tree/ivana/custom-sampling-context-integrations-extra-stuff
Conversation 2 https://github.com/getsentry/sentry-python/pull/3774
Commits 29 https://github.com/getsentry/sentry-python/pull/3774/commits
Checks 0 https://github.com/getsentry/sentry-python/pull/3774/checks
Files changed https://github.com/getsentry/sentry-python/pull/3774/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3774/files
Use semantic attributes in traces sampler for ASGI spans https://github.com/getsentry/sentry-python/pull/3774/files#top
Show all changes 29 commits https://github.com/getsentry/sentry-python/pull/3774/files
18103bc Remove custom_sampling_context sentrivana Nov 7, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/18103bcd0c81980eaa2bf647835ba0f10b6c4368
68402ff confusing wording sentrivana Nov 7, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/68402fff97e3f7b77aa07c58b45ae784200df912
70d02cc Merge branch 'potel-base' into ivana/sampling-context sentrivana Nov 7, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/70d02cc4032d4d41534027688766f989ecb51667
fa5d0ba keep old format (why not) sentrivana Nov 7, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/fa5d0ba76c57fde8d1498d2b2dc1ae1c674867a8
5df9ccc . sentrivana Nov 7, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/5df9ccc6336a513e11cdeb14c6339297c116eb0f
472ab5c add attrs sentrivana Nov 7, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/472ab5c23690fc7ae6cbd3c658654b36c8b31e1e
f893f12 . sentrivana Nov 7, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/f893f12a2deee3f5d6af89a767b92bb1d5a767e1
fff9f16 . sentrivana Nov 7, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/fff9f163cb4d94e9930d50530d2f5752f0aaae97
ce815e8 more removals sentrivana Nov 7, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/ce815e8ccee4d5940258b754bc13e16b432adf2f
d307fe1 Merge branch 'potel-base' into ivana/sampling-context sentrivana Nov 12, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/d307fe1c3ae7e904d4a2b6c312d7a3964165d7d9
747ecc6 more readme sentrivana Nov 12, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/747ecc6ca113fbf2d3b5488732c649c7c1dcdccc
7ae6745 more info sentrivana Nov 12, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/7ae6745076486ce851ce3375b75aa49869f7993a
09d247e comment sentrivana Nov 12, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/09d247ec3a1ffe1a96533efd1ba8014645513f5c
1aeeb68 small change sentrivana Nov 12, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/1aeeb68d7d3a00de82ea2dd60181eb8fd61d6ac2
786bb9e . sentrivana Nov 12, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/786bb9ea3ad3a8987734097c93e4854019bf09e7
80427c6 dont do everything in this pr sentrivana Nov 12, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/80427c6d4a304466c73b5897a1fcd0c74091dcd6
2acef08 get rid of none attributes sentrivana Nov 12, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/2acef08640fd3f15e0b429f423de3ea754cfa339
eb2df70 dropped result too sentrivana Nov 12, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/eb2df70b988c52fda9362181f0a965e1caffac4b
2cee373 Replace custom_sampling_context with attributes in ASGI sentrivana Nov 12, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/2cee3737a4ef7108ae653bcc04c5d90ad38e3cc2
f6fb9a9 add source too sentrivana Nov 12, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/f6fb9a91c704dae255fbb38fe61a0ec131362fe0
86c6373 Merge branch 'potel-base' into ivana/custom-sampling-context-integrat… sentrivana Nov 12, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/86c6373ef595fa995a10c637e3e603f8db7341b1
4002f38 fix starlette tests sentrivana Nov 12, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/4002f38e1383409c553c9e041179708e3c0a8726
dbc8ba2 fix fastapi sentrivana Nov 12, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/dbc8ba2eb79b404837fdec04683ee9e39a6a19c3
52f918a remove middleware spans toggle sentrivana Nov 13, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/52f918a997a0e77452e3ee1c0e822f60cbb347c8
6b063cf Merge branch 'potel-base' into ivana/custom-sampling-context-integrat… sentrivana Nov 13, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/6b063cf609717a70603761fba2aa9073a5e1dab1
f69b800 better attrs sentrivana Nov 13, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/f69b800fc3162120ba990be520a0a3b6a8cde586
2ed3860 rename sentrivana Nov 13, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/2ed3860b1c668d918636bfd15b011e493f14e52e
a684a7c Merge branch 'potel-base' into ivana/custom-sampling-context-integrat… sentrivana Nov 14, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/a684a7c31dbee73f00a7e5814946f2813981afbc
f674be1 Merge branch 'potel-base' into ivana/custom-sampling-context-integrat… sentrivana Nov 14, 2024 https://github.com/getsentry/sentry-python/pull/3774/commits/f674be18d0547d6506f0addf2bcd59861b07249f
Clear filters https://github.com/getsentry/sentry-python/pull/3774/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3774/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3774/files
MIGRATION_GUIDE.md https://github.com/getsentry/sentry-python/pull/3774/files#diff-45651f4c3460b0f20be048556615842a07ec86d262fe5d3d346b5e4a9ce56d6a
_asgi_common.py https://github.com/getsentry/sentry-python/pull/3774/files#diff-6cbfe16ca018eaec74a361ca83994486f9a680df7b9c0d13279f1c214406f36f
asgi.py https://github.com/getsentry/sentry-python/pull/3774/files#diff-f8ecdcad48bf089612dbfcc2ddc7bf66c39ce04ab4b036615e9c8ad74603a1c9
test_asgi.py https://github.com/getsentry/sentry-python/pull/3774/files#diff-a4ca49dac9c5fcce27a4fb5fb53e5f8e764b807773ba7c5476d70d74a9789353
test_fastapi.py https://github.com/getsentry/sentry-python/pull/3774/files#diff-9884f1a87d46827d199c87d41b5792f0877fa0d9e9234739ed65bb26826357be
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
MIGRATION_GUIDE.mdhttps://github.com/getsentry/sentry-python/pull/3774/files#diff-45651f4c3460b0f20be048556615842a07ec86d262fe5d3d346b5e4a9ce56d6a
View file https://github.com/getsentry/sentry-python/blob/f674be18d0547d6506f0addf2bcd59861b07249f/MIGRATION_GUIDE.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3774/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3774/files#diff-45651f4c3460b0f20be048556615842a07ec86d262fe5d3d346b5e4a9ce56d6a
https://github.com/getsentry/sentry-python/pull/3774/files#diff-45651f4c3460b0f20be048556615842a07ec86d262fe5d3d346b5e4a9ce56d6a
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
sentry_sdk/integrations/_asgi_common.pyhttps://github.com/getsentry/sentry-python/pull/3774/files#diff-6cbfe16ca018eaec74a361ca83994486f9a680df7b9c0d13279f1c214406f36f
View file https://github.com/getsentry/sentry-python/blob/f674be18d0547d6506f0addf2bcd59861b07249f/sentry_sdk/integrations/_asgi_common.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3774/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3774/files#diff-6cbfe16ca018eaec74a361ca83994486f9a680df7b9c0d13279f1c214406f36f
https://github.com/getsentry/sentry-python/pull/3774/files#diff-6cbfe16ca018eaec74a361ca83994486f9a680df7b9c0d13279f1c214406f36f
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
sentry_sdk/integrations/asgi.pyhttps://github.com/getsentry/sentry-python/pull/3774/files#diff-f8ecdcad48bf089612dbfcc2ddc7bf66c39ce04ab4b036615e9c8ad74603a1c9
View file https://github.com/getsentry/sentry-python/blob/f674be18d0547d6506f0addf2bcd59861b07249f/sentry_sdk/integrations/asgi.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3774/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3774/files#diff-f8ecdcad48bf089612dbfcc2ddc7bf66c39ce04ab4b036615e9c8ad74603a1c9
https://github.com/getsentry/sentry-python/pull/3774/files#diff-f8ecdcad48bf089612dbfcc2ddc7bf66c39ce04ab4b036615e9c8ad74603a1c9
https://github.com/getsentry/sentry-python/pull/3774/files#diff-f8ecdcad48bf089612dbfcc2ddc7bf66c39ce04ab4b036615e9c8ad74603a1c9
https://github.com/getsentry/sentry-python/pull/3774/files#diff-f8ecdcad48bf089612dbfcc2ddc7bf66c39ce04ab4b036615e9c8ad74603a1c9
https://github.com/getsentry/sentry-python/pull/3774/files#diff-f8ecdcad48bf089612dbfcc2ddc7bf66c39ce04ab4b036615e9c8ad74603a1c9
https://github.com/getsentry/sentry-python/pull/3774/files#diff-f8ecdcad48bf089612dbfcc2ddc7bf66c39ce04ab4b036615e9c8ad74603a1c9
https://github.com/getsentry/sentry-python/pull/3774/files#diff-f8ecdcad48bf089612dbfcc2ddc7bf66c39ce04ab4b036615e9c8ad74603a1c9
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
tests/integrations/asgi/test_asgi.pyhttps://github.com/getsentry/sentry-python/pull/3774/files#diff-a4ca49dac9c5fcce27a4fb5fb53e5f8e764b807773ba7c5476d70d74a9789353
View file https://github.com/getsentry/sentry-python/blob/f674be18d0547d6506f0addf2bcd59861b07249f/tests/integrations/asgi/test_asgi.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3774/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3774/files#diff-a4ca49dac9c5fcce27a4fb5fb53e5f8e764b807773ba7c5476d70d74a9789353
https://github.com/getsentry/sentry-python/pull/3774/files#diff-a4ca49dac9c5fcce27a4fb5fb53e5f8e764b807773ba7c5476d70d74a9789353
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
tests/integrations/fastapi/test_fastapi.pyhttps://github.com/getsentry/sentry-python/pull/3774/files#diff-9884f1a87d46827d199c87d41b5792f0877fa0d9e9234739ed65bb26826357be
View file https://github.com/getsentry/sentry-python/blob/f674be18d0547d6506f0addf2bcd59861b07249f/tests/integrations/fastapi/test_fastapi.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3774/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3774/files#diff-9884f1a87d46827d199c87d41b5792f0877fa0d9e9234739ed65bb26826357be
sentrivanahttps://github.com/sentrivana
Nov 14, 2024https://github.com/getsentry/sentry-python/pull/3774/files#r1842058865
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3774/files
https://github.com/getsentry/sentry-python/pull/3774/files#diff-9884f1a87d46827d199c87d41b5792f0877fa0d9e9234739ed65bb26826357be
https://github.com/getsentry/sentry-python/pull/3774/files#diff-9884f1a87d46827d199c87d41b5792f0877fa0d9e9234739ed65bb26826357be
https://github.com/getsentry/sentry-python/pull/3774/files#diff-9884f1a87d46827d199c87d41b5792f0877fa0d9e9234739ed65bb26826357be
https://github.com/getsentry/sentry-python/pull/3774/files#diff-9884f1a87d46827d199c87d41b5792f0877fa0d9e9234739ed65bb26826357be
https://github.com/getsentry/sentry-python/pull/3774/files#diff-9884f1a87d46827d199c87d41b5792f0877fa0d9e9234739ed65bb26826357be
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.