René's URL Explorer Experiment


Title: Sample on root span level by sentrivana · Pull Request #3767 · getsentry/sentry-python · GitHub

Open Graph Title: Sample on root span level by sentrivana · Pull Request #3767 · getsentry/sentry-python

X Title: Sample on root span level by sentrivana · Pull Request #3767 · getsentry/sentry-python

Description: for spans that have a local parent (i.e., non-root spans/transactions), just inherit the sampling decision from the parent update some tests Closes #3766

Open Graph Description: for spans that have a local parent (i.e., non-root spans/transactions), just inherit the sampling decision from the parent update some tests Closes #3766

X Description: for spans that have a local parent (i.e., non-root spans/transactions), just inherit the sampling decision from the parent update some tests Closes #3766

Opengraph URL: https://github.com/getsentry/sentry-python/pull/3767

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8ef6c85a-b15e-2853-c17a-5ce19e5a9708
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC11C:1F98:993A:D13A:6B00D284
html-safe-nonce4f1f62ca33da473b3ac578abd36b344785c3fc9cc9b70f347f8dc26a76c1b388
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTFDOjFGOTg6OTkzQTpEMTNBOjZCMDBEMjg0IiwidmlzaXRvcl9pZCI6IjYwODEwNzI2NjgwOTI3MTU2NTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4ec7ba2a48ff59b685a391272596bf9ba8140dead3c1ce3d4d253a0fe1e648ce
hovercard-subject-tagpull_request:2176817206
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/getsentry/sentry-python/pull/3767/files
twitter:imagehttps://avatars.githubusercontent.com/u/131587164?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/131587164?s=400&v=4
og:image:altfor spans that have a local parent (i.e., non-root spans/transactions), just inherit the sampling decision from the parent update some tests Closes #3766
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None85bbdfe2b6ba16e234513bc6ceff5d848ef8449820c900692a2b4e67061931e5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4943239a6d2c591325dad6e5c313e1cafda877f6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/3767/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F3767%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F3767%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/3767/files
Reloadhttps://github.com/getsentry/sentry-python/pull/3767/files
Reloadhttps://github.com/getsentry/sentry-python/pull/3767/files
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
sentrivanahttps://github.com/sentrivana
potel-basehttps://github.com/getsentry/sentry-python/tree/potel-base
ivana/potel/fix-samplerhttps://github.com/getsentry/sentry-python/tree/ivana/potel/fix-sampler
Conversation 8 https://github.com/getsentry/sentry-python/pull/3767
Commits 13 https://github.com/getsentry/sentry-python/pull/3767/commits
Checks 0 https://github.com/getsentry/sentry-python/pull/3767/checks
Files changed https://github.com/getsentry/sentry-python/pull/3767/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3767/files
Sample on root span level https://github.com/getsentry/sentry-python/pull/3767/files#top
Show all changes 13 commits https://github.com/getsentry/sentry-python/pull/3767/files
c017b01 Sample on root span level sentrivana Nov 13, 2024 https://github.com/getsentry/sentry-python/pull/3767/commits/c017b015f33ed28ed5d9842eea28f16f757ed6da
b47bc70 note sentrivana Nov 13, 2024 https://github.com/getsentry/sentry-python/pull/3767/commits/b47bc70b814f078b870ccc8c3fc4f7809e6473e7
1d77484 better wording sentrivana Nov 13, 2024 https://github.com/getsentry/sentry-python/pull/3767/commits/1d77484ea093b080bd13a72d5f533b0d6da11ec6
cefb27c reword and support parent_sampled sentrivana Nov 13, 2024 https://github.com/getsentry/sentry-python/pull/3767/commits/cefb27ca9af9e7cefc47e5d17c8101f0936389a2
3fcbf65 tests sentrivana Nov 13, 2024 https://github.com/getsentry/sentry-python/pull/3767/commits/3fcbf65005ab2344928099f2644746025eba8474
9600484 . sentrivana Nov 13, 2024 https://github.com/getsentry/sentry-python/pull/3767/commits/9600484725c330697609c5eb722f8058fe3f3cf5
69dfe92 remove, this is not a change afait sentrivana Nov 13, 2024 https://github.com/getsentry/sentry-python/pull/3767/commits/69dfe92ce655636ac0ca5ef173f06a3d32a19c45
1b8521b simplify sentrivana Nov 13, 2024 https://github.com/getsentry/sentry-python/pull/3767/commits/1b8521b66a6de4f26c0e3e57765864f6aed34fad
d9b7f71 remove parent_sampled sentrivana Nov 13, 2024 https://github.com/getsentry/sentry-python/pull/3767/commits/d9b7f7178344a45f635353e42748902591e46a26
8ae99c0 fix tests sentrivana Nov 13, 2024 https://github.com/getsentry/sentry-python/pull/3767/commits/8ae99c087874024b755c58ac39386f09602c5b9c
a11ff46 remove all parent_sampled stuff sentrivana Nov 13, 2024 https://github.com/getsentry/sentry-python/pull/3767/commits/a11ff463cdce702abfbdb8fc7b6969fcd9cbbf19
e6d1421 Merge branch 'potel-base' into ivana/potel/fix-sampler sentrivana Nov 13, 2024 https://github.com/getsentry/sentry-python/pull/3767/commits/e6d1421b3fe489670c8d83bcaa3953f428f7db5b
032a6c4 fix test sentrivana Nov 14, 2024 https://github.com/getsentry/sentry-python/pull/3767/commits/032a6c4fe4ede48d4d9b495001ca32df7bcc91a3
Clear filters https://github.com/getsentry/sentry-python/pull/3767/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3767/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3767/files
MIGRATION_GUIDE.md https://github.com/getsentry/sentry-python/pull/3767/files#diff-45651f4c3460b0f20be048556615842a07ec86d262fe5d3d346b5e4a9ce56d6a
sampler.py https://github.com/getsentry/sentry-python/pull/3767/files#diff-59aa7195d955e153b5cdd730f888994996a72eaf5e9ea174335ce961841584a9
test_sampling.py https://github.com/getsentry/sentry-python/pull/3767/files#diff-b51eab357bbfb00b250fe03b91239ec6bb40d7f11d4c0f22944f1b23d3d24fcc
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
MIGRATION_GUIDE.mdhttps://github.com/getsentry/sentry-python/pull/3767/files#diff-45651f4c3460b0f20be048556615842a07ec86d262fe5d3d346b5e4a9ce56d6a
View file https://github.com/getsentry/sentry-python/blob/032a6c4fe4ede48d4d9b495001ca32df7bcc91a3/MIGRATION_GUIDE.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3767/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3767/files#diff-45651f4c3460b0f20be048556615842a07ec86d262fe5d3d346b5e4a9ce56d6a
https://github.com/getsentry/sentry-python/pull/3767/files#diff-45651f4c3460b0f20be048556615842a07ec86d262fe5d3d346b5e4a9ce56d6a
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
sentry_sdk/integrations/opentelemetry/sampler.pyhttps://github.com/getsentry/sentry-python/pull/3767/files#diff-59aa7195d955e153b5cdd730f888994996a72eaf5e9ea174335ce961841584a9
View file https://github.com/getsentry/sentry-python/blob/032a6c4fe4ede48d4d9b495001ca32df7bcc91a3/sentry_sdk/integrations/opentelemetry/sampler.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3767/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3767/files#diff-59aa7195d955e153b5cdd730f888994996a72eaf5e9ea174335ce961841584a9
https://github.com/getsentry/sentry-python/pull/3767/files#diff-59aa7195d955e153b5cdd730f888994996a72eaf5e9ea174335ce961841584a9
https://github.com/getsentry/sentry-python/pull/3767/files#diff-59aa7195d955e153b5cdd730f888994996a72eaf5e9ea174335ce961841584a9
https://github.com/getsentry/sentry-python/pull/3767/files#diff-59aa7195d955e153b5cdd730f888994996a72eaf5e9ea174335ce961841584a9
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
tests/tracing/test_sampling.pyhttps://github.com/getsentry/sentry-python/pull/3767/files#diff-b51eab357bbfb00b250fe03b91239ec6bb40d7f11d4c0f22944f1b23d3d24fcc
View file https://github.com/getsentry/sentry-python/blob/032a6c4fe4ede48d4d9b495001ca32df7bcc91a3/tests/tracing/test_sampling.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3767/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3767/files#diff-b51eab357bbfb00b250fe03b91239ec6bb40d7f11d4c0f22944f1b23d3d24fcc
https://github.com/getsentry/sentry-python/pull/3767/files#diff-b51eab357bbfb00b250fe03b91239ec6bb40d7f11d4c0f22944f1b23d3d24fcc
https://github.com/getsentry/sentry-python/pull/3767/files#diff-b51eab357bbfb00b250fe03b91239ec6bb40d7f11d4c0f22944f1b23d3d24fcc
https://github.com/getsentry/sentry-python/pull/3767/files#diff-b51eab357bbfb00b250fe03b91239ec6bb40d7f11d4c0f22944f1b23d3d24fcc
https://github.com/getsentry/sentry-python/pull/3767/files#diff-b51eab357bbfb00b250fe03b91239ec6bb40d7f11d4c0f22944f1b23d3d24fcc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.