René's URL Explorer Experiment


Title: Sample on root span level by sentrivana · Pull Request #3767 · getsentry/sentry-python · GitHub

Open Graph Title: Sample on root span level by sentrivana · Pull Request #3767 · getsentry/sentry-python

X Title: Sample on root span level by sentrivana · Pull Request #3767 · getsentry/sentry-python

Description: The official Python SDK for Sentry.io. Contribute to getsentry/sentry-python development by creating an account on GitHub.

Open Graph Description: for spans that have a local parent (i.e., non-root spans/transactions), just inherit the sampling decision from the parent update some tests Closes #3766

X Description: for spans that have a local parent (i.e., non-root spans/transactions), just inherit the sampling decision from the parent update some tests Closes #3766

Opengraph URL: https://github.com/getsentry/sentry-python/pull/3767

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b880218b-9f05-49fe-6e5b-eda595df6051
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9FF0:3AE93F:847691:B04357:6B00B23E
html-safe-nonce19e02fc6aecfad53313a5631c3a83caa1e36c771238f2f3b3ce43b4a0072b8c9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkYwOjNBRTkzRjo4NDc2OTE6QjA0MzU3OjZCMDBCMjNFIiwidmlzaXRvcl9pZCI6IjM2Nzk4NTM0MzY1MzI2MTg4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6e8187ff967582aa840470e5ea0d0f91dff592762e68a85d9beb425fb3f144d1
hovercard-subject-tagpull_request:2176817206
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/getsentry/sentry-python/3767/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b791b3673f456383e89dc31a377e00acf39021dbe3ffefc4e908b7df35a2d42f/getsentry/sentry-python/pull/3767
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b791b3673f456383e89dc31a377e00acf39021dbe3ffefc4e908b7df35a2d42f/getsentry/sentry-python/pull/3767
og:image:altfor spans that have a local parent (i.e., non-root spans/transactions), just inherit the sampling decision from the parent update some tests Closes #3766
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesentrivana
hostnamegithub.com
expected-hostnamegithub.com
Nonec0dd5f5d6f515a591019ecd66df2c4eab3379c2d3b0777568a90d8c7ae10b79e
turbo-cache-controlno-cache
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release729d8cda69b3d267995675dfbf89ff27ccf61bf6
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/3767#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F3767
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F3767
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/3767
Reloadhttps://github.com/getsentry/sentry-python/pull/3767
Reloadhttps://github.com/getsentry/sentry-python/pull/3767
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
https://github.com/getsentry/sentry-python
sentrivanahttps://github.com/sentrivana
potel-basehttps://github.com/getsentry/sentry-python/tree/potel-base
ivana/potel/fix-samplerhttps://github.com/getsentry/sentry-python/tree/ivana/potel/fix-sampler
Conversationhttps://github.com/getsentry/sentry-python/pull/3767
Commits13 (13)https://github.com/getsentry/sentry-python/pull/3767/commits
Checkshttps://github.com/getsentry/sentry-python/pull/3767/checks
Files changedhttps://github.com/getsentry/sentry-python/pull/3767/files
Sample on root span levelhttps://github.com/getsentry/sentry-python/pull/3767#top
sentrivanahttps://github.com/sentrivana
potel-basehttps://github.com/getsentry/sentry-python/tree/potel-base
ivana/potel/fix-samplerhttps://github.com/getsentry/sentry-python/tree/ivana/potel/fix-sampler
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
Nov 13, 2024https://github.com/getsentry/sentry-python/pull/3767#issue-2654769834
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3767
#3766https://github.com/getsentry/sentry-python/issues/3766
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3767
sentrivanahttps://github.com/sentrivana
November 13, 2024 10:09https://github.com/getsentry/sentry-python/pull/3767#commits-pushed-c017b01
https://github.com/sentrivana
Sample on root span levelhttps://github.com/getsentry/sentry-python/pull/3767/commits/c017b015f33ed28ed5d9842eea28f16f757ed6da
c017b01https://github.com/getsentry/sentry-python/pull/3767/commits/c017b015f33ed28ed5d9842eea28f16f757ed6da
https://github.com/sentrivana
notehttps://github.com/getsentry/sentry-python/pull/3767/commits/b47bc70b814f078b870ccc8c3fc4f7809e6473e7
b47bc70https://github.com/getsentry/sentry-python/pull/3767/commits/b47bc70b814f078b870ccc8c3fc4f7809e6473e7
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Nov 13, 2024https://github.com/getsentry/sentry-python/pull/3767#issuecomment-2472921602
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3767
Test Analytics Dashboardhttps://app.codecov.io/gh/getsentry/sentry-python/tests/ivana%2Fpotel%2Ffix-sampler
Githubhttps://github.com/codecov/feedback/issues
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3767
sentrivanahttps://github.com/sentrivana
November 13, 2024 10:15https://github.com/getsentry/sentry-python/pull/3767#commits-pushed-1d77484
https://github.com/sentrivana
better wordinghttps://github.com/getsentry/sentry-python/pull/3767/commits/1d77484ea093b080bd13a72d5f533b0d6da11ec6
1d77484https://github.com/getsentry/sentry-python/pull/3767/commits/1d77484ea093b080bd13a72d5f533b0d6da11ec6
https://github.com/sentrivana
reword and support parent_sampledhttps://github.com/getsentry/sentry-python/pull/3767/commits/cefb27ca9af9e7cefc47e5d17c8101f0936389a2
cefb27chttps://github.com/getsentry/sentry-python/pull/3767/commits/cefb27ca9af9e7cefc47e5d17c8101f0936389a2
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
Nov 13, 2024 https://github.com/getsentry/sentry-python/pull/3767#pullrequestreview-2432423793
View reviewed changes https://github.com/getsentry/sentry-python/pull/3767/files/cefb27ca9af9e7cefc47e5d17c8101f0936389a2
sentry_sdk/tracing.pyhttps://github.com/getsentry/sentry-python/pull/3767/files/cefb27ca9af9e7cefc47e5d17c8101f0936389a2#diff-771cb012ea65fcb826b77e2abb36b504fdf3407fbe8054857b05fe5a41ed5164
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3767
sentrivanahttps://github.com/sentrivana
November 13, 2024 11:26https://github.com/getsentry/sentry-python/pull/3767#commits-pushed-3fcbf65
https://github.com/sentrivana
testshttps://github.com/getsentry/sentry-python/pull/3767/commits/3fcbf65005ab2344928099f2644746025eba8474
3fcbf65https://github.com/getsentry/sentry-python/pull/3767/commits/3fcbf65005ab2344928099f2644746025eba8474
https://github.com/sentrivana
.https://github.com/getsentry/sentry-python/pull/3767/commits/9600484725c330697609c5eb722f8058fe3f3cf5
9600484https://github.com/getsentry/sentry-python/pull/3767/commits/9600484725c330697609c5eb722f8058fe3f3cf5
https://github.com/sentrivana
remove, this is not a change afaithttps://github.com/getsentry/sentry-python/pull/3767/commits/69dfe92ce655636ac0ca5ef173f06a3d32a19c45
69dfe92https://github.com/getsentry/sentry-python/pull/3767/commits/69dfe92ce655636ac0ca5ef173f06a3d32a19c45
https://github.com/sentrivana
simplifyhttps://github.com/getsentry/sentry-python/pull/3767/commits/1b8521b66a6de4f26c0e3e57765864f6aed34fad
1b8521bhttps://github.com/getsentry/sentry-python/pull/3767/commits/1b8521b66a6de4f26c0e3e57765864f6aed34fad
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
November 13, 2024 10:35https://github.com/getsentry/sentry-python/pull/3767#event-15280513155
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
antonpirkerhttps://github.com/antonpirker
sl0thentr0pyhttps://github.com/sl0thentr0py
November 13, 2024 10:35https://github.com/getsentry/sentry-python/pull/3767#event-15280514542
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
Nov 13, 2024 https://github.com/getsentry/sentry-python/pull/3767#ref-pullrequest-2652056160
Unpack custom_sampling_context into attributes in ASGI #3764 https://github.com/getsentry/sentry-python/pull/3764
https://github.com/sl0thentr0py
sl0thentr0pyhttps://github.com/sl0thentr0py
Nov 13, 2024 https://github.com/getsentry/sentry-python/pull/3767#pullrequestreview-2433255517
View reviewed changes https://github.com/getsentry/sentry-python/pull/3767/files/1b8521b66a6de4f26c0e3e57765864f6aed34fad
sentry_sdk/integrations/opentelemetry/sampler.pyhttps://github.com/getsentry/sentry-python/pull/3767/files/1b8521b66a6de4f26c0e3e57765864f6aed34fad#diff-59aa7195d955e153b5cdd730f888994996a72eaf5e9ea174335ce961841584a9
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3767
sentry_sdk/tracing.pyhttps://github.com/getsentry/sentry-python/pull/3767/files/cefb27ca9af9e7cefc47e5d17c8101f0936389a2#diff-771cb012ea65fcb826b77e2abb36b504fdf3407fbe8054857b05fe5a41ed5164
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3767
sentrivanahttps://github.com/sentrivana
November 13, 2024 15:19https://github.com/getsentry/sentry-python/pull/3767#commits-pushed-d9b7f71
https://github.com/sentrivana
remove parent_sampledhttps://github.com/getsentry/sentry-python/pull/3767/commits/d9b7f7178344a45f635353e42748902591e46a26
d9b7f71https://github.com/getsentry/sentry-python/pull/3767/commits/d9b7f7178344a45f635353e42748902591e46a26
https://github.com/sentrivana
fix testshttps://github.com/getsentry/sentry-python/pull/3767/commits/8ae99c087874024b755c58ac39386f09602c5b9c
8ae99c0https://github.com/getsentry/sentry-python/pull/3767/commits/8ae99c087874024b755c58ac39386f09602c5b9c
https://github.com/sentrivana
remove all parent_sampled stuffhttps://github.com/getsentry/sentry-python/pull/3767/commits/a11ff463cdce702abfbdb8fc7b6969fcd9cbbf19
a11ff46https://github.com/getsentry/sentry-python/pull/3767/commits/a11ff463cdce702abfbdb8fc7b6969fcd9cbbf19
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
Nov 13, 2024https://github.com/getsentry/sentry-python/pull/3767#issuecomment-2473797618
@sl0thentr0pyhttps://github.com/sl0thentr0py
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3767
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
sl0thentr0pyhttps://github.com/sl0thentr0py
November 13, 2024 14:34https://github.com/getsentry/sentry-python/pull/3767#event-15284190153
https://github.com/sentrivana
Merge branch 'potel-base' into ivana/potel/fix-samplerhttps://github.com/getsentry/sentry-python/pull/3767/commits/e6d1421b3fe489670c8d83bcaa3953f428f7db5b
e6d1421https://github.com/getsentry/sentry-python/pull/3767/commits/e6d1421b3fe489670c8d83bcaa3953f428f7db5b
https://github.com/sl0thentr0py
sl0thentr0pyhttps://github.com/sl0thentr0py
Nov 14, 2024 https://github.com/getsentry/sentry-python/pull/3767#pullrequestreview-2435706780
View reviewed changes https://github.com/getsentry/sentry-python/pull/3767/files/e6d1421b3fe489670c8d83bcaa3953f428f7db5b
tests/tracing/test_sampling.pyhttps://github.com/getsentry/sentry-python/pull/3767/files/e6d1421b3fe489670c8d83bcaa3953f428f7db5b#diff-b51eab357bbfb00b250fe03b91239ec6bb40d7f11d4c0f22944f1b23d3d24fcc
sl0thentr0pyhttps://github.com/sl0thentr0py
Nov 14, 2024https://github.com/getsentry/sentry-python/pull/3767#discussion_r1841990543
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3767
https://github.com/sentrivana
fix testhttps://github.com/getsentry/sentry-python/pull/3767/commits/032a6c4fe4ede48d4d9b495001ca32df7bcc91a3
032a6c4https://github.com/getsentry/sentry-python/pull/3767/commits/032a6c4fe4ede48d4d9b495001ca32df7bcc91a3
https://github.com/sl0thentr0py
sl0thentr0pyhttps://github.com/sl0thentr0py
Nov 14, 2024 https://github.com/getsentry/sentry-python/pull/3767#pullrequestreview-2435759555
View reviewed changes https://github.com/getsentry/sentry-python/pull/3767/files/032a6c4fe4ede48d4d9b495001ca32df7bcc91a3
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
ff7e134https://github.com/getsentry/sentry-python/commit/ff7e1342d854415698d3cb6d5be13eb5e488e64a
Nov 14, 2024https://github.com/getsentry/sentry-python/pull/3767#event-15296786287
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
November 14, 2024 10:58https://github.com/getsentry/sentry-python/pull/3767#event-15296786783
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
Nov 14, 2024 https://github.com/getsentry/sentry-python/pull/3767#ref-pullrequest-2344614538
POtel implementation base branch (aka SDK 3.0.0) #3152 https://github.com/getsentry/sentry-python/pull/3152
https://github.com/BYK
BYKhttps://github.com/BYK
Sep 3, 2025 https://github.com/getsentry/sentry-python/pull/3767#ref-pullrequest-3379689704
breaking: Remove Spotlight Django integration #4747 https://github.com/getsentry/sentry-python/pull/4747
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F3767
https://github.com/sl0thentr0py
sl0thentr0py https://github.com/sl0thentr0py
https://github.com/getsentry/sentry-python/pull/3767/files/032a6c4fe4ede48d4d9b495001ca32df7bcc91a3
https://github.com/antonpirker
antonpirker https://github.com/antonpirker
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3767
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3767
https://github.com/sentrivana
https://github.com/sl0thentr0py
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.