René's URL Explorer Experiment


Title: Fix breadcrumbs in redis by antonpirker · Pull Request #3680 · getsentry/sentry-python · GitHub

Open Graph Title: Fix breadcrumbs in redis by antonpirker · Pull Request #3680 · getsentry/sentry-python

X Title: Fix breadcrumbs in redis by antonpirker · Pull Request #3680 · getsentry/sentry-python

Description: This moves the creation of redis breadcrumbs from the maybe_create_breadcrumbs_from_span into the integrations. And as well fixes some span related tests by using render_span_tree.

Open Graph Description: This moves the creation of redis breadcrumbs from the maybe_create_breadcrumbs_from_span into the integrations. And as well fixes some span related tests by using render_span_tree.

X Description: This moves the creation of redis breadcrumbs from the maybe_create_breadcrumbs_from_span into the integrations. And as well fixes some span related tests by using render_span_tree.

Opengraph URL: https://github.com/getsentry/sentry-python/pull/3680

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a0329961-486a-2429-a1a2-86dcdc8af503
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD4CE:134361:57CE10:75DE6A:6B00CF84
html-safe-nonce97876e83b778e089509a883418e6d8ac8a5f2d9f544545c61e0c14216a192a83
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENENFOjEzNDM2MTo1N0NFMTA6NzVERTZBOjZCMDBDRjg0IiwidmlzaXRvcl9pZCI6IjMzMzU1NTQ2NTk5NDYzODUyODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd94c2c9dfa6d4575f8bc8abebfcba86cb88669317a57e070e6e39e079097a162
hovercard-subject-tagpull_request:2137720601
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/getsentry/sentry-python/pull/3680/files
twitter:imagehttps://avatars.githubusercontent.com/u/202325?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/202325?s=400&v=4
og:image:altThis moves the creation of redis breadcrumbs from the maybe_create_breadcrumbs_from_span into the integrations. And as well fixes some span related tests by using render_span_tree.
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None85bbdfe2b6ba16e234513bc6ceff5d848ef8449820c900692a2b4e67061931e5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4943239a6d2c591325dad6e5c313e1cafda877f6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/3680/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F3680%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F3680%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/3680/files
Reloadhttps://github.com/getsentry/sentry-python/pull/3680/files
Reloadhttps://github.com/getsentry/sentry-python/pull/3680/files
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
antonpirkerhttps://github.com/antonpirker
potel-basehttps://github.com/getsentry/sentry-python/tree/potel-base
antonpirker/potel/fix-breadcrumbs-in-redishttps://github.com/getsentry/sentry-python/tree/antonpirker/potel/fix-breadcrumbs-in-redis
Conversation 2 https://github.com/getsentry/sentry-python/pull/3680
Commits 15 https://github.com/getsentry/sentry-python/pull/3680/commits
Checks 0 https://github.com/getsentry/sentry-python/pull/3680/checks
Files changed https://github.com/getsentry/sentry-python/pull/3680/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3680/files
Fix breadcrumbs in redis https://github.com/getsentry/sentry-python/pull/3680/files#top
Show all changes 15 commits https://github.com/getsentry/sentry-python/pull/3680/files
93fd159 Rename _set_db_data_on_span to _get_connection_data antonpirker Oct 22, 2024 https://github.com/getsentry/sentry-python/pull/3680/commits/93fd1598f8926c0964eb90e5d0979a3d3010ed6f
b853560 Rename _set_db_data to _get_db_data antonpirker Oct 22, 2024 https://github.com/getsentry/sentry-python/pull/3680/commits/b853560161e531db6c38748c4228b6c172963931
54e1e9f Rename _set_cluster_db_data to _get_cluster_db_data antonpirker Oct 22, 2024 https://github.com/getsentry/sentry-python/pull/3680/commits/54e1e9fc1a4dbc15d0b22b76306d2a7af31ffdff
7275d57 Renamce _set_async_cluster_db_data to _get_async_cluster_db_data antonpirker Oct 22, 2024 https://github.com/getsentry/sentry-python/pull/3680/commits/7275d57eabc09f2a9bbd81d3d561a3caeb4edfe6
57d1930 Rename _set_async_cluster_pipeline_db_data to _get_async_cluster_pipe… antonpirker Oct 22, 2024 https://github.com/getsentry/sentry-python/pull/3680/commits/57d19302dce48cc1e972edae8bb1c97ad03ada87
c2dfdc3 Rename _get_pipeline_data to _set_pipeline_data antonpirker Oct 22, 2024 https://github.com/getsentry/sentry-python/pull/3680/commits/c2dfdc385f0263cefa3a989e8c50d747606dbbf6
7c10709 Rename _set_cache_data to _get_cache_data antonpirker Oct 22, 2024 https://github.com/getsentry/sentry-python/pull/3680/commits/7c10709c549e2015d90f98953755c89311b62fb2
05569f1 Rename _set_client_data to _get_client_data antonpirker Oct 22, 2024 https://github.com/getsentry/sentry-python/pull/3680/commits/05569f18d6ff7f7440625852d25c1b8fa0d3756f
5445427 After gathering all the data, set it on the span antonpirker Oct 22, 2024 https://github.com/getsentry/sentry-python/pull/3680/commits/544542781983d198bca916be3141c09f4b99933d
fb7bfef Linting antonpirker Oct 22, 2024 https://github.com/getsentry/sentry-python/pull/3680/commits/fb7bfefe2d488b4cdc393c34eb399ab160e3dfdb
6e129b6 Now create the breadcrumbs antonpirker Oct 22, 2024 https://github.com/getsentry/sentry-python/pull/3680/commits/6e129b6ded9a174729a8480f32563fb0a812e2ae
6979215 Do not create the redis breadcrumbs in tracing code (because this is … antonpirker Oct 22, 2024 https://github.com/getsentry/sentry-python/pull/3680/commits/6979215f5cbe5685a42c6a8970eb78d8a4ac2bbe
9bfb8bc Fixed some tests antonpirker Oct 22, 2024 https://github.com/getsentry/sentry-python/pull/3680/commits/9bfb8bc7b86a5d930bb62e043a80c1bbc9a91a6c
f4207df Using render_span_tree antonpirker Oct 22, 2024 https://github.com/getsentry/sentry-python/pull/3680/commits/f4207dfc477b0871b74668507f23d7c05fb335ef
b7df053 Merge branch 'potel-base' into antonpirker/potel/fix-breadcrumbs-in-r… antonpirker Oct 22, 2024 https://github.com/getsentry/sentry-python/pull/3680/commits/b7df053e2f14565554d3bb5ca6598ec029241ba6
Clear filters https://github.com/getsentry/sentry-python/pull/3680/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3680/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3680/files
_async_common.py https://github.com/getsentry/sentry-python/pull/3680/files#diff-dfd9f2f9bc22216d06ba611949b4cccfed58753ad3f64fa5d0d5bfb98ec56fed
_sync_common.py https://github.com/getsentry/sentry-python/pull/3680/files#diff-506d240ee3b88383a270d256534c97f7233f54dde974bd1ebba5c1ec1fb170e3
caches.py https://github.com/getsentry/sentry-python/pull/3680/files#diff-f7c6816382c9d7852050c6b5076006db5752a26caff75e46892c5ffe2ee55714
queries.py https://github.com/getsentry/sentry-python/pull/3680/files#diff-6c26accdaa2c74a6aed91a70b48e2bc571858ab7af81d696a57f17285f12d50e
rb.py https://github.com/getsentry/sentry-python/pull/3680/files#diff-524b3e7c4c8d7562202679dbbb3a912c600a59b355c431c36d2ae56ec97a24a1
redis.py https://github.com/getsentry/sentry-python/pull/3680/files#diff-9e5e6479b5d390b9bef40033f0e04396eec336d805f1bf37fb5fdfc50b2b20b7
redis_cluster.py https://github.com/getsentry/sentry-python/pull/3680/files#diff-57dc4f8ec20d97f6fc0f3ed0e6661e76fb988884ca14ea07447a8d3c5a979482
redis_py_cluster_legacy.py https://github.com/getsentry/sentry-python/pull/3680/files#diff-c284a5482ad2a34e81d3a11d8ad70cae3f33935fd33f8ae27fba73bf5f3cee70
utils.py https://github.com/getsentry/sentry-python/pull/3680/files#diff-79a3788011179b24960642acf26b7cd5a7daaef510906fb683364309338546fc
tracing_utils.py https://github.com/getsentry/sentry-python/pull/3680/files#diff-7c64294459f5053c93d44e0e33e4e73ffcef0adefcd77ba91f4031aa461a8c42
test_redis.py https://github.com/getsentry/sentry-python/pull/3680/files#diff-8938151d698cbfb097e131557138203710105f1f96519e016a24c13d7ca9308a
test_redis_cache_module.py https://github.com/getsentry/sentry-python/pull/3680/files#diff-404e8d77fd79dab732ad6af060c6d8d4c3a8eabebe73f138a667eb3f888e6c37
test_redis_cache_module_async.py https://github.com/getsentry/sentry-python/pull/3680/files#diff-ab27e616b8dc6b347d153bf3e48779e245bdc6ac0fad534b0832985d09d6b7b5
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
sentry_sdk/integrations/redis/_async_common.pyhttps://github.com/getsentry/sentry-python/pull/3680/files#diff-dfd9f2f9bc22216d06ba611949b4cccfed58753ad3f64fa5d0d5bfb98ec56fed
View file https://github.com/getsentry/sentry-python/blob/b7df053e2f14565554d3bb5ca6598ec029241ba6/sentry_sdk/integrations/redis/_async_common.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3680/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3680/files#diff-dfd9f2f9bc22216d06ba611949b4cccfed58753ad3f64fa5d0d5bfb98ec56fed
https://github.com/getsentry/sentry-python/pull/3680/files#diff-dfd9f2f9bc22216d06ba611949b4cccfed58753ad3f64fa5d0d5bfb98ec56fed
https://github.com/getsentry/sentry-python/pull/3680/files#diff-dfd9f2f9bc22216d06ba611949b4cccfed58753ad3f64fa5d0d5bfb98ec56fed
https://github.com/getsentry/sentry-python/pull/3680/files#diff-dfd9f2f9bc22216d06ba611949b4cccfed58753ad3f64fa5d0d5bfb98ec56fed
https://github.com/getsentry/sentry-python/pull/3680/files#diff-dfd9f2f9bc22216d06ba611949b4cccfed58753ad3f64fa5d0d5bfb98ec56fed
https://github.com/getsentry/sentry-python/pull/3680/files#diff-dfd9f2f9bc22216d06ba611949b4cccfed58753ad3f64fa5d0d5bfb98ec56fed
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
sentry_sdk/integrations/redis/_sync_common.pyhttps://github.com/getsentry/sentry-python/pull/3680/files#diff-506d240ee3b88383a270d256534c97f7233f54dde974bd1ebba5c1ec1fb170e3
View file https://github.com/getsentry/sentry-python/blob/b7df053e2f14565554d3bb5ca6598ec029241ba6/sentry_sdk/integrations/redis/_sync_common.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3680/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3680/files#diff-506d240ee3b88383a270d256534c97f7233f54dde974bd1ebba5c1ec1fb170e3
https://github.com/getsentry/sentry-python/pull/3680/files#diff-506d240ee3b88383a270d256534c97f7233f54dde974bd1ebba5c1ec1fb170e3
https://github.com/getsentry/sentry-python/pull/3680/files#diff-506d240ee3b88383a270d256534c97f7233f54dde974bd1ebba5c1ec1fb170e3
https://github.com/getsentry/sentry-python/pull/3680/files#diff-506d240ee3b88383a270d256534c97f7233f54dde974bd1ebba5c1ec1fb170e3
https://github.com/getsentry/sentry-python/pull/3680/files#diff-506d240ee3b88383a270d256534c97f7233f54dde974bd1ebba5c1ec1fb170e3
https://github.com/getsentry/sentry-python/pull/3680/files#diff-506d240ee3b88383a270d256534c97f7233f54dde974bd1ebba5c1ec1fb170e3
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
sentry_sdk/integrations/redis/modules/caches.pyhttps://github.com/getsentry/sentry-python/pull/3680/files#diff-f7c6816382c9d7852050c6b5076006db5752a26caff75e46892c5ffe2ee55714
View file https://github.com/getsentry/sentry-python/blob/b7df053e2f14565554d3bb5ca6598ec029241ba6/sentry_sdk/integrations/redis/modules/caches.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3680/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3680/files#diff-f7c6816382c9d7852050c6b5076006db5752a26caff75e46892c5ffe2ee55714
https://github.com/getsentry/sentry-python/pull/3680/files#diff-f7c6816382c9d7852050c6b5076006db5752a26caff75e46892c5ffe2ee55714
https://github.com/getsentry/sentry-python/pull/3680/files#diff-f7c6816382c9d7852050c6b5076006db5752a26caff75e46892c5ffe2ee55714
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
sentry_sdk/integrations/redis/modules/queries.pyhttps://github.com/getsentry/sentry-python/pull/3680/files#diff-6c26accdaa2c74a6aed91a70b48e2bc571858ab7af81d696a57f17285f12d50e
View file https://github.com/getsentry/sentry-python/blob/b7df053e2f14565554d3bb5ca6598ec029241ba6/sentry_sdk/integrations/redis/modules/queries.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3680/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3680/files#diff-6c26accdaa2c74a6aed91a70b48e2bc571858ab7af81d696a57f17285f12d50e
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
sentry_sdk/integrations/redis/rb.pyhttps://github.com/getsentry/sentry-python/pull/3680/files#diff-524b3e7c4c8d7562202679dbbb3a912c600a59b355c431c36d2ae56ec97a24a1
View file https://github.com/getsentry/sentry-python/blob/b7df053e2f14565554d3bb5ca6598ec029241ba6/sentry_sdk/integrations/redis/rb.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3680/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3680/files#diff-524b3e7c4c8d7562202679dbbb3a912c600a59b355c431c36d2ae56ec97a24a1
https://github.com/getsentry/sentry-python/pull/3680/files#diff-524b3e7c4c8d7562202679dbbb3a912c600a59b355c431c36d2ae56ec97a24a1
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
sentry_sdk/integrations/redis/redis.pyhttps://github.com/getsentry/sentry-python/pull/3680/files#diff-9e5e6479b5d390b9bef40033f0e04396eec336d805f1bf37fb5fdfc50b2b20b7
View file https://github.com/getsentry/sentry-python/blob/b7df053e2f14565554d3bb5ca6598ec029241ba6/sentry_sdk/integrations/redis/redis.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3680/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3680/files#diff-9e5e6479b5d390b9bef40033f0e04396eec336d805f1bf37fb5fdfc50b2b20b7
https://github.com/getsentry/sentry-python/pull/3680/files#diff-9e5e6479b5d390b9bef40033f0e04396eec336d805f1bf37fb5fdfc50b2b20b7
https://github.com/getsentry/sentry-python/pull/3680/files#diff-9e5e6479b5d390b9bef40033f0e04396eec336d805f1bf37fb5fdfc50b2b20b7
https://github.com/getsentry/sentry-python/pull/3680/files#diff-9e5e6479b5d390b9bef40033f0e04396eec336d805f1bf37fb5fdfc50b2b20b7
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3680/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.