René's URL Explorer Experiment


Title: Fix breadcrumbs in redis by antonpirker · Pull Request #3680 · getsentry/sentry-python · GitHub

Open Graph Title: Fix breadcrumbs in redis by antonpirker · Pull Request #3680 · getsentry/sentry-python

X Title: Fix breadcrumbs in redis by antonpirker · Pull Request #3680 · getsentry/sentry-python

Description: The official Python SDK for Sentry.io. Contribute to getsentry/sentry-python development by creating an account on GitHub.

Open Graph Description: This moves the creation of redis breadcrumbs from the maybe_create_breadcrumbs_from_span into the integrations. And as well fixes some span related tests by using render_span_tree.

X Description: This moves the creation of redis breadcrumbs from the maybe_create_breadcrumbs_from_span into the integrations. And as well fixes some span related tests by using render_span_tree.

Opengraph URL: https://github.com/getsentry/sentry-python/pull/3680

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:70c145ae-0102-c58b-2328-258d66ef4e4d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCDE4:99F53:83BA88:AECB59:6B00B225
html-safe-nonce9e0cdbeadf8d0c3860fab52cb3d92ef6223ca7c102386aa726fa492a94ce02bd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDREU0Ojk5RjUzOjgzQkE4ODpBRUNCNTk6NkIwMEIyMjUiLCJ2aXNpdG9yX2lkIjoiNjIyNTU5NjM4NDg2NzgyNDE2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2c063b7521dda5fa162e2c8fa13507ebdf7dec40cea67d0aadedab7555ec938b
hovercard-subject-tagpull_request:2137720601
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/getsentry/sentry-python/3680/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f172376c6e311200e053e09f0b5570127b02de8f3cd0a282ecacdd91943c67a7/getsentry/sentry-python/pull/3680
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f172376c6e311200e053e09f0b5570127b02de8f3cd0a282ecacdd91943c67a7/getsentry/sentry-python/pull/3680
og:image:altThis moves the creation of redis breadcrumbs from the maybe_create_breadcrumbs_from_span into the integrations. And as well fixes some span related tests by using render_span_tree.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameantonpirker
hostnamegithub.com
expected-hostnamegithub.com
Nonec0dd5f5d6f515a591019ecd66df2c4eab3379c2d3b0777568a90d8c7ae10b79e
turbo-cache-controlno-cache
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release729d8cda69b3d267995675dfbf89ff27ccf61bf6
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/3680#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F3680
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F3680
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/3680
Reloadhttps://github.com/getsentry/sentry-python/pull/3680
Reloadhttps://github.com/getsentry/sentry-python/pull/3680
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
https://github.com/getsentry/sentry-python
antonpirkerhttps://github.com/antonpirker
potel-basehttps://github.com/getsentry/sentry-python/tree/potel-base
antonpirker/potel/fix-breadcrumbs-in-redishttps://github.com/getsentry/sentry-python/tree/antonpirker/potel/fix-breadcrumbs-in-redis
Conversationhttps://github.com/getsentry/sentry-python/pull/3680
Commits15 (15)https://github.com/getsentry/sentry-python/pull/3680/commits
Checkshttps://github.com/getsentry/sentry-python/pull/3680/checks
Files changedhttps://github.com/getsentry/sentry-python/pull/3680/files
Fix breadcrumbs in redishttps://github.com/getsentry/sentry-python/pull/3680#top
antonpirkerhttps://github.com/antonpirker
potel-basehttps://github.com/getsentry/sentry-python/tree/potel-base
antonpirker/potel/fix-breadcrumbs-in-redishttps://github.com/getsentry/sentry-python/tree/antonpirker/potel/fix-breadcrumbs-in-redis
https://github.com/antonpirker
antonpirkerhttps://github.com/antonpirker
Oct 22, 2024https://github.com/getsentry/sentry-python/pull/3680#issue-2604554447
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3680
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3680
antonpirkerhttps://github.com/antonpirker
October 22, 2024 09:20https://github.com/getsentry/sentry-python/pull/3680#commits-pushed-93fd159
https://github.com/antonpirker
Rename _set_db_data_on_span to _get_connection_datahttps://github.com/getsentry/sentry-python/pull/3680/commits/93fd1598f8926c0964eb90e5d0979a3d3010ed6f
93fd159https://github.com/getsentry/sentry-python/pull/3680/commits/93fd1598f8926c0964eb90e5d0979a3d3010ed6f
https://github.com/antonpirker
Rename _set_db_data to _get_db_datahttps://github.com/getsentry/sentry-python/pull/3680/commits/b853560161e531db6c38748c4228b6c172963931
b853560https://github.com/getsentry/sentry-python/pull/3680/commits/b853560161e531db6c38748c4228b6c172963931
https://github.com/antonpirker
Rename _set_cluster_db_data to _get_cluster_db_datahttps://github.com/getsentry/sentry-python/pull/3680/commits/54e1e9fc1a4dbc15d0b22b76306d2a7af31ffdff
54e1e9fhttps://github.com/getsentry/sentry-python/pull/3680/commits/54e1e9fc1a4dbc15d0b22b76306d2a7af31ffdff
https://github.com/antonpirker
Renamce _set_async_cluster_db_data to _get_async_cluster_db_datahttps://github.com/getsentry/sentry-python/pull/3680/commits/7275d57eabc09f2a9bbd81d3d561a3caeb4edfe6
7275d57https://github.com/getsentry/sentry-python/pull/3680/commits/7275d57eabc09f2a9bbd81d3d561a3caeb4edfe6
https://github.com/antonpirker
Rename _set_async_cluster_pipeline_db_data to _get_async_cluster_pipe…https://github.com/getsentry/sentry-python/pull/3680/commits/57d19302dce48cc1e972edae8bb1c97ad03ada87
57d1930https://github.com/getsentry/sentry-python/pull/3680/commits/57d19302dce48cc1e972edae8bb1c97ad03ada87
https://github.com/antonpirker
antonpirkerhttps://github.com/antonpirker
Project: POTel https://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Project%3A%20POTel%22
Oct 22, 2024https://github.com/getsentry/sentry-python/pull/3680#event-14779332445
https://github.com/antonpirker
antonpirkerhttps://github.com/antonpirker
Oct 22, 2024https://github.com/getsentry/sentry-python/pull/3680#event-14779332478
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 22, 2024https://github.com/getsentry/sentry-python/pull/3680#issuecomment-2428496057
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3680
Test Analytics Dashboardhttps://app.codecov.io/gh/getsentry/sentry-python/tests/antonpirker%2Fpotel%2Ffix-breadcrumbs-in-redis
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3680
antonpirkerhttps://github.com/antonpirker
October 22, 2024 09:45https://github.com/getsentry/sentry-python/pull/3680#commits-pushed-c2dfdc3
https://github.com/antonpirker
Rename _get_pipeline_data to _set_pipeline_datahttps://github.com/getsentry/sentry-python/pull/3680/commits/c2dfdc385f0263cefa3a989e8c50d747606dbbf6
c2dfdc3https://github.com/getsentry/sentry-python/pull/3680/commits/c2dfdc385f0263cefa3a989e8c50d747606dbbf6
https://github.com/antonpirker
Rename _set_cache_data to _get_cache_datahttps://github.com/getsentry/sentry-python/pull/3680/commits/7c10709c549e2015d90f98953755c89311b62fb2
7c10709https://github.com/getsentry/sentry-python/pull/3680/commits/7c10709c549e2015d90f98953755c89311b62fb2
https://github.com/antonpirker
Rename _set_client_data to _get_client_datahttps://github.com/getsentry/sentry-python/pull/3680/commits/05569f18d6ff7f7440625852d25c1b8fa0d3756f
05569f1https://github.com/getsentry/sentry-python/pull/3680/commits/05569f18d6ff7f7440625852d25c1b8fa0d3756f
https://github.com/antonpirker
After gathering all the data, set it on the spanhttps://github.com/getsentry/sentry-python/pull/3680/commits/544542781983d198bca916be3141c09f4b99933d
5445427https://github.com/getsentry/sentry-python/pull/3680/commits/544542781983d198bca916be3141c09f4b99933d
https://github.com/antonpirker
Lintinghttps://github.com/getsentry/sentry-python/pull/3680/commits/fb7bfefe2d488b4cdc393c34eb399ab160e3dfdb
fb7bfefhttps://github.com/getsentry/sentry-python/pull/3680/commits/fb7bfefe2d488b4cdc393c34eb399ab160e3dfdb
https://github.com/antonpirker
Now create the breadcrumbshttps://github.com/getsentry/sentry-python/pull/3680/commits/6e129b6ded9a174729a8480f32563fb0a812e2ae
6e129b6https://github.com/getsentry/sentry-python/pull/3680/commits/6e129b6ded9a174729a8480f32563fb0a812e2ae
https://github.com/antonpirker
Do not create the redis breadcrumbs in tracing code (because this is …https://github.com/getsentry/sentry-python/pull/3680/commits/6979215f5cbe5685a42c6a8970eb78d8a4ac2bbe
6979215https://github.com/getsentry/sentry-python/pull/3680/commits/6979215f5cbe5685a42c6a8970eb78d8a4ac2bbe
https://github.com/antonpirker
Fixed some testshttps://github.com/getsentry/sentry-python/pull/3680/commits/9bfb8bc7b86a5d930bb62e043a80c1bbc9a91a6c
9bfb8bchttps://github.com/getsentry/sentry-python/pull/3680/commits/9bfb8bc7b86a5d930bb62e043a80c1bbc9a91a6c
https://github.com/antonpirker
Using render_span_treehttps://github.com/getsentry/sentry-python/pull/3680/commits/f4207dfc477b0871b74668507f23d7c05fb335ef
f4207dfhttps://github.com/getsentry/sentry-python/pull/3680/commits/f4207dfc477b0871b74668507f23d7c05fb335ef
https://github.com/antonpirker
Merge branch 'potel-base' into antonpirker/potel/fix-breadcrumbs-in-r…https://github.com/getsentry/sentry-python/pull/3680/commits/b7df053e2f14565554d3bb5ca6598ec029241ba6
b7df053https://github.com/getsentry/sentry-python/pull/3680/commits/b7df053e2f14565554d3bb5ca6598ec029241ba6
https://github.com/antonpirker
antonpirkerhttps://github.com/antonpirker
October 22, 2024 11:59https://github.com/getsentry/sentry-python/pull/3680#event-14783784185
https://github.com/antonpirker
antonpirkerhttps://github.com/antonpirker
sentrivanahttps://github.com/sentrivana
October 22, 2024 11:59https://github.com/getsentry/sentry-python/pull/3680#event-14783785910
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
Oct 22, 2024 https://github.com/getsentry/sentry-python/pull/3680#pullrequestreview-2385234844
View reviewed changes https://github.com/getsentry/sentry-python/pull/3680/files/b7df053e2f14565554d3bb5ca6598ec029241ba6
sentrivanahttps://github.com/sentrivana
https://github.com/getsentry/sentry-python/pull/3680#pullrequestreview-2385234844
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3680
https://github.com/antonpirker
antonpirkerhttps://github.com/antonpirker
949ff5bhttps://github.com/getsentry/sentry-python/commit/949ff5bc0d2f68f457da89e1ce3e0b35abafbcc8
Oct 22, 2024https://github.com/getsentry/sentry-python/pull/3680#event-14787246336
https://github.com/antonpirker
antonpirkerhttps://github.com/antonpirker
October 22, 2024 14:56https://github.com/getsentry/sentry-python/pull/3680#event-14787247144
https://github.com/antonpirker
antonpirkerhttps://github.com/antonpirker
Oct 22, 2024 https://github.com/getsentry/sentry-python/pull/3680#ref-pullrequest-2344614538
POtel implementation base branch (aka SDK 3.0.0) #3152 https://github.com/getsentry/sentry-python/pull/3152
https://github.com/BYK
BYKhttps://github.com/BYK
Sep 3, 2025 https://github.com/getsentry/sentry-python/pull/3680#ref-pullrequest-3379689704
breaking: Remove Spotlight Django integration #4747 https://github.com/getsentry/sentry-python/pull/4747
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F3680
https://github.com/sentrivana
sentrivana https://github.com/sentrivana
https://github.com/getsentry/sentry-python/pull/3680/files/b7df053e2f14565554d3bb5ca6598ec029241ba6
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3680
https://github.com/antonpirker
antonpirker https://github.com/antonpirker
Project: POTel https://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Project%3A%20POTel%22
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3680
https://github.com/antonpirker
https://github.com/sentrivana
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.