René's URL Explorer Experiment


Title: Fix clickhouse-driver integration spans by sentrivana · Pull Request #3638 · getsentry/sentry-python · GitHub

Open Graph Title: Fix clickhouse-driver integration spans by sentrivana · Pull Request #3638 · getsentry/sentry-python

X Title: Fix clickhouse-driver integration spans by sentrivana · Pull Request #3638 · getsentry/sentry-python

Description: General change POTelSpan._get_attribute to public POTelSpan.get_attribute clickhouse-driver integration Change set_data to set_attribute Span attr db.params is now a string params are now stored on the connection temporarily. Previously, they were saved on the span, but since we're setting them once and then reading them and appending to them in another place, span attrs no longer work for this nicely -- we'd need to serialize them to str, then deserialize to add stuff, and serialize again. So I'm changing this to keep track of them elsewhere to avoid this dance. Span attr db.query.text has been added. Previously, we were storing query on the span temporarily, but then were getting rid of it. This PR preserves it and gives it an OTel-friendly name. (This also means the query text is now stored on the span 3x -- in the description, in sentry.name and in db.query.text.) We were checking same_process_as_parent in the tests, now we're not. In OTel, the spans now have a status attribute, we're also not checking this in the tests. Caveats Breadcrumbs will not work yet -- this needs #3637

Open Graph Description: General change POTelSpan._get_attribute to public POTelSpan.get_attribute clickhouse-driver integration Change set_data to set_attribute Span attr db.params is now a string params are now stored...

X Description: General change POTelSpan._get_attribute to public POTelSpan.get_attribute clickhouse-driver integration Change set_data to set_attribute Span attr db.params is now a string params are now stored...

Opengraph URL: https://github.com/getsentry/sentry-python/pull/3638

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:48894138-0504-21d6-a62f-dc3a2a4757e0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8AC8:28815B:BDFD2E:FE974F:6B00F731
html-safe-noncec76c4981b6a9c9b98f144e9d64859bd0a818d319d554a42eda0db1fae1470291
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QUM4OjI4ODE1QjpCREZEMkU6RkU5NzRGOjZCMDBGNzMxIiwidmlzaXRvcl9pZCI6IjM2NjQ3NDI5NDgwMzkzNTgyNTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7a6ce1ece2cec80aeed07f1e83d0431824d2feaa7486c5380158a349cc631a2f
hovercard-subject-tagpull_request:2115187829
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/getsentry/sentry-python/pull/3638/files
twitter:imagehttps://avatars.githubusercontent.com/u/131587164?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/131587164?s=400&v=4
og:image:altGeneral change POTelSpan._get_attribute to public POTelSpan.get_attribute clickhouse-driver integration Change set_data to set_attribute Span attr db.params is now a string params are now stored...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/3638/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F3638%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F3638%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/3638/files
Reloadhttps://github.com/getsentry/sentry-python/pull/3638/files
Reloadhttps://github.com/getsentry/sentry-python/pull/3638/files
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
sentrivanahttps://github.com/sentrivana
potel-basehttps://github.com/getsentry/sentry-python/tree/potel-base
ivana/potel/fix-clickhousehttps://github.com/getsentry/sentry-python/tree/ivana/potel/fix-clickhouse
Conversation 5 https://github.com/getsentry/sentry-python/pull/3638
Commits 10 https://github.com/getsentry/sentry-python/pull/3638/commits
Checks 0 https://github.com/getsentry/sentry-python/pull/3638/checks
Files changed https://github.com/getsentry/sentry-python/pull/3638/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3638/files
Fix clickhouse-driver integration spans https://github.com/getsentry/sentry-python/pull/3638/files#top
Show all changes 10 commits https://github.com/getsentry/sentry-python/pull/3638/files
fe3cdda Fix data in clickhouse-driver integration sentrivana Oct 9, 2024 https://github.com/getsentry/sentry-python/pull/3638/commits/fe3cddae84eac2f1952c285966b18980de8b69f5
35b7015 add more attrs sentrivana Oct 9, 2024 https://github.com/getsentry/sentry-python/pull/3638/commits/35b7015e9a75d8f70eb4d7d3af814367c978290e
66cb16a expose get_attribute sentrivana Oct 9, 2024 https://github.com/getsentry/sentry-python/pull/3638/commits/66cb16ae9933c830efd6c00fb821dab989fd765e
cd22cbd more fixes sentrivana Oct 9, 2024 https://github.com/getsentry/sentry-python/pull/3638/commits/cd22cbd92097bd7881ff617574e856d4f6599783
b9b02e6 fixes sentrivana Oct 9, 2024 https://github.com/getsentry/sentry-python/pull/3638/commits/b9b02e6ce8aae2ca34d41292892e385ac771737a
d96ec3c . sentrivana Oct 9, 2024 https://github.com/getsentry/sentry-python/pull/3638/commits/d96ec3cc1f292b33be6289ac9a97efd2b231fdf1
0d31853 save stuff on conn sentrivana Oct 10, 2024 https://github.com/getsentry/sentry-python/pull/3638/commits/0d3185381672a522418fccb9707bb1dda1c269a4
64f77b2 clean up after ourselves sentrivana Oct 10, 2024 https://github.com/getsentry/sentry-python/pull/3638/commits/64f77b2824cf3c10fcc25fbe4bec51df44496477
1aab2f3 no query id sentrivana Oct 10, 2024 https://github.com/getsentry/sentry-python/pull/3638/commits/1aab2f32abf4f8b157b7069b470c2ed651dcebaa
5f440df use spandata sentrivana Oct 10, 2024 https://github.com/getsentry/sentry-python/pull/3638/commits/5f440df8bd62877ad3e2a3e99caaa09c89201e0e
Clear filters https://github.com/getsentry/sentry-python/pull/3638/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3638/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3638/files
MIGRATION_GUIDE.md https://github.com/getsentry/sentry-python/pull/3638/files#diff-45651f4c3460b0f20be048556615842a07ec86d262fe5d3d346b5e4a9ce56d6a
clickhouse_driver.py https://github.com/getsentry/sentry-python/pull/3638/files#diff-0b76ea6a545ac6dd35fed901b016aae8c254ac63f28f0fd6d92fa392cfdb8668
tracing.py https://github.com/getsentry/sentry-python/pull/3638/files#diff-771cb012ea65fcb826b77e2abb36b504fdf3407fbe8054857b05fe5a41ed5164
test_clickhouse_driver.py https://github.com/getsentry/sentry-python/pull/3638/files#diff-472d1c606fe5950b2e65088d700af9430d10cc44056d2d130c3bd1d45f0da822
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
MIGRATION_GUIDE.mdhttps://github.com/getsentry/sentry-python/pull/3638/files#diff-45651f4c3460b0f20be048556615842a07ec86d262fe5d3d346b5e4a9ce56d6a
View file https://github.com/getsentry/sentry-python/blob/5f440df8bd62877ad3e2a3e99caaa09c89201e0e/MIGRATION_GUIDE.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3638/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3638/files#diff-45651f4c3460b0f20be048556615842a07ec86d262fe5d3d346b5e4a9ce56d6a
https://github.com/getsentry/sentry-python/pull/3638/files#diff-45651f4c3460b0f20be048556615842a07ec86d262fe5d3d346b5e4a9ce56d6a
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
sentry_sdk/integrations/clickhouse_driver.pyhttps://github.com/getsentry/sentry-python/pull/3638/files#diff-0b76ea6a545ac6dd35fed901b016aae8c254ac63f28f0fd6d92fa392cfdb8668
View file https://github.com/getsentry/sentry-python/blob/5f440df8bd62877ad3e2a3e99caaa09c89201e0e/sentry_sdk/integrations/clickhouse_driver.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3638/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3638/files#diff-0b76ea6a545ac6dd35fed901b016aae8c254ac63f28f0fd6d92fa392cfdb8668
https://github.com/getsentry/sentry-python/pull/3638/files#diff-0b76ea6a545ac6dd35fed901b016aae8c254ac63f28f0fd6d92fa392cfdb8668
https://github.com/getsentry/sentry-python/pull/3638/files#diff-0b76ea6a545ac6dd35fed901b016aae8c254ac63f28f0fd6d92fa392cfdb8668
https://github.com/getsentry/sentry-python/pull/3638/files#diff-0b76ea6a545ac6dd35fed901b016aae8c254ac63f28f0fd6d92fa392cfdb8668
https://github.com/getsentry/sentry-python/blob/potel-base/.github/CODEOWNERS#L1
sentry_sdk/tracing.pyhttps://github.com/getsentry/sentry-python/pull/3638/files#diff-771cb012ea65fcb826b77e2abb36b504fdf3407fbe8054857b05fe5a41ed5164
View file https://github.com/getsentry/sentry-python/blob/5f440df8bd62877ad3e2a3e99caaa09c89201e0e/sentry_sdk/tracing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3638/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3638/files#diff-771cb012ea65fcb826b77e2abb36b504fdf3407fbe8054857b05fe5a41ed5164
https://github.com/getsentry/sentry-python/pull/3638/files#diff-771cb012ea65fcb826b77e2abb36b504fdf3407fbe8054857b05fe5a41ed5164
https://github.com/getsentry/sentry-python/pull/3638/files#diff-771cb012ea65fcb826b77e2abb36b504fdf3407fbe8054857b05fe5a41ed5164
https://github.com/getsentry/sentry-python/pull/3638/files#diff-771cb012ea65fcb826b77e2abb36b504fdf3407fbe8054857b05fe5a41ed5164
https://github.com/getsentry/sentry-python/pull/3638/files#diff-771cb012ea65fcb826b77e2abb36b504fdf3407fbe8054857b05fe5a41ed5164
https://github.com/getsentry/sentry-python/pull/3638/files#diff-771cb012ea65fcb826b77e2abb36b504fdf3407fbe8054857b05fe5a41ed5164
https://github.com/getsentry/sentry-python/pull/3638/files#diff-771cb012ea65fcb826b77e2abb36b504fdf3407fbe8054857b05fe5a41ed5164
https://github.com/getsentry/sentry-python/pull/3638/files#diff-771cb012ea65fcb826b77e2abb36b504fdf3407fbe8054857b05fe5a41ed5164
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3638/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.