René's URL Explorer Experiment


Title: fix: Fix breadcrumb timestamp casting and its tests by BYK · Pull Request #3546 · getsentry/sentry-python · GitHub

Open Graph Title: fix: Fix breadcrumb timestamp casting and its tests by BYK · Pull Request #3546 · getsentry/sentry-python

X Title: fix: Fix breadcrumb timestamp casting and its tests by BYK · Pull Request #3546 · getsentry/sentry-python

Description: These tests were failing for me locally as the timestamps were without tzinfo and all were assumed UTC whereas my local timezone is BST at the moment. This patch fixes the tests along with faulty/incomplete breadcrumb timestamp parsing logic on py3.7 and py3.8.

Open Graph Description: These tests were failing for me locally as the timestamps were without tzinfo and all were assumed UTC whereas my local timezone is BST at the moment. This patch fixes the tests along with faulty/i...

X Description: These tests were failing for me locally as the timestamps were without tzinfo and all were assumed UTC whereas my local timezone is BST at the moment. This patch fixes the tests along with faulty/i...

Opengraph URL: https://github.com/getsentry/sentry-python/pull/3546

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:94303152-cace-7931-1e3b-53269a4f7e8f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC8BE:6365:4CE32C:68F723:6B00CEDB
html-safe-nonce6ab65ad8a8a974f1897eb5981159c3f2f5c281b31cedc2dd48a2900f4debff86
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOEJFOjYzNjU6NENFMzJDOjY4RjcyMzo2QjAwQ0VEQiIsInZpc2l0b3JfaWQiOiI4Mjg0NjYxMjY3NzIxOTMyNTA3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac601b25a707ad305162ea4b9cf0c3b74815f67b8ba73979a72964019bc7e2d85c
hovercard-subject-tagpull_request:2078719256
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/getsentry/sentry-python/pull/3546/files
twitter:imagehttps://avatars.githubusercontent.com/u/126780?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/126780?s=400&v=4
og:image:altThese tests were failing for me locally as the timestamps were without tzinfo and all were assumed UTC whereas my local timezone is BST at the moment. This patch fixes the tests along with faulty/i...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None85bbdfe2b6ba16e234513bc6ceff5d848ef8449820c900692a2b4e67061931e5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4943239a6d2c591325dad6e5c313e1cafda877f6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/3546/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F3546%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F3546%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/3546/files
Reloadhttps://github.com/getsentry/sentry-python/pull/3546/files
Reloadhttps://github.com/getsentry/sentry-python/pull/3546/files
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgetsentry%2Fsentry-python%2Fissues%2Fnew%2Fchoose
sentrivanahttps://github.com/sentrivana
getsentry:masterhttps://github.com/getsentry/sentry-python/tree/master
Conversation 11 https://github.com/getsentry/sentry-python/pull/3546
Commits 27 https://github.com/getsentry/sentry-python/pull/3546/commits
Checks 0 https://github.com/getsentry/sentry-python/pull/3546/checks
Files changed https://github.com/getsentry/sentry-python/pull/3546/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3546/files
fix: Fix breadcrumb timestamp casting and its tests https://github.com/getsentry/sentry-python/pull/3546/files#top
Show all changes 27 commits https://github.com/getsentry/sentry-python/pull/3546/files
b9e2c16 tests: Fix breadcrumb ordering tests BYK Sep 18, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/b9e2c16ebead606e5fdaffb154ba61b9e7339407
23034b6 Also parse Z with strptime antonpirker Sep 19, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/23034b68222546637d3de4ab14407a97af3f285b
2eec36b blacken BYK Sep 19, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/2eec36b7e6f60e118d2fc7d4f1e683a2d1e9815c
66af626 parse timezone with %z so +00:00 also works (py3.6) BYK Sep 19, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/66af6267c405259414402f96fa09502b74d44ec6
c42b7ab Revert "parse timezone with %z so +00:00 also works (py3.6)" BYK Sep 19, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/c42b7abd91bebddcfef638a1034249cdf2494b66
b12efb8 Revert "blacken" BYK Sep 19, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/b12efb885161ad932f1e384bab0924d57ab078f5
8773060 Revert "Also parse Z with strptime" BYK Sep 19, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/8773060f0eb8b25f879023abe9d6fbacc5347856
08d7d0c add note about py3.6 and .replace('Z','') ugliness BYK Sep 19, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/08d7d0c837b8a5096f298c6989bd8328acdadbf7
e817ac9 sigh, python3.6 BYK Sep 19, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/e817ac989b87fe508ad6de552fbfd5ec15b003e9
89e697e try to fix edge case BYK Sep 19, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/89e697e5ba12ef245c5716c6decd7af53e686364
9d86048 fix edge case and tests BYK Sep 19, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/9d86048a76a46c0a1915d1169fa5f41804f80f98
603139e add logging BYK Sep 19, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/603139e4d29f4e8204cf44f0002b06421c509d5b
b9b1a48 resort to print BYK Sep 19, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/b9b1a488b11b845bf93e78794282512d39bc4809
e211b11 hopefully fix it once and for all BYK Sep 19, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/e211b11ac6ca459b2ac947a7728ad548b1bd4978
ba2b90b add more tests BYK Sep 19, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/ba2b90b3ed70d46affec8c58a94c70dcb61ee1b9
0c1f681 timezones BYK Sep 19, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/0c1f681557f315868e36a52b7391dd8c9422516e
a7f7776 fix cohere errors BYK Sep 19, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/a7f7776bb1231d45ddb33fad93dfbc5ca3e6198c
9f410a2 remove type ignore (though it was used locally for me?) BYK Sep 19, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/9f410a2af0bb09173e66d56a2ef39e52b6a0fcef
9f0b114 split off cohere fix BYK Sep 19, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/9f0b114029cdfa8ea4c6e1037f857d0f293cc977
aedde93 Merge branch 'master' into byk/tests/timezones sentrivana Sep 20, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/aedde936a6334526cf53899b01efdd1b6382b70e
54b407a remove forgotton print BYK Sep 20, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/54b407a6cdcf04dbcdb2757a7e625d8756496c49
c2d00cd simplify code and fix edge-case BYK Sep 21, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/c2d00cd67e71aed6ca5e0b9465f676ae789f3b3c
6064185 mionr fixes and unit tests BYK Sep 21, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/606418536a15dd0404329b5ceabb8aa347bd6ff3
5746856 Merge branch 'master' into byk/tests/timezones BYK Sep 21, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/57468560e3f396401093f031f13467f06fdc6d46
157c7d1 change log msg to debug sentrivana Sep 23, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/157c7d1be2958927012f5dd95be9c4274e46077a
7234416 Merge branch 'master' into byk/tests/timezones sentrivana Sep 23, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/723441619f519cb5636c2ca4ac88aebbb9bf935d
9099d97 Merge branch 'master' into byk/tests/timezones sentrivana Sep 23, 2024 https://github.com/getsentry/sentry-python/pull/3546/commits/9099d97d60cd79f8fa98474a1dcfcebccf50a393
Clear filters https://github.com/getsentry/sentry-python/pull/3546/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3546/files
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/3546/files
scope.py https://github.com/getsentry/sentry-python/pull/3546/files#diff-c935006d78056bc518dd6e898d31d972c130c63119df74edf122e2cf4a5733bc
utils.py https://github.com/getsentry/sentry-python/pull/3546/files#diff-e9f88ca6368ce622839e078ed26c741a927752c01ceae64cd504d3ae86de6fd2
test_basics.py https://github.com/getsentry/sentry-python/pull/3546/files#diff-c5adef305dd5f109524ae8d595822cfe685b08677a79ae2556eae67219d83a05
test_utils.py https://github.com/getsentry/sentry-python/pull/3546/files#diff-33c13e0b177bacd2f02e29bcb8aea5b49e7ce34901fd8f41fefb65defba1bd33
https://github.com/getsentry/sentry-python/blob/master/.github/CODEOWNERS#L1
sentry_sdk/scope.pyhttps://github.com/getsentry/sentry-python/pull/3546/files#diff-c935006d78056bc518dd6e898d31d972c130c63119df74edf122e2cf4a5733bc
View file https://github.com/getsentry/sentry-python/blob/9099d97d60cd79f8fa98474a1dcfcebccf50a393/sentry_sdk/scope.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3546/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3546/files#diff-c935006d78056bc518dd6e898d31d972c130c63119df74edf122e2cf4a5733bc
https://github.com/getsentry/sentry-python/pull/3546/files#diff-c935006d78056bc518dd6e898d31d972c130c63119df74edf122e2cf4a5733bc
https://github.com/getsentry/sentry-python/pull/3546/files#diff-c935006d78056bc518dd6e898d31d972c130c63119df74edf122e2cf4a5733bc
https://github.com/getsentry/sentry-python/pull/3546/files#diff-c935006d78056bc518dd6e898d31d972c130c63119df74edf122e2cf4a5733bc
https://github.com/getsentry/sentry-python/blob/master/.github/CODEOWNERS#L1
sentry_sdk/utils.pyhttps://github.com/getsentry/sentry-python/pull/3546/files#diff-e9f88ca6368ce622839e078ed26c741a927752c01ceae64cd504d3ae86de6fd2
View file https://github.com/getsentry/sentry-python/blob/9099d97d60cd79f8fa98474a1dcfcebccf50a393/sentry_sdk/utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3546/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3546/files#diff-e9f88ca6368ce622839e078ed26c741a927752c01ceae64cd504d3ae86de6fd2
https://github.com/getsentry/sentry-python/pull/3546/files#diff-e9f88ca6368ce622839e078ed26c741a927752c01ceae64cd504d3ae86de6fd2
https://github.com/getsentry/sentry-python/blob/master/.github/CODEOWNERS#L1
tests/test_basics.pyhttps://github.com/getsentry/sentry-python/pull/3546/files#diff-c5adef305dd5f109524ae8d595822cfe685b08677a79ae2556eae67219d83a05
View file https://github.com/getsentry/sentry-python/blob/9099d97d60cd79f8fa98474a1dcfcebccf50a393/tests/test_basics.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3546/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3546/files#diff-c5adef305dd5f109524ae8d595822cfe685b08677a79ae2556eae67219d83a05
https://github.com/getsentry/sentry-python/pull/3546/files#diff-c5adef305dd5f109524ae8d595822cfe685b08677a79ae2556eae67219d83a05
https://github.com/getsentry/sentry-python/pull/3546/files#diff-c5adef305dd5f109524ae8d595822cfe685b08677a79ae2556eae67219d83a05
https://github.com/getsentry/sentry-python/pull/3546/files#diff-c5adef305dd5f109524ae8d595822cfe685b08677a79ae2556eae67219d83a05
https://github.com/getsentry/sentry-python/pull/3546/files#diff-c5adef305dd5f109524ae8d595822cfe685b08677a79ae2556eae67219d83a05
https://github.com/getsentry/sentry-python/blob/master/.github/CODEOWNERS#L1
tests/test_utils.pyhttps://github.com/getsentry/sentry-python/pull/3546/files#diff-33c13e0b177bacd2f02e29bcb8aea5b49e7ce34901fd8f41fefb65defba1bd33
View file https://github.com/getsentry/sentry-python/blob/9099d97d60cd79f8fa98474a1dcfcebccf50a393/tests/test_utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/3546/{{ revealButtonHref }}
https://github.com/getsentry/sentry-python/pull/3546/files#diff-33c13e0b177bacd2f02e29bcb8aea5b49e7ce34901fd8f41fefb65defba1bd33
https://github.com/getsentry/sentry-python/pull/3546/files#diff-33c13e0b177bacd2f02e29bcb8aea5b49e7ce34901fd8f41fefb65defba1bd33
https://github.com/getsentry/sentry-python/pull/3546/files#diff-33c13e0b177bacd2f02e29bcb8aea5b49e7ce34901fd8f41fefb65defba1bd33
https://github.com/getsentry/sentry-python/pull/3546/files#diff-33c13e0b177bacd2f02e29bcb8aea5b49e7ce34901fd8f41fefb65defba1bd33
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.