René's URL Explorer Experiment


Title: feat(typing): Make monitor_config a TypedDict by sentrivana · Pull Request #2931 · getsentry/sentry-python · GitHub

Open Graph Title: feat(typing): Make monitor_config a TypedDict by sentrivana · Pull Request #2931 · getsentry/sentry-python

X Title: feat(typing): Make monitor_config a TypedDict by sentrivana · Pull Request #2931 · getsentry/sentry-python

Description: The official Python SDK for Sentry.io. Contribute to getsentry/sentry-python development by creating an account on GitHub.

Open Graph Description: Better type hinting for monitor configs. Closes #2930 General Notes Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters....

X Description: Better type hinting for monitor configs. Closes #2930 General Notes Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters....

Opengraph URL: https://github.com/getsentry/sentry-python/pull/2931

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:14bdff32-034d-d955-d961-82054a23aa65
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBBC6:1BB3B1:5DEE4F:7DFA6A:6B00AA0D
html-safe-nonce688d52874e5ae74965674dcb74d7446c9f4bc738ab9be85e5aae0f44345c4fe6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQkM2OjFCQjNCMTo1REVFNEY6N0RGQTZBOjZCMDBBQTBEIiwidmlzaXRvcl9pZCI6IjU2MjU1NDQwMTcxNTc1OTc3MDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacabb709d5f5c713eb080a22c910341339a6b11377d3f28b2bb52a75b21af941cd
hovercard-subject-tagpull_request:1802584797
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/getsentry/sentry-python/2931/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/212e2e02193e50a8a25360704beed99214b1d8f461ecd3dd724241ca2751f814/getsentry/sentry-python/pull/2931
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/212e2e02193e50a8a25360704beed99214b1d8f461ecd3dd724241ca2751f814/getsentry/sentry-python/pull/2931
og:image:altBetter type hinting for monitor configs. Closes #2930 General Notes Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters....
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesentrivana
hostnamegithub.com
expected-hostnamegithub.com
None455b493e3402a3a3a06beac5d20bb7db3da060808b220aa48d6a7eca7c59863a
turbo-cache-controlno-cache
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2f575159976167242d488c0b062eb355c4e198b7
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/2931#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F2931
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F2931
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/2931
Reloadhttps://github.com/getsentry/sentry-python/pull/2931
Reloadhttps://github.com/getsentry/sentry-python/pull/2931
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
https://github.com/getsentry/sentry-python
sentrivanahttps://github.com/sentrivana
masterhttps://github.com/getsentry/sentry-python/tree/master
ivana/monitor-config-typeddicthttps://github.com/getsentry/sentry-python/tree/ivana/monitor-config-typeddict
Conversationhttps://github.com/getsentry/sentry-python/pull/2931
Commits15 (15)https://github.com/getsentry/sentry-python/pull/2931/commits
Checkshttps://github.com/getsentry/sentry-python/pull/2931/checks
Files changedhttps://github.com/getsentry/sentry-python/pull/2931/files
feat(typing): Make monitor_config a TypedDicthttps://github.com/getsentry/sentry-python/pull/2931#top
sentrivanahttps://github.com/sentrivana
masterhttps://github.com/getsentry/sentry-python/tree/master
ivana/monitor-config-typeddicthttps://github.com/getsentry/sentry-python/tree/ivana/monitor-config-typeddict
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
Apr 2, 2024https://github.com/getsentry/sentry-python/pull/2931#issue-2220604642
#2930https://github.com/getsentry/sentry-python/issues/2930
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2931
sentrivanahttps://github.com/sentrivana
April 2, 2024 15:57https://github.com/getsentry/sentry-python/pull/2931#commits-pushed-bdf983b
https://github.com/sentrivana
ref(typing): Make monitor_config a TypedDicthttps://github.com/getsentry/sentry-python/pull/2931/commits/bdf983b0eda96fa4c8f7336fda92c846e059f04e
bdf983bhttps://github.com/getsentry/sentry-python/pull/2931/commits/bdf983b0eda96fa4c8f7336fda92c846e059f04e
https://github.com/sentrivana
unit typehttps://github.com/getsentry/sentry-python/pull/2931/commits/6b1aa2948253e912f0bd188e4cd98c0bc601ceac
6b1aa29https://github.com/getsentry/sentry-python/pull/2931/commits/6b1aa2948253e912f0bd188e4cd98c0bc601ceac
https://github.com/sentrivana
more monitorconfigshttps://github.com/getsentry/sentry-python/pull/2931/commits/c9b840df1eebbb3e20272db50fafe7a61e695baf
c9b840dhttps://github.com/getsentry/sentry-python/pull/2931/commits/c9b840df1eebbb3e20272db50fafe7a61e695baf
https://github.com/sentrivana
make type for more schedule thingshttps://github.com/getsentry/sentry-python/pull/2931/commits/4f42df3e2b2ec91a1859df69179b759da27ab94b
4f42df3https://github.com/getsentry/sentry-python/pull/2931/commits/4f42df3e2b2ec91a1859df69179b759da27ab94b
https://github.com/sentrivana
...https://github.com/getsentry/sentry-python/pull/2931/commits/9b64c8585eee3eff3db89432bbad09d7d27fcea7
9b64c85https://github.com/getsentry/sentry-python/pull/2931/commits/9b64c8585eee3eff3db89432bbad09d7d27fcea7
https://github.com/sentrivana
...https://github.com/getsentry/sentry-python/pull/2931/commits/94db78724842cc1fa6eefd25fb7ff21582b3938e
94db787https://github.com/getsentry/sentry-python/pull/2931/commits/94db78724842cc1fa6eefd25fb7ff21582b3938e
https://github.com/sentrivana
cast shouldnt be under TYPE_CHECKINGhttps://github.com/getsentry/sentry-python/pull/2931/commits/c90f335df5975c051a2fe547f481e690076392f7
c90f335https://github.com/getsentry/sentry-python/pull/2931/commits/c90f335df5975c051a2fe547f481e690076392f7
https://github.com/sentrivana
grrhttps://github.com/getsentry/sentry-python/pull/2931/commits/dceb48bb095cdc05e4bf64552e0026f9d6d4a65e
dceb48bhttps://github.com/getsentry/sentry-python/pull/2931/commits/dceb48bb095cdc05e4bf64552e0026f9d6d4a65e
https://github.com/sentrivana
Merge branch 'master' into ivana/monitor-config-typeddicthttps://github.com/getsentry/sentry-python/pull/2931/commits/ed80d37a1c46035efb18317782814a2527b9e410
ed80d37https://github.com/getsentry/sentry-python/pull/2931/commits/ed80d37a1c46035efb18317782814a2527b9e410
https://github.com/sentrivana
Merge branch 'master' into ivana/monitor-config-typeddicthttps://github.com/getsentry/sentry-python/pull/2931/commits/c8e1eb46360ab39fdc02e4dd5b607a012fac4627
c8e1eb4https://github.com/getsentry/sentry-python/pull/2931/commits/c8e1eb46360ab39fdc02e4dd5b607a012fac4627
https://github.com/sentrivana
Merge branch 'master' into ivana/monitor-config-typeddicthttps://github.com/getsentry/sentry-python/pull/2931/commits/2576f887ecc0b8e4c918d7720c86a21d82d2efbb
2576f88https://github.com/getsentry/sentry-python/pull/2931/commits/2576f887ecc0b8e4c918d7720c86a21d82d2efbb
https://github.com/sentrivana
Merge branch 'master' into ivana/monitor-config-typeddicthttps://github.com/getsentry/sentry-python/pull/2931/commits/4dbf501770039b6865895644e0a5330da94a58aa
4dbf501https://github.com/getsentry/sentry-python/pull/2931/commits/4dbf501770039b6865895644e0a5330da94a58aa
https://github.com/sentrivana
attempthttps://github.com/getsentry/sentry-python/pull/2931/commits/514aa47d2068bbd8c2fce86be261c3ccc7dcd078
514aa47https://github.com/getsentry/sentry-python/pull/2931/commits/514aa47d2068bbd8c2fce86be261c3ccc7dcd078
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
Apr 4, 2024 https://github.com/getsentry/sentry-python/pull/2931#pullrequestreview-1979343936
View reviewed changes https://github.com/getsentry/sentry-python/pull/2931/files/514aa47d2068bbd8c2fce86be261c3ccc7dcd078
sentry_sdk/integrations/celery.pyhttps://github.com/getsentry/sentry-python/pull/2931/files/514aa47d2068bbd8c2fce86be261c3ccc7dcd078#diff-bbcc458d29b0f1880cf429abbf8a94a5e8517f61072945d783e44fec4969a10b
sentrivanahttps://github.com/sentrivana
Apr 4, 2024https://github.com/getsentry/sentry-python/pull/2931#discussion_r1551349504
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2931
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2931
sentrivanahttps://github.com/sentrivana
Apr 10, 2024https://github.com/getsentry/sentry-python/pull/2931#discussion_r1559220871
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@szokeasaurusrexhttps://github.com/szokeasaurusrex
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2931
szokeasaurusrexhttps://github.com/szokeasaurusrex
Apr 10, 2024https://github.com/getsentry/sentry-python/pull/2931#discussion_r1559247590
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2931
szokeasaurusrexhttps://github.com/szokeasaurusrex
Apr 10, 2024https://github.com/getsentry/sentry-python/pull/2931#discussion_r1559252303
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2931
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
Apr 4, 2024 https://github.com/getsentry/sentry-python/pull/2931#pullrequestreview-1979351150
View reviewed changes https://github.com/getsentry/sentry-python/pull/2931/files/514aa47d2068bbd8c2fce86be261c3ccc7dcd078
sentry_sdk/_types.pyhttps://github.com/getsentry/sentry-python/pull/2931/files/514aa47d2068bbd8c2fce86be261c3ccc7dcd078#diff-e3349c1b1ad2cbd12844ebfa0e2210f645cfb5c75cea5ff2dbaa769e35becd9f
sentrivanahttps://github.com/sentrivana
Apr 4, 2024https://github.com/getsentry/sentry-python/pull/2931#discussion_r1551354056
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2931
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
April 4, 2024 09:50https://github.com/getsentry/sentry-python/pull/2931#event-12355275278
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
szokeasaurusrexhttps://github.com/szokeasaurusrex
April 4, 2024 09:52https://github.com/getsentry/sentry-python/pull/2931#event-12355299198
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
Apr 4, 2024https://github.com/getsentry/sentry-python/pull/2931#event-12355374413
https://github.com/antonpirker
antonpirkerhttps://github.com/antonpirker
Apr 10, 2024 https://github.com/getsentry/sentry-python/pull/2931#pullrequestreview-1990996598
View reviewed changes https://github.com/getsentry/sentry-python/pull/2931/files/646ca9ba81b2a881dc552781a8dd9ed5162a56da
antonpirkerhttps://github.com/antonpirker
https://github.com/getsentry/sentry-python/pull/2931#pullrequestreview-1990996598
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2931
sentrivanahttps://github.com/sentrivana
April 10, 2024 11:57https://github.com/getsentry/sentry-python/pull/2931#commits-pushed-62b1d2a
https://github.com/sentrivana
Merge branch 'master' into ivana/monitor-config-typeddicthttps://github.com/getsentry/sentry-python/pull/2931/commits/62b1d2a89bd35d9f0690d8a0ca4db3923397cadd
62b1d2ahttps://github.com/getsentry/sentry-python/pull/2931/commits/62b1d2a89bd35d9f0690d8a0ca4db3923397cadd
https://github.com/sentrivana
Merge branch 'master' into ivana/monitor-config-typeddicthttps://github.com/getsentry/sentry-python/pull/2931/commits/646ca9ba81b2a881dc552781a8dd9ed5162a56da
646ca9bhttps://github.com/getsentry/sentry-python/pull/2931/commits/646ca9ba81b2a881dc552781a8dd9ed5162a56da
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
April 10, 2024 11:24https://github.com/getsentry/sentry-python/pull/2931#event-12420365845
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
a584653https://github.com/getsentry/sentry-python/commit/a584653e6e0f047171ae26682dcf621de2afd64d
Apr 10, 2024https://github.com/getsentry/sentry-python/pull/2931#event-12420578460
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
April 10, 2024 11:43https://github.com/getsentry/sentry-python/pull/2931#event-12420578693
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F2931
https://github.com/szokeasaurusrex
szokeasaurusrex https://github.com/szokeasaurusrex
https://github.com/antonpirker
antonpirker https://github.com/antonpirker
https://github.com/getsentry/sentry-python/pull/2931/files/646ca9ba81b2a881dc552781a8dd9ed5162a56da
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2931
Monitor config TypedDict https://github.com/getsentry/sentry-python/issues/2930
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2931
https://github.com/sentrivana
https://github.com/antonpirker
https://github.com/szokeasaurusrex
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.