| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:14bdff32-034d-d955-d961-82054a23aa65 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BBC6:1BB3B1:5DEE4F:7DFA6A:6B00AA0D |
| html-safe-nonce | 688d52874e5ae74965674dcb74d7446c9f4bc738ab9be85e5aae0f44345c4fe6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQkM2OjFCQjNCMTo1REVFNEY6N0RGQTZBOjZCMDBBQTBEIiwidmlzaXRvcl9pZCI6IjU2MjU1NDQwMTcxNTc1OTc3MDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | abb709d5f5c713eb080a22c910341339a6b11377d3f28b2bb52a75b21af941cd |
| hovercard-subject-tag | pull_request:1802584797 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/getsentry/sentry-python/2931/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/212e2e02193e50a8a25360704beed99214b1d8f461ecd3dd724241ca2751f814/getsentry/sentry-python/pull/2931 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/212e2e02193e50a8a25360704beed99214b1d8f461ecd3dd724241ca2751f814/getsentry/sentry-python/pull/2931 |
| og:image:alt | Better type hinting for monitor configs.
Closes #2930
General Notes
Thank you for contributing to sentry-python!
Please add tests to validate your changes, and lint your code using tox -e linters.... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sentrivana |
| hostname | github.com |
| expected-hostname | github.com |
| None | 455b493e3402a3a3a06beac5d20bb7db3da060808b220aa48d6a7eca7c59863a |
| turbo-cache-control | no-cache |
| go-import | github.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git |
| octolytics-dimension-user_id | 1396951 |
| octolytics-dimension-user_login | getsentry |
| octolytics-dimension-repository_id | 137814779 |
| octolytics-dimension-repository_nwo | getsentry/sentry-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 137814779 |
| octolytics-dimension-repository_network_root_nwo | getsentry/sentry-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2f575159976167242d488c0b062eb355c4e198b7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/getsentry/sentry-python/pull/2931#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F2931 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F2931 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=getsentry%2Fsentry-python |
| Reload | https://github.com/getsentry/sentry-python/pull/2931 |
| Reload | https://github.com/getsentry/sentry-python/pull/2931 |
| Reload | https://github.com/getsentry/sentry-python/pull/2931 |
| getsentry | https://github.com/getsentry |
| sentry-python | https://github.com/getsentry/sentry-python |
| Code | https://github.com/getsentry/sentry-python |
| Issues345 (345) | https://github.com/getsentry/sentry-python/issues |
| Pull requests42 (42) | https://github.com/getsentry/sentry-python/pulls |
| Discussions | https://github.com/getsentry/sentry-python/discussions |
| Actions | https://github.com/getsentry/sentry-python/actions |
| Security and quality2 (2) | https://github.com/getsentry/sentry-python/security |
| Insights | https://github.com/getsentry/sentry-python/insights |
| https://github.com/getsentry/sentry-python |
| sentrivana | https://github.com/sentrivana |
| master | https://github.com/getsentry/sentry-python/tree/master |
| ivana/monitor-config-typeddict | https://github.com/getsentry/sentry-python/tree/ivana/monitor-config-typeddict |
| Conversation | https://github.com/getsentry/sentry-python/pull/2931 |
| Commits15 (15) | https://github.com/getsentry/sentry-python/pull/2931/commits |
| Checks | https://github.com/getsentry/sentry-python/pull/2931/checks |
| Files changed | https://github.com/getsentry/sentry-python/pull/2931/files |
| feat(typing): Make monitor_config a TypedDict | https://github.com/getsentry/sentry-python/pull/2931#top |
| sentrivana | https://github.com/sentrivana |
| master | https://github.com/getsentry/sentry-python/tree/master |
| ivana/monitor-config-typeddict | https://github.com/getsentry/sentry-python/tree/ivana/monitor-config-typeddict |
|
| https://github.com/sentrivana |
| sentrivana | https://github.com/sentrivana |
| Apr 2, 2024 | https://github.com/getsentry/sentry-python/pull/2931#issue-2220604642 |
| #2930 | https://github.com/getsentry/sentry-python/issues/2930 |
| Please reload this page | https://github.com/getsentry/sentry-python/pull/2931 |
| sentrivana | https://github.com/sentrivana |
| April 2, 2024 15:57 | https://github.com/getsentry/sentry-python/pull/2931#commits-pushed-bdf983b |
|
| https://github.com/sentrivana |
| ref(typing): Make monitor_config a TypedDict | https://github.com/getsentry/sentry-python/pull/2931/commits/bdf983b0eda96fa4c8f7336fda92c846e059f04e |
| bdf983b | https://github.com/getsentry/sentry-python/pull/2931/commits/bdf983b0eda96fa4c8f7336fda92c846e059f04e |
|
| https://github.com/sentrivana |
| unit type | https://github.com/getsentry/sentry-python/pull/2931/commits/6b1aa2948253e912f0bd188e4cd98c0bc601ceac |
| 6b1aa29 | https://github.com/getsentry/sentry-python/pull/2931/commits/6b1aa2948253e912f0bd188e4cd98c0bc601ceac |
|
| https://github.com/sentrivana |
| more monitorconfigs | https://github.com/getsentry/sentry-python/pull/2931/commits/c9b840df1eebbb3e20272db50fafe7a61e695baf |
| c9b840d | https://github.com/getsentry/sentry-python/pull/2931/commits/c9b840df1eebbb3e20272db50fafe7a61e695baf |
|
| https://github.com/sentrivana |
| make type for more schedule things | https://github.com/getsentry/sentry-python/pull/2931/commits/4f42df3e2b2ec91a1859df69179b759da27ab94b |
| 4f42df3 | https://github.com/getsentry/sentry-python/pull/2931/commits/4f42df3e2b2ec91a1859df69179b759da27ab94b |
|
| https://github.com/sentrivana |
| ... | https://github.com/getsentry/sentry-python/pull/2931/commits/9b64c8585eee3eff3db89432bbad09d7d27fcea7 |
| 9b64c85 | https://github.com/getsentry/sentry-python/pull/2931/commits/9b64c8585eee3eff3db89432bbad09d7d27fcea7 |
|
| https://github.com/sentrivana |
| ... | https://github.com/getsentry/sentry-python/pull/2931/commits/94db78724842cc1fa6eefd25fb7ff21582b3938e |
| 94db787 | https://github.com/getsentry/sentry-python/pull/2931/commits/94db78724842cc1fa6eefd25fb7ff21582b3938e |
|
| https://github.com/sentrivana |
| cast shouldnt be under TYPE_CHECKING | https://github.com/getsentry/sentry-python/pull/2931/commits/c90f335df5975c051a2fe547f481e690076392f7 |
| c90f335 | https://github.com/getsentry/sentry-python/pull/2931/commits/c90f335df5975c051a2fe547f481e690076392f7 |
|
| https://github.com/sentrivana |
| grr | https://github.com/getsentry/sentry-python/pull/2931/commits/dceb48bb095cdc05e4bf64552e0026f9d6d4a65e |
| dceb48b | https://github.com/getsentry/sentry-python/pull/2931/commits/dceb48bb095cdc05e4bf64552e0026f9d6d4a65e |
|
| https://github.com/sentrivana |
| Merge branch 'master' into ivana/monitor-config-typeddict | https://github.com/getsentry/sentry-python/pull/2931/commits/ed80d37a1c46035efb18317782814a2527b9e410 |
| ed80d37 | https://github.com/getsentry/sentry-python/pull/2931/commits/ed80d37a1c46035efb18317782814a2527b9e410 |
|
| https://github.com/sentrivana |
| Merge branch 'master' into ivana/monitor-config-typeddict | https://github.com/getsentry/sentry-python/pull/2931/commits/c8e1eb46360ab39fdc02e4dd5b607a012fac4627 |
| c8e1eb4 | https://github.com/getsentry/sentry-python/pull/2931/commits/c8e1eb46360ab39fdc02e4dd5b607a012fac4627 |
|
| https://github.com/sentrivana |
| Merge branch 'master' into ivana/monitor-config-typeddict | https://github.com/getsentry/sentry-python/pull/2931/commits/2576f887ecc0b8e4c918d7720c86a21d82d2efbb |
| 2576f88 | https://github.com/getsentry/sentry-python/pull/2931/commits/2576f887ecc0b8e4c918d7720c86a21d82d2efbb |
|
| https://github.com/sentrivana |
| Merge branch 'master' into ivana/monitor-config-typeddict | https://github.com/getsentry/sentry-python/pull/2931/commits/4dbf501770039b6865895644e0a5330da94a58aa |
| 4dbf501 | https://github.com/getsentry/sentry-python/pull/2931/commits/4dbf501770039b6865895644e0a5330da94a58aa |
|
| https://github.com/sentrivana |
| attempt | https://github.com/getsentry/sentry-python/pull/2931/commits/514aa47d2068bbd8c2fce86be261c3ccc7dcd078 |
| 514aa47 | https://github.com/getsentry/sentry-python/pull/2931/commits/514aa47d2068bbd8c2fce86be261c3ccc7dcd078 |
| https://github.com/sentrivana |
| sentrivana | https://github.com/sentrivana |
|
Apr 4, 2024
| https://github.com/getsentry/sentry-python/pull/2931#pullrequestreview-1979343936 |
|
View reviewed changes
| https://github.com/getsentry/sentry-python/pull/2931/files/514aa47d2068bbd8c2fce86be261c3ccc7dcd078 |
| sentry_sdk/integrations/celery.py | https://github.com/getsentry/sentry-python/pull/2931/files/514aa47d2068bbd8c2fce86be261c3ccc7dcd078#diff-bbcc458d29b0f1880cf429abbf8a94a5e8517f61072945d783e44fec4969a10b |
| sentrivana | https://github.com/sentrivana |
| Apr 4, 2024 | https://github.com/getsentry/sentry-python/pull/2931#discussion_r1551349504 |
| Please reload this page | https://github.com/getsentry/sentry-python/pull/2931 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/getsentry/sentry-python/pull/2931 |
| sentrivana | https://github.com/sentrivana |
| Apr 10, 2024 | https://github.com/getsentry/sentry-python/pull/2931#discussion_r1559220871 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @szokeasaurusrex | https://github.com/szokeasaurusrex |
| Please reload this page | https://github.com/getsentry/sentry-python/pull/2931 |
| szokeasaurusrex | https://github.com/szokeasaurusrex |
| Apr 10, 2024 | https://github.com/getsentry/sentry-python/pull/2931#discussion_r1559247590 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/getsentry/sentry-python/pull/2931 |
| szokeasaurusrex | https://github.com/szokeasaurusrex |
| Apr 10, 2024 | https://github.com/getsentry/sentry-python/pull/2931#discussion_r1559252303 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/getsentry/sentry-python/pull/2931 |
| https://github.com/sentrivana |
| sentrivana | https://github.com/sentrivana |
|
Apr 4, 2024
| https://github.com/getsentry/sentry-python/pull/2931#pullrequestreview-1979351150 |
|
View reviewed changes
| https://github.com/getsentry/sentry-python/pull/2931/files/514aa47d2068bbd8c2fce86be261c3ccc7dcd078 |
| sentry_sdk/_types.py | https://github.com/getsentry/sentry-python/pull/2931/files/514aa47d2068bbd8c2fce86be261c3ccc7dcd078#diff-e3349c1b1ad2cbd12844ebfa0e2210f645cfb5c75cea5ff2dbaa769e35becd9f |
| sentrivana | https://github.com/sentrivana |
| Apr 4, 2024 | https://github.com/getsentry/sentry-python/pull/2931#discussion_r1551354056 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/getsentry/sentry-python/pull/2931 |
| https://github.com/sentrivana |
| sentrivana | https://github.com/sentrivana |
| April 4, 2024 09:50 | https://github.com/getsentry/sentry-python/pull/2931#event-12355275278 |
| https://github.com/sentrivana |
| sentrivana | https://github.com/sentrivana |
| szokeasaurusrex | https://github.com/szokeasaurusrex |
| April 4, 2024 09:52 | https://github.com/getsentry/sentry-python/pull/2931#event-12355299198 |
| https://github.com/sentrivana |
| sentrivana | https://github.com/sentrivana |
| Apr 4, 2024 | https://github.com/getsentry/sentry-python/pull/2931#event-12355374413 |
| https://github.com/antonpirker |
| antonpirker | https://github.com/antonpirker |
|
Apr 10, 2024
| https://github.com/getsentry/sentry-python/pull/2931#pullrequestreview-1990996598 |
|
View reviewed changes
| https://github.com/getsentry/sentry-python/pull/2931/files/646ca9ba81b2a881dc552781a8dd9ed5162a56da |
| antonpirker | https://github.com/antonpirker |
| https://github.com/getsentry/sentry-python/pull/2931#pullrequestreview-1990996598 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/getsentry/sentry-python/pull/2931 |
| sentrivana | https://github.com/sentrivana |
| April 10, 2024 11:57 | https://github.com/getsentry/sentry-python/pull/2931#commits-pushed-62b1d2a |
|
| https://github.com/sentrivana |
| Merge branch 'master' into ivana/monitor-config-typeddict | https://github.com/getsentry/sentry-python/pull/2931/commits/62b1d2a89bd35d9f0690d8a0ca4db3923397cadd |
| 62b1d2a | https://github.com/getsentry/sentry-python/pull/2931/commits/62b1d2a89bd35d9f0690d8a0ca4db3923397cadd |
|
| https://github.com/sentrivana |
| Merge branch 'master' into ivana/monitor-config-typeddict | https://github.com/getsentry/sentry-python/pull/2931/commits/646ca9ba81b2a881dc552781a8dd9ed5162a56da |
| 646ca9b | https://github.com/getsentry/sentry-python/pull/2931/commits/646ca9ba81b2a881dc552781a8dd9ed5162a56da |
| https://github.com/sentrivana |
| sentrivana | https://github.com/sentrivana |
| April 10, 2024 11:24 | https://github.com/getsentry/sentry-python/pull/2931#event-12420365845 |
| https://github.com/sentrivana |
| sentrivana | https://github.com/sentrivana |
| a584653 | https://github.com/getsentry/sentry-python/commit/a584653e6e0f047171ae26682dcf621de2afd64d |
| Apr 10, 2024 | https://github.com/getsentry/sentry-python/pull/2931#event-12420578460 |
| https://github.com/sentrivana |
| sentrivana | https://github.com/sentrivana |
| April 10, 2024 11:43 | https://github.com/getsentry/sentry-python/pull/2931#event-12420578693 |
| https://github.co/hiddenchars |
| https://github.com/getsentry/sentry-python/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F2931 |
|
| https://github.com/szokeasaurusrex |
|
szokeasaurusrex
| https://github.com/szokeasaurusrex |
|
| https://github.com/antonpirker |
|
antonpirker
| https://github.com/antonpirker |
|
| https://github.com/getsentry/sentry-python/pull/2931/files/646ca9ba81b2a881dc552781a8dd9ed5162a56da |
| Please reload this page | https://github.com/getsentry/sentry-python/pull/2931 |
|
Monitor config TypedDict
| https://github.com/getsentry/sentry-python/issues/2930 |
| Please reload this page | https://github.com/getsentry/sentry-python/pull/2931 |
|
| https://github.com/sentrivana |
|
| https://github.com/antonpirker |
|
| https://github.com/szokeasaurusrex |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |