René's URL Explorer Experiment


Title: fix(crons): Make `monitor` async friendly by sentrivana · Pull Request #2912 · getsentry/sentry-python · GitHub

Open Graph Title: fix(crons): Make `monitor` async friendly by sentrivana · Pull Request #2912 · getsentry/sentry-python

X Title: fix(crons): Make `monitor` async friendly by sentrivana · Pull Request #2912 · getsentry/sentry-python

Description: The official Python SDK for Sentry.io. Contribute to getsentry/sentry-python development by creating an account on GitHub.

Open Graph Description: Our monitor decorator/context manager is not async friendly. If you wrap an async function in it, monitor will only wrap the creation of the coroutine, rather than its execution, which means it'...

X Description: Our monitor decorator/context manager is not async friendly. If you wrap an async function in it, monitor will only wrap the creation of the coroutine, rather than its execution, which means it&...

Opengraph URL: https://github.com/getsentry/sentry-python/pull/2912

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0f56d349-7b6d-02a9-b474-613523477112
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8F46:81DA9:1FE00B:2BCB0C:6B008580
html-safe-noncef523778b5acc64d38646e01367df4d256af2af35abccf5cfd5ff604336bcb46b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjQ2OjgxREE5OjFGRTAwQjoyQkNCMEM6NkIwMDg1ODAiLCJ2aXNpdG9yX2lkIjoiMjc2MjcwMTEzMDQxNTc2ODk2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac584920793a0bd69f2691fa4657e37d2b95669193de856be3d1f18b509141d1ad
hovercard-subject-tagpull_request:1793629386
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/getsentry/sentry-python/2912/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f7422d9e1c56ac9125c94ea139ce10347f79175c98a970d54a3895a10cf261d1/getsentry/sentry-python/pull/2912
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f7422d9e1c56ac9125c94ea139ce10347f79175c98a970d54a3895a10cf261d1/getsentry/sentry-python/pull/2912
og:image:altOur monitor decorator/context manager is not async friendly. If you wrap an async function in it, monitor will only wrap the creation of the coroutine, rather than its execution, which means it'...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesentrivana
hostnamegithub.com
expected-hostnamegithub.com
None4d3d8e50f02c1d7bf86d5acfa1d3bfe9366abd6528a6b429eb07a168429d2b61
turbo-cache-controlno-cache
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedb758f8e02b8257935fb03edf81a3e76eb3abd11
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/2912#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F2912
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F2912
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/2912
Reloadhttps://github.com/getsentry/sentry-python/pull/2912
Reloadhttps://github.com/getsentry/sentry-python/pull/2912
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests41 (41)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
https://github.com/getsentry/sentry-python
sentrivanahttps://github.com/sentrivana
masterhttps://github.com/getsentry/sentry-python/tree/master
ivana/make-monitor-work-with-async-funshttps://github.com/getsentry/sentry-python/tree/ivana/make-monitor-work-with-async-funs
Conversationhttps://github.com/getsentry/sentry-python/pull/2912
Commits12 (12)https://github.com/getsentry/sentry-python/pull/2912/commits
Checkshttps://github.com/getsentry/sentry-python/pull/2912/checks
Files changedhttps://github.com/getsentry/sentry-python/pull/2912/files
fix(crons): Make monitor async friendlyhttps://github.com/getsentry/sentry-python/pull/2912#top
sentrivanahttps://github.com/sentrivana
masterhttps://github.com/getsentry/sentry-python/tree/master
ivana/make-monitor-work-with-async-funshttps://github.com/getsentry/sentry-python/tree/ivana/make-monitor-work-with-async-funs
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
Mar 27, 2024https://github.com/getsentry/sentry-python/pull/2912#issue-2210432588
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2912
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2912
sentrivanahttps://github.com/sentrivana
March 27, 2024 11:27https://github.com/getsentry/sentry-python/pull/2912#commits-pushed-caa281e
https://github.com/sentrivana
fix(crons): Makehttps://github.com/getsentry/sentry-python/pull/2912/commits/caa281e4413ed579630a2236a8fdcd86a55800ef
@monitorhttps://github.com/monitor
work with async functionshttps://github.com/getsentry/sentry-python/pull/2912/commits/caa281e4413ed579630a2236a8fdcd86a55800ef
caa281ehttps://github.com/getsentry/sentry-python/pull/2912/commits/caa281e4413ed579630a2236a8fdcd86a55800ef
https://github.com/sentrivana
py2https://github.com/getsentry/sentry-python/pull/2912/commits/af271cb8511226577d3814ae4de879fcf44e1b30
af271cbhttps://github.com/getsentry/sentry-python/pull/2912/commits/af271cb8511226577d3814ae4de879fcf44e1b30
https://github.com/sentrivana
typo, fixhttps://github.com/getsentry/sentry-python/pull/2912/commits/f55c3ff696033d3034d80fadf80bd2647e753fa2
f55c3ffhttps://github.com/getsentry/sentry-python/pull/2912/commits/f55c3ff696033d3034d80fadf80bd2647e753fa2
https://github.com/sentrivana
silence flake8https://github.com/getsentry/sentry-python/pull/2912/commits/7decde0c27bc679ac0c146393a7afd36ff965756
7decde0https://github.com/getsentry/sentry-python/pull/2912/commits/7decde0c27bc679ac0c146393a7afd36ff965756
https://github.com/sentrivana
py2.7https://github.com/getsentry/sentry-python/pull/2912/commits/d63fb87b77a61b6b5f2b7d1e2d6fc2e347a6ba9b
d63fb87https://github.com/getsentry/sentry-python/pull/2912/commits/d63fb87b77a61b6b5f2b7d1e2d6fc2e347a6ba9b
https://github.com/sentrivana
doing it differentlyhttps://github.com/getsentry/sentry-python/pull/2912/commits/6b1ec4c5c87a3b1464ac97cca5c077afc0e4ee0d
6b1ec4chttps://github.com/getsentry/sentry-python/pull/2912/commits/6b1ec4c5c87a3b1464ac97cca5c077afc0e4ee0d
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
Feature: Crons https://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Feature%3A%20Crons%22
Mar 27, 2024https://github.com/getsentry/sentry-python/pull/2912#event-12264587483
sentrivanahttps://github.com/sentrivana
March 27, 2024 13:10https://github.com/getsentry/sentry-python/pull/2912#commits-pushed-89e6ad3
https://github.com/sentrivana
notehttps://github.com/getsentry/sentry-python/pull/2912/commits/89e6ad3d3e944ae7575e72c1165e11c07f460a58
89e6ad3https://github.com/getsentry/sentry-python/pull/2912/commits/89e6ad3d3e944ae7575e72c1165e11c07f460a58
https://github.com/sentrivana
mypyhttps://github.com/getsentry/sentry-python/pull/2912/commits/0259700a58a6f449d42178ef3d2d7b191abfce49
0259700https://github.com/getsentry/sentry-python/pull/2912/commits/0259700a58a6f449d42178ef3d2d7b191abfce49
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
Mar 27, 2024https://github.com/getsentry/sentry-python/pull/2912#event-12264829380
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
March 27, 2024 12:26https://github.com/getsentry/sentry-python/pull/2912#event-12264831537
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
antonpirkerhttps://github.com/antonpirker
szokeasaurusrexhttps://github.com/szokeasaurusrex
March 27, 2024 12:28https://github.com/getsentry/sentry-python/pull/2912#event-12264849546
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
Mar 27, 2024https://github.com/getsentry/sentry-python/pull/2912#event-12265105211
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
Mar 27, 2024https://github.com/getsentry/sentry-python/pull/2912#event-12266577546
https://github.com/sentrivana
Merge branch 'master' into ivana/make-monitor-work-with-async-funshttps://github.com/getsentry/sentry-python/pull/2912/commits/27f8ae3dd5718f7cc3db0d9b4e09cc3b9722315a
27f8ae3https://github.com/getsentry/sentry-python/pull/2912/commits/27f8ae3dd5718f7cc3db0d9b4e09cc3b9722315a
https://github.com/szokeasaurusrex
szokeasaurusrexhttps://github.com/szokeasaurusrex
Mar 27, 2024 https://github.com/getsentry/sentry-python/pull/2912#pullrequestreview-1963718041
View reviewed changes https://github.com/getsentry/sentry-python/pull/2912/files/0259700a58a6f449d42178ef3d2d7b191abfce49
sentry_sdk/crons/_decorator.pyhttps://github.com/getsentry/sentry-python/pull/2912/files/0259700a58a6f449d42178ef3d2d7b191abfce49#diff-e0127ba03ea7db36f7e8813f5b9dce2f55674554b756338a4ea9b774e03dfb4d
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2912
sentry_sdk/crons/_decorator.pyhttps://github.com/getsentry/sentry-python/pull/2912/files/0259700a58a6f449d42178ef3d2d7b191abfce49#diff-e0127ba03ea7db36f7e8813f5b9dce2f55674554b756338a4ea9b774e03dfb4d
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2912
https://github.com/sentrivana
better naming & typinghttps://github.com/getsentry/sentry-python/pull/2912/commits/b510a119d47e45cdf405b17c14c24d37dc57d487
b510a11https://github.com/getsentry/sentry-python/pull/2912/commits/b510a119d47e45cdf405b17c14c24d37dc57d487
https://github.com/szokeasaurusrex
szokeasaurusrexhttps://github.com/szokeasaurusrex
Mar 27, 2024 https://github.com/getsentry/sentry-python/pull/2912#pullrequestreview-1963846833
View reviewed changes https://github.com/getsentry/sentry-python/pull/2912/files/b510a119d47e45cdf405b17c14c24d37dc57d487
https://github.com/antonpirker
antonpirkerhttps://github.com/antonpirker
Mar 28, 2024 https://github.com/getsentry/sentry-python/pull/2912#pullrequestreview-1965279380
View reviewed changes https://github.com/getsentry/sentry-python/pull/2912/files/b510a119d47e45cdf405b17c14c24d37dc57d487
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
Mar 28, 2024https://github.com/getsentry/sentry-python/pull/2912#event-12278721719
sentrivanahttps://github.com/sentrivana
March 28, 2024 11:49https://github.com/getsentry/sentry-python/pull/2912#commits-pushed-3dc5bc2
https://github.com/sentrivana
fix mypyhttps://github.com/getsentry/sentry-python/pull/2912/commits/3dc5bc2379a126dc187de8a6be76163f8a981e54
3dc5bc2https://github.com/getsentry/sentry-python/pull/2912/commits/3dc5bc2379a126dc187de8a6be76163f8a981e54
https://github.com/sentrivana
fix mypyhttps://github.com/getsentry/sentry-python/pull/2912/commits/d923c51554508dd4a03fb145e1cc2addccf23531
d923c51https://github.com/getsentry/sentry-python/pull/2912/commits/d923c51554508dd4a03fb145e1cc2addccf23531
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
Mar 28, 2024 https://github.com/getsentry/sentry-python/pull/2912#ref-pullrequest-2212981060
ref(crons): Simplify example, add async note getsentry/sentry-docs#9574 https://github.com/getsentry/sentry-docs/pull/9574
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
b742c45https://github.com/getsentry/sentry-python/commit/b742c45ce893d96864ec9d907141223a0ea728f1
Mar 28, 2024https://github.com/getsentry/sentry-python/pull/2912#event-12280017055
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
March 28, 2024 11:29https://github.com/getsentry/sentry-python/pull/2912#event-12280017320
https://github.com/data-sync-user
data-sync-userhttps://github.com/data-sync-user
Jun 3, 2024 https://github.com/getsentry/sentry-python/pull/2912#ref-pullrequest-2230378329
Bump sentry-sdk from 1.42.0 to 1.44.1 MozillaFoundation/foundation.mozilla.org#12159 https://github.com/MozillaFoundation/foundation.mozilla.org/pull/12159
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F2912
https://github.com/szokeasaurusrex
szokeasaurusrex https://github.com/szokeasaurusrex
https://github.com/getsentry/sentry-python/pull/2912/files/0259700a58a6f449d42178ef3d2d7b191abfce49
https://github.com/antonpirker
antonpirker https://github.com/antonpirker
https://github.com/getsentry/sentry-python/pull/2912/files/b510a119d47e45cdf405b17c14c24d37dc57d487
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2912
https://github.com/sentrivana
sentrivana https://github.com/sentrivana
Feature: Crons https://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Feature%3A%20Crons%22
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2912
https://github.com/sentrivana
https://github.com/antonpirker
https://github.com/szokeasaurusrex
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.