René's URL Explorer Experiment


Title: feat(profiling): Add thread data to spans by Zylphrex · Pull Request #2843 · getsentry/sentry-python · GitHub

Open Graph Title: feat(profiling): Add thread data to spans by Zylphrex · Pull Request #2843 · getsentry/sentry-python

X Title: feat(profiling): Add thread data to spans by Zylphrex · Pull Request #2843 · getsentry/sentry-python

Description: The official Python SDK for Sentry.io. Contribute to getsentry/sentry-python development by creating an account on GitHub.

Open Graph Description: As per getsentry/rfcs#75 getsentry/rfc#75, this adds the thread data to the spans. This will be needed for the continuous profiling mode in #2830.

X Description: As per getsentry/rfcs#75 getsentry/rfc#75, this adds the thread data to the spans. This will be needed for the continuous profiling mode in #2830.

Opengraph URL: https://github.com/getsentry/sentry-python/pull/2843

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7d1b4f8b-2dea-b73a-b90f-c788378db657
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8F6C:31F2FA:3322DE:475F45:6B008582
html-safe-nonce85f1415a084ef8454462b7ea5d2af59fbb5917a22e1c671e5b651232e3b382b6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjZDOjMxRjJGQTozMzIyREU6NDc1RjQ1OjZCMDA4NTgyIiwidmlzaXRvcl9pZCI6Ijg2MzAwODg3MzI2NzE3NzIwMzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd83e09860dcf97c58a9ddeb9cb62f66ac6e6b95de3df949216f85b413619f06b
hovercard-subject-tagpull_request:1778412233
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/getsentry/sentry-python/2843/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9800ffc89dfdb2c907e69dae380dcea24f056f5f7906bc8b94bb3ba9cbb925f0/getsentry/sentry-python/pull/2843
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9800ffc89dfdb2c907e69dae380dcea24f056f5f7906bc8b94bb3ba9cbb925f0/getsentry/sentry-python/pull/2843
og:image:altAs per getsentry/rfcs#75 getsentry/rfc#75, this adds the thread data to the spans. This will be needed for the continuous profiling mode in #2830.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameZylphrex
hostnamegithub.com
expected-hostnamegithub.com
None4d3d8e50f02c1d7bf86d5acfa1d3bfe9366abd6528a6b429eb07a168429d2b61
turbo-cache-controlno-cache
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedb758f8e02b8257935fb03edf81a3e76eb3abd11
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/2843#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F2843
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F2843
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/2843
Reloadhttps://github.com/getsentry/sentry-python/pull/2843
Reloadhttps://github.com/getsentry/sentry-python/pull/2843
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests41 (41)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
https://github.com/getsentry/sentry-python
Zylphrexhttps://github.com/Zylphrex
masterhttps://github.com/getsentry/sentry-python/tree/master
txiao/feat/add-thread-data-to-spanshttps://github.com/getsentry/sentry-python/tree/txiao/feat/add-thread-data-to-spans
Conversationhttps://github.com/getsentry/sentry-python/pull/2843
Commits21 (21)https://github.com/getsentry/sentry-python/pull/2843/commits
Checkshttps://github.com/getsentry/sentry-python/pull/2843/checks
Files changedhttps://github.com/getsentry/sentry-python/pull/2843/files
feat(profiling): Add thread data to spanshttps://github.com/getsentry/sentry-python/pull/2843#top
Zylphrexhttps://github.com/Zylphrex
masterhttps://github.com/getsentry/sentry-python/tree/master
txiao/feat/add-thread-data-to-spanshttps://github.com/getsentry/sentry-python/tree/txiao/feat/add-thread-data-to-spans
https://github.com/Zylphrex
Zylphrexhttps://github.com/Zylphrex
Mar 18, 2024https://github.com/getsentry/sentry-python/pull/2843#issue-2193328614
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2843
getsentry/rfcs#75https://github.com/getsentry/rfcs/pull/75
#2830https://github.com/getsentry/sentry-python/pull/2830
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2843
Zylphrexhttps://github.com/Zylphrex
March 18, 2024 17:09https://github.com/getsentry/sentry-python/pull/2843#commits-pushed-f44dec5
https://github.com/Zylphrex
feat(profiling): Add thread data to spanshttps://github.com/getsentry/sentry-python/pull/2843/commits/f44dec539501a0c556b7768da8c6650d7c56a6cd
f44dec5https://github.com/getsentry/sentry-python/pull/2843/commits/f44dec539501a0c556b7768da8c6650d7c56a6cd
#2830https://github.com/getsentry/sentry-python/pull/2830
https://github.com/Zylphrex
fix some testshttps://github.com/getsentry/sentry-python/pull/2843/commits/95331f53e00fb3b91426fe00e096425350e23fac
95331f5https://github.com/getsentry/sentry-python/pull/2843/commits/95331f53e00fb3b91426fe00e096425350e23fac
https://github.com/Zylphrex
Zylphrexhttps://github.com/Zylphrex
force-pushedhttps://github.com/getsentry/sentry-python/compare/2344d79549898b5e96cdc9c1e82317e8e91346c9..95331f53e00fb3b91426fe00e096425350e23fac
2344d79https://github.com/getsentry/sentry-python/commit/2344d79549898b5e96cdc9c1e82317e8e91346c9
95331f5https://github.com/getsentry/sentry-python/commit/95331f53e00fb3b91426fe00e096425350e23fac
Compare https://github.com/getsentry/sentry-python/compare/2344d79549898b5e96cdc9c1e82317e8e91346c9..95331f53e00fb3b91426fe00e096425350e23fac
March 18, 2024 21:41https://github.com/getsentry/sentry-python/pull/2843#event-12159827245
Zylphrexhttps://github.com/Zylphrex
March 18, 2024 17:58https://github.com/getsentry/sentry-python/pull/2843#commits-pushed-0bcd02f
https://github.com/Zylphrex
fix more testshttps://github.com/getsentry/sentry-python/pull/2843/commits/0bcd02f391249faa4f81d62dda0f11eb601d3c2c
0bcd02fhttps://github.com/getsentry/sentry-python/pull/2843/commits/0bcd02f391249faa4f81d62dda0f11eb601d3c2c
https://github.com/Zylphrex
fix even more testshttps://github.com/getsentry/sentry-python/pull/2843/commits/77f1f60688f01e8afbb5ad5b39bb927854ed39f8
77f1f60https://github.com/getsentry/sentry-python/pull/2843/commits/77f1f60688f01e8afbb5ad5b39bb927854ed39f8
https://github.com/Zylphrex
fix another testshttps://github.com/getsentry/sentry-python/pull/2843/commits/c39c69205e9007d4fe7ae8b97c06d12324f303d0
c39c692https://github.com/getsentry/sentry-python/pull/2843/commits/c39c69205e9007d4fe7ae8b97c06d12324f303d0
https://github.com/Zylphrex
fix a few more testshttps://github.com/getsentry/sentry-python/pull/2843/commits/5c6969a1367a784cdc70e378a6beb23b288132a2
5c6969ahttps://github.com/getsentry/sentry-python/pull/2843/commits/5c6969a1367a784cdc70e378a6beb23b288132a2
https://github.com/Zylphrex
fix even more testshttps://github.com/getsentry/sentry-python/pull/2843/commits/86d31a151817a60440c0a45a2ab08386ae77ddd5
86d31a1https://github.com/getsentry/sentry-python/pull/2843/commits/86d31a151817a60440c0a45a2ab08386ae77ddd5
https://github.com/Zylphrex
fix importhttps://github.com/getsentry/sentry-python/pull/2843/commits/e5019c5cc53d825e4bb1d662510c55468e5ed4ea
e5019c5https://github.com/getsentry/sentry-python/pull/2843/commits/e5019c5cc53d825e4bb1d662510c55468e5ed4ea
https://github.com/Zylphrex
fix a few more testshttps://github.com/getsentry/sentry-python/pull/2843/commits/079945387988d2c4613fd8b616fa194dde6bf2f0
0799453https://github.com/getsentry/sentry-python/pull/2843/commits/079945387988d2c4613fd8b616fa194dde6bf2f0
https://github.com/Zylphrex
fix another testhttps://github.com/getsentry/sentry-python/pull/2843/commits/120eeb70fb06956c5351e010eec024be4e57c354
120eeb7https://github.com/getsentry/sentry-python/pull/2843/commits/120eeb70fb06956c5351e010eec024be4e57c354
https://github.com/Zylphrex
fix yet another testhttps://github.com/getsentry/sentry-python/pull/2843/commits/f7baf774f4ac0e9d0a7b2978c7b1a8f3db17c1a6
f7baf77https://github.com/getsentry/sentry-python/pull/2843/commits/f7baf774f4ac0e9d0a7b2978c7b1a8f3db17c1a6
https://github.com/Zylphrex
fix more testshttps://github.com/getsentry/sentry-python/pull/2843/commits/dd584fa0e19f4845c01fa9d0999aaf92e4682ab1
dd584fahttps://github.com/getsentry/sentry-python/pull/2843/commits/dd584fa0e19f4845c01fa9d0999aaf92e4682ab1
https://github.com/Zylphrex
run blackhttps://github.com/getsentry/sentry-python/pull/2843/commits/88ed33ea1d691f0cb887fd97eff5ef7893249ae1
88ed33ehttps://github.com/getsentry/sentry-python/pull/2843/commits/88ed33ea1d691f0cb887fd97eff5ef7893249ae1
https://github.com/Zylphrex
we dont know the name of the gevent threadshttps://github.com/getsentry/sentry-python/pull/2843/commits/bb5e9b356ffcdfe2e5355edd8eb0fac2f2b1de84
bb5e9b3https://github.com/getsentry/sentry-python/pull/2843/commits/bb5e9b356ffcdfe2e5355edd8eb0fac2f2b1de84
https://github.com/Zylphrex
thread id should be stringhttps://github.com/getsentry/sentry-python/pull/2843/commits/0daeabde77efd3b6e5272c4a9d7ad48cbea966cd
0daeabdhttps://github.com/getsentry/sentry-python/pull/2843/commits/0daeabde77efd3b6e5272c4a9d7ad48cbea966cd
https://github.com/Zylphrex
Zylphrexhttps://github.com/Zylphrex
March 19, 2024 16:13https://github.com/getsentry/sentry-python/pull/2843#event-12172128565
https://github.com/Zylphrex
Zylphrexhttps://github.com/Zylphrex
antonpirkerhttps://github.com/antonpirker
sentrivanahttps://github.com/sentrivana
March 19, 2024 16:43https://github.com/getsentry/sentry-python/pull/2843#event-12172521366
https://github.com/antonpirker
antonpirkerhttps://github.com/antonpirker
Mar 20, 2024 https://github.com/getsentry/sentry-python/pull/2843#pullrequestreview-1948489580
View reviewed changes https://github.com/getsentry/sentry-python/pull/2843/files/0daeabde77efd3b6e5272c4a9d7ad48cbea966cd
antonpirkerhttps://github.com/antonpirker
https://github.com/getsentry/sentry-python/pull/2843#pullrequestreview-1948489580
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2843
https://github.com/Zylphrex
Zylphrexhttps://github.com/Zylphrex
Mar 20, 2024https://github.com/getsentry/sentry-python/pull/2843#issuecomment-2009724474
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2843
https://github.com/Zylphrex
Zylphrexhttps://github.com/Zylphrex
March 20, 2024 15:20https://github.com/getsentry/sentry-python/pull/2843#event-12186626774
Zylphrexhttps://github.com/Zylphrex
March 20, 2024 11:47https://github.com/getsentry/sentry-python/pull/2843#commits-pushed-6a87a36
https://github.com/Zylphrex
add a few more failure case testshttps://github.com/getsentry/sentry-python/pull/2843/commits/6a87a36c69f128dda680768d803dfd5bdbf260bc
6a87a36https://github.com/getsentry/sentry-python/pull/2843/commits/6a87a36c69f128dda680768d803dfd5bdbf260bc
https://github.com/Zylphrex
this syntax fails in older pythonhttps://github.com/getsentry/sentry-python/pull/2843/commits/d81a1de0598f037176ce2af09e753f53c75f4f1e
d81a1dehttps://github.com/getsentry/sentry-python/pull/2843/commits/d81a1de0598f037176ce2af09e753f53c75f4f1e
https://github.com/Zylphrex
Zylphrexhttps://github.com/Zylphrex
March 20, 2024 16:24https://github.com/getsentry/sentry-python/pull/2843#event-12187690229
Zylphrexhttps://github.com/Zylphrex
March 20, 2024 12:24https://github.com/getsentry/sentry-python/pull/2843#commits-pushed-1d05db3
https://github.com/Zylphrex
missed one morehttps://github.com/getsentry/sentry-python/pull/2843/commits/1d05db3c7bb49790e1fc11ae939ed401916fb2b8
1d05db3https://github.com/getsentry/sentry-python/pull/2843/commits/1d05db3c7bb49790e1fc11ae939ed401916fb2b8
https://github.com/Zylphrex
run blackhttps://github.com/getsentry/sentry-python/pull/2843/commits/33cb135a232aa9b8f99bbd9851a1162120087196
33cb135https://github.com/getsentry/sentry-python/pull/2843/commits/33cb135a232aa9b8f99bbd9851a1162120087196
https://github.com/Zylphrex
disable test for python<3.4https://github.com/getsentry/sentry-python/pull/2843/commits/5bf2efa468b239bb6348c127001616a525087c10
5bf2efahttps://github.com/getsentry/sentry-python/pull/2843/commits/5bf2efa468b239bb6348c127001616a525087c10
https://github.com/Zylphrex
Merge branch 'master' into txiao/feat/add-thread-data-to-spanshttps://github.com/getsentry/sentry-python/pull/2843/commits/6f3a00e04ab9d4e83f29991ddcb0f5219c677b31
6f3a00ehttps://github.com/getsentry/sentry-python/pull/2843/commits/6f3a00e04ab9d4e83f29991ddcb0f5219c677b31
https://github.com/Zylphrex
Zylphrexhttps://github.com/Zylphrex
48d7767https://github.com/getsentry/sentry-python/commit/48d77672a4e576de568f76ca7c64ca0d63b9d5fd
Mar 20, 2024https://github.com/getsentry/sentry-python/pull/2843#event-12189474249
https://github.com/Zylphrex
Zylphrexhttps://github.com/Zylphrex
March 20, 2024 18:24https://github.com/getsentry/sentry-python/pull/2843#event-12189474403
Bump sentry-sdk from 1.42.0 to 1.44.0 MozillaFoundation/foundation.mozilla.org#12129 https://github.com/MozillaFoundation/foundation.mozilla.org/pull/12129
Bump sentry-sdk from 1.42.0 to 1.44.1 MozillaFoundation/foundation.mozilla.org#12159 https://github.com/MozillaFoundation/foundation.mozilla.org/pull/12159
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F2843
https://github.com/sentrivana
sentrivana https://github.com/sentrivana
https://github.com/antonpirker
antonpirker https://github.com/antonpirker
https://github.com/getsentry/sentry-python/pull/2843/files/0daeabde77efd3b6e5272c4a9d7ad48cbea966cd
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2843
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2843
https://github.com/Zylphrex
https://github.com/antonpirker
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.