René's URL Explorer Experiment


Title: feat: metric span summaries by mitsuhiko · Pull Request #2522 · getsentry/sentry-python · GitHub

Open Graph Title: feat: metric span summaries by mitsuhiko · Pull Request #2522 · getsentry/sentry-python

X Title: feat: metric span summaries by mitsuhiko · Pull Request #2522 · getsentry/sentry-python

Description: The official Python SDK for Sentry.io. Contribute to getsentry/sentry-python development by creating an account on GitHub.

Open Graph Description: This PR adds metric summaries to spans. Refs this RFC: https://github.com/getsentry/rfcs/blob/main/text/0123-metrics-correlation.md For now they are guarded behind a sample rate which is 0 by defau...

X Description: This PR adds metric summaries to spans. Refs this RFC: https://github.com/getsentry/rfcs/blob/main/text/0123-metrics-correlation.md For now they are guarded behind a sample rate which is 0 by defau...

Opengraph URL: https://github.com/getsentry/sentry-python/pull/2522

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9e8e8174-c2b6-c18f-30f5-ec73bc8b165d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE600:0DB8:21CEF3:2EEE17:6B0085A7
html-safe-noncedc3a07373d2f9b2a3d68c221d8e7502d9519a98e9c1abea215237f9fd5fd07f6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjAwOjBEQjg6MjFDRUYzOjJFRUUxNzo2QjAwODVBNyIsInZpc2l0b3JfaWQiOiI0ODc0OTUzODMxNzAxNTc5MTc1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac65ea81ebbe77f6edf7265ab06db5c94d332829671876490fd2c6d40d3356d496
hovercard-subject-tagpull_request:1610886915
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/getsentry/sentry-python/2522/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/98563045997822d44b2bcd2ff4525eebaefd33f9045bbf46efefa348acf969d5/getsentry/sentry-python/pull/2522
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/98563045997822d44b2bcd2ff4525eebaefd33f9045bbf46efefa348acf969d5/getsentry/sentry-python/pull/2522
og:image:altThis PR adds metric summaries to spans. Refs this RFC: https://github.com/getsentry/rfcs/blob/main/text/0123-metrics-correlation.md For now they are guarded behind a sample rate which is 0 by defau...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemitsuhiko
hostnamegithub.com
expected-hostnamegithub.com
None4d3d8e50f02c1d7bf86d5acfa1d3bfe9366abd6528a6b429eb07a168429d2b61
turbo-cache-controlno-cache
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedb758f8e02b8257935fb03edf81a3e76eb3abd11
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/2522#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F2522
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F2522
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/2522
Reloadhttps://github.com/getsentry/sentry-python/pull/2522
Reloadhttps://github.com/getsentry/sentry-python/pull/2522
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests41 (41)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
https://github.com/getsentry/sentry-python
sentrivanahttps://github.com/sentrivana
masterhttps://github.com/getsentry/sentry-python/tree/master
feature/span-aggregationhttps://github.com/getsentry/sentry-python/tree/feature/span-aggregation
Conversationhttps://github.com/getsentry/sentry-python/pull/2522
Commits16 (16)https://github.com/getsentry/sentry-python/pull/2522/commits
Checkshttps://github.com/getsentry/sentry-python/pull/2522/checks
Files changedhttps://github.com/getsentry/sentry-python/pull/2522/files
feat: metric span summarieshttps://github.com/getsentry/sentry-python/pull/2522#top
sentrivanahttps://github.com/sentrivana
masterhttps://github.com/getsentry/sentry-python/tree/master
feature/span-aggregationhttps://github.com/getsentry/sentry-python/tree/feature/span-aggregation
https://github.com/mitsuhiko
mitsuhikohttps://github.com/mitsuhiko
Nov 21, 2023https://github.com/getsentry/sentry-python/pull/2522#issue-2004195704
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2522
https://github.com/getsentry/rfcs/blob/main/text/0123-metrics-correlation.mdhttps://github.com/getsentry/rfcs/blob/main/text/0123-metrics-correlation.md
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2522
mitsuhikohttps://github.com/mitsuhiko
November 20, 2023 14:51https://github.com/getsentry/sentry-python/pull/2522#commits-pushed-ca28591
https://github.com/mitsuhiko
wip: span aggregationhttps://github.com/getsentry/sentry-python/pull/2522/commits/ca28591bad2745d38da99e8bf1daf7819ab23a40
ca28591https://github.com/getsentry/sentry-python/pull/2522/commits/ca28591bad2745d38da99e8bf1daf7819ab23a40
https://github.com/mitsuhiko
Add metrics as summaries to protocolhttps://github.com/getsentry/sentry-python/pull/2522/commits/45ed1a6eda0949bae2998e794d18152364f154fc
45ed1a6https://github.com/getsentry/sentry-python/pull/2522/commits/45ed1a6eda0949bae2998e794d18152364f154fc
https://github.com/mitsuhiko
Fix min/maxhttps://github.com/getsentry/sentry-python/pull/2522/commits/72876d12cfc9fa7eaca99be8056c8a5fd0ec938f
72876d1https://github.com/getsentry/sentry-python/pull/2522/commits/72876d12cfc9fa7eaca99be8056c8a5fd0ec938f
https://github.com/mitsuhiko
Associate metric tags with the automatically created spanhttps://github.com/getsentry/sentry-python/pull/2522/commits/293fea6b07f3b9a8ab6122d20889e406d6fa8dc0
293fea6https://github.com/getsentry/sentry-python/pull/2522/commits/293fea6b07f3b9a8ab6122d20889e406d6fa8dc0
https://github.com/mitsuhiko
mitsuhikohttps://github.com/mitsuhiko
Nov 21, 2023 https://github.com/getsentry/sentry-python/pull/2522#ref-pullrequest-2004197235
Update the metrics correlation RFC based on recent feedback getsentry/rfcs#124 https://github.com/getsentry/rfcs/pull/124
mitsuhikohttps://github.com/mitsuhiko
November 21, 2023 13:44https://github.com/getsentry/sentry-python/pull/2522#commits-pushed-bf2e77f
https://github.com/mitsuhiko
Fixed a bughttps://github.com/getsentry/sentry-python/pull/2522/commits/bf2e77fe31f66ce7cd557a897f171075a6900268
bf2e77fhttps://github.com/getsentry/sentry-python/pull/2522/commits/bf2e77fe31f66ce7cd557a897f171075a6900268
https://github.com/mitsuhiko
Simplify local aggregatorhttps://github.com/getsentry/sentry-python/pull/2522/commits/2222383f47557f8618d953ade71c9ab38a5aa96d
2222383https://github.com/getsentry/sentry-python/pull/2522/commits/2222383f47557f8618d953ade71c9ab38a5aa96d
https://github.com/mitsuhiko
Simplify local aggregator addhttps://github.com/getsentry/sentry-python/pull/2522/commits/fd77e2db80cdadca572546c8292e7ce907f0aa7c
fd77e2dhttps://github.com/getsentry/sentry-python/pull/2522/commits/fd77e2db80cdadca572546c8292e7ce907f0aa7c
https://github.com/mitsuhiko
Add a global sample rate for metric summarieshttps://github.com/getsentry/sentry-python/pull/2522/commits/e259e1fe53793c9000da83ebc6b14144ede5b8b7
e259e1fhttps://github.com/getsentry/sentry-python/pull/2522/commits/e259e1fe53793c9000da83ebc6b14144ede5b8b7
https://github.com/mitsuhiko
Merge branch 'master' into feature/span-aggregationhttps://github.com/getsentry/sentry-python/pull/2522/commits/f0d87d242e6970abe8a3d3019814f2493cc53602
f0d87d2https://github.com/getsentry/sentry-python/pull/2522/commits/f0d87d242e6970abe8a3d3019814f2493cc53602
https://github.com/mitsuhiko
mitsuhikohttps://github.com/mitsuhiko
November 22, 2023 09:07https://github.com/getsentry/sentry-python/pull/2522#event-11033729532
mitsuhikohttps://github.com/mitsuhiko
November 23, 2023 09:47https://github.com/getsentry/sentry-python/pull/2522#commits-pushed-92825db
https://github.com/mitsuhiko
Added a dynamic callback for metric summary filteringhttps://github.com/getsentry/sentry-python/pull/2522/commits/92825dbac7b69d6b938c7865761d3b5315ec5954
92825dbhttps://github.com/getsentry/sentry-python/pull/2522/commits/92825dbac7b69d6b938c7865761d3b5315ec5954
https://github.com/mitsuhiko
Merge branch 'feature/span-aggregation' of github.com:getsentry/sentr…https://github.com/getsentry/sentry-python/pull/2522/commits/677ad471cf266a763feb5314a54773e50715cc6a
677ad47https://github.com/getsentry/sentry-python/pull/2522/commits/677ad471cf266a763feb5314a54773e50715cc6a
feat: Added metrics summary sample rates as options getsentry/sentry#60506 https://github.com/getsentry/sentry/pull/60506
Add metrics summaries to spans getsentry/sentry#60252 https://github.com/getsentry/sentry/issues/60252
feat(protocol): Add stub metric summaries to spans and the event getsentry/relay#2757 https://github.com/getsentry/relay/pull/2757
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
Nov 23, 2023 https://github.com/getsentry/sentry-python/pull/2522#pullrequestreview-1746457721
View reviewed changes https://github.com/getsentry/sentry-python/pull/2522/files/677ad471cf266a763feb5314a54773e50715cc6a
sentrivanahttps://github.com/sentrivana
https://github.com/getsentry/sentry-python/pull/2522#pullrequestreview-1746457721
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2522
tests/test_metrics.pyhttps://github.com/getsentry/sentry-python/pull/2522/files/677ad471cf266a763feb5314a54773e50715cc6a#diff-c013839ae9f8d11da7ba9ed964de9d4b9ef733c1dd3d1a5487f32a5b2062e1cf
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2522
https://github.com/mitsuhiko
mitsuhikohttps://github.com/mitsuhiko
Nov 27, 2023 https://github.com/getsentry/sentry-python/pull/2522#ref-issue-1990375364
[Milestone] Enhance Workflow getsentry/sentry#59833 https://github.com/getsentry/sentry/issues/59833
scttcperhttps://github.com/scttcper
Nov 27, 2023 https://github.com/getsentry/sentry-python/pull/2522#ref-commit-6f033b1
https://github.com/mitsuhiko
feat: Added metrics summary sample rates as options (https://github.com/getsentry/sentry/commit/6f033b1a26390af0c1198a00e732880e4a83d42b
#60506https://github.com/getsentry/sentry/pull/60506
)https://github.com/getsentry/sentry/commit/6f033b1a26390af0c1198a00e732880e4a83d42b
6f033b1https://github.com/getsentry/sentry/commit/6f033b1a26390af0c1198a00e732880e4a83d42b
getsentry/sentry-python#2522https://github.com/getsentry/sentry-python/pull/2522
https://github.com/mitsuhiko
Remove stray printhttps://github.com/getsentry/sentry-python/pull/2522/commits/5f66712a42a82268ed0f8b44adfe6e1815168d6a
5f66712https://github.com/getsentry/sentry-python/pull/2522/commits/5f66712a42a82268ed0f8b44adfe6e1815168d6a
https://github.com/bruno-garcia
bruno-garciahttps://github.com/bruno-garcia
Nov 28, 2023 https://github.com/getsentry/sentry-python/pull/2522#ref-issue-2005415131
Add Metrics API getsentry/sentry-dotnet#2880 https://github.com/getsentry/sentry-dotnet/issues/2880
mitsuhikohttps://github.com/mitsuhiko
November 29, 2023 09:04https://github.com/getsentry/sentry-python/pull/2522#commits-pushed-a692948
https://github.com/mitsuhiko
mergehttps://github.com/getsentry/sentry-python/pull/2522/commits/a692948fc77080127d1244d8dfc5b680a13ccb73
a692948https://github.com/getsentry/sentry-python/pull/2522/commits/a692948fc77080127d1244d8dfc5b680a13ccb73
https://github.com/mitsuhiko
Remove no longer needed workaroundhttps://github.com/getsentry/sentry-python/pull/2522/commits/ffa714afa107f2e478d8a0a2f3499676e164c308
ffa714ahttps://github.com/getsentry/sentry-python/pull/2522/commits/ffa714afa107f2e478d8a0a2f3499676e164c308
https://github.com/sentrivana
Merge branch 'master' into feature/span-aggregationhttps://github.com/getsentry/sentry-python/pull/2522/commits/a82d3074e5750fac1fd79b6bc0fc3c01a39884bc
a82d307https://github.com/getsentry/sentry-python/pull/2522/commits/a82d3074e5750fac1fd79b6bc0fc3c01a39884bc
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
Nov 29, 2023 https://github.com/getsentry/sentry-python/pull/2522#pullrequestreview-1754953507
View reviewed changes https://github.com/getsentry/sentry-python/pull/2522/files/28881b9285b4c41fe6fc356d2357ec0970b80975
sentrivanahttps://github.com/sentrivana
https://github.com/getsentry/sentry-python/pull/2522#pullrequestreview-1754953507
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2522
https://github.com/sentrivana
Merge branch 'master' into feature/span-aggregationhttps://github.com/getsentry/sentry-python/pull/2522/commits/28881b9285b4c41fe6fc356d2357ec0970b80975
28881b9https://github.com/getsentry/sentry-python/pull/2522/commits/28881b9285b4c41fe6fc356d2357ec0970b80975
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
November 29, 2023 11:20https://github.com/getsentry/sentry-python/pull/2522#event-11095048284
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
b250a89https://github.com/getsentry/sentry-python/commit/b250a8929d9238e7d8ab30b6e5af7dc1ec1b79bd
Nov 29, 2023https://github.com/getsentry/sentry-python/pull/2522#event-11095109581
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
November 29, 2023 11:26https://github.com/getsentry/sentry-python/pull/2522#event-11095109766
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F2522
https://github.com/sentrivana
sentrivana https://github.com/sentrivana
https://github.com/getsentry/sentry-python/pull/2522/files/28881b9285b4c41fe6fc356d2357ec0970b80975
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2522
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/2522
https://github.com/mitsuhiko
https://github.com/sentrivana
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.