René's URL Explorer Experiment


Title: fix(tracing): Break `transaction` / `span` circular references before garbage collection by lobsterkatie · Pull Request #1184 · getsentry/sentry-python · GitHub

Open Graph Title: fix(tracing): Break `transaction` / `span` circular references before garbage collection by lobsterkatie · Pull Request #1184 · getsentry/sentry-python

X Title: fix(tracing): Break `transaction` / `span` circular references before garbage collection by lobsterkatie · Pull Request #1184 · getsentry/sentry-python

Description: The official Python SDK for Sentry.io. Contribute to getsentry/sentry-python development by creating an account on GitHub.

Open Graph Description: Background for anyone not familiar with Python's internal workings (skip ahead if you that's not you): Python handles memory deallocation through a combination of reference counting and cyc...

X Description: Background for anyone not familiar with Python's internal workings (skip ahead if you that's not you): Python handles memory deallocation through a combination of reference counting...

Opengraph URL: https://github.com/getsentry/sentry-python/pull/1184

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:23465003-b356-c54d-7970-b12e4a3cba57
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id85D8:5885B:2FC67:410CF:6B007DE3
html-safe-nonce5837408276cab27cce8ff090da2fdb0b80b4696e74907540506370f580d46a16
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUQ4OjU4ODVCOjJGQzY3OjQxMENGOjZCMDA3REUzIiwidmlzaXRvcl9pZCI6IjcyMzIyNTk5ODk0NTk0Njc3NDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbf6262ee968256cc72cb3dcf436e1eaa351340e15ed4e44ec3ea0c3e1de4b0f9
hovercard-subject-tagpull_request:729028343
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/getsentry/sentry-python/1184/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9eff63565a8bad91fb3b561666cef7852155efcdc2711be9b97f21faf8bd7cd7/getsentry/sentry-python/pull/1184
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9eff63565a8bad91fb3b561666cef7852155efcdc2711be9b97f21faf8bd7cd7/getsentry/sentry-python/pull/1184
og:image:altBackground for anyone not familiar with Python's internal workings (skip ahead if you that's not you): Python handles memory deallocation through a combination of reference counting and cyc...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelobsterkatie
hostnamegithub.com
expected-hostnamegithub.com
None82c186f13e104004ab7bdb779f3195e59dd38bfde531aaa74b76470fc2462b83
turbo-cache-controlno-cache
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released1bc2aa1939001689f5ce935982c10a6138f745c
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/1184#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F1184
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F1184
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/1184
Reloadhttps://github.com/getsentry/sentry-python/pull/1184
Reloadhttps://github.com/getsentry/sentry-python/pull/1184
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests41 (41)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
https://github.com/getsentry/sentry-python
lobsterkatiehttps://github.com/lobsterkatie
kmclb-add-tracestate-header-handlinghttps://github.com/getsentry/sentry-python/tree/kmclb-add-tracestate-header-handling
kmclb-fix-transaction-span-circular-referencehttps://github.com/getsentry/sentry-python/tree/kmclb-fix-transaction-span-circular-reference
Conversationhttps://github.com/getsentry/sentry-python/pull/1184
Commits6 (6)https://github.com/getsentry/sentry-python/pull/1184/commits
Checkshttps://github.com/getsentry/sentry-python/pull/1184/checks
Files changedhttps://github.com/getsentry/sentry-python/pull/1184/files
fix(tracing): Break transaction / span circular references before garbage collectionhttps://github.com/getsentry/sentry-python/pull/1184#top
lobsterkatiehttps://github.com/lobsterkatie
kmclb-add-tracestate-header-handlinghttps://github.com/getsentry/sentry-python/tree/kmclb-add-tracestate-header-handling
kmclb-fix-transaction-span-circular-referencehttps://github.com/getsentry/sentry-python/tree/kmclb-fix-transaction-span-circular-reference
https://github.com/lobsterkatie
lobsterkatiehttps://github.com/lobsterkatie
Sep 7, 2021https://github.com/getsentry/sentry-python/pull/1184#issue-990438633
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/1184
https://devguide.python.org/garbage_collector/https://devguide.python.org/garbage_collector/
https://docs.python.org/3/library/gc.html?highlight=gc#module-gchttps://docs.python.org/3/library/gc.html?highlight=gc#module-gc
@untitakerhttps://github.com/untitaker
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/1184
https://github.com/untitaker
untitakerhttps://github.com/untitaker
force-pushedhttps://github.com/getsentry/sentry-python/compare/bd3123d01f85790c20bae9b7fa315a36a62d6438..531aee151f1ed5d9d83b5689fe84f428ed84571e
bd3123dhttps://github.com/getsentry/sentry-python/commit/bd3123d01f85790c20bae9b7fa315a36a62d6438
531aee1https://github.com/getsentry/sentry-python/commit/531aee151f1ed5d9d83b5689fe84f428ed84571e
Compare https://github.com/getsentry/sentry-python/compare/bd3123d01f85790c20bae9b7fa315a36a62d6438..531aee151f1ed5d9d83b5689fe84f428ed84571e
September 8, 2021 11:51https://github.com/getsentry/sentry-python/pull/1184#event-5271790172
https://github.com/lobsterkatie
lobsterkatiehttps://github.com/lobsterkatie
force-pushedhttps://github.com/getsentry/sentry-python/compare/ebf9b56a11f3d43514db3077f5fe399d353ec052..3d5008572ddbd40e82a541b4a5628f46f7ce45d9
ebf9b56https://github.com/getsentry/sentry-python/commit/ebf9b56a11f3d43514db3077f5fe399d353ec052
3d50085https://github.com/getsentry/sentry-python/commit/3d5008572ddbd40e82a541b4a5628f46f7ce45d9
Compare https://github.com/getsentry/sentry-python/compare/ebf9b56a11f3d43514db3077f5fe399d353ec052..3d5008572ddbd40e82a541b4a5628f46f7ce45d9
September 10, 2021 06:17https://github.com/getsentry/sentry-python/pull/1184#event-5282578310
lobsterkatiehttps://github.com/lobsterkatie
September 10, 2021 00:15https://github.com/getsentry/sentry-python/pull/1184#commits-pushed-114e251
https://github.com/lobsterkatie
stop adding transaction to span recorderhttps://github.com/getsentry/sentry-python/pull/1184/commits/114e251944a63c8f992956e12d30fb7735d4fc4e
114e251https://github.com/getsentry/sentry-python/pull/1184/commits/114e251944a63c8f992956e12d30fb7735d4fc4e
https://github.com/lobsterkatie
get to span recorder through transaction rather than storing it on spanhttps://github.com/getsentry/sentry-python/pull/1184/commits/dfdf9aa6e961e42d36b9e9215ce88b34b9a96ac4
dfdf9aahttps://github.com/getsentry/sentry-python/pull/1184/commits/dfdf9aa6e961e42d36b9e9215ce88b34b9a96ac4
https://github.com/lobsterkatie
break transaction -> span recorder -> span -> containing transaction …https://github.com/getsentry/sentry-python/pull/1184/commits/4f5c1bf01fe730fc05d924a2d23636ce407a6a0b
4f5c1bfhttps://github.com/getsentry/sentry-python/pull/1184/commits/4f5c1bf01fe730fc05d924a2d23636ce407a6a0b
https://github.com/lobsterkatie
lobsterkatiehttps://github.com/lobsterkatie
force-pushedhttps://github.com/getsentry/sentry-python/compare/3d5008572ddbd40e82a541b4a5628f46f7ce45d9..1cd961fbe49cdbe5b090cc7cfbde05e01f9d6c43
3d50085https://github.com/getsentry/sentry-python/commit/3d5008572ddbd40e82a541b4a5628f46f7ce45d9
1cd961fhttps://github.com/getsentry/sentry-python/commit/1cd961fbe49cdbe5b090cc7cfbde05e01f9d6c43
Compare https://github.com/getsentry/sentry-python/compare/3d5008572ddbd40e82a541b4a5628f46f7ce45d9..1cd961fbe49cdbe5b090cc7cfbde05e01f9d6c43
September 10, 2021 07:19https://github.com/getsentry/sentry-python/pull/1184#event-5282796212
lobsterkatiehttps://github.com/lobsterkatie
September 10, 2021 01:49https://github.com/getsentry/sentry-python/pull/1184#commits-pushed-577600b
https://github.com/lobsterkatie
add circular reference testhttps://github.com/getsentry/sentry-python/pull/1184/commits/577600b76ac5413e84dfbe3772899c0434c7b421
577600bhttps://github.com/getsentry/sentry-python/pull/1184/commits/577600b76ac5413e84dfbe3772899c0434c7b421
https://github.com/lobsterkatie
fix sqlalchemy testhttps://github.com/getsentry/sentry-python/pull/1184/commits/9fe89d0322206d8d6dce86d9356a70ac87ae1595
9fe89d0https://github.com/getsentry/sentry-python/pull/1184/commits/9fe89d0322206d8d6dce86d9356a70ac87ae1595
https://github.com/lobsterkatie
lobsterkatiehttps://github.com/lobsterkatie
force-pushedhttps://github.com/getsentry/sentry-python/compare/1cd961fbe49cdbe5b090cc7cfbde05e01f9d6c43..9fe89d0322206d8d6dce86d9356a70ac87ae1595
1cd961fhttps://github.com/getsentry/sentry-python/commit/1cd961fbe49cdbe5b090cc7cfbde05e01f9d6c43
9fe89d0https://github.com/getsentry/sentry-python/commit/9fe89d0322206d8d6dce86d9356a70ac87ae1595
Compare https://github.com/getsentry/sentry-python/compare/1cd961fbe49cdbe5b090cc7cfbde05e01f9d6c43..9fe89d0322206d8d6dce86d9356a70ac87ae1595
September 10, 2021 08:50https://github.com/getsentry/sentry-python/pull/1184#event-5283217588
https://github.com/untitaker
untitakerhttps://github.com/untitaker
Sep 10, 2021 https://github.com/getsentry/sentry-python/pull/1184#pullrequestreview-751398859
View reviewed changes https://github.com/getsentry/sentry-python/pull/1184/files/9fe89d0322206d8d6dce86d9356a70ac87ae1595
tests/integrations/sqlalchemy/test_sqlalchemy.pyhttps://github.com/getsentry/sentry-python/pull/1184/files/9fe89d0322206d8d6dce86d9356a70ac87ae1595#diff-79037249d5849a3209d4dc312145654a9f3f6e9168404f828b19a85782b6c321
untitakerhttps://github.com/untitaker
Sep 10, 2021https://github.com/getsentry/sentry-python/pull/1184#discussion_r706172390
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/1184
lobsterkatiehttps://github.com/lobsterkatie
Sep 13, 2021https://github.com/getsentry/sentry-python/pull/1184#discussion_r707406801
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/1184
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/1184
tests/tracing/test_misc.pyhttps://github.com/getsentry/sentry-python/pull/1184/files/9fe89d0322206d8d6dce86d9356a70ac87ae1595#diff-3e743413fb15a66395482f0e3a4c79a94010c629c8acc6428a1958dcefc2c78c
untitakerhttps://github.com/untitaker
Sep 10, 2021https://github.com/getsentry/sentry-python/pull/1184#discussion_r706172585
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/1184
sentry_sdk/tracing.pyhttps://github.com/getsentry/sentry-python/pull/1184/files/9fe89d0322206d8d6dce86d9356a70ac87ae1595#diff-771cb012ea65fcb826b77e2abb36b504fdf3407fbe8054857b05fe5a41ed5164
untitakerhttps://github.com/untitaker
Sep 10, 2021https://github.com/getsentry/sentry-python/pull/1184#discussion_r706173603
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/1184
lobsterkatiehttps://github.com/lobsterkatie
Sep 13, 2021https://github.com/getsentry/sentry-python/pull/1184#discussion_r707501820
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/1184
https://github.com/lobsterkatie
mock uuid4https://github.com/getsentry/sentry-python/pull/1184/commits/ef45c8511de2a5c35a475b8b555a92c564483ab7
ef45c85https://github.com/getsentry/sentry-python/pull/1184/commits/ef45c8511de2a5c35a475b8b555a92c564483ab7
https://github.com/lobsterkatie
lobsterkatiehttps://github.com/lobsterkatie
force-pushedhttps://github.com/getsentry/sentry-python/compare/999b5ca5e17ee713b405308e60249cd4689ef3b4..ef45c8511de2a5c35a475b8b555a92c564483ab7
999b5cahttps://github.com/getsentry/sentry-python/commit/999b5ca5e17ee713b405308e60249cd4689ef3b4
ef45c85https://github.com/getsentry/sentry-python/commit/ef45c8511de2a5c35a475b8b555a92c564483ab7
Compare https://github.com/getsentry/sentry-python/compare/999b5ca5e17ee713b405308e60249cd4689ef3b4..ef45c8511de2a5c35a475b8b555a92c564483ab7
September 13, 2021 19:54https://github.com/getsentry/sentry-python/pull/1184#event-5295184516
https://github.com/lobsterkatie
lobsterkatiehttps://github.com/lobsterkatie
48cadf1https://github.com/getsentry/sentry-python/commit/48cadf10da994478cb42f90ec9e5b44881e8c092
Sep 13, 2021https://github.com/getsentry/sentry-python/pull/1184#event-5295416739
https://github.com/lobsterkatie
lobsterkatiehttps://github.com/lobsterkatie
September 13, 2021 20:43https://github.com/getsentry/sentry-python/pull/1184#event-5295416764
lobsterkatiehttps://github.com/lobsterkatie
Sep 13, 2021 https://github.com/getsentry/sentry-python/pull/1184#ref-commit-27240ee
https://github.com/lobsterkatie
fix(tracing): Break transaction / span circular references before…https://github.com/getsentry/sentry-python/commit/27240eeccc882b71f46aea1946bdd1567c46ccf8
27240eehttps://github.com/getsentry/sentry-python/commit/27240eeccc882b71f46aea1946bdd1567c46ccf8
#1184https://github.com/getsentry/sentry-python/pull/1184
https://github.com/lobsterkatie
lobsterkatiehttps://github.com/lobsterkatie
Sep 13, 2021 https://github.com/getsentry/sentry-python/pull/1184#ref-pullrequest-985366187
feat(tracing): Add tracestate header handling #1179 https://github.com/getsentry/sentry-python/pull/1179
lobsterkatiehttps://github.com/lobsterkatie
Sep 16, 2021 https://github.com/getsentry/sentry-python/pull/1184#ref-commit-54bc81c
https://github.com/lobsterkatie
feat(tracing): Addhttps://github.com/getsentry/sentry-python/commit/54bc81cfb68d4c1df752d2358b8caf1969f1490d
tracestatehttps://github.com/getsentry/sentry-python/commit/54bc81cfb68d4c1df752d2358b8caf1969f1490d
header handling (https://github.com/getsentry/sentry-python/commit/54bc81cfb68d4c1df752d2358b8caf1969f1490d
#1179https://github.com/getsentry/sentry-python/pull/1179
)https://github.com/getsentry/sentry-python/commit/54bc81cfb68d4c1df752d2358b8caf1969f1490d
54bc81chttps://github.com/getsentry/sentry-python/commit/54bc81cfb68d4c1df752d2358b8caf1969f1490d
#1173https://github.com/getsentry/sentry-python/pull/1173
#1184https://github.com/getsentry/sentry-python/pull/1184
#971https://github.com/getsentry/sentry-python/pull/971
https://www.w3.org/TR/trace-context/#tracestate-headerhttps://www.w3.org/TR/trace-context/#tracestate-header
https://develop.sentry.dev/sdk/performance/trace-context/https://develop.sentry.dev/sdk/performance/trace-context/
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F1184
https://github.com/untitaker
untitaker https://github.com/untitaker
https://github.com/getsentry/sentry-python/pull/1184/files/9fe89d0322206d8d6dce86d9356a70ac87ae1595
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/1184
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/1184
https://github.com/lobsterkatie
https://github.com/untitaker
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.