René's URL Explorer Experiment


Title: bug(flask): Transactions missing body by ahmedetefy · Pull Request #1034 · getsentry/sentry-python · GitHub

Open Graph Title: bug(flask): Transactions missing body by ahmedetefy · Pull Request #1034 · getsentry/sentry-python

X Title: bug(flask): Transactions missing body by ahmedetefy · Pull Request #1034 · getsentry/sentry-python

Description: The official Python SDK for Sentry.io. Contribute to getsentry/sentry-python development by creating an account on GitHub.

Open Graph Description: This PR fixes the bug that transactions were missing data/body because weakref to the request object was garbage collected before the request object made into the event_processor Removed weakref t...

X Description: This PR fixes the bug that transactions were missing data/body because weakref to the request object was garbage collected before the request object made into the event_processor Removed weakref t...

Opengraph URL: https://github.com/getsentry/sentry-python/pull/1034

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2100207a-e3b0-f1ec-a345-ee675af043be
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8538:200C95:2437F9:3077FD:6B0085AC
html-safe-nonce95259800ede256dfbddf85c5dedafe661f0b89f5f51a7fc8191e62adbd31db79
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTM4OjIwMEM5NToyNDM3Rjk6MzA3N0ZEOjZCMDA4NUFDIiwidmlzaXRvcl9pZCI6IjYxMzEzODU3MTg4ODQzMDQzMDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8418bd8b1e38e510a1c8b0fb2ca4ebc6ffd05364656e3988a929c915dc466a0f
hovercard-subject-tagpull_request:580761398
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/getsentry/sentry-python/1034/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3de12b46678ce5681ff8c754c240dc2ec3077b752dd162153d52406ba96c3f21/getsentry/sentry-python/pull/1034
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3de12b46678ce5681ff8c754c240dc2ec3077b752dd162153d52406ba96c3f21/getsentry/sentry-python/pull/1034
og:image:altThis PR fixes the bug that transactions were missing data/body because weakref to the request object was garbage collected before the request object made into the event_processor Removed weakref t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameahmedetefy
hostnamegithub.com
expected-hostnamegithub.com
None4d3d8e50f02c1d7bf86d5acfa1d3bfe9366abd6528a6b429eb07a168429d2b61
turbo-cache-controlno-cache
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedb758f8e02b8257935fb03edf81a3e76eb3abd11
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/pull/1034#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F1034
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F1034
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/pull/1034
Reloadhttps://github.com/getsentry/sentry-python/pull/1034
Reloadhttps://github.com/getsentry/sentry-python/pull/1034
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests41 (41)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
https://github.com/getsentry/sentry-python
ahmedetefyhttps://github.com/ahmedetefy
masterhttps://github.com/getsentry/sentry-python/tree/master
bug/flask_transaction_missing_bodyhttps://github.com/getsentry/sentry-python/tree/bug/flask_transaction_missing_body
Conversationhttps://github.com/getsentry/sentry-python/pull/1034
Commits4 (4)https://github.com/getsentry/sentry-python/pull/1034/commits
Checkshttps://github.com/getsentry/sentry-python/pull/1034/checks
Files changedhttps://github.com/getsentry/sentry-python/pull/1034/files
bug(flask): Transactions missing bodyhttps://github.com/getsentry/sentry-python/pull/1034#top
ahmedetefyhttps://github.com/ahmedetefy
masterhttps://github.com/getsentry/sentry-python/tree/master
bug/flask_transaction_missing_bodyhttps://github.com/getsentry/sentry-python/tree/bug/flask_transaction_missing_body
https://github.com/ahmedetefy
ahmedetefyhttps://github.com/ahmedetefy
Feb 26, 2021https://github.com/getsentry/sentry-python/pull/1034#issue-817235771
https://app.asana.com/0/1142928854421177/1199663160066590https://app.asana.com/0/1142928854421177/1199663160066590
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/1034
ahmedetefyhttps://github.com/ahmedetefy
February 26, 2021 10:41https://github.com/getsentry/sentry-python/pull/1034#commits-pushed-a3206d0
https://github.com/ahmedetefy
Add test that ensreus transaction includes body data even if no excep…https://github.com/getsentry/sentry-python/pull/1034/commits/a3206d07cd50b17e516cbbee9eb2d15eba35d14b
a3206d0https://github.com/getsentry/sentry-python/pull/1034/commits/a3206d07cd50b17e516cbbee9eb2d15eba35d14b
https://github.com/ahmedetefy
Removed weakref to request that was being gc before it was passed to …https://github.com/getsentry/sentry-python/pull/1034/commits/9691f96b7072bd1a8785a60790d3a5a53ed10604
9691f96https://github.com/getsentry/sentry-python/pull/1034/commits/9691f96b7072bd1a8785a60790d3a5a53ed10604
fix: Formattinghttps://github.com/getsentry/sentry-python/pull/1034/commits/231b18b951d923c3c997f4eebe95aac047ab20ff
231b18bhttps://github.com/getsentry/sentry-python/pull/1034/commits/231b18b951d923c3c997f4eebe95aac047ab20ff
https://github.com/ahmedetefy
ahmedetefyhttps://github.com/ahmedetefy
untitakerhttps://github.com/untitaker
February 26, 2021 10:29https://github.com/getsentry/sentry-python/pull/1034#event-4381144752
https://github.com/untitaker
untitakerhttps://github.com/untitaker
Feb 26, 2021 https://github.com/getsentry/sentry-python/pull/1034#pullrequestreview-599447954
View reviewed changes https://github.com/getsentry/sentry-python/pull/1034/files/231b18b951d923c3c997f4eebe95aac047ab20ff
untitakerhttps://github.com/untitaker
https://github.com/getsentry/sentry-python/pull/1034#pullrequestreview-599447954
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/1034
https://github.com/ahmedetefy
ahmedetefyhttps://github.com/ahmedetefy
Feb 26, 2021https://github.com/getsentry/sentry-python/pull/1034#issuecomment-786561997
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/1034
https://github.com/ahmedetefy
Linting fixeshttps://github.com/getsentry/sentry-python/pull/1034/commits/9a8cba8b3257a6378471db5140cccd9d0c9ee244
9a8cba8https://github.com/getsentry/sentry-python/pull/1034/commits/9a8cba8b3257a6378471db5140cccd9d0c9ee244
https://github.com/ahmedetefy
ahmedetefyhttps://github.com/ahmedetefy
Feb 26, 2021https://github.com/getsentry/sentry-python/pull/1034#issuecomment-786620971
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/1034
https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/integrations/flask.py#L117-L119https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/integrations/flask.py#L117-L119
@untitakerhttps://github.com/untitaker
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/1034
https://github.com/untitaker
untitakerhttps://github.com/untitaker
Feb 26, 2021https://github.com/getsentry/sentry-python/pull/1034#issuecomment-786703415
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/1034
https://github.com/ahmedetefy
ahmedetefyhttps://github.com/ahmedetefy
ed7d722https://github.com/getsentry/sentry-python/commit/ed7d722fdd086a1044d44bc28f2d29a91d87d8ca
Mar 2, 2021https://github.com/getsentry/sentry-python/pull/1034#event-4394392386
https://github.com/ahmedetefy
ahmedetefyhttps://github.com/ahmedetefy
March 2, 2021 08:28https://github.com/getsentry/sentry-python/pull/1034#event-4394392451
alexmvhttps://github.com/alexmv
Mar 5, 2021 https://github.com/getsentry/sentry-python/pull/1034#ref-commit-2fdbb1d
https://github.com/alexmv
requirements: Upgrade via ./scripts/upgrade-requirementshttps://github.com/CAVaccineInventory/vial/commit/2fdbb1de38c91488267350d306a80a559662a93f
2fdbb1dhttps://github.com/CAVaccineInventory/vial/commit/2fdbb1de38c91488267350d306a80a559662a93f
getsentry/sentry-python#994https://github.com/getsentry/sentry-python/pull/994
getsentry/sentry-python#1035https://github.com/getsentry/sentry-python/pull/1035
getsentry/sentry-python#1034https://github.com/getsentry/sentry-python/pull/1034
getsentry/sentry-python#1037https://github.com/getsentry/sentry-python/pull/1037
getsentry/sentry-python#1032https://github.com/getsentry/sentry-python/pull/1032
https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.mdhttps://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md
Bump sentry-sdk from 0.19.5 to 1.0.0 freelawproject/courtlistener#1608 https://github.com/freelawproject/courtlistener/pull/1608
Bump sentry-sdk from 0.20.3 to 1.0.0 philgyford/django-hines#275 https://github.com/philgyford/django-hines/pull/275
Bump sentry-sdk from 0.20.3 to 1.0.0 in /natlas-agent natlas/natlas#688 https://github.com/natlas/natlas/pull/688
Bump sentry-sdk from 0.17.3 to 1.0.0 in /backend emilfars/code-review#137 https://github.com/emilfars/code-review/pull/137
Bump sentry-sdk[flask] from 0.18.0 to 1.0.0 olivluca/alerta#20 https://github.com/olivluca/alerta/pull/20
Update sentry-sdk[flask] requirement from ~=0.19.5 to ~=1.0.0 ComputerScienceHouse/profiles#92 https://github.com/ComputerScienceHouse/profiles/pull/92
Bump sentry-sdk from 0.20.3 to 1.0.0 oddbird/Metecho#909 https://github.com/oddbird/Metecho/pull/909
Bump sentry-sdk from 0.19.5 to 1.0.0 hsm207/rasa#157 https://github.com/hsm207/rasa/pull/157
Bump sentry-sdk from 0.19.5 to 1.0.0 metriqteam/rasa#7 https://github.com/metriqteam/rasa/pull/7
Bump sentry-sdk from 0.20.3 to 1.0.0 python-discord/forms-backend#71 https://github.com/python-discord/forms-backend/pull/71
Bump sentry-sdk from 0.20.3 to 1.0.0 SaravgiYash/openlibrary#52 https://github.com/SaravgiYash/openlibrary/pull/52
Bump sentry-sdk from 0.20.3 to 1.0.0 internetarchive/openlibrary#4821 https://github.com/internetarchive/openlibrary/pull/4821
Bump sentry-sdk from 0.17.3 to 1.0.0 alphagov/govuk-shielded-vulnerable-people-service#325 https://github.com/alphagov/govuk-shielded-vulnerable-people-service/pull/325
Bump sentry-sdk from 0.17.3 to 1.0.0 alphagov/transfer-coronavirus-data-service#116 https://github.com/alphagov/transfer-coronavirus-data-service/pull/116
Bump sentry-sdk from 0.18.0 to 1.0.0 eddieferrer/sizesquirrel-open#214 https://github.com/eddieferrer/sizesquirrel-open/pull/214
https://github.com/ahmedetefy
ahmedetefyhttps://github.com/ahmedetefy
Mar 19, 2021 https://github.com/getsentry/sentry-python/pull/1034#ref-pullrequest-835773472
feat: Support tracing on Tornado #1060 https://github.com/getsentry/sentry-python/pull/1060
https://github.co/hiddenchars
https://github.com/getsentry/sentry-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fpull%2F1034
https://github.com/untitaker
untitaker https://github.com/untitaker
https://github.com/getsentry/sentry-python/pull/1034/files/231b18b951d923c3c997f4eebe95aac047ab20ff
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/1034
Please reload this pagehttps://github.com/getsentry/sentry-python/pull/1034
https://github.com/ahmedetefy
https://github.com/untitaker
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.