René's URL Explorer Experiment


Title: SpanBatcher serializes spans while holding its buffer lock · Issue #8023 · getsentry/sentry-python · GitHub

Open Graph Title: SpanBatcher serializes spans while holding its buffer lock · Issue #8023 · getsentry/sentry-python

X Title: SpanBatcher serializes spans while holding its buffer lock · Issue #8023 · getsentry/sentry-python

Description: Problem SpanBatcher._flush() holds _lock while calling _dynamic_sampling_context() and serializing spans with _to_transport_format(). This blocks concurrent additions for the entire serialization step and leaves a possible re-entrant loc...

Open Graph Description: Problem SpanBatcher._flush() holds _lock while calling _dynamic_sampling_context() and serializing spans with _to_transport_format(). This blocks concurrent additions for the entire serialization s...

X Description: Problem SpanBatcher._flush() holds _lock while calling _dynamic_sampling_context() and serializing spans with _to_transport_format(). This blocks concurrent additions for the entire serialization s...

Opengraph URL: https://github.com/getsentry/sentry-python/issues/8023

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"SpanBatcher serializes spans while holding its buffer lock","articleBody":"### Problem\n\n`SpanBatcher._flush()` holds `_lock` while calling `_dynamic_sampling_context()` and serializing spans with `_to_transport_format()`. This blocks concurrent additions for the entire serialization step and leaves a possible re-entrant lock-order hazard. The related fix in #7776 explicitly excludes `SpanBatcher`.\n\n### Reproduction\n\nPatch `_to_transport_format` to pause on a `threading.Event`, then try `batcher._lock.acquire(blocking=False)` from another thread. It fails while serialization is in progress on `master`.\n\n### Proposed fix\n\nDetach selected per-trace buffers under the lock, serialize outside the lock, and restore detached spans ahead of newly arrived spans if serialization fails. Keep the existing per-trace envelope boundaries.\n\nA small candidate patch and three regression tests are on [this branch](https://github.com/mhatipog/sentry-python/tree/fix/span-batcher-flush-outside-lock). Local focused tests against SDK 2.61.0: **3 failed on baseline, 3 passed with the patch**. Full upstream CI has not been run.\n\nWould this approach be acceptable? I'll hold the draft PR until a maintainer has weighed in, in line with CONTRIBUTING.md.","author":{"url":"https://github.com/mhatipog","@type":"Person","name":"mhatipog"},"datePublished":"2026-10-13T23:38:28Z","url":"https://github.com/getsentry/sentry-python/issues/8023"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:d2013d9a-7fb0-ed41-d48b-4ab7a7efbcfc
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9E36:134361:BC2C99:F90A37:6B00F097
html-safe-nonce79c941797a8eb6c9158bc3ba2180ab3470390bc64e4fc24cd58f5201d4327c4c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTM2OjEzNDM2MTpCQzJDOTk6RjkwQTM3OjZCMDBGMDk3IiwidmlzaXRvcl9pZCI6IjEyNTE5OTMxMTc1ODY5NDQxNTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7868c129c872513c1bdd639df63b22b96e6cbfa9c79bbef8c7e018c6f1106054
hovercard-subject-tagissue:5839379060
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/getsentry/sentry-python/8023/issue_layout
twitter:imagehttps://opengraph.githubassets.com/da6cc28d6043342d367470dc266c5ca3e4dabf5f46a818a38a15e6ad224aad5e/getsentry/sentry-python/issues/8023
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/da6cc28d6043342d367470dc266c5ca3e4dabf5f46a818a38a15e6ad224aad5e/getsentry/sentry-python/issues/8023
og:image:altProblem SpanBatcher._flush() holds _lock while calling _dynamic_sampling_context() and serializing spans with _to_transport_format(). This blocks concurrent additions for the entire serialization s...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemhatipog
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/issues/8023#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fissues%2F8023
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fissues%2F8023
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/issues/8023
Reloadhttps://github.com/getsentry/sentry-python/issues/8023
Reloadhttps://github.com/getsentry/sentry-python/issues/8023
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
https://github.com/getsentry/sentry-python
New issuehttps://github.com/login?return_to=https://github.com/getsentry/sentry-python/issues/8023
New issuehttps://github.com/login?return_to=https://github.com/getsentry/sentry-python/issues/8023
SpanBatcher serializes spans while holding its buffer lockhttps://github.com/getsentry/sentry-python/issues/8023#top
Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Bug%22
PythonSDKhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Python%22
https://github.com/mhatipog
mhatipoghttps://github.com/mhatipog
on Oct 13, 2026https://github.com/getsentry/sentry-python/issues/8023#issue-5839379060
#7776https://github.com/getsentry/sentry-python/pull/7776
this branchhttps://github.com/mhatipog/sentry-python/tree/fix/span-batcher-flush-outside-lock
getsantryhttps://github.com/apps/getsantry
Waiting for: Product Ownerhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Waiting%20for%3A%20Product%20Owner%22
on Oct 13, 2026https://github.com/getsentry/sentry-python/issues/8023#event-33180861220
https://github.com/apps/linear-code
linear-codehttps://github.com/apps/linear-code
on Oct 13, 2026https://github.com/getsentry/sentry-python/issues/8023#issuecomment-6157499168
Linear Codehttps://linear.app
PY-2999https://linear.app/getsentry/issue/PY-2999
getsantryhttps://github.com/apps/getsantry
GitHub Issues with 👀 3https://github.com/orgs/getsentry/projects/227
on Oct 13, 2026https://github.com/getsentry/sentry-python/issues/8023
getsantryhttps://github.com/apps/getsantry
GitHub Issues with 👀 3https://github.com/orgs/getsentry/projects/227
on Oct 13, 2026https://github.com/getsentry/sentry-python/issues/8023#event-33423896561
linear-codehttps://github.com/apps/linear-code
Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Bug%22
PythonSDKhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Python%22
on Oct 13, 2026https://github.com/getsentry/sentry-python/issues/8023#event-33180887422
sentrivanahttps://github.com/sentrivana
Waiting for: Product Ownerhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Waiting%20for%3A%20Product%20Owner%22
on Oct 14, 2026https://github.com/getsentry/sentry-python/issues/8023#event-33208299600
getsantryhttps://github.com/apps/getsantry
GitHub Issues with 👀 3https://github.com/orgs/getsentry/projects/227
on Oct 14, 2026https://github.com/getsentry/sentry-python/issues/8023
Sign up for freehttps://github.com/signup?return_to=https://github.com/getsentry/sentry-python/issues/8023
Sign in to commenthttps://github.com/login?return_to=https://github.com/getsentry/sentry-python/issues/8023
Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Bug%22
PythonSDKhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Python%22
GitHub Issues with 👀 3https://github.com/orgs/getsentry/projects/227
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.