René's URL Explorer Experiment


Title: Deadlock between log batcher lock and logging handler lock when GC runs a finalizer that logs · Issue #7775 · getsentry/sentry-python · GitHub

Open Graph Title: Deadlock between log batcher lock and logging handler lock when GC runs a finalizer that logs · Issue #7775 · getsentry/sentry-python

X Title: Deadlock between log batcher lock and logging handler lock when GC runs a finalizer that logs · Issue #7775 · getsentry/sentry-python

Description: Environment: sentry-sdk 2.66.1 and 2.71.0, Python 3.14, enable_logs=True with the default LoggingIntegration. Batcher._flush holds self._lock while _add_to_envelope serializes the buffered items. If a cyclic GC runs during that serializa...

Open Graph Description: Environment: sentry-sdk 2.66.1 and 2.71.0, Python 3.14, enable_logs=True with the default LoggingIntegration. Batcher._flush holds self._lock while _add_to_envelope serializes the buffered items. I...

X Description: Environment: sentry-sdk 2.66.1 and 2.71.0, Python 3.14, enable_logs=True with the default LoggingIntegration. Batcher._flush holds self._lock while _add_to_envelope serializes the buffered items. I...

Opengraph URL: https://github.com/getsentry/sentry-python/issues/7775

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Deadlock between log batcher lock and logging handler lock when GC runs a finalizer that logs","articleBody":"**Environment:** sentry-sdk 2.66.1 and 2.71.0, Python 3.14, `enable_logs=True` with the default `LoggingIntegration`.\n\n`Batcher._flush` holds `self._lock` while `_add_to_envelope` serializes the buffered items. If a cyclic GC runs during that serialization, and it collects an object whose `__del__` calls `logging`, the flush thread goes through `Handler.handle` and blocks acquiring the `SentryLogsHandler` handler lock. `add()`'s thread-local `_active` guard (#5684) doesn't help here, because the handler lock is taken before `add()` is ever reached. If another thread is logging at the same moment, it already holds that handler lock inside `emit` and waits for `Batcher._lock` in `add()`. The result is a lock-order inversion: every later log call in the process blocks, forever. We hit this in production: Celery tasks froze until they were hard-killed.\n\n**Minimal repro** (deadlocks in ~5s, 7/7 runs across both versions):\n\n```python\nimport gc, logging, sys, threading, time, traceback\nimport sentry_sdk\nfrom sentry_sdk.transport import Transport\n\nclass DropTransport(Transport):\n    def capture_envelope(self, envelope):\n        pass\n\nsentry_sdk.init(dsn=\"https://k@o0.ingest.sentry.io/0\", transport=DropTransport, enable_logs=True)\nlogger = logging.getLogger(\"repro\")\nlogger.setLevel(logging.INFO)\n\nclass Leaky:\n    def __init__(self):\n        self.cycle = self\n    def __del__(self):\n        logger.warning(\"finalizer logging\")\n\nprogress = [0]\ndef log_forever():\n    while True:\n        logger.info(\"hello\")\n        progress[0] += 1\n\ndef make_garbage():\n    while True:\n        Leaky()\n        time.sleep(0.0005)\n\ngc.set_threshold(200, 2, 2)\nfor fn in (log_forever, log_forever, log_forever, make_garbage):\n    threading.Thread(target=fn, daemon=True).start()\n\nlast = -1\nwhile True:\n    time.sleep(5)\n    if progress[0] == last:\n        print(\"DEADLOCK\")\n        for tid, frame in sys._current_frames().items():\n            traceback.print_stack(frame)\n        break\n    last = progress[0]\n```\n\nThe stacks show `_flush_loop → _flush → _add_to_envelope → _to_transport_format → __del__ → logger.warning → Handler.handle` blocked on the handler lock, and a logging thread at `Handler.handle → emit → Batcher.add` blocked on `_lock`.\n\n**Suggested fix:** in `Batcher._flush`, swap the buffer out under the lock, then serialize outside it:\n\n```python\nwith self._lock:\n    if not self._buffer:\n        return None\n    items, self._buffer = self._buffer, []\n# build the envelope from `items` here, outside the lock\n```\n\nWith that patch applied, the repro above ran 0 deadlocks in 3×60s. Happy to open a PR.\n","author":{"url":"https://github.com/NicoHinderling","@type":"Person","name":"NicoHinderling"},"datePublished":"2026-09-29T22:00:49Z","url":"https://github.com/getsentry/sentry-python/issues/7775"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:c4641525-c51c-49b3-90ff-b11f5c7bc284
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8014:2AAD2E:85D621:B4A45F:6B00E35A
html-safe-nonced0f1e83b117830223c1040dfb5d7768ecb92e8f9b48f37d0176b7dfbbc1ded14
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDE0OjJBQUQyRTo4NUQ2MjE6QjRBNDVGOjZCMDBFMzVBIiwidmlzaXRvcl9pZCI6IjQwNjc3NDc1NTA1NTg0NzkxOTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace6280d185d41e30c8458ef869696e8e611089aaefefa106d2bfe5621f6284777
hovercard-subject-tagissue:5637663586
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/getsentry/sentry-python/7775/issue_layout
twitter:imagehttps://opengraph.githubassets.com/33e1569226832eb35f7c9089e75aeb98470df83b4207afcf927c6f0e940c847e/getsentry/sentry-python/issues/7775
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/33e1569226832eb35f7c9089e75aeb98470df83b4207afcf927c6f0e940c847e/getsentry/sentry-python/issues/7775
og:image:altEnvironment: sentry-sdk 2.66.1 and 2.71.0, Python 3.14, enable_logs=True with the default LoggingIntegration. Batcher._flush holds self._lock while _add_to_envelope serializes the buffered items. I...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameNicoHinderling
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-preview
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/issues/7775#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fissues%2F7775
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fissues%2F7775
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/issues/7775
Reloadhttps://github.com/getsentry/sentry-python/issues/7775
Reloadhttps://github.com/getsentry/sentry-python/issues/7775
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
https://github.com/getsentry/sentry-python
New issuehttps://github.com/login?return_to=https://github.com/getsentry/sentry-python/issues/7775
New issuehttps://github.com/login?return_to=https://github.com/getsentry/sentry-python/issues/7775
#7776https://github.com/getsentry/sentry-python/pull/7776
Deadlock between log batcher lock and logging handler lock when GC runs a finalizer that logshttps://github.com/getsentry/sentry-python/issues/7775#top
#7776https://github.com/getsentry/sentry-python/pull/7776
Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Bug%22
Logshttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Logs%22
PythonSDKhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Python%22
https://github.com/NicoHinderling
NicoHinderlinghttps://github.com/NicoHinderling
on Sep 29, 2026https://github.com/getsentry/sentry-python/issues/7775#issue-5637663586
#5684https://github.com/getsentry/sentry-python/pull/5684
https://github.com/apps/linear-code
linear-codehttps://github.com/apps/linear-code
on Sep 29, 2026https://github.com/getsentry/sentry-python/issues/7775#issuecomment-5899859667
Linear Codehttps://linear.app
PY-2909https://linear.app/getsentry/issue/PY-2909
linear-codehttps://github.com/apps/linear-code
Logshttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Logs%22
PythonSDKhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Python%22
Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Bug%22
on Sep 29, 2026https://github.com/getsentry/sentry-python/issues/7775#event-32117718407
Sign up for freehttps://github.com/signup?return_to=https://github.com/getsentry/sentry-python/issues/7775
Sign in to commenthttps://github.com/login?return_to=https://github.com/getsentry/sentry-python/issues/7775
Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Bug%22
Logshttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Logs%22
PythonSDKhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Python%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.